| 0146463d70355592da85c3605aaaef4cf0b7335e |
|
17-Aug-2017 |
Jack He <siyuanh@google.com> |
Bluetooth: Thread-safe binder invocation
* Binder object may become null between null check and actual invocation
if using a instance private variable assignable by service connection
callbacks
* The solution to this problem without locking is to assign existing
binder variable to a local final variable before the null check
* Any further invocation to a disconnected binder object will result in
RemoteException that is caught by the try-catch block
* Read and write to volatile variable is always atomic and hence thread-safe
* Removed unnecessary synchronization in BluetoothAdapter constructor
* Private mConnection objects should be final
* Simplfied several return statements where booleans can be returned
directly
* Removed unnecessary catches for NPE since there won't be any
Bug: 64724692
Test: make, pair and use devices, no functional change
Change-Id: Ifc9d6337c0d451a01484b61243230725d5314f8e
(cherry picked from commit 16eeac356c68f3674677169b618774718ec982b2)
/frameworks/base/core/java/android/bluetooth/BluetoothPbapClient.java
|
| 0a17db1cc5942ea000ca87bb72853de57a15ec64 |
|
04-Nov-2016 |
Jeff Sharkey <jsharkey@android.com> |
Detect non-oneway calls leaving system_server.
To protect system stability, any Binder calls leaving the
system_server must carefully be performed using FLAG_ONEWAY (or
the 'oneway' verb in AIDL) which prevents the call from blocking
indefinitely on the remote process.
In this CL, the system_server uses the new Binder.setWarnOnBlocking()
method to enable detection by default for all remote Binder
interfaces. It can also use Binder.allowBlocking() to allow
blocking calls on certain remote interfaces that have been
determined to be safe.
This CL adds the 'oneway' verb to several interfaces and methods
where it should have been added, and marks a handful of system
ContentProviders as being safe to call into. Also, we assume that
any services obtained from ServiceManager are part of the core
OS, and are okay to make blocking calls to.
Test: builds, boots, runs with minimal logs triggered
Bug: 32715088
Change-Id: Ide476e120cb40436a94b7faf7615c943d691f4c0
/frameworks/base/core/java/android/bluetooth/BluetoothPbapClient.java
|
| 563c700f7025d2f792a52b7483725b3d58eaa7a6 |
|
21-Mar-2016 |
Joseph Pirozzo <pirozzoj@google.com> |
PBAP client Settings profile.
Add content to Settings and SettingsLib to add a checkbox for PBAP
client profile, and remove the box for PBAP server profile when the
client profile is enabled.
Bug: 27642222
Change-Id: I125559904a8e017a01ae90b1f6425129a87cbee3
/frameworks/base/core/java/android/bluetooth/BluetoothPbapClient.java
|
| cfa8a6469463ace9c3336e3686d950792a2c7ad4 |
|
04-Mar-2016 |
Joseph Pirozzo <pirozzoj@google.com> |
Add BluetoothProfile for PBAP PCE role.
Create a new Bluetooth profile for Pbap Client.
Bug: 27490041
Change-Id: I77d2c7eeeb8e955ea61386d784b02b14f415b318
/frameworks/base/core/java/android/bluetooth/BluetoothPbapClient.java
|