| acaf8c1684c84679643bb899045546620520cb14 |
|
20-Sep-2017 |
Abodunrinwa Toki <toki@google.com> |
Flags to enable/disable smart selection in EditText
1. smart_selection_enabled_for_edit_text
Disables smart selection for editable text.
2. smart_selection_dark_launch
Dark launch TextClassifierImpl.suggestSelection(...)
In this mode we run the method, but never change the user's
selection to measure the quality of the results based on what
the user actually wanted.
Bug: 65959640
Test: Manually tested flags turn on/off feature with 'adb shell
settings put global' and GServices override.
Test: bit FrameworksCoreTests:android.provider.SettingsBackupTest
Merged-In: Iacc561c8ee004b0123de66ad1ee06b1f56b4e4b4
Change-Id: Iacc561c8ee004b0123de66ad1ee06b1f56b4e4b4
(cherry picked from commit ba60ab604c880699166cc5fbfad95aa0f2501141)
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 692b196cc12f6852b0bb9009c882a69b67dda4d8 |
|
15-Aug-2017 |
Abodunrinwa Toki <toki@google.com> |
Introduce SmartSelectionEventTracker.
This will be used for logging text selection interaction.
Bug: 64914512
Test: No test. Everything builds fine.
Change-Id: Idb28864e0fc969be05d81855b2e7cd8389bd835e
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 86ef9827dabc05832997898e8d85504e007a206b |
|
11-May-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier: Ensure url scheme is in lowercase
packageManager.resolveActivity(intentWithUppercaseScheme, 0) returns null.
This means we don't find an activity to handle the browser intent.
Create a browser intent with url's scheme in lowercase instead.
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Fixes: 36504599
Change-Id: Idb0c5b73d54cf77d5d6fb4ee0af4478ec11e8b82
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 1d77557517918258cbf4264e647a138d1b9b648f |
|
08-May-2017 |
Abodunrinwa Toki <toki@google.com> |
TRON: Count smart selection events.
Logs:
- Smart selection occured
- TextView menu item activated on smart selection
- Smart selection reset
- Smart selection modified
Test: Manually checked logging happens as per go/tron-howto and verified
nothing is broken in related classes by running:
bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
bit FrameworksCoreTests:android.widget.TextViewActivityTest
Bug: 32572232
Change-Id: Ia9081d92ae9aea50d863455be770eecd0c73be1a
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 6dcae2b91f2bee8664e5ccee4f0f8f5e3df590e8 |
|
05-May-2017 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Reject smart selection if outside original selection." into oc-dev
|
| b416297433c91ff6694fdf5ce41f7ab6f1ee346b |
|
05-May-2017 |
Abodunrinwa Toki <toki@google.com> |
Reject smart selection if outside original selection.
- The aim is to be defensive and prefer to reject a selection if
it is likely to be wrong.
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 38019270
Change-Id: I35ebc84fb102373949366296434a31d899edfef3
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 15644eff8d17db4e8497217bc55005af01a1cd63 |
|
03-May-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier: Remove debug logs.
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 34778895
Change-Id: I1478fe1a2849b1d4661a71ecbf9a27f38430ee28
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 70d41cd792cbbc1eb6b2c36be54cfcae7b53c03a |
|
02-May-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier: Append http:// to url intents that need one.
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 36504599
Change-Id: I5008225a6a3df2d8e07e4a9ae0e340a6582f9e7b
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 6ace8930263b55fe7e9ff92468a14524c4e68407 |
|
28-Apr-2017 |
Abodunrinwa Toki <toki@google.com> |
Close file descriptor after SmartSelection is initialized.
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 37446398
Change-Id: I6f6d927f447d3cc1dffaee2406ff240d0600eb19
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| e0b57893c68a685d287664df28467694a39e4432 |
|
28-Apr-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier: API rename
getTextClassificationResult() -> classifyText()
TextClassificationResult -> TextClassification
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 37769880
Change-Id: I2d926e89058babf06bcff390bee3a45e965984e8
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 146d0d4f6dbab461d1c8e53a65ccddca5041b767 |
|
25-Apr-2017 |
Abodunrinwa Toki <toki@google.com> |
SmartSelection: Use downloaded model file.
This cl introduces support for reading the smart selection model
file downloaded via ConfigUpdater. It decides on whether to use this
file based on the language and version of the model file.
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 34780396
Change-Id: Ie17b9908a0b4eac16a671b0bd633a89da7bc3fee
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 54486c16bac3b31dc04074d2377fe8c63a2e4a0f |
|
19-Apr-2017 |
Abodunrinwa Toki <toki@google.com> |
TRON: Log "textAssist" actions.
- Logs when the assist menu item appears in the text selection menu.
- Logs when the assist menu item is selected.
- Logs the the type of the assist menu item that was presented.
Test: Manually tested by looking at the logs. See: go/tron-howto
Bug: 32572232
Change-Id: Ibbbf59423b3f510ab6f2f072962a556c3d6e2f65
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| a2df6e5415d2481dfda96c07acb24c7898abd80a |
|
13-Apr-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifierImpl: Fix empty locale list issue.
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 37289966
Change-Id: Ib822f2cc2fbaeb67dcc06e1f9fea306ee1c8c9ef
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| c39006a1cdef46a3bd36b7a0e9bb9489564ef944 |
|
29-Mar-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier: Switch model based on locale
Test: cts-tradefed run cts-dev -m CtsViewTestCases -t
android.view.textclassifier.cts.TextClassificationManagerTest
Change-Id: I91f814fc47bd75922c0e42a774dc7376daf65366
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| d2d1399a62087b4e9e36aca5d53f628b4c06e1d7 |
|
24-Mar-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier updates
- Increase the size of the text sent as context to the classifier
- Pass regex match hints to the classifer
Test: Build still works. Regex hints logged correctly. The hints won't
matter until we've actually passed in this values to native code. Native
library test will be written and I've got a tracker bug to write more robust Java tests.
Bug: 35416389
Bug: 36584397
Change-Id: I29e56189b388b36dc0cc7a8bb13ef237ff55be7b
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 9841ea07c044e5f28f387198a233adbd9ba19ce2 |
|
22-Mar-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier cleanup.
- Remove "removed" methods.
- Temporarily log more information about the classification result.
Test: Successfully builds. Manually inspected logs.
Change-Id: I81312ac9992c08ce6137610bd16b339777f8f1fc
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 7d9b297f8cb4a02e6cdddbbe1bc380e5412e511c |
|
14-Mar-2017 |
Abodunrinwa Toki <toki@google.com> |
Fix selected entity type.
This should be the highest scoring one, not the first one.
Test: cts-tradefed run cts-dev -m CtsViewTestCases -t
android.view.textclassifier.cts.TextClassificationManagerTest
Change-Id: Ib790d8aa4aeccdd7a7972eaa6c04ed4fc69ad00e
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| a6096f6c4c56c4937b52efb593d4333db301d6ad |
|
08-Mar-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier: Multiple entities & confidence scores.
- Updates JNI layer to support multiple entities & confidence scores
- Updates code to include multiple entities & confidence scores
- Fixes EntityConfidence sorting to be descending order
Test: cts-tradefed run cts-dev -m CtsViewTestCases -t
android.view.textclassifier.cts.TextClassificationManagerTest
Bug: 35153211
Change-Id: I4878fe7573f5cb7f3eafb1b50c7baf331a336cb1
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 4cfda0beefc7f21f1818c689ca54dd11480c68f2 |
|
28-Feb-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifier: Introduce LocaleList in the API.
Test: API change. Ensured that tests (see topic) compiles
Bug: 35257733
Change-Id: I036af7948fcd691b8a7de586a9cc1b3165946f8a
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 792d820cc9970cd08f3861e89bf5da641e55442a |
|
07-Mar-2017 |
Abodunrinwa Toki <toki@google.com> |
Prevent crashes when in insertion mode.
Test: Manually tested. Automated core tests will be written in another
CL.
Change-Id: If07fa6a81e60de43d8be2cbcf37b355403779fb8
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 9b4c82a83cc3c1aafac2325d7a601ba3e090b90b |
|
06-Feb-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassifierImpl: Handle urls.
This cl also updates label strings, renames an internal method,
and fixes some bugs in TextClassifierImpl caught by tests.
Test: See: I31ee94177e58c986e61e9b24c6c5816fa4b022e1
Bug: 34778263
Bug: 34922928
Change-Id: Ibf60d345d462dfc8a13dead6f01053f1ae50f35a
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| f67f0a584e6dad90a3c6dabff208c3a01fcd51e6 |
|
09-Feb-2017 |
Abodunrinwa Toki <toki@google.com> |
Change package for LangId and SmartSelection.
Package change from android.text to android.view.textclassifier.
This change was delayed until the native library code was updated
to reflect this package change.
Test: cts-tradefed run cts-dev -m CtsViewTestCases -t android.view.textclassifier.cts.TextClassificationManagerTest
Bug: 34777495
Change-Id: I723aaf79f8fbed4758bb4ee6727dfb6a8e35bf99
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| b89cf026cf731108daa293f076ffcb32bbd2c8d7 |
|
06-Feb-2017 |
Abodunrinwa Toki <toki@google.com> |
TextClassificationManager: Avoid exposing lock.
Test: CtsViewTestCases passes
Bug: 35040457
Change-Id: Ia27730816f8aa4832a16aa9ebcafac68acb79e27
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| fafdb7372fe0da277a32b47cff825dbb244e4af0 |
|
02-Feb-2017 |
Abodunrinwa Toki <toki@google.com> |
Fix TextClassifier.getTextClassificationResult()
Gracefully handles situations where a default app cannot be found
to handle the intent.
1. If we can not find any app to handle the intent,
do not include an "assist" menu item entry to fire the intent.
Also, do not linkify the entry.
2. If we do not have a default app to handle the intent,
show a generic title for apps that will handle the intent
and do not include an icon.
In the ideal case where we find a default app to include the intent,
show the app's (preferably activity's) title and icon.
Test: Manually tested. There's an AI to write more automated tests.
Bug: 34777322
Bug: 34927631
Change-Id: Ia94efbbdda3da8f181fac9228cd2d3a76cb727d3
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 6b76675248d442b722e5fbb5c34e5274ced9aeb8 |
|
18-Jan-2017 |
Abodunrinwa Toki <toki@google.com> |
Implement TextClassifierImpl.getLinks
This is a simple implementation of getLinks that works. I plan to
improve on the algorithm later.
Bug: 34661057
Test: See: Ic2a5eceeaec4cd2943c6c753084df46d30511fee
Change-Id: Icb9d4678e19a72ff89556dcaef5940ffab5d95d5
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|
| 43e0350922556e86b641da084a2c9dc2b07fc662 |
|
13-Jan-2017 |
Abodunrinwa Toki <toki@google.com> |
Implement TextClassification-related methods.
Implements TextClassificationManager.detectLanguages
Implements TextClassifier interface
Bug: 34661057
Test: See: Ic2a5eceeaec4cd2943c6c753084df46d30511fee
Change-Id: Ic640b96f48bcad7cdd8c4dfac354b008a7ae3961
/frameworks/base/core/java/android/view/textclassifier/TextClassifierImpl.java
|