History log of /frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
c43b30ca476ce5d1b6a959215ddf54ff611ebeae 06-Sep-2017 Sundeep Ghuman <sghuman@google.com> Do not pause scanning during Network state changes.

This prevents UI bugs in WifiSettings where scan results would become to
old upon switching networks and thus all the APs would be removed from
the wifi picker. Now scanning is only paused/resumed during start/stop
tracking as well as on wifi state changes between enabled/ not enabled.

Also adds additional logging to scan result age in verbose logging.

Bug: b/64989100
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java
Manual: 1. Repeated switch back and forth between different networks.
2. Ensure that AccessPoints in WifiSettings do not disappear after new
connections.

Change-Id: I11e424bcce799a5f3d003a955dcee004294058b7
Merged-In: I11e424bcce799a5f3d003a955dcee004294058b7
(cherry picked from commit db9b94c195f056248b1f5c3b4ef5e907c1b82028)
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
1e98151104022d7dbc1f3d49501f46fe8090d265 29-Aug-2017 Sundeep Ghuman <sghuman@google.com> Change score cache eviction time to settings value.

Reduce default eviction time from intended 24 hours (erroneously input
as 24 days) to 20 minutes.

Bug: b/63073866
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I89eae2483b9a65a65d7cf5b1151952609b6b7fd7
Merged-In: I89eae2483b9a65a65d7cf5b1151952609b6b7fd7
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
a78256947d190a84169a31340c086cfacfcf0697 24-Aug-2017 Sundeep Ghuman <sghuman@google.com> Always use SSID average for SpeedLabel.

When showing the SpeedLabel for the connected network, continue to use
the SSID based average rather than switching to the curve for the known
AP. This addresses changes in SpeedLabel from when the user selects a
network vs when it appears in the connected section.

Bug: 63073866
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I06edc1ca4b1b5c8e8615f48c000544ea22a6bbbd
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
a419b9b4db99c5ca6df759ba7ffebe0855fc0891 16-Aug-2017 Sundeep Ghuman <sghuman@google.com> Implement score cache eviction in AccessPoint.

This prevents cached scores from being held indefinitely and used for
SSID fallback logic in WifiTracker (Picker).

Bug: 63073866
Test: runtest --path frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
Change-Id: Ib351d20db30dfd18b69bb1f8e4d4f26fc6b74ef0
Merged-In: Ib351d20db30dfd18b69bb1f8e4d4f26fc6b74ef0
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
6390fa836e4c345240e37e360f2b52f3d6c9a77a 02-Aug-2017 Sundeep Ghuman <sghuman@google.com> Generate fallback speed label in AccessPoint.java

Cache all seen matching ScoredNetworks, and use these networks to
generate a fallback curve. This cache is kept in sync with WifiTracker's
WifiNetworkScoreCache, hence it does not permanently create any new
objects other than the map itself.

Bug: 63073866
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I0cdf17f63f0238e0e3a8324190f75d82beaa6672
Merged-In: I0cdf17f63f0238e0e3a8324190f75d82beaa6672
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
d1e449267a68220e84c45065ed0d6eb8fe393ed0 07-Aug-2017 Sundeep Ghuman <sghuman@google.com> Refactor WifiTracker sStaleScanResults.

In ag/2580164, in order to minimize changes, we used mutable static
state in WifiTracker to control cache eviction. This breaks a certain
flow in SetupWizard. This change reverts sStaleScanResults to an
instance member and then pipes the value into the AccessPoint update
call to control cache eviction instead of relying on error prone use of
mutable static state.

Bug: 63479352
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
&&
runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java
Manual: See bug

Change-Id: Ia6d79c1904294da69841cbdf6eafbf42fa70f2d0
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
fca9a47ba86163defeb100a75fc856be6c1f3159 03-Aug-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "SettingsLib: wifi: add support for tracking carrier Wi-Fi APs" into oc-mr1-dev
280581b1053f9a52457a7a9b8873bc6fef1b5472 24-Jul-2017 Peter Qiu <zqiu@google.com> SettingsLib: wifi: add support for tracking carrier Wi-Fi APs

Added carrier network info AccessPoint to indicate if a given
AP is associated with a cellular carrier.

Bug: 30988281
Test: manual
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.
java

Change-Id: I10e44b5e18099c7052a973ea24809e75bb2ba9ea
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
0b8700f842a0d92e73ce096e0513c5acc7876ee5 25-Jul-2017 Eric Schwarzenbach <easchwar@google.com> Add individual ScanResult speeds to verbose logging.

Moves the individual ScanResult summary string generation out of
getVisibilityStatus into its own method `verboseScanResultSummary`,
to reduce duplication and to enable testing the per-ScanResult speed labeling.

Bug: 63866500
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I9583d142a7d50314017154703df4e1ce69fc68aa
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
3b8ce7c6d73c5391ac06ebc473ee47da5896e369 26-Jul-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Sort APs by Speed label value instead of ranking score." into oc-mr1-dev
640f04ef38d39c03b5374a1616ce96f333df0851 21-Jul-2017 Glen Kuhne <kuh@google.com> Merge "Don't set AccessPoint with WifiInfo.INVALID_RSSI" into oc-dr1-dev
am: 860f185c66

Change-Id: I9069d51fa6214d9b78c04eea6ab6adebff13ca2e
f4f3842b02262a2483b958aa4b1e9b9e8fc4fb7b 18-Jul-2017 Eric Schwarzenbach <easchwar@google.com> Sort APs by Speed label value instead of ranking score.

This prevents unintuitive sorting if the ranking score (somehow)
sorts differently from the speed label.

This change also fixes a broken test in AccessPointTest.java
'testSummaryString_showsSpeedLabel()'.

Bug: 63116984
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I4a9e55950541ddbf32e01508484bd40326ef228e
(cherry picked from commit 0b431c9af2324f412edfb329047c5ae9f1ebccd8)
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
d38708c1ab1bad1dd2e811204e21a76e33a69182 19-Jul-2017 Glen Kuhne <kuh@google.com> Don't set AccessPoint with WifiInfo.INVALID_RSSI

This stops the RSSI of an AccessPoint object being updated from WifiInfo
for the current network, when that WifiInfo does not have a valid RSSI.
This occurs when attempting to connect to a network, and the connection
has not yet been established.
Fixes a UI bug where the signal strength would appear to be zero when
attempting to connect to something, or after failing to.

Bug: 63487286
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
Test: Manual. Attempt to connect to network with bad PSK. Observe Signal
strength does not get set to zero.

Change-Id: Ia5343fb6f0935134e6a4f82034de164342fe55d4
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
a28050ae42edb487239d9800b173ea334981f2b5 13-Jul-2017 Sundeep Ghuman <sghuman@google.com> Use scores from connected AP only.

When connected to a specific base station, show the speed label for that
specific access point, rather than the best label for all similar access
points in the area.

Bug: b/63073866
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: Ic3b3c5838ca8b43daa226335125bb8046dee3884
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
43d2a1700b6eb1d804924c6a1e5e0161a13a5348 12-Jul-2017 Jeff Sharkey <jsharkey@android.com> Move "metered" persistence to WifiConfiguration.

For a long time we've had a nasty tangled dependency between Wi-Fi
and NPMS, since they both persisted different details for configured
networks. As part of preparing for new carrier data plan APIs, move
the tracking of meteredness over to WifiConfiguration.

This also cleans up how meteredness is communicated through
NetworkAgents to rely completely on NET_CAPABILITY_NOT_METERED by
removing the metered flag on NetworkInfo, which has caused confusion
and staleness.

Migrates any existing user-configured metered networks over to
WifiConfiguration once the device finishes booting.

Remove support for NetworkQuotaInfo, since this information can no
longer be made available to apps. Frustratingly, some apps are
using it, so keep the object around returning stub values, and shame
them in the logs.

Bug: 63391323
Test: builds, boots, Wi-Fi policy is upgraded
Exempt-From-Owner-Approval: Bug 63673347
Change-Id: I64f865ddeb65cfcd330f8d2a847368abdf960a07
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
d911da3adcdc009c6fcbd956f7059838bf55fe69 06-Jul-2017 Sundeep Ghuman <sghuman@google.com> Fix NPE on network forget from details page.

Forgetting a network from the wifi network details page throws an NPE in
WifiSettings when the details fragment exits, crashing the app.

Bug: b/63351286
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I749ecbda5654ff7a86ffe4c38ca74ebe338923f0
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
c93f7b215b474c4ce39604b9595d0ec3628ea482 29-Jun-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Update WifiConfiguration in AccessPoint." into oc-dr1-dev
f1febb57d8e39567ad6bcf99ef82b9659392b35f 29-Jun-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Change TRON counters to reflect cl/159755374" into oc-dr1-dev
f4d3302b06bf910fe122cdb2ef39900c7a36b038 06-Jun-2017 Sundeep Ghuman <sghuman@google.com> Update WifiConfiguration in AccessPoint.

Currently, calling AccessPoint.update(config, info, networkInfo) will
not store the new WifiConfiguration object if it has changed. This can
cause the summary statement to fall out of sync.

Bug: b/38409294
Test: Open WifiNetworkDetails page with verbose logging. Stale state no
longer shown when config changes.
runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I86411527472621f86ab691ee772c0b3d2153d01f
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
6a62328517920d2c0aa431e350fce6ba2c105bc2 29-Jun-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Add case sensitive sort to AccessPoint compareTo." into oc-dr1-dev
53200edba1bee7fe6dc3f567fb92876780881ac2 22-Jun-2017 Sundeep Ghuman <sghuman@google.com> Change TRON counters to reflect cl/159755374

This updates to the newly defined TRON counters and futures proofs us
for new values. Prior to this change, introducing a new enum would throw
an IllegalArgumentException.

Bug: b/35628911
Test: NA
Change-Id: I46662d53b31858396c9a5a6113b1166fba4dfc51
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
d44b8e4689f9ab1a36f9ba0c6e7756532b17596c 22-Jun-2017 Sundeep Ghuman <sghuman@google.com> Add case sensitive sort to AccessPoint compareTo.

If APs differ only in case, further compare by case.

Bug: b/36719423
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: Ic36a2221a668fa59230bb0ddbee2055776d2dc44
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
9c4c6ad6accb6170c37d050b86d22241fb36a790 20-Jun-2017 Peter Qiu <zqiu@google.com> SettingsLib: set network status for wrong password error

Bug: 62444625
Test: Manually connect to a WPA network with a wrong password,
verify "Check password and try again" is shown under the network name

Change-Id: Ic226f4bb9b97969ef7e369de4f7a6976a229ba77
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
55adc6b2fc524a79805e422bf0c772c2dd202838 06-Jun-2017 Sundeep Ghuman <sghuman@google.com> Add SLOW network and remove deprecated enums.

Stop using deprecated API enums and instead define internal constants
for different network speeds. Add support for 'SLOW' networks.

Bug: b/35628911
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I3394f801118adffcb4ba49035e0b22eebb9f0e9a
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
271e5de583e78fea09c12984df77c927be0ad671 30-May-2017 Sundeep Ghuman <sghuman@google.com> Enable speed labeling based on existing network badges.

Bug: b/35628911
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I0fd96da6a06dafd8c8ebb435a2725ab155bd26ed
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
b5bcb8d4d60a4cc667b11448577b0c82e518008a 20-May-2017 Stephen Chen <stewchen@google.com> Check network info for metering state on AccessPoint.

This resolves bug where networks manually marked as metered by Settings
UI were not tagged with a metered friction icon in the Wi-Fi picker.

Bug: 38460378
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I2ffe25e898ac001549e7d7492a2aa335ee415a4e
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
96a53579088a21590cb02e5befc88ef965520d3e 21-Apr-2017 Sundeep Ghuman <sghuman@google.com> Updating network info state should return true.

Update AccessPoint.java so that network state changes return updated
equals true, so that corresponding UI elements will updated
appropriately.

Bug: b/37289220
Test: runtest --path
packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I1bc74997227b46468ef11efbf183a95ec0d2b15f
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
71f4a82b51f53ba7b99fc7f1d1f81a29b7c88072 19-Apr-2017 Sundeep Ghuman <sghuman@google.com> Remove all pending callbacks in stopTracking.

This prevents callbacks occurring on the Settings UI thread in the
WifiSettings fragment after its Activity is already destroyed. When
removing pending ACCESS_POINTS_CHANGED_MESSAGES, release the lock.

Also fixed some flakey tests due to threading issues.

Bug: b/37472533
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java

Change-Id: I764caf52e38b7f7e33c67c7ea3aa3d2301095dca
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
21f6868d8096ca2ff64cdb9fdc4457277d70bf07 04-Apr-2017 Stephen Chen <stewchen@google.com> Set AccessPoint metered bit using ScoredNetwork, WifiInfo, and WifiConfiguration.

Bug: 36888471
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: I5228512a832665916520658acddc9bf93d78a1a1
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
ced37dba7b2ce04ea65a47273d5892ace90ac33c 14-Mar-2017 Peter Qiu <zqiu@google.com> SettingsLib: wifi: encapsulate Passpoint configuration in AccessPoint

The configurations that are managed by "Saved Networks" page are
centered around the abstraction of AccessPoint. Since we will
need to manage Passpoint configuration in the "Saved Networks"
(for configuration removal), encapsulate necessary information
in an AccessPoint for a Passpoint configuration.

Bug: 34207710
Test: manual test
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
Change-Id: Ide556f5ec6c4ef9e1f82016efe17dc9860f298de
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
ce78a5f2d33716fde95f12b1e02df953d013e986 16-Mar-2017 Sundeep Ghuman <sghuman@google.com> Average scan results for AccessPoints.

This reduces jitter in the WifiTracker and is modeled after a prior
broken implementation which attempted to half-life the rssi each time
AccessPoint.update(ScanResult) is called.

Bug: 34774783
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: Iab3f9914af40f2fd56e8ae7b45dcbd62176c8a67
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
54bdcfa08180a69b852c8f71b39d30f0061ce6ff 09-Mar-2017 Sundeep Ghuman <sghuman@google.com> Consolidate getRssi logic to return mRssi.

Changed previous getRssi method to updateeRssi in order to clarify
process, and also changed logic to return current mRssi when the given
AP is active. mRssi is set directly from WifiInfo for active networks.
For non-active networks we return the highest Rssi for any recently seen
BSSID (multiple APs with the same SSID are grouped together).

Change getSeen to updateSeen for consistency, although seen is never
used anywhere.

Also fixes b/34889252.

Bug: b/36077865
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java

Change-Id: Ic52df41b8eb317e83d835c745b404007a53cf5d7
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
9853743705603e0b5214e5995bea8c9267708813 08-Feb-2017 Dave Schaefer <daveschaefer@google.com> AccessPoint - Add Builder; Add unit tests for compareTo()

Add a Builder class to make testing easy and clean.
Add unit tests to enforce the sorting order that we want.
Refactor some compareTo() internals to use existing methods rather than
duplicating functionality.
Refactor isReachable() functionality to a new method.
Update tests to use Truth assertion library.

Test: Run local AccessPoint unit tests:

adb shell am instrument -w -e class
com.android.settingslib.wifi.AccessPointTest
com.android.settingslib/android.support.test.runner.AndroidJUnitRunner

Bug: 35042429
Change-Id: I7c8a1ca69800f62e1fb13141e58b4e52b2bc3d70
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java
914afbfbd048721fb9ece683b9e881b79a01e34e 01-Nov-2016 Fan Zhang <zhfan@google.com> Create test for CategoryManager.

- Move SettingsLibTests to tests/integ
- Create a new robotests directory for SettingsLib.
- Add test cases for CategoryManager#backwardCompatCleanupForCategory

Bug: 32382487
Test: make RunSettingsLibRoboTests
Change-Id: I7ef5921ce8c47a3e1e7209be1abc97ea549a2378
/frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/AccessPointTest.java