| c07ae9cf090270da73bb50a5c7260b5fede9370b |
|
04-Aug-2017 |
Fan Zhang <zhfan@google.com> |
Remove logic for parsing dismiss rule
We now still parse dismiss_rule from activity metadata, but intead of
treating it as "first show on Day x, then on day y if user dismiss
suggestion", we simply start showing suggestion on day x. If user
dismisses the suggestion, it's gone forever.
Change-Id: Ia4d14167a407983df22e582f8dbab0c2cc153e1e
Fix: 64297191
Test: robotests
/frameworks/base/packages/SettingsLib/tests/robotests/src/com/android/settingslib/suggestions/SuggestionParserTest.java
|
| 7b77cf89382d13dc89e7d800c7fd04ac33ec55f3 |
|
21-Jul-2017 |
Fan Zhang <zhfan@google.com> |
Fix suggestion crash if parser fails to parse dismiss rule
We store a index value in shared pref to figure out when a suggestion
should be displayed next time. However the rule can change due to
various reasons. When the index and the rule itself go out of sync, we
should not crash.
Change-Id: Id3ea88b6d321434e20ac0cd3e2670524c237e24e
Bug: 63908636
Test: robotests
(cherry picked from commit 4d37a1a1e1ca902b8a65bce64fafa0eeea51a4dd)
/frameworks/base/packages/SettingsLib/tests/robotests/src/com/android/settingslib/suggestions/SuggestionParserTest.java
|
| e138ef1d2bd6b72e11e73a9738ab95699364d0ec |
|
12-May-2017 |
Fan Zhang <zhfan@google.com> |
Refactor suggestion parser.
Move it to a suggestions package
Wrap suggestion list with a SuggestionList class, with additional
metadata.
Bug: 37947647
Test: make RunSettingsLibRoboTests
Change-Id: I1343d76c8e9acc0d17eb00a87e7f3a86551481d8
/frameworks/base/packages/SettingsLib/tests/robotests/src/com/android/settingslib/suggestions/SuggestionParserTest.java
|