History log of /frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
85d3c8a8f87d4b30ec0ad5c944d371026e2f593e 16-Sep-2017 Winson Chung <winsonc@google.com> Ensure profile-specific PiP notification is shown.

- Pipe through user id when an activity is pinned, to ensure we show the
right notification with the correct profile badge that launches into the
correct profile's PiP settings.

Bug: 65417722
Test: Enter PiP for work profile app, ensure that it shows the notification
for that profile, and launches the profile-specific PiP settings.

Change-Id: I62b8e1b23cb81bfc60c93f452cf950ab06cbf32d
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
44315c64ed4d41bd1bf4e554b17ff52c3eddeb1b 24-Aug-2017 Winson Chung <winsonc@google.com> Adjusting PiP for the TV IME.

Bug: 63898225
Test: Ensure that PiP does not overlap with the IME on TV
Change-Id: I6aced6331b56cd92599cbdb9c13d04ae9138c59b
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
1a01d1298ff3bf191a6c5be876654af964c877e8 15-Jun-2017 Winson Chung <winsonc@google.com> Merge "Update TV to show custom actions." into oc-dev
b6de872eb3316d6c5893373ba2848ffee07adb3c 02-Jun-2017 Winson Chung <winsonc@google.com> Update TV to show custom actions.

Bug: 62293171
Test: Open PIP, ensure custom actions are shown, ensure media session
actions are shown if no custom actions exist.

Change-Id: Ib92f175d3246d93abe954b835c800608db19eddd
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
8068ec2ef12f2ed4e697d2031b50e57778a31970 02-Jun-2017 Winson Chung <winsonc@google.com> Initialize last-orientation to ensure we don't skip loading config.

- This was a regression introduced in ag/2297883

Bug: 62191663
Test: Launch PiP, open settings
Change-Id: I66c28b57361143f2df927776dba5bc58a022bcb4
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
0c5a59292c20edb36ef3af946c8d74b76776c3a1 23-May-2017 Winson Chung <winsonc@google.com> Fix issue with TV PIP clobbering resize on orientation change.

- When the device rotates due to a test that requests a specific
orientation, the TV PiP logic was resizing the state back to
mDefaultPipBounds, which doesn't change depending on orientation change,
clobbering the bounds in the new orientation that were calculated in WM.
Since TV does not really care about the rotation case, we can just
ignore the configuration changes due to orientation changes for the sake
of passing the common CTS tests across handhelds and TV.

Bug: 38246863
Test: android.server.cts.ActivityManagerPinnedStackTests
Change-Id: Id7988a0b02f14f67908d3202cdd73b186d9fea16
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
ee69756d542c9e65389e2907c2dc7aa8cca1250d 18-May-2017 Winson Chung <winsonc@google.com> Adding cached value for current user for per-SysUI process components.

- Also ensuring that we don't do additional work for non-current users when
the task stack changes.

Bug: 38390446
Test: Launch Recents in multiple users, ensure that it works and does not
make a binder call to get the current user id

Change-Id: If075675edc3874d809bad30d0aa564a8e59771d3
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
0553cbcf3654734438fa8f2fc88b9c6f2578daa9 17-May-2017 Winson Chung <winsonc@google.com> Merge "Updating Overview to work with PiP" into oc-dev
0a65737c55c5b1af5cedf086020558a8cc13763a 13-May-2017 Winson Chung <winsonc@google.com> Ensure that we check against the pending state while suspended.

Bug: 38192462
Test: Launch PIP, try to make PIP fullscreen.

Change-Id: I575f57492506224b8ee9f247f3c5903c812a04d6
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
b502690e2d0a120993279a6fe800ad07dccc8872 03-May-2017 Winson Chung <winsonc@google.com> Updating Overview to work with PiP

- Ensure that an activity that is auto-entering PiP when hitting Overview
does not show up in Overview. This is done by listening for the
onActivityPinned() callback from the system, and remove the pinned task.
- Ensure that we show the PiP task in Overview after it is dismissed, while
Overview is open. This is done by listening for the onActivityUnpinned()
callback from the system and refreshing the task list similar to when
the multi-window mode changes.
- When launching from a PiP activity, or launching back into Overview where
the next task should be PiP, then ensure that we scroll the stack to the
front so that the first task is fully visible.
- Fix two lingering Overview issues, when there are no handlers (ie. with
dynamically registered handlers), ensure that we call pre/post dispatch
callbacks (otherwise it could cause animated events not to work correctly).
Also, ensure that we don't update the dummy stack view TaskStack without
clearing the stack first, since we may be modifying the same stack
that the activity consumed when starting.

Bug: 34185886
Bug: 38207296
Test: Launch PIP activity from hitting Overview in the various ways
described above
Change-Id: I699e655106e6ed7206e163f9d3c15477bbfd52ef
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
2e0d4551774a916885c63491c14007d5b12d4ac7 09-May-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "TV PIP: Fix broken TV PIP" into oc-dev
26c63563972568c1d7c4ed302ec51628a8b1806d 26-Apr-2017 Jaewan Kim <jaewan@google.com> TV PIP: Fix broken TV PIP

Bug: 37249867
Test: Manual test (checked that the notification UI is shown when the
PIP starts, and dismissed when the PIP is closed. The 'DETAILS' and
the 'DISMISS' button in the notification also worked.)
Change-Id: I12e385b51f834991a0115ce5ba7dd98180577adb
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
e6385a23d7d7e0628544c9751c59507d1df7885c 03-May-2017 Winson Chung <winsonc@google.com> Workaround launching PiP task with CLEAR_TASK & NEW_TASK flag.

- When launching an activity with CLEAR_TASK and NEW_TASK, the result code
of the start is START_SUCCESS, but we still need to notify SystemUI to
expand the PiP. However, because the PiP transition now waits for the
first draw, this can cause severe jank and delay if the original activity
is a trampoline activity. As a workaround, we immediately move the task
to the fullscreen stack when clearing and restarting the task to ensure
that the new task shows without delay.

Bug: 37501224
Test: Open YT in PIP, launch sub-shortcut from Home

Change-Id: I16bebf19b082f30695e99da1d93bc4adf5e9df0c
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
c2627353c44f00c751f77b4e45a124f4988f61d9 18-Apr-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Tightening up rotation behavior for PIP (3/3)" into oc-dev
ef4dc81d508a44b321581db7c2098701da53494d 11-Apr-2017 Winson Chung <winsonc@google.com> Tightening up rotation behavior for PIP (3/3)

- Fixing up edge case when SysUI resizing conflicts with updating the
display rotation bounds. When an interaction causes both a display
rotation and a resize from SystemUI, we should defer the resize animation
until the rotation has been propagated to SystemUI, otherwise the bounds
used will be incorrect.

Bug: 36879891
Test: android.server.cts.ActivityManagerPinnedStackTests
Change-Id: Ife1b7ab0c2f1f11f33cbc9614778ff49a28c79f6
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
e630923b557f1ec03a95a2490bfd4d432a5295e6 14-Apr-2017 Jaewan Kim <jaewan@google.com> TV PIP: Remove onboarding activity and overlay activity

Remove both activities until the new OC UX spec is finalized.

Bug: 36370535
Test: Manual test (Checked that onboarding nor overlay activities aren't
shown after the FDR)
Change-Id: I97c4b2038aabf4f00cac957af6b79dcd874000ae
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
244e4854c34385e6e27bb0f94fd9dbff0c9eb09f 03-Apr-2017 Winson Chung <winsonc@google.com> Merge "Fixing regression in PiP TV." into oc-dev
d62acec309161783f7079b9ff99dee03136c21c3 01-Apr-2017 Winson Chung <winsonc@google.com> Fixing regression in PiP TV.

- Don't clobber the state if we are deferring resizing due to finishing
activities.
- Fix issue with PiP tasks being visible after the stack is removed, due
to it being put below a non-fullscreen task in the fullscreen stack.
Instead just move it to the back of the stack.

Bug: 36592307
Test: android.server.cts.ActivityManagerPinnedStackTests

Change-Id: Ia18fe155b8a045a8ffea84612fd08af3ef3982d8
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
ac52f2892d5c72c26387d510093ddfc741a8a632 30-Mar-2017 Winson Chung <winsonc@google.com> Ensure we show the PiP menu in response to KEYCODE_WINDOW.

Bug: 36687605
Test: android.server.cts.ActivityManagerPinnedStackTests
Test: #testWindowButtonEntersPip
Change-Id: I0bb35fd666eb6a438e4676267f6726b44bffb3db
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
c81c0ce2e903ae469a532e0537b2f882fd81ec6c 17-Mar-2017 Winson Chung <winsonc@google.com> Showing notification when activity is in PiP.

- Adding callback to SystemUI to be notified which package entered PiP,
and when it leaves PiP.
- Showing a BTW notification on a new PiP-specific channel.

Bug: 36070720
Test: Launch PiP, observe notification, leave PiP, observe no notification
Change-Id: Ibe10298288fe0464d7d136f2571e855f3f5c70ea
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
0e88d32b96526adc241ce7a0970e8177b4254810 08-Mar-2017 Sid Soundararajan <ssoundar@google.com> RecentsTV : Remove all Recents TV Code

This patch will remove the Recents TV Code from SystemUI.

Test: To test this removes the Recents Feature and has no
side effects, try to launch recents with long-press HOME. This
should result in launching the phone version of recents.

BUG: 36035359
Change-Id: I9026b480968575ce08e1ce344512f168fdc5fe87
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
baa7b721dc8ee22f8e5f8c373fe6ab1630446f0f 04-Mar-2017 Winson Chung <winsonc@google.com> Small fixes and tweaks to PiP transition.

- Fixing case where default bounds did not account for ime height
- Ensuring that we using the animating/target bounds when calculating
the new ime-offset bounds
- Tweaking transition interpolators and durations

Bug: 35396882
Test: android.server.cts.ActivityManagerPinnedStackTests
Change-Id: Ia22ea0008d834c47a3f26bf2e1f484c72fae8736
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
d95687c3efd84f34d32e3e1637bb7bd7d1a74021 03-Mar-2017 Winson Chung <winsonc@google.com> Removing check for launched-from package to expand PiP.

Bug: 35946309
Bug: 35927986
Test: android.server.cts.ActivityManagerPinnedStackTests
Change-Id: I71ed03dc664a080e93427c6e18a4c1e7ff99d726
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
f04c1dd047be918c7cababcfdc36c48d873f2d70 25-Feb-2017 Winson Chung <winsonc@google.com> Fixing regression when going to fullscreen from PiP.

- Just ensure that we don't resize the stack if it's already not
visible.

Bug: 35338156
Test: Enter/exit pip on TV
Change-Id: I0bd234dd18ecd3d7d4cb37edad9f1fb3053d96bb
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
dc29875ac087902907f3a839a0abe39c89a0dd62 24-Feb-2017 Jaewan Kim <jaewan@google.com> PIP: Address the comment from the previous CL

This address the comments from the following CL

8af250efae3 PIP: Use resource to maintain settings class list to shift
PIP to left

Test: Manual test
Change-Id: Ib7cae7ba019018375e9c1e51f1a0ef7d91447d52
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
8af250efae3412852ae8870dc58123ccf20f8c6f 14-Feb-2017 Jaewan Kim <jaewan@google.com> PIP: Use resource to maintain settings class list to shift PIP to left

Bug: 31322754
Test: manual test
Change-Id: Ic36c2437409d8d1fcddd71087eda754f1a8752e1
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
49affea25bcb669d845672f04b1352871c8aa8f6 17-Feb-2017 Winson Chung <winsonc@google.com> Fix trampoline activities when relaunching PiP

- We should be checking the actual launched-from package since that stores
the source package across trampoline activities

Bug: 35458117
Test: Enter PiP from a trampoline activity, launch again from Launcher
and ensure that it is expanded

Change-Id: Ia0e586e8b21dee63b513bd61a41a24e7da4325e1
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
29a786590f273b123efa4bb669c4ae51dd055a00 10-Feb-2017 Winson Chung <winsonc@google.com> Adding PipManager dumps.

Test: adb shell dumpsys activity service com.android.systemui
Change-Id: Id647833f1b4dcb6226517c058d17d1812f022671
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
db2ad5d974f56a0e7693d7cd2059249565bb6254 08-Feb-2017 Winson Chung <winsonc@google.com> Fixing crash when fetching stack bounds.

Bug: 35115909
Bug: 35112703
Test: Manual
Change-Id: I708501f2d94682e5e945e2ade52c5c53c2fb8067
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
2a82fe587b850061ace024d2025047554987c10d 02-Feb-2017 Winson Chung <winsonc@google.com> Refactor PiP logic in preparation for expanded state.

- #1: Move logic for handling IME size changes into SysUI, and only rely
on PinnedStackController to provide bounds when first entering
PiP and on rotation
- #2: Doing #1 allows us to move PipMotionHelper to SysUI completely, which
lets us aggregate the animation calls out of PipTouchHandler
- #3: Add proper callbacks to the listeners when the movement bounds
changed from config change, ime change, or aspect ratio change. This
allows SysUI to calculate the associated movement bounds for the
expanded state, and we can then remove the corresponding WM call.
It also means that SysUI is the only thing that needs to know about
the expanded state.
- #4: Fix issue where TV was getting the default bounds, not taking the
aspect ratio when the PiP was entered into account. Doing #3
allows us to report the right bounds.
- #5: Remove dead code related to edge snapping/minimizing now that they
are on by default and associated tuner setting, and controller
callbacks

Test: android.server.cts.ActivityManagerPinnedStackTests (all existing tests pass)

Change-Id: I3ef361bdf8d44094b4c0a11c70ba4db7d697fdec
Signed-off-by: Winson Chung <winsonc@google.com>
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
87794464669d1dba94c7277f1fa1f21d6e3be82d 25-Jan-2017 Winson Chung <winsonc@google.com> Skip resizing the stack when there is no current bounds.

- When initially calling loadConfigurationsAndApply(), the state is
set to STATE_NO_PIP when there is no pinned stack. As of change
ag/1725150, resizeStack no longer fails silently when there is no
such stack to resize. This CL skips the call to resizeStack() when
the PiP mode is set to STATE_NO_PIP.

Bug: 34692144
Test: Try and launch Fugu
Change-Id: Ic539f4431c2f94e7c10520c383fa49157d1d0631
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
3535df26e36df067b8704443e4a660526fe11e22 18-Jan-2017 Winson Chung <winsonc@google.com> Move activity to fullscreen stack when it is relaunched in PIP.

- Only happens when the caller is not from the same package.

Bug: 33754261
Test: Open a PIP activity, try to launch it again from launcher
Change-Id: I3c364ebe31a7626b9133d9c4c1fafc718c2eecf9
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
dc589ac82b5fe2063f4cfd94c8ae26d43d5420a0 11-Nov-2016 Sudheer Shanka <sudheersai@google.com> Update usage of ActivityManagerNative.

- Remove references to ActivityManagerProxy.
- Add isSystemReady to ActivityManager.

Bug: 30977067
Test: cts/hostsidetests/services/activityandwindowmanager/util/run-test android.server.cts
adb shell am instrument -e class com.android.server.am.ActivityManagerTest,com.android.server.am.TaskStackChangedListenerTest \
-w com.android.frameworks.servicestests/android.support.test.runner.AndroidJUnitRunner
Change-Id: I07390b6124fb1515821f5c0b37baf6ae74adc8fa
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
03c8e3f7714f33d19164b2349051a50900b3060c 01-Nov-2016 Jaewan Kim <jaewan@google.com> Merge "PIP: Ignore TaskStackListener calls from another user"
17ca4e33e0e6391960428b9105157465efa74f81 31-Oct-2016 Jaewan Kim <jaewan@google.com> PIP: Ignore TaskStackListener calls from another user

Bug: 32533254
Change-Id: I0987c69ebbd33000b4d3cadb64e28a4c321bd486
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
655332c641ccb12ee1ae3ce89135ca847fba1abf 31-Oct-2016 Winson Chung <winsonc@google.com> Creating PinnedStackController.

- Creating a PinnedStackController to keep track of the state of the PIP
to prevent changes in the system (ie. IME showing) and user interaction
from clobbering each other.
- Refactoring calls in AM into WM/controller

Test: android.server.cts.ActivityManagerPinnedStackTests

Change-Id: Ie59dfd45d5c54764ba69a589b3b8148845e92cc3
Signed-off-by: Winson Chung <winsonc@google.com>
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
303c6b78b645a9a655e09677e4856269d278a85d 25-Oct-2016 Winson Chung <winsonc@google.com> Fix wrong bounds being used in landscape.

- Ensure we use the right display size when calculating PIP bounds.
- Also update interface to take the display id.

Test: android.server.cts.ActivityManagerPinnedStackTests
Test: #testPinnedStackDefaultBounds
Test: #testPinnedStackMovementBounds

Change-Id: I01fd8ba6dee212c29a9a092673ee8f7843e41af6
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java
bf8c2c0f99e70514a37da85b1f31d91964daa0c4 19-Oct-2016 Winson <winsonc@google.com> Moving TV PIP logic to the PIP sub package.

Test: Existing tests pass.
Change-Id: I4ca1f68d01206cb2fc7de27f3d445d6ac13d644a
/frameworks/base/packages/SystemUI/src/com/android/systemui/pip/tv/PipManager.java