History log of /frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
0b8a985cd6ad499e8532d8468ea0ef68147eed2d 20-Jul-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Update alignment for gear / snooze icons to shift when expanded" into oc-dr1-dev
89e15ec9fbdbf7cd43736e3009ae31ec81a02623 29-Jun-2017 Mady Mellor <madym@google.com> Fixes issue where notification jumps when user is dragging and its updated

Also fixes an issue where onTouchEvent wasn't being called plumbed through
for the down event.

Test: manual - have a notification, get an update to it while dragging
Change-Id: I681d4333a60616a7b4b1800fb01504c792e343fc
Fixes: 63094338
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
54540975a51c5433b4c77447acf1f6cb2b1e3562 07-Jun-2017 Mady Mellor <madym@google.com> Update alignment for gear / snooze icons to shift when expanded

How do the icons get placed?
- Ideally they are centered in the “normal” notification height
- If the notification is larger than that, they remain in the same place
- If the notification is smaller than that they are centered in the
remaining space
- If the height changes while showing, they shift

Test: manual - have min notification, show gear / snooze, expand it
note that the gear / snooze icons shift when expanded. Also
tested on variety of sized notifications (big picture, custom
view + groups)
Fixes: 37922756

Change-Id: I6a2d8cd9e76e5a816adf79d052c4e15cf855886b
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
0b3f004acbb0eef38ee5e8d920e934f7ab2f7cde 21-Jun-2017 Mady Mellor <madym@google.com> If the menu hasn't been created yet don't do things with it

Test: runtest systemui
Fixes: 62594598
Change-Id: I1050e2b2bf1ece960d19ad13cb6a9bf71512db57
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
f3f6ddf7cb9641b40c3eb7ddde4565e06ded8b6c 12-Jun-2017 Mady Mellor <madym@google.com> Merge "Updates to NotificationMenuRowPlugin so that long press may be captured" into oc-dr1-dev
4ab2820e6c668ae7c55b300f126bb9f70c202ba3 06-Jun-2017 Mady Mellor <madym@google.com> Updates to NotificationMenuRowPlugin so that long press may be captured

This will allow the NotificationMenuRow plugin to do something else
rather than showing a menu when the view is long pressed.

- Allow menu to intercept touch events
- If the menu item provided to long press is null, don’t show it
- Also passes the status bar notification when the menu is created
or updated

Bug: 62534409
Test: manual, have no plugin and long press -> see notification info
have a plugin that returns null for long press -> nothing happens
Change-Id: I384c5217d5343e990f4c3506eb2477b015705e5c
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
81a9d48d5bf29cda5618533edb9c324f2ef01b88 30-May-2017 Mady Mellor <madym@google.com> Ensure the menu items are properly recreated after a density change

Test: manual - longpress on a notification, change screen density,
longpress on the same notification
Fixes: 62055005
Change-Id: I5b084afecd8cfcd0e806142855b2a86b5e1c5c2d
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
70739fb812e2acb9880c008941015a467fca2001 26-May-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Check for false touches when determining if the notif menu should be shown" into oc-dev
bd707492a2ef3641a9e9a64ef72b3b031dac0bb6 11-May-2017 Mady Mellor <madym@google.com> Check for false touches when determining if the notif menu should be shown

If it's a false touch don't show the menu.

Test: manual: try swiping things away on the lockscreen (fast + long)
try showing notification menu on the lockscreen
Bug: 38208094

Change-Id: I16ceedd90a5fbc80156a9495d6cfd6fa02771886
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
98d8bdb23076b796018b43287b3931118ad55edb 19-May-2017 Mady Mellor <madym@google.com> Don’t reset the menu state if the menu is showing during an update

Test: Manual - have a notification, schedule an update to it, show the
menu, wait for the update, note that the menu is still visible
Bug: 38334364
Change-Id: Idcd49e4ffa4b422653a7090ae6365b8f404ec7b3
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
97d52db8541de930871322847a36467c7a293e3b 10-May-2017 Mady Mellor <madym@google.com> Merge "Fixes issue where the notification menu was not visible after RTL changes" into oc-dev
d9c2232c9952d204a774041305b1ad5ce3d13715 05-Apr-2017 Mady Mellor <madym@google.com> Fixes issue where the notification menu was not visible after RTL changes

- Altered how the menu location is set so that it doesn't depend on RTL
state
- Also fixes an issue where if you change from landscape to portrait or
vice versa then the menu wouldn't be visible because the placement is
based on the width of the notification which changes based on orientation

Test: (1) have notifications and show the menu, toggle the RTL state,
show the menu, note that it is visible
(2) have notifications and show the menu, rotate the device, note
that the menu is still visible
Fixes: 36874498
Merged-In: I33b8f87e53a3393a2802842ad2196c9d089ec7fc
Merged-In: I3a3b688f2b301f5ac0446a55b668db79c323a95c
Change-Id: I3a3b688f2b301f5ac0446a55b668db79c323a95c
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
0f66a4cc16ec1a927c90ac559c73c80ddcb5ee71 29-Apr-2017 Selim Cinek <cinek@google.com> Moving Row inflation to the background too

Previously only the contentview inflation was on the
background, now the inflation of the row is too.

Test: runtest systemui
Bug: 34888292
Change-Id: I3adc6b3311217421c9de5c37794397b8a3fd665d
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
aa94a61c56b8f493fe77fe52b09d0439e7889bc7 27-Apr-2017 Mady Mellor <madym@google.com> Merge "Improve swipe to show notification menu gesture" into oc-dev
043ae355e93010e21dcc341cb26b496e383bd80b 19-Apr-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Fix issue where the notification could snap to the menu while its invisible" into oc-dev
3ca223a8ce3d43cd6411adecd393538150dd6d77 17-Apr-2017 Adrian Roos <roosa@google.com> AOD: Do not show guts nor snooze

Fixes: 37179751
Test: receive notification while phone is off, try longpress or accessing the gear icon through swiping, ensure neither works
Change-Id: If18ac166eac28cd7ad05a12f670b2ddbad9e29b8
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
7a5b2b6d382cd8f9a081989ceab7a63ce9eee4d0 15-Apr-2017 Mady Mellor <madym@google.com> Fix issue where the notification could snap to the menu while its invisible

1) If the snap back animation is cancelled, the menu shouldn't be reset
because it hasn't actually been snapped back -- this could happen when
the menu was being shown and then the icon alpha would get set to 0
resulting in notification snapped to menu but no menu visible
2) Cancel the callback to fade the menu in on dismiss to match original
behavior before refactor of NMR

Test: manual - no clear repro steps for this, I could get it by
violently moving a notification back and forth, with this patch
I haven't been able to repro it.
Bug: 37320279
Change-Id: I4eea37e3c454e7324d0e295b0ec2fe022d219253
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
5574425c32c75825004471434e0cd2fccdd4e5c0 10-Apr-2017 Mady Mellor <madym@google.com> Improve swipe to show notification menu gesture

- Increases minimum velocity for dismiss (100->500 dp/sec)
- Increases minimum distance for dismiss (40->60% of notification width)
- Alters logic when menu was already showing and notification
gets moved (if it doesn't move enough sticks to menu, else it looks
for dismiss or snap back into position)
- Changes swipe helper so that the dismiss direction takes the
translation into account

Test: manual / had some people play with the gesture
Bug: 28693375
Change-Id: Ibe4c51627a78b9c3b7d889cf7e06a63da7113072
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
4b7b01c1cc55e63761584b3951216a2cdfcc1e8d 14-Apr-2017 Mady Mellor <madym@google.com> Merge "Fix issue where menu items visible on 'closed' notification on lockscreen" into oc-dev
9e87dd0d31c0a3320d29ded29338c451ecdb69a6 12-Apr-2017 Mady Mellor <madym@google.com> Fix issue where menu items visible on 'closed' notification on lockscreen

Needed to cancel / remove check for the fade in animator when the
notification gets snapped back since the icons shouldn't show in this case.

Test: manual
Bug: 37260033
Change-Id: I5b5ce51f930025dc819a8578f2285c60fa041e7c
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
4c19760b9131a67b379f9b7060c5830cb5beaad7 11-Apr-2017 Mady Mellor <madym@google.com> Don't offer snooze for foreground service notifications

Also updates NotificationMenuRow tests to actually check if menu
was created.

Test: Manual, have foreground service, check if snooze is visible
Bug: 37152715
Change-Id: I09cf60598c3e8991f2da731da1ef7e0a718c3435
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
0df26108c56d1b3826f257eb9a0216ddac97bd8f 03-Apr-2017 Mady Mellor <madym@google.com> Make sure to remove child views when recreating notification menu row

Test: added NotificationMenuRowTest.testRecreateMenu() + runtest systemui
Bug: 36855649
Change-Id: I4045dc292eb2b5a817ae8d2e78cbce50d4d22b41
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
95d743c38c919dd500d9dcacf9f998500d403d9e 10-Jan-2017 Mady Mellor <madym@google.com> Add plugin interfaces to control notification menu / swipe behavior

1) Updates the notification menu plugin to do more:
- The plugin can now supply the view it wants to display behind a
notification as the menu
- Touch interaction (i.e. notification translating on top) is piped
through to the plugin so it can update the view behind the notification

2) Makes NotificationMenuRow an implementor of the plugin which moves
a bunch of that logic out of NotificationStackScroller

Test: runtest systemui
Change-Id: I8723b96c195ff7311317d5523418cfcbe2a79b52
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
5bec68fbea1a02d7debc2eeeaf01b9478de216e5 09-Feb-2017 Jason Monk <jmonk@google.com> New system for versioning sysui plugins

Use annotations to handle the multi-dimensionalness of interface
versions, but still maintain compile time inclusion of current
versions.

Test: runtest systemui
Change-Id: I0789a72112cf6630a6406f76020071c8a6d9e24c
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
de850bbcaa61c1874b803f2086443febbafd81a4 02-Feb-2017 Jason Monk <jmonk@google.com> Fix leaks in sysui

Add support for testing for PluginManager and TunerService leaks
and add tests for the known leaks and fix them. Also port PluginManager
and TunerService to Dependency to make them easier to handle in
tests.

Test: runtest systemui
Change-Id: I5642539ee24dd72f802905106decd0c87b41b4eb
Fixes: 34846972
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
04d7a0fca0c2d7c1bb08fbcc0301fcf0cdc7838f 25-Jan-2017 Mady Mellor <madym@google.com> Add snooze to notification menu row

Moves the snooze plugin code into system UI.
Does not include assistant suggestions.

Test: manual
Change-Id: Ie2c51d65381530c9a72cd8a871efdbf0d63da490
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
87d7945f0693d3ca943bfb6491d4eba3a8d7cc75 10-Jan-2017 Mady Mellor <madym@google.com> Change NotificationGuts to contain a view

NotificationGuts is now given a view to display, the notification
management controls have been moved into their own view.

NotificationGuts is provided a view to show via a MenuItem.

This allows configuration via the NotificationMenuRowProvider Plugin.

Test: manual
Change-Id: I68cb23ea2cada30cc6e930fa8c03e0aa4014dfe2
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java
761cde1173cdfbc058034ffb10283e5507ed0ed4 10-Jan-2017 Mady Mellor <madym@google.com> Rename notification settings icon row / gear to notification menu row

Test: manual
Change-Id: I3a84c5ea180bd1e53495c5a44a93fa1982056174
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationMenuRow.java