| b86a6c2c71514e0cb693597a955e224811b90f96 |
|
27-Sep-2017 |
Dake Gu <dake@google.com> |
leanback: prefer support lib fragment
Historically leanback implemented framework fragment class first,
and generates support lib fragment code from framework fragment code.
Now we are going to give priority to support lib fragment.
Rewrite python script to convert in the opposite direction.
This implies when we later add new feature, the support fragment will
be tried first before framework fragment.
Still not decided if we want to deprecate the framework fragment
classes.
Test: leanback tests
Bug: 66707813
Change-Id: Ie4e8ebedd5a7ce42d91361b34edcafa98e26f091
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 8b66ca38dbb9f4af7814e7048a14924deb6251a9 |
|
15-Sep-2017 |
Dake Gu <dake@google.com> |
leanback: skip startEntranceTransition after destroyed
Though the app should check before calling startEntranceTransition,
added extra check in leanback library.
Bug: 65687171
Test: startEntranceTransitionAfterDestroyed
Change-Id: I5b3fd108d907b404798f1fbf6facc8cc4b732074
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 76c53f6a2152d31a255a36276ada145be5ec474a |
|
21-Apr-2017 |
Dake Gu <dake@google.com> |
leanback: fix new errorprone warnings
Bug: none
Test: ./gradlew :support-leanback-v17:assmebleErrorProne
Change-Id: I519b67edae6e0f15cd1e97d79fc5478939a0940a
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 49dff44ccf0cef8fc8130415fd1dae1a69e4c786 |
|
19-Apr-2017 |
Dake Gu <dake@google.com> |
leanback: make BaseFragment public
Follow the same rationale of ag/2132368.
If we dont want user subclass, make the constructor
package private, but make the class public so we have
less trouble in api/docs.
Bug: None
Test: generateDocs
Change-Id: I0de0b0651aa45aa8fcd794a320be38685410bd09
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 89097f67f988ebba714a95e10369665280db0c27 |
|
25-Mar-2017 |
Dake Gu <dake@google.com> |
DetailsFragment: support switchToVideo in onCreate
Allows DetailsFragment to be put in intial video mode
and skip entrance transition and enter transition.
The DetailsFragment's state model is fairly complicated
including entrance transition, enter transition and
switchToVideo call. So reworked StateMachine and based
DetailsFragment on StateMachine, remove the PF_ flags used
before.
When switchToVideo is called in DetailsFragment.onCreate,
there is no video fragment yet, but we still fade out
cover drawable and create a pending flag once the video
fragment view is created will focus on to it.
Added support in GridLayoutManager to allow slideOut() when
there is no child, and layout the first pass out of
window.
switchToVideo is not allowed with entrance transition.
once prepareEntranceTransition is called, switchToVideo will
be ignored until entrance transition is finished. On the other
hand, calling prepareEntranceTransition after switchToVideo
will be ignored.
switchToVideo will clear activity enter transitions. Once
it is called in onCreate, we do not want the activity enter
transition to run.
Test: bunch of new tests in DetailsFragmentTest for all kinds
of scenarios
Bug: 36126851
Change-Id: Ic0279331b12b1e285507dffda3ad351245c01a1b
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 694edde99dc3782374977dab6d9aa34a16c13337 |
|
15-Mar-2017 |
Dake Gu <dake@google.com> |
leanback: fix errorprone warnings
Bug: 36252690
Test: N/A
Change-Id: I60a692554882a17d63789a689b4d4c3c37a00aed
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 2452cde3b8d7cbe62f6eb2fbcbcf9a02448d6891 |
|
13-Jan-2017 |
Dake Gu <dake@google.com> |
Switch from getActivity() to getContext()
In case we host the fragment outside activity.
Bug: 34276716
Test: leanback unit tests and SupportLeanbackDemo app
Change-Id: Ic8e16c038a8590c3359533d00b41f80dca917092
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| cc671dd3caac1d0cbf3f6999ab063c9ff1f297b2 |
|
18-Oct-2016 |
Dake Gu <dake@google.com> |
Add checkstyle:off flag
Test: None
Bug: 32243836
Change-Id: I5c28ee5b4623e25126518ceb99f17b5ee384cb76
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 2a9b6dfcc745e9ebe3697b590d7f5cdd116b0c3f |
|
24-Sep-2016 |
Dake Gu <dake@google.com> |
Fix Crash when Fragment is removed after startEntranceTransition
Bug: 31398332
Test: VerticalGridFragmentTest.immediateRemoveFragment
VerticalGridSupportFragmentTest.immediateRemoveFragment
Change-Id: If40fa401f985e44436f9c9c62002a5d817e7413a
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 3103f63e99d47573823957f7aa34308555873221 |
|
20-Sep-2016 |
Aurimas Liutikas <aurimas@google.com> |
Fix all operator wrapping issues in leanback library.
Test: code still compiles, there should be no code/logic changes.
Change-Id: I6e97e2ba429c323022055263540c3fb6d0003822
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 99ec8b0cb375f7e5577ea3ec9f09e6ff7a95de0d |
|
25-Aug-2016 |
Aurimas Liutikas <aurimas@google.com> |
Remove all the extra accessor methods added by javac in support-leanback.
Change private methods to be package protected to avoid extra methods
that get added to be able to access them from inner classes.
This CL saves 469 methods in our jar.
Bug: 31075707
Change-Id: I68c8152d060c9f35c72a2d78c608a9bccd12c86e
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 684f4a94f6f55b2abc5ed2677dfdfc9501dd6407 |
|
18-Mar-2016 |
susnata <susnata@google.com> |
Adding support for ProgressBar widget inside BrowseFragment.
Change-Id: Ie2c5833e6f244dfcaf23fbaccc8c7936eb81f361
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| a5a85434f936023043f074fb86eaa6d48f7f6411 |
|
17-Mar-2016 |
Dake Gu <dake@google.com> |
BrowseFragment: Fix enter transition for lazy loaded MainFragment
Entrance transition stops working because the MainFragment is no longer
created in onViewCreated().
It causes two issues:
1. mMainFragment.setEntranceTransitionState(false) and
onPrepareEntranceTransition() are called before mMainFragment is
created, thus gets ignored.
2. The entrance transition is launched too early before mMainFragment
view is created.
The fix abstracted precondition for prepareEntranceTransition()
and precondition for startEntranceTransition(). Refactored
code using a StateMachine defining preconditions and actions for
each step.
Change-Id: I5d5abe60cfdf896e0bdb2ffaa1afa6e4f1faf7b4
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 8403619efebe94666c0615c3fc85080a303acf80 |
|
14-Oct-2015 |
Dake Gu <dake@google.com> |
leanback: fix NPE of transition listener and clean up
We actually can not support setListener(null) because transition
class only provides addListener() and removeListener(). Details fragment
adds a transition listener with null callback to the sharedelemententer
transition. The bug was not discovered because leanback theme always
specifies the sharedElementReturn transition. When sharedElementReturn
transition is not specified. When pressing back, the null callback listener
of sharedElementEnter transition are cloned into sharedElementReturn transition.
Now we switch to use addListener/removeListener and change
TransitionHelper methods to static.
Bug 24202013
Change-Id: I7cc918013e4a357a59987ea9727bc03c15cb0097
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 902e68c114f86e8002516ff3f0248b722b6c5711 |
|
29-Jun-2015 |
Dake Gu <dake@google.com> |
leanback: prevent RV update children during transition
Introduce onTransitionPrepare() which is earlier than onTransitionStart().
Now it's three stages:
- onTransitionPrepare() stops animation, scroll, user interaction but
allows RV change without item animation.
- onTransitionStart() further stops RV layout, prevent any child change until
onTransitionEnd() resumes it. Adapter change is postponed.
- onTransitionEnd() restores everything.
Fixed a bug when focused header view is re-binding, select level
gets assigned to 0.
b/22067316
Change-Id: If3e05e0bffe8b1b3d67e424989142dc9b69cccdb
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| e7246ef136ed686d8caf339d4d1fd8e37b499c6a |
|
24-Feb-2015 |
Craig Stout <cstout@google.com> |
Broaden support for title/branding.
Unhide TitleView and BrowseFrameLayout.
Refactored branding fragment apis into base class BrandedFragment.
Browse, details, vertical grid are now BrandedFragments.
Create TitleHelper for devs managing TitleViews without BrandedFragment.
Ensure moving toward 'end' from TitleView passes focus correctly.
b/16029942
Change-Id: I5f48e404694997b359cbed579735544e79f6319b
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 572ed31d757c2635ea0a5cdd7ec8a33cd16f77b7 |
|
26-Jan-2015 |
Dake Gu <dake@google.com> |
Fix leanback crash in Kitkat (API19)
1. Fixed crash caused by KitKat is unable to load custom transition
from resource. Created kitkat specific helper class to create
custom title transition.
2. Fixed crash caused by entrance transition is not supported before
LOLLIPOP: disabled entrance transition before LOLLIPOP.
Bug: 19147233
Change-Id: Id628fdd11fe268ff42c53d8ee437a8f0ce5bf8fb
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|
| 3f0f3eb255bde49549a77c0b5d252decaa2a0202 |
|
13-Nov-2014 |
Dake Gu <dake@google.com> |
Leanback: Support delayed details entrance transition
Added a BaseFragment and move shared entrance transition code in.
b/17628884
Change-Id: Ibfe78116a0822925dbd25dbfde38e9b1c8e6c488
/frameworks/support/v17/leanback/src/android/support/v17/leanback/app/BaseSupportFragment.java
|