History log of /frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
54463cbaec9a8fd707c983aaeac490af2ed141c5 20-Jul-2017 Dake Gu <dake@google.com> Revert "Revert "RV: Fix onMeasure() wrong size in second run""

This reverts commit cc7edbcde85a7bc8140a28262a31447f5d3b8370.

Change-Id: I0f50cdd81ccc41cbf46cb7b299323b20da911fda
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
cc7edbcde85a7bc8140a28262a31447f5d3b8370 19-Jul-2017 Dake Gu <dake@google.com> Revert "RV: Fix onMeasure() wrong size in second run"

This reverts commit 740a0867696bd7f6ffe59831f6f6464f47367cd6.

Change-Id: If11e24b2f786abf305ab380ba43bb457fa7411cd
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
740a0867696bd7f6ffe59831f6f6464f47367cd6 15-Jul-2017 Dake Gu <dake@google.com> RV: Fix onMeasure() wrong size in second run

There is some issue with ag/2480331 onMeasure fix.

In the second onMeasure() run, it should use measure result of first
run, defaultOnMeasure() gives a wrong size and causes the row being
unexpected short and cards are given a wrong Y value.

To be safe, also stop horizontal gridview's animation during transition.
This make sure that transition and RV item animator never conflicts
with each other. We cannot simply disable the RV layout during
transition, RV layout is still needed to capture the card size change
in open/close fast lane transition.

Bug: 63597044
Test: rowNotifyItemRangeChange rowNotifyItemRangeChangeWithTransition
Manually tested with play movie TV app

Change-Id: Ie6ffb99c96dc4cc914e0e92dca64cf2fde1452b0
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
e6cf359406cd7baaa0659b54c1b7d8ac45db122a 30-Jun-2017 Aurimas Liutikas <aurimas@google.com> Mark tests @LargeTest if they don't fit @MediumTest times.

Test: None
Change-Id: I2ae471927588ea6f6d1666f45a7a687ee980b139
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
0f17cc8625257f29840f3bb61c52366e052554e7 04-May-2017 Dake Gu <dake@google.com> leanback: maybe fix flaky RowsSupportFragmentTest#defaultAlignment

Seems to be a multi thread issue, the view can be temporarily detached
from RecyclerView in UI thread.

Bug: 37985204
Test: RowsSupportFragment#defaultAlignment
Change-Id: I3ac72d86f412d6e50d55650ac4fe9e96e08f4169
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
c807587e03e775abb23f62894ad59bfb91cfbd97 20-Apr-2017 Dake Gu <dake@google.com> leanback: fix crash late assigning Adapter that has stable ids

We cannot assign a ItemBridgeAdapter to RecyclerView
and later RowsFragment.setAdapter() to change hasStableId
to true. RecylcerView will crash.

So BaseRowsFragment have to delay the
RecyclerView.setAdapter(itemBridgeAdapter)
until app pass in a adapter.

However, this has a side effect on FocusHighlightHelper.
setupHeaderItemFocusHighlight(VerticalGridView). We no longer
guarantee the VerticalGridView will have an ItemBridgeAdapter
assigned to it in onViewCreated(). So we have to introduce
new APIs to expose getBridgeAdapter() and let FocusHighlightHelper
use ItemBridgeAdapter.

Bug: 37515649
Test: HeadersFragmentTest#disableScaleInConstructor
RowsFragmentTest#changeHasStableIdToTrueAfterViewCreated

Change-Id: I1137b81ced68a9d9a8fb13ca689882b9a39d09c7
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
6828e7da34b4a86bf6fd6c28561528b5a4d14d1b 05-Apr-2017 Dake Gu <dake@google.com> resolve merge conflicts of d1dfcffe0e to oc-dev

Change-Id: Id25699322e4382605e09c195f2922287d21ed360
dec38f028e4991e352cb45f0e3c1bc85fd9b973d 04-Apr-2017 Dake Gu <dake@google.com> leanback: fix flaky tests

Dont wait activity isDestroyed() in afterTest.
And remove member mActivity from test class.

Bug: 36701683
Test: run DetailsFragmentTest multiple times on emulator
Change-Id: I0e0e037f6e85f86a1157a7640b864661cc074e4f
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
813b0740517a5b63f2c3744dfe3f011910a600b3 28-Mar-2017 Dake Gu <dake@google.com> Merge "leanback: fix item listener for preteched row" into nyc-support-25.4-dev
am: 967dfaab04

Change-Id: I97eee01bfa9eaeffddda5454ccb2e5d412a630d1
b1f50ac6f9fa8a8140873cad549efb118d0baea9 28-Mar-2017 Dake Gu <dake@google.com> leanback: fix item listener for preteched row

leanback had assumption that items on a row was bound after row is
attached to window, row gets OnItemViewClickedListener when it
is attached to window. This assumption is broken when pretch a row.
The first few items of that row is bound before row is attached to
window at that time there is no OnItemViewClickedListener on the row.

Bug: 36665531
Test: RowsFragmentTest#prefetchChildItemsBeforeAttach
Change-Id: I8a88ad955773b533ef362b6e759ce4d88aa88037
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
e2104f4b5c8e3ad63570306a25e61502dfe4c418 05-Mar-2017 Aurimas Liutikas <aurimas@google.com> Add all missing @Override annotations.

Historically, we could not add @Override for certain methods due to
using older SDKs to build support library. That is no longer the case
so we can add @Override everywhere now.

Test: ./gradlew assemble assembleAndroidTest still works
Change-Id: I85e3c1157f0e253e3eab7584189f3bf95cf030e9
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
9869eb38607552105baa88a0fcba610461045eb5 16-Feb-2017 Dake Gu <dake@google.com> DetailsFragment: move navigation actions out of focusSearch

Move the showTitle and slideOut actions from focusSearch()
method to when focus actually changed.

Doing actions in focusSearch is generally a bad idea, wont work
with talkback which completely bypass the focusSearch() senario.
This is first step toward supporting talkback.

Refactored DetailsFragmentTest and added script to generate
DetailsSupportFragmentTest.
Added Test of navigation between video/rows/title using
requestFocus and DPAD.

Test: DetailsFragmentTest DetailsSupportFragmentTest
Bug: 35437018

Change-Id: I01f51c07675dc6858fbc1a83ea23921294fb48ac
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
514b6d101c6b7d4b7151cf8789424bde66fab511 06-Feb-2017 Dake Gu <dake@google.com> Leanback: fix late selection of BaseRowsFragment

If view was layout before adapter gets data, mSelectedPosition
will be overwritten by onChildViewHolderSelected() event with -1.
The test was only failing on 4.4 and 5.0 because those platform
seems has extra layout pass at beginning. Added manual
requestLayout to test the situation.

Bug: 34777164
Test: RowsFragmentTest RowsSupportFragmentTest

Change-Id: I7e2c78a32a1074586024c52f4a67427393a550e6
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
1d3f9193bfe7929dec656536813f02e5ba281883 04-Feb-2017 Dake Gu <dake@google.com> Disable the new RowsFragmentTest

Still failing on nexus4 and nexus5.
Could be timing, will investigate later.

Bug: 34777164

Change-Id: I554f41f90f82540a0e9c51a49d3360e73d80a327
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
ea89ed4fd190e0b2a0fe595f2172bc649af67bf7 04-Feb-2017 Dake Gu <dake@google.com> Fix RowFragmentTest

Remove assertNull(findByPostion(0)) which is unnecessary
and depending on screen height.

Bug 34777164

Change-Id: I2728aa59a7d85236246b1f44c6d43042af930137
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
50cf9ada93e50e906f20f5edf595234ada196d45 28-Jan-2017 Dake Gu <dake@google.com> Add option to allow customize HeadersFragment

To support enable/disable focus scale of HeadersFragment,
Refactored BaseRowFragment and Presenter to allow retaining
the same ItemBridgeAdapter when wrapped Adapter changes or
Presenter changes. So user can set up FocusHighlight
on the ItemBridgeAdapter without worrying it was overwritten
when recreating the ItemBridgeAdapter.
Added BrowseFragment.onCreateHeadersFragment() for user to
override HeadersFragment.

Added more test in RowsFragmentTest, Added HeadersFragmentTest.

Bug: 34777164
Test: RowsFragmentTest RowsSupportFragmentTest
HeadersFragmentTest HeadersSupportFragmentTest

Change-Id: Id3fbc9cb0b5b0a3c637d9bc789bb1104fbaa21f3
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java
5083c1eeb9cea04354f7ad4cea84a6d27ce985dd 03-Jan-2017 Dake Gu <dake@google.com> RowsFragment: use default alignment if setAlignment() not called

Some apps expects default alignment, a regression in support lib
25 will make RowsFragment rows to align to top of screen by default.

Bug 33279341
Test RowsFragmentTest RowsSupportFragmentTest

Change-Id: I2a8c78ac1c40fe6c0b12b624ab99bb6ced06a8ee
/frameworks/support/v17/leanback/tests/java/android/support/v17/leanback/app/RowsSupportFragmentTest.java