History log of /frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
972194a1b95305d31f6c850c4473d91cdcc41f11 01-Jun-2017 Evan Rosky <erosky@google.com> Removed old go-to-actionbar hotkey

This is not widely known and didn't always work before. In O+,
cluster hotkeys now handle this behavior (meta+tab).

Bug: 62227631
Test: KeyboardShortcutsTestCaseWithToolbar
Change-Id: If28d25493c894834d50fac3571dbe01e93152ff1
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
8a6d3a17d966d841ff7a02521ca2783d896d696d 22-Mar-2017 Evan Rosky <erosky@google.com> Add compat shims for keyboard navigation clusters

Bug: 34361159
Test: Updated KeyboardShortcutsTestCaseWithToolbar#testAccessActionBar

Change-Id: I314143bf655c625d462d194a3fc4ebdb4a408a74
(cherry picked from commit 2bcb55fd82a953c7e295412b1f5407783aa190dc)
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
d38b36c6370fe2aa448b7b824e8fb399fb3f0b97 01-Feb-2017 Alan Viverette <alanv@google.com> Require lint when building release target

Make plugin more groovy. Fixes lint errors that were blocking submit.
Fixes lint API database path to be relative to project directory.

Change-Id: I0c3d8b0ba0b9c40d4a7979677f03b9eff6dcf2ce
Fixes: 29630077
Test: ./gradlew createArchive
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
0800a58729f5fdc6e399cbd299fbbc7442dbdb38 13-Feb-2017 Aurimas Liutikas <aurimas@google.com> resolve merge conflicts of 3be4cef3e4 to master

Change-Id: Ib5e4df4aba3637a51777ee167eed5bb9a8d99913
44ece5ceaaee232f9139ccbde40ac4a5e642bdee 12-Feb-2017 Christophe Beyls <software@digitalia.be> Fixed various it's -> its typos in comments and documentation

Test: None
Change-Id: I25617e1cfe26cdeacaa54040676a7abff475478e
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
e22ae93397361d1bd5568fa51d82e2f7553712e1 08-Dec-2016 Alan Viverette <alanv@google.com> Remove unnecessary @TargetApi annotations

Bug: 33412815
Test: ./gradlew assemble
Change-Id: I0be3358fb97d6e637357c253f3f43f39355a643a
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
8f886fe8c7e23fe6ccb8734167c960c2ed3429c3 25-Oct-2016 Alan Viverette <alanv@google.com> Annotate support classes with RequiresApi / TargetApi

Also inlines version codes in SDK_INT checks so that lint
understands them. Removes some unnecessary TargetApi annotations.

Bug: 29630077
Change-Id: I67a9235480ca14711b0496a54beca5c0e6c6b2d1
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
2c1bad7ecd5879bf0f29ce2ce1bc5bd67a3f4682 25-Aug-2016 Aurimas Liutikas <aurimas@google.com> Remove all the extra accessor methods added by javac in support-v7-appcompat.

Change private methods to be package protected to avoid extra methods
that get added to be able to access them from inner classes.

This CL saves 196 methods in our jar.

Bug: 31075707
Change-Id: I2592b845b920384ff523fe130f634d5808a382a8
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
19ef8b22fccfd1649ac27cec9fe74933265f5745 14-Jul-2016 Chris Banes <chrisbanes@google.com> Tidy ups for AppCompat vector support

- Add an UncaughtExceptionHandler to make any resulting
exceotions clearer.
- Make sure that any manually created views are
AppCompat versions.

Change-Id: I8165cfe6c7c5beef1b358b4616af7a90f554ee25
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
12acd8f6d6926aaa5cc16543386e0aeee64716ed 30-Jun-2016 Chris Banes <chrisbanes@google.com> Make sure we recreate the Activity for night changes

Also added a delayed runnable which will automatically
update if we go over a time change while an Activity is
open.

BUG: 29872805

Change-Id: I2581efebe641d94e9e35c6ce63199ddcee40ee42
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
593d8bcc82c01a559f737dfcbc6e806005300a64 22-Feb-2016 Chris Banes <chrisbanes@google.com> Add ThemeOverlay.AppCompat.Dialog themes

We've now also moved to tinted backgrounds on
Dialogs. Woooooo.

BUG: 26954228

Change-Id: I365007b230a53b5a88edf30e9bfab2eaed407819
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
733d0b2acb07ede7455b9d020901a10586053923 04-Jan-2016 Chris Banes <chrisbanes@google.com> Fix ToolbarActionBar invalidating destroyed Activities

BUG: 26375399
Change-Id: I4e4298748b9040b8ee307bbf1c09450618bdd494
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
ff7f258a9b0781de5c6325358c7075128bf05a91 07-Dec-2015 Chris Banes <chrisbanes@google.com> Re-add DayNight functionality to AppCompat

There are now a number of themes with the prefix
Theme.AppCompat.DayNight which support automatic
light/dark switching based on the time.

There are now two main APIs to enable these themes
to work. AppCompatDelegate.setDefaultNightMode() allows
setting of the night mode globally within an app.
setLocalNightMode() allows overriding of the default
for the specfic host component instance.

Change-Id: If0349165fc9163deb2bab974ea63939edc00c6dd
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
66698bb15ba0f873aa1c2290cc50d6bb839a474a 26-Oct-2015 Chris Banes <chrisbanes@google.com> Flatten AppCompat class hierarchy

This allows us to do two things:

1) Move away from using public @hidden classes
everywhere.
2) Workaround silly OEM bugs.

BUG: 18218511

Change-Id: I7582e242c7564c32feeb044fc9eff6bfb5c56536
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
0df7523d5586db69bd4960d9e72b2c24c12b73a0 26-Aug-2015 Chris Banes <chrisbanes@google.com> resolved conflicts for merge of 1c9cc133 to mnc-ub-dev

Change-Id: I7c03f041d7b8aefd057030002fd0089bad684dff
a4b5c35036e68c7551dd77641ceec17b92c6368d 19-Aug-2015 Chris Banes <chrisbanes@google.com> Fix AppCompatDialogFragment crashing

We now model PhoneWindow in when it reads the theme
window flags. Added a unit test too

BUG: 23336734

Change-Id: I990bd91d29d1009e0e18f976c7b3c542782660e6
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
ef45ec823d39029e03ff29eb618eaa5a78839470 25-Aug-2015 Chris Banes <chrisbanes@google.com> Fix OnMenuVisibilityChangeListeners not working

Caused by Activity always returning true from onMenuOpened
which meant that AppCompat's dispatch was never completed.

BUG: 23510839
Change-Id: Ie5293d8d863aa6e27ad766159786896fbdfbc6d6
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
91a95c4599d0d5fa936b81396c71210ae7e68e54 05-Aug-2015 Chris Banes <chrisbanes@google.com> Throw exception if setContentView() is called improperly

Currently we will just crash with a random message
if setContentView() is called before super.onCreate().
We now throw a nicer exception message.

Change-Id: I1f0928ae3f25e1e2b50663f827b60ef7d9648632
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
f2149b131fa96dc0a26fc86b3a36c4094c63a73a 16-Jul-2015 Chris Banes <chrisbanes@google.com> Remove DayNight functionality DO NOT MERGE

BUG: 22488087

Change-Id: I69298e07b8aae124a4982d30c070ea042c6e3568
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
4e0a0984e80ced79b8aa3cf71fc261044ecc08a6 23-Jun-2015 Chris Banes <chrisbanes@google.com> am 5ba742a3: Merge "Fix leak for MenuInflater + setSupportActionBar" into lmp-mr1-ub-dev

* commit '5ba742a37d06a0961f20e41c18cc6f8f4d5fd514':
Fix leak for MenuInflater + setSupportActionBar
5ecdb2c5042da49d36d7cda3fa08f1d9151a1fbd 22-Jun-2015 Chris Banes <chrisbanes@google.com> Fix leak for MenuInflater + setSupportActionBar

Caused when there are multiple calls to
setSupportActionBar(). getMenuInflater() will
instantiate and keep an instance to the first
Toolbar (and it's container, etc).

BUG: 21638877
Change-Id: I4c79b4832534b06e7ab2819e78e303dde4a7d76a
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
2a5e18155a210d06ebb142059746becb31f67945 18-Jun-2015 Chris Banes <chrisbanes@google.com> Merge commit '62d9aaed' into manualmerge

Change-Id: I22d22d6a496759a98b81c3f1bf1c226b48fa8e17
8d4765883ff24f0f79bf64fea23d4687d50cec85 18-Jun-2015 Chris Banes <chrisbanes@google.com> Fix memory leak in ToolbarActionBar

Caused when there are multiple calls to
setSupportActionBar() (i.e. fragments). ToolbarActionBar
currently just wraps the Window's current Callback. Which
means that for every setSupportActionBar() call, we're
re-wrapping a ToolbarActionBar Window.Callback wrapper.

This CL fixes it by making sure that we always wrap the
correct 'root' Window.Callback.

BUG: 21914909

Change-Id: I8f21b94d60eb488630b1fe7377ba62d3608accef
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
8122ad54f129c2214631fad86cabda82815cc0d8 08-Jun-2015 Chris Banes <chrisbanes@google.com> Fix window decor Action Bar init

BUG: 21575069

Change-Id: I2e9919c36f221c968bc38c8d7ba4e476f41b45f7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
88c0ac5649d6b82c882e2de4bc4f043b107a4428 02-Jun-2015 Chris Banes <chrisbanes@google.com> Move our Window flags handling closer to PhoneWindow

Fixes some issues around stack overflows for certain
flag combinations.

BUG: 21575069
Change-Id: I6f6c98863f7cfb4510cbeeb8a1be6e16c6de509f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
1282e55f13234e9275cd76d3e02559e1eabf12e3 08-Jun-2015 Chris Banes <chrisbanes@google.com> Fix window decor Action Bar init

BUG: 21575069

Change-Id: I2e9919c36f221c968bc38c8d7ba4e476f41b45f7
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
85d77caf73c0bfe957304951f94f88650a064efb 08-Jun-2015 Chris Banes <chrisbanes@google.com> Merge "Move our Window flags handling closer to PhoneWindow DO NOT MERGE" into lmp-mr1-ub-dev
559fa14454cc053127b3b96c0e63c48c06937e38 03-Jun-2015 Chris Banes <chrisbanes@google.com> Revert the previous fix for stealing KEYCODE_MENU

We now just steal those events if we can actually
handle them.

BUG: 20529185
Change-Id: I09119b9efcd24e15b39990a22a7da55257ebfd96
(cherry picked from commit a6624356b85f8a31c5d951c92ce39ef1070fd9db)
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
a6624356b85f8a31c5d951c92ce39ef1070fd9db 03-Jun-2015 Chris Banes <chrisbanes@google.com> Revert the previous fix for stealing KEYCODE_MENU DO NOT MERGE

We now just steal those events if we can actually
handle them.

BUG: 20529185
Change-Id: I09119b9efcd24e15b39990a22a7da55257ebfd96
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
0c4414fd7d27eef2a3545cb36db29070f8a3ea77 02-Jun-2015 Chris Banes <chrisbanes@google.com> Move our Window flags handling closer to PhoneWindow DO NOT MERGE

Fixes some issues around stack overflows for certain
flag combinations.

BUG: 21575069
Change-Id: I6f6c98863f7cfb4510cbeeb8a1be6e16c6de509f
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
15ad53853d367f5d593bb019d88fb613878fd8fc 14-May-2015 Chris Banes <chrisbanes@google.com> Theme.AppCompat.DayNight working back to API v14

This CL enables the use of -night and -notnight resource
qualifiers, and thus allowing Theme.AppCompat.DayNight
to work on those API levels.

TwilightCalculator and TwilightManager are simplified versions
of those internally in the framework. Since we don't want to
force the use of location permissions, we have a fallback of
hardcoded 'night' time.

BUG: 21119724

Change-Id: I48ff5f0ea0c02ba60d3c2979aa9fa2997080de37
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
d25af35061a9f20d59b25329d613c62c20184dad 04-May-2015 Chris Banes <chrisbanes@google.com> Window.Callback passthrough fixes

We currently do not proxy onMenuOpened or onPanelClosed
events to the Activity because we overload the FEATURE_ACTION_BAR
ID internally. From v11+, those methods in Activity do special
handling and try and init it's own Action Bar (which usually results
in a crash).

To fix this, we now use our own special feature IDs:
FEATURE_SUPPORT_ACTION_BAR and FEATURE_SUPPORT_ACTION_BAR_OVERLAY.
Meaning, we can now pass the calls through without the default impl
blowing up.

We still accept the normal window feature IDs for requestWindowFeature()
but we log an info message.

BUG: 20816353

Change-Id: Ieea6d451279469b9de7bd96a17e5338600fdf9d8
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
556a65bcf38cb6197f018ff4700f822538758261 30-Apr-2015 Chris Banes <chrisbanes@google.com> Merge "Fix our pre-JB onPreparePanel() workaround" into lmp-mr1-ub-dev
ba79f0593a0f53d254b4e555c8702ed1d0435120 29-Apr-2015 Chris Banes <chrisbanes@google.com> Fix getSupportActionBar() returning null for Toolbars

Change-Id: I00d966f9de447c746355c5b820aecb3a49b6fde0
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
4e411251159c965caccb3bf3727c2921d74f06c1 29-Apr-2015 Chris Banes <chrisbanes@google.com> Fix our pre-JB onPreparePanel() workaround

We now call Activity.onPreparePanel() as normal which
fixes FragmentActivity dispatching the call to it's
fragments.

BUG: 20680612
Change-Id: If9325b78e54f61c472284334133e0d29b3778f63
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
5ec61b424dc658e52f65d40d05ee14b869c59374 28-Apr-2015 Chris Banes <chrisbanes@google.com> Merge "Let the Activity/Dialog handle KeyEvents first" into lmp-mr1-ub-dev
a9279663ecb98b85bf95a5ba1ebc145756fc13a2 27-Apr-2015 Chris Banes <chrisbanes@google.com> Don't allow an Action Bar to be created for floating windows

BUG: 20624627
Change-Id: I9d3505b03d099ff8e09558094136094ad2e26213
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
e68562a419ae9fdcd2505bbc146214e3ec1883b1 26-Apr-2015 Chris Banes <chrisbanes@google.com> Let the Activity/Dialog handle KeyEvents first

BUG: 20529185
Change-Id: I123aa7d206026c82984fb945f67f42bdf770ade9
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
547a80d347e0dc9751bbe3cf91f947477145bdba 13-Apr-2015 Chris Banes <chrisbanes@google.com> Action Mode fixes

- Added a switch to disable native CAB handling
- They now use the correct theme
- Using a better way to intercept framework CABs
- We now only intercept on v14+.

BUG: 20171499
BUG: 20022929
BUG: 20208108

Depends on Iacffdf908b98739770f13665732d7755b14b9a25

Change-Id: Ia64beb77ba0a08186e4cdea4544cd9880bf4a4d9
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
0f58401dc72db8ea2a201e3c0220f6529f2a7b33 04-Feb-2015 Chris Banes <chrisbanes@google.com> Add AppCompat specific windowNoTitle attribute

More useful now that we support Dialogs. Also reworked
the sub decor code to match more closely to the framework.

BUG: 19194408
Change-Id: If48a338e583dddedfd620993aed92bca5e253781
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
16e8d4dd91083260223c007c797e46bc8f631055 23-Dec-2014 Chris Banes <chrisbanes@google.com> Material Dialog themes

Lots of changes needed for this, building upon the
refactoring CL. AppCompatDelegate can now handle Dialogs
as well as Activitys (which was easy after the refactor).

This was needed so that we can install a custom decor
for Dialogs.

Also added borderless button styles as they were
needed for Dialogs.

Change-Id: I88a7e4de5de85477982e401c832aeae732f81647
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java
f3ad1351d8b40ec5defe35e79d3430ad3c384b6d 27-Nov-2014 Chris Banes <chrisbanes@google.com> Refactor AppCompat's Activity structure

- The activity delegates now have a public abstract class
called AppCompatDelegate. Any Activity can create one,
but they must call through to the delegate at certain
lifecycle methods.
- Related, I've reduced the number of manual lifecycle
calls needed by using Window.Callback where possible.
- Activities can implement the the new AppCompatActivityCallback
interface to receive certain callbacks.
- AppCompatActivity does all of this automatically
- ActionBarActivity is now a deprecated alias for AppCompatActivity
- Removed support for the v4 Drawer Toggle
- Remove our internal callback in favor of using Window.Callback
directly

BUG: 18547959

Change-Id: I8ece4372fa2abbc5b5246544643fafe0e22874be
/frameworks/support/v7/appcompat/src/android/support/v7/app/AppCompatDelegateImplBase.java