History log of /packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
cab802a9688cba8dfb8faceab820d1320370722b 02-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Merge "Fix OnAdvertisingSetStopped callback not being called" am: f9d9bf4199 am: d57765298d
am: fe8465217c

Change-Id: Ie797e01689155a65a49e7a66e7a4c8409f3db3a8
1642b48f9d3b00ca80d43830f9bfd6c15fa5ba66 02-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Fix OnAdvertisingSetStopped callback not being called

Bug: 62031687
Test: sl4a AdvertisingSetTest
Change-Id: I6de84bb68d8c54d8c9685e701ca5ee4967a7b6f0
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
792b3b63ea8109fb0d30135e9249256f3d891d9e 26-Apr-2017 Joe Onorato <joeo@google.com> Turn off logspam (Bluetooth)

For more information, see https://source.android.com/source/code-style#log-sparingly

Bug: 37252687
Test: development/tools/logblame/medium_idle_test
Change-Id: I8c839eff19fa0b00d1b6a04fbb554b39010884d9
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
00129680f9863701255425567f408e66ec84caf1 19-Apr-2017 Jakub Pawlowski <jpawlowski@google.com> Expose LE advertiser address for easier PTS tests (2/6)

This patchset adds a hidden method getOwnAddress, that lets app with
BLUETOOTH_PRIVILEGED permission to lear their own addreess. This is done
exclusively for PTS tests.

Bug: 35147497
Test: manual
Change-Id: I8da0128c1dac2995e488f1e0c48aa7d5fd399b4c
(cherry picked from commit f10e5516ed308be0493173fcd7982fb4f0a8cd0e)
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
f10e5516ed308be0493173fcd7982fb4f0a8cd0e 19-Apr-2017 Jakub Pawlowski <jpawlowski@google.com> Expose LE advertiser address for easier PTS tests (2/6)

This patchset adds a hidden method getOwnAddress, that lets app with
BLUETOOTH_PRIVILEGED permission to lear their own addreess. This is done
exclusively for PTS tests.

Bug: 35147497
Test: manual
Change-Id: I8da0128c1dac2995e488f1e0c48aa7d5fd399b4c
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
7f4a31f44f61bf765dad1d3b570e314fa1a98f85 31-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Bluetooth 5 advertising duration refactoring (3/4)

Expose both duration and maximum extended advertising events to limit
advertising time.

Test: manual
Bug: 30622771
Change-Id: I81ee59086f40b64d07eb43b32f1a59a6856ab886
(cherry picked from commit de068ddbc7bc4de68b178c5e32a44180ddf257a0)
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
de068ddbc7bc4de68b178c5e32a44180ddf257a0 31-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Bluetooth 5 advertising duration refactoring (3/4)

Expose both duration and maximum extended advertising events to limit
advertising time.

Test: manual
Bug: 30622771
Change-Id: I81ee59086f40b64d07eb43b32f1a59a6856ab886
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
8afb5229a27e775f16f920c43db30061a7a96593 22-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Bluetooth 5 Enable->Enabled (2/2)

Test: manual
Bug: 30622771
Change-Id: Ifce2fc20fde2c55f26cb54012c9ee4eb44b1c91e
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
8cc4343c3b71c7a4d57c0b8c669b0a6188185f6b 17-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Bluetooth 5 AdvertisingSet implementation (2/4)

Test: manual
Bug: 30622771
Change-Id: I69e1ce6be3b776f783d2b2d18aee63a494b8cfd1
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
b3246f3a27d269b4c0ef19cb2c8772d039eb26cc 17-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Bluetooth 5 move timeout parameter (2/2)

Timeout is not a parameter, it is a property of enabling the
advertising. Move it into more proper place.

Test: manual
Bug: 30622771
Change-Id: Ib688f183bf71fe429da6b9c3c8eb3591e9c6ec1d
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
917f34e18aa235e68ac0663e24f52100e95970b7 13-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Bluetooth 5 AdvertisingSet implementation (2/4)

This patch wires up fist methods of AdvertisingSet, making it possible
to start advertising and stop advertising. It also replaces legacy
implemementation with calls to new implementation.

Bug: 30622771
Test: sl4a ConcurrentBleAdvertisingTest
Change-Id: I35e7db5df1945d101402299f78dd541e346d548c
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
7bdbdb9c5c81e08957c442f91d70fb34d8b34dde 20-Jan-2017 Jakub Pawlowski <jpawlowski@google.com> Remove advertiser during unregistration

When advertiser is being unregistered in non-regular flow, i.e. due to
failure to start advertising, or when started with timeout, remove
client instance from map.

Bug: 34440704
Test: sl4a ConcurrentBleAdvertising:test_timeout
Change-Id: Id7b2079bf7936b344afada80f079666dc0ea6440
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
c8ffb102474da9834e70ab72641fea143f5f3a3d 05-Dec-2016 Jakub Pawlowski <jpawlowski@google.com> Expose Bluetooth 5.0 properties to JNI

Bug: 30622771
Test: sl4a ConcurrentBleAdvertisingTest
Change-Id: I1cfdd29075a41057ae99b5b458876a4a9916e845
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
4d6c42f3481f1ef7657b10f1ba5198216b67c498 01-Dec-2016 Jakub Pawlowski <jpawlowski@google.com> Fix null settings in AdvertiseCallback.onStartSuccess

Test: acts FilteringTest
Bug: 33171815
Bug: 30622771
Change-Id: Ib3df1d13535999ede0e820651fc6d69daeb8ef17
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
52ec4e757eff12405d0d074d58822b061cd77d84 23-Nov-2016 Jakub Pawlowski <jpawlowski@google.com> Cleanup startAdvertising call

AdvertiseManager.startAdvertising no longer sends multiple commands.
Its native counterpart, BleAdvertisingManagerImpl.RegisterAdvertiser,
thanks to better tests, guarantees that it either sends a success or
error callback. Therefore, no additional synchronization is required.

The only cases when the native code can get executed without a callback
are when the controller sends no response, or the bta thread is stuck.
Both of those cases should result in a crash and restart of bluetooth.

This patch also fixes an error, where if a timeout happens, the error
callback gets called twice.

Bug: 30622771
Test: sl4a ConcurrentBleAdvertising
Change-Id: I72a729f4da2bd8d5d62a81a6f93dbadab088a036
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
7770f07e7444ff63d56df3ff48a335296c11fcf4 23-Nov-2016 Jakub Pawlowski <jpawlowski@google.com> Remove unnecessary advertiser count check

Bluetooth stack won't allow to register more advertisers that it can
handle, so checking count of registered advertisers make no sense when
calling startAdvertising.

Bug: 30622771
Test: sl4a ConcurrentBleAdvertisingTest
Change-Id: Ifbaf583871cf59ce8e345d7bca8e9a9ea1540734
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
335fb7b425b0a585c271ae34901ea443ec88be38 19-Nov-2016 Jakub Pawlowski <jpawlowski@google.com> Move some AdvertiseManager methods into separate helper

This patch is moving some methods from AdvertiseManager into a
AdvertiseHelper. This is a preparation to add tests to
advertiseDataToBytes and others.

Bug: 30622771
Test: sl4a ConcurrentBleAdvertisingTest BleAdvertiseApiTest
Change-Id: I41f857379c892f76a5cec807879722764ef3cfa7
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
e82cce565b1549001f5a70526239c2d92106f85a 17-Nov-2016 Jakub Pawlowski <jpawlowski@google.com> Move startAdvertising() logic into native code (1/3)

AdvertiseManager.startAdvertising() was implemented in Java layer for
historical reasons. Now that we have nice native callbacks and tests,
it can be moved into native code, where it will be shared between
Android daemon and bluetoothtbd.

Bug: 30622771
Test: native tests added to cover startAdvertising
Change-Id: Ifee1fc74ad3e749ffc0c6a734e450c540b5b59bb
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
6d5a03f00fc00a4fe9d9e2bd1e6a2abc8ffc5284 04-Nov-2016 Jakub Pawlowski <jpawlowski@google.com> Unify advertising API (3/3)

This patch unifies advertising API. On startup, if VSC multi advertising
is avaliable, it will be used, otherwise
BleAdvertiserLegacyHciInterfaceImpl will be used, which provides one
advertising instance.

Test: sl4a tests are passing, all proper tests updated accordingly
Change-Id: I899ed51bf4e747e1e3ff1a472a55f060249cbb75
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
97f86114a40281176c8feb81874427ee79c78745 03-Nov-2016 Chris Manton <cmanton@google.com> Merge "BLE Check and send scan response data"
4ded021f96d858848e68b0a901848211694bbe92 01-Nov-2016 Chris Manton <cmanton@google.com> BLE Check and send scan response data

If there is scan response data, load it up during
when start advertising. The current stack does
not provide callback for these calls.

Bug: 32539880

Test: Verified scan response occurs with CL

Change-Id: I33effbf3aa3a60c3353d4ca7708ea06df8a05a7d
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
4aad8ce02068598e90dd2cdcb8165dba9d152e22 31-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Move start advertise method to advertising interface (1/3)

Advertising related code should be exposed through
BleAdvertiserInterface. Move client.listen function into this interface.
Remove reduntant clientif parameter.

Bug: 30622771
Bug: 24099160
Test: no tests necessary
Change-Id: Ifa3ba482993264f2e737cb1ca44028941056631a
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
5335419d1b6f366c284037ca38524141f0e80d74 19-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Change how Advertise Data is passed to BTIF (3/3)

The way that AD data is passed right now put some additional
limitations, i.e. only one manufacturer specific data can be set, or
only one service UUID. By moving AD generation to upper layers, aother
set of limitations is removed.

Test: Covered by BleAdvertiseApiTest sl4a test
Bug: 30622771
Change-Id: I5444455a89ee085dcccfdc98846955374d58c374
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
a017a7dbd303ee779e876d2e8b25f2a5629cae78 23-Aug-2016 Jakub Pawlowski <jpawlowski@google.com> Bluetooth: split setting params and enabling advertising (1/3)

Proper order of commands when starting advertising:
* set parameters
* set data
* enable advertising

This cannot be achieved when setting advertising parameters and enabling
advertising is put together in one function. Enabling before setting
data might cause first advertisements to be empty. If a device with
hardware filter pick up such advertisement, it might fail to properly
recognize our device.

Bug: 30622771
Bug: 19372779

Change-Id: I66c71f1b2c07c832eda0983ead816741798e923b
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
64bf8e33481bb787aec895c603748eedb634a93b 13-Jul-2016 Jakub Pawlowski <jpawlowski@google.com> Separate advertiser from GATT client (2/4)

Bug: 30622771
Change-Id: Icacf1fa6a526d67ffadb8acc056d2acfefc5e895
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
c6064ccebc5f55b49628296ce578288b3ad704e1 19-May-2016 Ian Rogers <irogers@google.com> Fix a test related to GATT client that could never succeed

Caught by Error Prone:
warning: [CollectionIncompatibleType] Argument 'clientIf' should not be
passed to this method; its type int is not compatible with its
collection's type argument AdvertiseClient.

Bug: 27723540
Change-Id: I395b17a46c3734afd0f49866b7aa0bd0f1c6cef4
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
ba73d4b554ff0016d6b11a6102c2a75b5b0c149d 12-Nov-2014 Matadeen Mishra <matade@codeaurora.org> GATT: Fix FD leak caused by GATT profile

Use case: BT ON/OFF with one BLE APP active

Failure: FD leak is observed with ON/OFF stress test
which eventually lead to crash due to unavailability
of FDs.

Steps:
BT ON/OFF with one BLE APP active to retain the
same Bluetooth process ID to check the FD leak issue.

Root Cause: As the Advertisementi manager and Scan
Manager are not cleaning up the looper instances as
part of cleanup, it causes FD leak.

Fix: Cleanup the handler threads in Advertisementmanager
and ScanManager so that there are no resource leaks.

Change-Id: Ia51899f449d57c1ef68a9516b8472d1fd492572b
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
a1664d61821a59145f8095a75373403a0c54244e 23-Sep-2014 Wei Wang <weiwa@google.com> Add support of advertising through standard instance.(2/4)

Use standard advertising instance if peripheral mode is support but multi adv is not.

Bug: 17552672
Change-Id: I21044665d0ac38f84abb95bfe1348d7bf83bfd2a
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
96509d5ff7109bc42a4c25143f70ec41a127d109 03-Sep-2014 Wei Wang <weiwa@google.com> Fixed batch scan returning status 12 when restarted.

Also fixed no batch scan results when both truncated and
full batch are enabled.

Added a BatchScanParams to hold parameters for batch scan.

Bug:16850169
Bug:17213118
Change-Id: Ib3bb7442aa2657912ef4377f825388ac8e1010bb
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
d54785926fc0150661b6e70d5d0dabef87be3d73 25-Aug-2014 Wei Wang <weiwa@google.com> Merge "Fix API council review comments. Also hide certain APIs(2/3)." into lmp-dev
039bf1606bddb3794fd6aa9adee704733f89544f 12-Aug-2014 Wei Wang <weiwa@google.com> Fix race condition when advertising app dies.

Bug: 16565960
Change-Id: Ica801a1186e62fcba666deabe5989dd47d404b68
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
db0920ed7d9ef5385e36dfa922f351e4e6556a3e 15-Aug-2014 Wei Wang <weiwa@google.com> Fix API council review comments. Also hide certain APIs(2/3).

b/17006825

Change-Id: I6c0e739e44f8a9d26f3f2b03937b38d4dec893e7
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
755ef770144daf1a0fbbabaa310bc300190dfd9c 08-Aug-2014 Andre Eisenbach <eisenbach@google.com> Merge "LE: Add limited advertising duration capability (3/3)" into lmp-dev
c1512abbe9bb60c94c5f46e90918983d1514c8e3 08-Aug-2014 Andre Eisenbach <eisenbach@google.com> LE: Add limited advertising duration capability (3/3)

Change-Id: Ib025d8a10cce07e8f731c005d963245aa988be73
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
00975169ba4eb5251397a66532ee9a3288c0f137 05-Aug-2014 Wei Wang <weiwa@google.com> Clear pending data and allow all filter when batch stopped.

Also send batch data to multiple clients for full batch.

b/16802098

Change-Id: Ife1723b818531fcf2cff897686f33f6b0a1d0aaa
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
18999c2cfd477050de0ca88c3a73458235d82656 30-Jul-2014 Wei Wang <weiwa@google.com> Add a default impelementation of IBluetoothGattCallback(2/2).

b/16636127 Explicitly use UTF-8 for ScanRecord's local name

Change-Id: Ib152239cdee0becf3f49f1b610dfe1c2296c3647
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
7dca73a9bdbdbbea93bb0b6150702d21c533b229 01-Aug-2014 Wei Wang <weiwa@google.com> Merge "Change service data and manufacturer data to be repeated." into lmp-dev
e34b91565499994a4b04a1014432c8f90678972a 30-Jul-2014 Wei Wang <weiwa@google.com> Change service data and manufacturer data to be repeated.

Change-Id: Ie45ca40d3d84d192d65003ea3ac9ad428b281f94
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
61b76fd94c45ee1909cde1d08a643fc031ef287f 31-Jul-2014 Yicheng Fan <yichengfan@google.com> Remove client from advertiseManager correctly

Bug: 16711409
Change-Id: I3881593818edcf822ec07353da4a5ea6970f5d7c
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
bebb0fe84fe06a47bd88cdfb9cba8ffe4d2c463a 26-Jul-2014 Wei Wang <weiwa@google.com> Combine manu id and data before setting to stack.

Change-Id: Idef33daa87939a0533dae37dad53a827155d79ca
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
86c292ab0f0fed25345a2eaef0fd92ff9c72a9e5 24-Jul-2014 Wei Wang <weiwa@google.com> Use scanner for lagacy LE scan (2/2).

Change-Id: I273e7a2b6687f38d051c3264ff1bbb0025507820
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
f206ddd8115bdcb66ecee0c6feac35b3dc8d4da2 19-Jul-2014 Wei Wang <weiwa@google.com> Fix build

Change-Id: I0e4f8ffec53f606c75dbfae0db50da51118d8ddf
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java
27bd5f277ccf471f2fa9cd9151a2a226b51bc825 16-Jul-2014 Wei Wang <weiwa@google.com> Add an AdvertiseManager for LE advertise operations.

Move all advertise logic out of GattServiceStateMachine.

Change-Id: I9bc9be29372e79e863fc6a0b16d4808918bfb404
/packages/apps/Bluetooth/src/com/android/bluetooth/gatt/AdvertiseManager.java