| 9b1b93772df8a52bcb22a1eccadfa9a31614fa3d |
|
14-Jun-2017 |
Gary Mai <garymai@google.com> |
Fix NPEs in shortcuts
Contacts with no data will have null for their display name which in
this version isn't caught.
Add null checks and use R.string.missing_name when a contact has no
display name.
Test: Manually verified no crashes on a Pixel with O-DR when :
* adding shortcut from overflow menu in QuickContact for a contact
with no name
* selecting a contact with no name when creating a shortcut by
long pressing the home screen
Bug: 62590004
Change-Id: If0c5d93a472d1d47c6657f72ae9e202c335de75c
/packages/apps/Contacts/src/com/android/contacts/ShortcutIntentBuilder.java
|
| dbf3e83dff7f60cf188c2ace57c691b30e163ce5 |
|
01-Jun-2017 |
Gary Mai <garymai@google.com> |
Fix shortcut icons on O
Use IconCompat to create the adaptive icons. When attaching the icon
to the result intent for ACTION_SHORTCUT on >= O use
IconCompat.addToShortcutResult(). Otherwise continue to manually add
it for pre-O.
Test: Manually verified creating shortcuts on N M and O still work as
expected.
Bug: 62112388
Change-Id: I07f5a8ffd1f49edb4c21aaa572b42f641111e798
/packages/apps/Contacts/src/com/android/contacts/ShortcutIntentBuilder.java
|
| 02c3dee53a1be051bc7369d401585cfe87e7c5d7 |
|
06-May-2017 |
Gary Mai <garymai@google.com> |
Fix adaptive shortcut icons
Use adaptive icon for the static add contact shortcut.
Add O specific shortcut icon size.
Instead of adding padding after already getting the drawable from
the letter avatars, scale the drawable down by the same percentage
to get the padding. This eliminates the extra transparent part around
the icons, which led to the launcher filling in with black.
Test: manually verified on Nexus 5X with O
(https://screenshot.googleplex.com/Pa1t37DqeNJ)
and Pixel with O
(https://screenshot.googleplex.com/qujpyze1Euz)
and Nexus 6P emulator running N
(https://screenshot.googleplex.com/1KWQPx8RZFC)
and Samsung Galaxy S7 running M
(https://screenshot.googleplex.com/J39VES1jT8o)
Bug: 37922561
Change-Id: I6573f91e5441333eda05ec2640dc5137890be317
/packages/apps/Contacts/src/com/android/contacts/ShortcutIntentBuilder.java
|
| 331d6508a23d79e754fb756a07bf3aaf5e0dcd9f |
|
13-Apr-2017 |
Hyunyoung Song <hyunyoungs@google.com> |
Change to AdaptiveIconDrawable.getExtraInsetFraction()
b/37079814
Test: manual, builds
Change-Id: Iba2c388d9aaac5cb4b451e9b60e6dd76785c6862
(cherry picked from commit 47af0f491e945f5f52e892d911503131959e5b02)
/packages/apps/Contacts/src/com/android/contacts/ShortcutIntentBuilder.java
|
| a80b937c0e7f98c547066ce3750b808645ac1ea9 |
|
22-Mar-2017 |
Gary Mai <garymai@google.com> |
Use Icon.createWithAdaptiveBitmap on >= O
Add padding around the bitmaps so the icons still look right.
Test: Manually verified shortcuts created on:
L, M, N, and O all look correct
O was tested on a Pixel.
Bug: 36405262
Change-Id: Ie14209357b91a866225a315d1c3355bc228c8dff
/packages/apps/Contacts/src/com/android/contacts/ShortcutIntentBuilder.java
|
| 191868386add89315f5bc8057dfa6b64f627c960 |
|
17-Mar-2017 |
Gary Mai <garymai@google.com> |
Add type for action (call/sms) shortcuts
Update all pinned shortcuts that are SHORTCUT_TYPE_CONTACT_URI.
Test: Manually verified pinning short cuts on O.
Also see that pinned shortcuts for quick contacts are updated
when one of them changes.
Bug: 34128487
Bug: 36032908
Change-Id: I2237dda56cc83caa55f175c7d4ed2b4a86031e0f
/packages/apps/Contacts/src/com/android/contacts/ShortcutIntentBuilder.java
|
| 08d87ee355cdac231c9ca4ef16bcfa5451a1a0b4 |
|
15-Mar-2017 |
Gary Mai <garymai@google.com> |
Adopt O shortcut changes for Intent.ACTION_CREATE_SHORTCUT
If we're on O, use ShortcutManager's .createShortcutResultIntent
and return that to the launcher.
Move ShortcutIntentBuilder out of list package since it doesn't
really make sense in there. Also allows us to keep DynamicShortcuts'
methods package private.
Test: Manually verify shortcuts created by long pressing on the
home screen (Contacts 1x1 widgets) are the newer app shortcuts on O
and are legacy shortcuts on pre-O (L, M, and N).
Bug: 36032908
Change-Id: Ic78c21daf223b59b45cbc98ceea2726fc29c055c
/packages/apps/Contacts/src/com/android/contacts/ShortcutIntentBuilder.java
|