History log of /packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
a181ca6021333cbb96ff9a6abeec9e64ea19c7f9 21-Dec-2016 Marcus Hagerott <mhagerott@google.com> Replace several usages for of AccountTypeManager.getAccounts

Test: Ran GoogleContactsTests

Bug 33627801

Change-Id: Ifde6c5f314558159bb468c92fa38b20a8d90bf06
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
75895e73379aa26a3d4135c772af4ecb8a79b4c9 13-Dec-2016 Marcus Hagerott <mhagerott@google.com> Add AccountInfo class

This holds the AccountWithDataSet, AccountType and AccountDisplayInfo
for an account because many usages of accounts need all three of these.

Test: manually verify that accounts in nav drawer are correct

Bug 33627801

Change-Id: I39962f9945714aa7ce48aca97f220f119a1741cd
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
e7a71cbbe8929a9d8a7ca0a3b5668646d49a611a 10-Dec-2016 Marcus Hagerott <mhagerott@google.com> Load accounts in background for SIM import

Test: manually verify SIM import screen displays accounts and preserve
checked state after rotation

Bug 33627801
Change-Id: Ie6545785db95febacff8c4fab2734ff7cdbb351c
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
0a49afa2ad697307cc04ef4cb86570574fa720f2 06-Dec-2016 Gary Mai <garymai@google.com> Collapse common package (2/2)

Ran optimize imports on the project as well to re-order everything
which would have changed because of removing common.

Test: Built GoogleContacts, GoogleContactsTests, Contacts,
ContactsTests and ran unit tests.

Bug: 33252370
Change-Id: I881f0ba8b8fef002b6eeefa9a16b34f15b2fd2a9
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
69c182afb0e6d82a341a28b4317aa703af768906 05-Dec-2016 Gary Mai <garymai@google.com> Collapse common packages (1/?)

Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.

Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.

Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
95246bb89a1c45459fe15eefdc6d924963247944 11-Nov-2016 Marcus Hagerott <mhagerott@google.com> DO NOT MERGE Add notification for SIM import

This provides feedback to the user if the import takes some time. Also
moved SIM import into it's own service instead of ContactSaveService
to prevent blocking the save service with a long-running operation.

Test
manually verified that notification is displayed when contacts are
imported from the SIM card

Bug 32781237

Change-Id: I8f26e524a08b62f69ff06ddb45cec2db5e98fe24
(cherry picked from commit ba47b41205ddcc3872d52bede1f6aaffb4c874b8)
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
c8b04ba7a0efa8b029d3615867ec9d03ccb957ff 24-Nov-2016 Marcus Hagerott <mhagerott@google.com> Fix crash after rotating SIM import screen on LMP

Test
manually verify that no crash occurs when rotating SIM import screen
on LMP emulator

Bug 33108913

Change-Id: Idcee6fa98f4cefb83aed60bf9648d69748a0c83b
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
a8b448a11f0a932366caf465027391017d1db709 18-Nov-2016 Marcus Hagerott <mhagerott@google.com> Make SIM import screen an activity

This fixes an accessibility bug where the toolbar navigation icon was
announced instead of the title when the screen is displayed

test
* manually verify that SIM import works as previously when launched from
settings and from assistant.
* manually verify that activity label is announced instead of navigation
icon

Bug 32947074

Change-Id: I1116d626f13842ad78e287c98dd3a051796b1f5f
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
e12757940ad6432ff0ed02bf4f8d4c8107a21ed3 17-Nov-2016 Marcus Hagerott <mhagerott@google.com> Include item disabled state for talkback in SIM import

Test
manually verified that SIM import list functions the same as previously
and that disabled state is now included in talkback description for
items

Bug 32950353

Change-Id: Iff93cde51b0d5d0edfb1096e5bfd539c68de941a
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
cfb2cd877fc232d86c1dd14d20d176350466f568 17-Nov-2016 Wenyi Wang <wenyiw@google.com> Merge "Make checkboxes not clickable" into ub-contactsdialer-h-dev
6c46e5b3b49e807e9806ae84186f64e0cf7d38c9 17-Nov-2016 Wenyi Wang <wenyiw@google.com> Make checkboxes not clickable

Bug: 30443581
Bug: 32950580

Test:
1. manually verified the following lists work well:
- all contacts / account view
- group view
- send-to view
- contact selection view (for adding contacts to group)
2. unit test

Change-Id: Ife4a31725ca31125c901ca9f9f1621422066342b
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
7c504673071be0219de0de58d6465932c8bd24e7 16-Nov-2016 Marcus Hagerott <mhagerott@google.com> Tweak end padding for checkbox in SIM import

test
manually verified appearance of SIM import screen

Change-Id: I07a18bee138b1704dcb8b113c0cab86fc400beff
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
115495cdba32af45a96ce146bb6b7499016e95b9 14-Nov-2016 Marcus Hagerott <mhagerott@google.com> Merge "Store selected state for all accounts in SIM import" into ub-contactsdialer-h-dev
48a2936c227b840ec93ebbd3c72786ccc9ccb006 14-Nov-2016 Marcus Hagerott <mhagerott@google.com> Store selected state for all accounts in SIM import

Previously only the selected state of the selected account were saved.

Test
manually verified that selection state for each account is the
preserved after rotating the screen

Bug 32841057

Change-Id: I681f3911348c056ba73b4208b1e2da5dc3fbc8ea
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
7217e6986c333aebb885b0a07a0a9344ef7a814c 10-Nov-2016 Marcus Hagerott <mhagerott@google.com> Update SIM import UI to match designs

Test
manually verify appearance of SIM import screen

Bug 32748785

Change-Id: I660d848880e6416fdb9c25f8a3c52a6597e64e0a
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
7333c37e858802a02ae46c49e726ce9a2bf94c9e 07-Nov-2016 Marcus Hagerott <mhagerott@google.com> Add ability to detect that SIM import is in progress

SIM import might be long running so things may need to be updated
when it starts rather then when it completes.

Test
See Iae69fe2d96bae6d268f77515ca85eb572c2dfe9b

Bug 31781331
Change-Id: I9efdb181b97f3fdf49cd31ba5d3eae43bcad674c
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
25251581a3045afa72a6771e29fb01929721be4a 03-Nov-2016 Marcus Hagerott <mhagerott@google.com> Fix talkback when tapping on disabled SIM contacts

Test
manually tap on disabled contact with Talkback on and verify that
snackbar is announced

Bug 31781331

Change-Id: I202349a5f7879f3446c632154ab7d9aa50eaacd6
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
b0914bcbaff3dd494613d441466e1c549e57e97e 02-Nov-2016 Marcus Hagerott <mhagerott@google.com> Remove avatars from SIM import

SIM contacts can't have a photo anyways.
Also fixed clipping when the SIM import list is scrolled.

Test
manually verified that avatars aren't displayed on SIM import screen

Bug 31781331

Change-Id: Iee958c90dfb4759d5a18ecc2b5bce5cdffbaae99
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
6c42b4c3cdfa23031b7cad5d90b68647b75a3948 31-Oct-2016 Marcus Hagerott <mhagerott@google.com> Disable only for current account in SIM import

SIM contacts are now only disabled if they exist in CP2 in the account that
is current selected in the SimImportFragment.

Test
manual:
1. have device with multiple accounts
2. import contacts from SIM card
3. go back to SIM import screen
4. verify that contacts are disabled and unselected when account from step 2
is selected
5. verify that contacts are enabled and selected when a different account is
selected

Bug 31781331
Bug 32575794
Change-Id: I682c678bfccf78abfcc67cb354efe7bd92fb3676
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
2aa3198b6881c3272a0295fec85646e7ef2282cf 25-Oct-2016 Marcus Hagerott <mhagerott@google.com> Disable existing contacts on SIM import screen.

Test
manual: import some SIM contacts and verify that they are disabled when opening
the SIM import screen the 2nd time.

Bug 31781331
Change-Id: I670a4650281246682dbce9320ef65e517bfe0f31
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
66e8b228b4dc76bf63a138de3087574adf694e87 24-Oct-2016 Marcus Hagerott <mhagerott@google.com> Add better support for importing from multiple SIMs

For I102f4f14ae976e550f65c83ee695d7cdc241e4e1

Test
See I102f4f14ae976e550f65c83ee695d7cdc241e4e1

Bug 31781331
Change-Id: I849e441d1ab42bff135b300b34595eb8ed468005
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
73b283f03cd2697ad0098711d62cd0956037952f 22-Oct-2016 Marcus Hagerott <mhagerott@google.com> Preserve SIM import checked state after rotation

Test
Manual:
* select import from SIM in settings
* uncheck some contacts
* rotate screen
* verify that same contacts are checked after rotation

Bug 32315354

Change-Id: Iad84d308ab61d813219bdd23e158f3c5acb969e8
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
da071fbbb186288a1c0363c0ecc1c3c3b1f31ed9 13-Oct-2016 Marcus Hagerott <mhagerott@google.com> Improve talkback usability of SIM import dialog.

Test
Manual: navigated SIM import dialog with talkback enabled

Bug 31781331

Change-Id: Ie58866469f816fae586ae1fa1878c905daea0d60
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java
819214d472fdadf3d69cb4580e238506194ed30e 29-Sep-2016 Marcus Hagerott <mhagerott@google.com> Create new SIM contacts import screen.

This is needed since SIM import is going be surfaced more prominently via an
assistant.

Test
Automated: Ran GoogleContactsTests
Manual: verify that contacts are imported when launched from settings

Bug 31781331

Change-Id: I55ea078056038d348d5b6f05f91f5159e1ee39d3
/packages/apps/Contacts/src/com/android/contacts/SimImportFragment.java