| 57a0e98eed836b72dd3dc3540b9cac029266ed7c |
|
25-Mar-2017 |
Wenyi Wang <wenyiw@google.com> |
Add isLoggable checks to all verbose and debug log outputs (1/2)
Bug: 6813854
Test: built apk and verified log is seen in logcat
Change-Id: Ib17cac0d2d9553276c4271221110305ab2d70a46
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ad21212b197c2a789d4a55709819bea7812ea7ba |
|
09-Feb-2017 |
Gary Mai <garymai@google.com> |
Merge "Handle revoked permissions when resuming the app (1/2)" into ub-contactsdialer-i-dev
|
| 1e899dc127a212bfd2198fe7adba5c33eb4cd751 |
|
08-Feb-2017 |
Gary Mai <garymai@google.com> |
Handle revoked permissions when resuming the app (1/2)
The activities that create these fragments will request permissions
but if these fragments were created and the permissions were revoked
then Activity's super.onCreate() will recreate these fragments before
the permission activity is started, which causes a bunch of issues
since the original activity never finishes it's onCreate method so
many things aren't initialized for the fragments.
So in activities that maybe start the permission activity and have
visisble fragments, instead of returning, continue initializing
everything.
In the case of editor, not being able to select a raw contact delta
is a legit case so it should have been handled as a failure and in
general we shouldn't be attempting to bind the editors if we don't
have the permissions.
Test: Manually verified removing permissions and going back to the
app from the recent apps screen doesn't crash while viewing:
* main list
* groups view
* first level suggestions
* duplicates view
* account view
* editor
* settings
* pick group member to add view
* pick phone numbers to send to from group
* pick emails to send to from group
The behavior is permissions get requested and will go back to the
original activity (PeopleActivity with main list loaded or the
editor activity).
Bug: 34741297
Change-Id: Ie234b1f44e83372b9c0ad9658fa4a2e9b40572b0
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 8d26c0a7214cf6520a4def851afa138a133a68a2 |
|
08-Feb-2017 |
Walter Jang <wjang@google.com> |
DO NOT MERGE Revert "Start ContactSheet instead of QuickContacts (1/2)"
This reverts commit 581585d9ad2e7d3d4b65798acaa0fa462d30710d.
Test: see I5ad160778d29a78e965fd7cb2ded67b017f4ab9a
Bug: 32604475
Change-Id: If92ea63ed5dbd8d62e3a9f84a8fcd953fa4c9738
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 9f691e8b1c30dcdae230daebd26da0f225f74008 |
|
11-Jan-2017 |
Gary Mai <garymai@google.com> |
Fix editor crash when rotating during contact insert
Remember the current account being saved to when setting state
for a new contact. Otherwise when during an insert it will never
get set unless you select a new account from the switcher dropdown.
Since it's null once the account load is finished it goes through
the set state for a new contact code path again which adds another
RawContactDelta to the list which breaks some of our assumptions
regarding the size of mState.
Test: Manually verified no crash occurs after rotation when adding
a new contact from:
* the fab
* recommendations assistant
* third party apps (dialer/messenger)
Bug: 34126254
Bug: 34131358
Change-Id: I874cc592f94584a98e54010751c557cfd3b0d389
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 80ab7ea6a518410594058c74f32c4b551097edbd |
|
03-Jan-2017 |
Marcus Hagerott <mhagerott@google.com> |
Prevent editor from closing after account is added
When the ContactEditorAccountsChangedActivity is shown (when creating
a new contact with no default account set) and a new account is added
the editor would close once an account was chosen because a new activity
instance was being created.
Test: manually verify that editor remains open after adding account
while choose account dialog is displayed
Bug 33627801
Change-Id: Icdfbceb0fc2e10619afde4fa772a2efaa21a0c5e
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 8c6b5bdb3812fcbe5680fafca59d2ab9ec90d839 |
|
22-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Add convenience methods for account loading
Test: ran GoogleContactsTests
Bug 33627801
Change-Id: Ib673838d9b041e5dc512a94bfaf47b4caf4a540f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| fbfeaeb4f2f5039f83dcf96caa924af4084685a5 |
|
21-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Merge "Use loaded accounts for editor account prompt" into ub-contactsdialer-i-dev
|
| c40f3e945c43ff1ff90abb7fb2daf56aba315e10 |
|
21-Dec-2016 |
Gary Mai <garymai@google.com> |
Use support toolbar in editor to fix issues in LMP
ContactEditorActivity has to switch to AppCompatActivity, and so
does its theme.
Use support AlertDialog in editor created dialogs so it uses the
appcompat theme correctly.
Test: Manually verified look and functionality of the toolbar in
LMP and on MNC.
Verified LMP cut/copy/paste toolbar appears over the toolbar instead
of pushing it down.
Bug: 33662452
Bug: 33587478
Change-Id: Ie6f4555a237b7a10877dd0b32615120b6d789646
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 807e6208d6bc4ff1a6b0b4d8900229df27077246 |
|
21-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Use loaded accounts for editor account prompt
Test: ran GoogleContactsTests
Bug 33627801
Change-Id: Id8bdf1d5a2a13bb526118b104bae06138f0333ac
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| b697ed768fb817f94524f6c3992547665df331c4 |
|
21-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Replace switches on resources with if-else
This is necessary for the project to build as an Android library which
is planned for Google3.
Test: ran GoogleContactsTests
Bug 33782320
Change-Id: I62f15486b7e976bb20a6e9c631dc8404a4170dbb
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 4bd50d69d2b8934dbd4cbd634ad83807d9b02735 |
|
16-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Use loader for accounts in editor fragment
Test: manually remove selected account in editor and verify that
it changes to the first account in list
Bug: 33627801
Change-Id: I6554f03c207fb761f7b8d971e0f07f7416efcd72
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 96e7fc65257e1aab2f1fc4f7900832514f584b0f |
|
19-Dec-2016 |
Gary Mai <garymai@google.com> |
Add null check before copying name fields
am: 860698b8d4
Change-Id: I4bb6db79340cb1a218739b7c3fcf5650b3beff4b
|
| 860698b8d4542a55da5ec40032a361433b525aad |
|
19-Dec-2016 |
Gary Mai <garymai@google.com> |
Add null check before copying name fields
Bail if either name value delta is null. This can happen because
external read only raw contacts may not have a StructuredName, such
as the ones created by the Signal app.
User facing consequence is the name isn't auto copied for them, but
without a StructuredName type declared by the read only raw contact
there isn't a reliable way to even get something to copy.
Test: Verified editing a Signal raw contact doesn't crash the app
and the editor loads with the same behavior as if a new contact was
being created.
Bug: 33622717
Change-Id: I87b513ca9f188750f0d5e4e5f5392e419565cf4e
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d14743263df73d2c715bca44962a181f5ac1ae3b |
|
19-Dec-2016 |
Gary Mai <garymai@google.com> |
Fix editor crash on rotation when no default account exists
am: c135a5d502
Change-Id: Ide3f311c0eaae6d53aa94f0d83029c599bace1a6
|
| c135a5d502130aee06ffcc11170513053396e9b0 |
|
19-Dec-2016 |
Gary Mai <garymai@google.com> |
Fix editor crash on rotation when no default account exists
Persist the current primary account in the fragment. Normally a
default account has to be chosen before a new contact is added
but when adding a new contact from an account view, that account
is passed in through an intent extra and set as the primary for
the fragment. On rotation it's lost because reading the intent
extras only happens when saveState is null.
Also remove an unused constant.
Test: Followed repro steps in the bug and verified no crash
happens and the new contact is saved to the correct account.
Bug: 33691259
Change-Id: I12a86af907be7d11980349583fa6d44b3097de15
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| bd9ef3c60669d71543b3506d4959c1fe4be409dc |
|
15-Dec-2016 |
John Shao <johnshao@google.com> |
Standardize and replace assets with vectors
Standarize naming of vector drawables and replace png
assets with vector drawables.
Test: build and run GoogleContactsTests
manual side by side sanity check with previous version
Bug: 33251913
Change-Id: Iafea5c1bba738c57437888da999fc2909d0765fd
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 1e24ae80f2ac1c661a90ee3a722ed521cbe9643f |
|
07-Dec-2016 |
John Shao <johnshao@google.com> |
Remove unnecessary variants causing apk bloat
We will see huge savings when string translations are removed
for values-sw600dp because there was special casing for tablets
in a error message that was too technical for normal users.
Also removes more holo assets that are now legacy.
Test: built Contacts and GoogleContacts
ran Tests
Bug: 33251913
Change-Id: Id9d3172fa4765f566dcc9832dcb6418164503aee
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 0a49afa2ad697307cc04ef4cb86570574fa720f2 |
|
06-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common package (2/2)
Ran optimize imports on the project as well to re-order everything
which would have changed because of removing common.
Test: Built GoogleContacts, GoogleContactsTests, Contacts,
ContactsTests and ran unit tests.
Bug: 33252370
Change-Id: I881f0ba8b8fef002b6eeefa9a16b34f15b2fd2a9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 69c182afb0e6d82a341a28b4317aa703af768906 |
|
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c000d2ee0e292d9b160f65ab74ebd1258346046b |
|
18-Nov-2016 |
Gary Mai <garymai@google.com> |
Add null check to Uri when getting the name to toast
When all contact details are removed from a contact when there are
no accounts (potentially if it's the device account) the contact is
fully deleted, so the Uri is null when we try to get the name to
display. Bail early and return null in this case.
Test: Verified no crash and consistent behavior with previous releases
when removing all contact info from a contact when no accounts are
present and when deleting all info from the ME profile with Google+
contacts sync turned off.
Bug: 32982336
Change-Id: I0fd236080750a5040a5c9ffd80a48a37cb1f8ae3
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d8f3da6a4ea4054bd47959db85657a7e01d28358 |
|
18-Nov-2016 |
Gary Mai <garymai@google.com> |
Set editor activity title for talkback
The toolbar will display the correct title for visual purposes
while setting the activity title will have talkback read out
the title when entering the activity.
Test: Manually entered editor activity for
* editing an existing contact
* adding a new contact
* viewing a read-only contact
and verified talkback read the proper title.
Change-Id: I77e366073e725734aa8ac29f52bb760b5e58c02f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 15646ce3e2e7a7f889976dc5684ecbc3029230c2 |
|
17-Nov-2016 |
Gary Mai <garymai@google.com> |
Use toolbar in editor
Lets us change content description of the navigation icon a bit
easier.
When it's an X read out "Cancel button".
When it's a back arrow read out "Back button".
Left the toolbar within the activity instead of putting it in the
fragment to reduce risk/testing needed for making this change.
Test: Manually verified for the above for:
* editing a contact
* adding a new contact
* viewing a read-only contact
Bug: 32950789
Change-Id: I125728786bdf3872e141863f60d38b34e01bb757
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| b9065ddb28a2040cabda251891be2062b5260217 |
|
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Implement linked contact menu option
Remove unlink option from QuickContact.
Link now appears when the contact has only one raw contact.
Otherwise a new "View linked contacts" menu option appears.
This dialog shows all linked contacts (including read-only) and
has buttons for adding another contact or unlinking all of them.
Show progress dialogs for each of these actions.
Test: Manually verified:
* View linked contacts only appears when there are more than one
raw contacts
* Link appears otherwise
* Pressing add goes to the contact picker and correctly joins the
selected contact
* Pressing unlink opens the confirmation dialog
* Canceling or dismissing the confirmation closes everything
* Unlinking from the confirmation does the unlink
* Confirmed the above with rotating on each dialog and during the
progress dialogs
Bug: 32707898
Change-Id: I39435a07fefce4276e34ba302001ff3dab352516
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 7b75145e9b4fcd46c3cbb5678f8842934467b3aa |
|
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Copy display name from the correct raw contact
Save a copy of the loaded Contact.
If editing multiple read-only contacts, get the name from the
one that contributes it to the contact's display name.
Test:
Manually verified the correct behavior
Bug: 32477129
Change-Id: I6308d645b1030ed0f317aafc907db8ba762750c2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 079598fa2e09c22bb672715a9559b9d8973044d5 |
|
03-Nov-2016 |
Gary Mai <garymai@google.com> |
UX updates to read-only view of raw contact
Use back arrow for navigation icon.
Use "view only" string for title.
Change account header per screenshot in bug.
Test:
Manually checked and verified headers/navigation icons/titles of:
* view of read-only raw contact
* edit view of writable raw contact
* add new contact
Bug: 31868376
Change-Id: I1d390f785bf4c0de90102e6a9e02477a8c19ddee
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 3107b25dcaea54943c58f984084fa9b348ea1885 |
|
03-Nov-2016 |
Gary Mai <garymai@google.com> |
Show "add account" dialog when it needs to appear
Don't show the dialog if the only account is not a device account.
Set the default to be the only account if it is *not* a device
account.
Test:
Manually checked:
* Removing only account and attempting to create a new account shows
dialog
* Clearing preferences shows dialog
* If dialog was canceled, verify dialog doesn't appear anymore.
* After adding a google account, (and without manually setting default)
verified adding a new contact did not show a dialog and the default was
automatically set to the only account on device.
* Having two accounts and no default shows the pick default account dialog
* Removing multiple accounts still has the same behavior as bullet 1
Bug:32555078
Change-Id: Iec664efca7e886d7376cd2aae7c5b2bdad3a8b84
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 678108ebb9926a79ad0d7ac4f11417dec1583d42 |
|
26-Oct-2016 |
Gary Mai <garymai@google.com> |
Change aggregation suggestions to be raw contacts
Each suggestion is a raw contact that belongs to the same account
of the currently edited raw contact.
Surfaced data is the raw contact's data.
Pass the current changes to the newly selected raw contact.
Remove a few unneeded methods.
Removed the join option for tapping on a suggestion since all raw
contacts selected from here will be editable.
Since QuickContact depends on the aggregation suggestion engine to
return contact level suggestions also removed everything related to
it there since it's currently disabled.
b/29216287 tracks plans bring it back but it probably won't be in the
form of using the suggestion engine to populate the card, so it felt
okay to remove the code. Layouts were left in case they can be reused
later.
Test:
Opened QuickContact
Tested the suggestions for a contact with multiple raw contacts both
in and out of the current account and made sure only ones in the
current accountwere shown.
Checked contact with raw contacts which have different names, made
sure those displayed correctly. CP2 doesn't store the alternative
versions of raw contact names so the primary one is always shown
which is a non-regression.
Bug: 32277025
Bug: 32278866
Bug: 31088704
Bug: 31704115
Change-Id: Ibd4bdaaf100ffd5524eebac300d23763bbe6a22d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 5336e6ef1924162b94942cbd8f69202d553822da |
|
23-Oct-2016 |
Gary Mai <garymai@google.com> |
Forward intent extras to editor activity from springboard
Apply the extras once we have selected a raw contact to edit.
Test:
Selected an existing contact to add to and saw passed in
data was correctly applied.
Tested cases where editor auto loads, and picker dialog shows up.
In the case of the picker made sure that selecting any of them
would have the data passed through.
Bug: 32345528
Change-Id: I9a4088b3358ab532362c878394c657781965fb03
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a4adae163d83db9226b831f8c9705914e68b5cd1 |
|
23-Oct-2016 |
Gary Mai <garymai@google.com> |
Update editor menu options
Remove pick ringtone and send to voice mail options.
Add Help & Feedback option.
Test:
Checked options menu when:
* Adding new contact
* Editing existing contact
* Viewing read-only contact
Checked feedback screenshots for the above
Saw Help & Feedback had articles for both adding and editing contacts.
Bug: 32339015
Bug: 32336608
Change-Id: I7f591714062fed3bd70a2e1997305b2779148f89
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| db22bd6950cde01af63fec7991d7aa3aea259244 |
|
20-Oct-2016 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Update logic on when raw contact picker dialog is shown" into ub-contactsdialer-h-dev
|
| 5a00de39004d298de4daee3e183add5eff17102c |
|
20-Oct-2016 |
Gary Mai <garymai@google.com> |
Update logic on when raw contact picker dialog is shown
Shouldn't be based on count of raw contacts, but whether writable
raw contacts exist.
Test:
Edit me profile that has 2 G+ accounts linked (where the me profile
has not already been created)
Edit an aggregate composed of 2 read-only accounts.
Edit aggregate of 1 write 1 read
Edit 1 read-only
Edit 1 write
Bug: 32289543
Bug: 31826229
Bug: 31088704
Change-Id: Ib01445b59fa9fc882a6d32d24f39917d726e6174
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 92b36e91dc520ab744f399d253d63401d8107b09 |
|
20-Oct-2016 |
Jim Laskey <laskey@google.com> |
Merge "Toast fixes for deletion and save" into ub-contactsdialer-h-dev
|
| e5a140a1b60854a08a0ea0dc2068e9bf7cb058e6 |
|
19-Oct-2016 |
James Laskey <laskey@google.com> |
Toast fixes for deletion and save
Bug: 32243988
Test: Save contact from editor in alternative display mode.
Test: Delete contact from editor in alternative display mode.
Test: Save contact from editor with only phonetic or email or company.
Test: Delete contacts from list view with default and alternative
display mode.
Change-Id: I82df2377692ea129a54a3f0f00948201d4d1411e
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| df86ede2101d902eb95838adf4176c89d9263c89 |
|
19-Oct-2016 |
Walter Jang <wjang@google.com> |
Update phenotype usage for GMS V4 (1/2)
Test: see ag/1555402
Bug: 31989967
Bug: 26400050
Change-Id: I806129e8593e091e2aa120e530d588efa5a0d508
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 36ceb4235ed685a222af86076dcf160ba124a583 |
|
17-Oct-2016 |
Gary Mai <garymai@google.com> |
Always write current state in EditorFragment
When the choose default account activity dialog is shown,
mState in EditorFragment is empty, so it doesn't get written to the
out bundle. When we come back to the fragment save state exists
and null is read.
Test:
Followed repro steps in bug. Only repro'd when don't keep activities
was enabled.
Bug: 32118572
Change-Id: I80e972cf18ac1b460a849a8e5a2cc8853bac62c4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 5eda257528e45fe6ae59cca3f1178590b53662f8 |
|
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Disable delete and unlink in editor
They currently work on a Contact level, so that functionality
has been moved to QuickContact.
They'll be re-enabled once they're raw contact based.
The attached bugs are tracking that effort.
Also disable link. That also makes more sense to live in
QuickContact since you're linking another Contact.
Test:
Manual check to see those items aren't in the menu
Bug: 30771904
Bug: 31827701
Change-Id: I96ba7d10c78a157c0d1374e81ad096cec414815b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d7faa65c1349a7ded4d2d478822c07d024e5e792 |
|
03-Oct-2016 |
Gary Mai <garymai@google.com> |
Remove account selector when editing a raw contact
Keep the header, but remove the onClick drop down.
Remove the boolean for if the raw contact is read only,
and use the current state to determine if that's true.
Test:
Applied this commit on top of the spring board one and tested:
1) edit read only raw contact
2) edit writable raw contact
3) edit contact made of single read only raw contact still opens
the insert a new raw contact version
4) insert new contact
Bug: 31826229
Bug: 31088704
Change-Id: Ia8e5b0a5965b77b0c160336ce81ddac801b201ff
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 62ec0b10c0ddc00053df39aeaed1f3316116e849 |
|
07-Oct-2016 |
Gary Mai <garymai@google.com> |
Ensure structured name exists when creating a new delta
When I was able to repro the NPE, the RawContactDelta had the five
entries that were ensured in createNewRawContactDelta. The only
likely cause is mIntentExtras is either null or empty so
nothing is copied over and the entries are empty.
Test:
Opened the editor for a single read-only contact a bunch of times.
Bug: 31874062
Change-Id: I7f47ff766457f3daf2099344661a3f5caf92388d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a6c80b378e03ebdf6b654dbdb12f2c665fe98a80 |
|
01-Oct-2016 |
Gary Mai <garymai@google.com> |
Implement editor springboard activity
Have the springboard handle edit intents.
Show a dialog if the contact is made of multiple raw contacts.
Go straight to editor if:
* Single raw contact
* Given a raw contact Uri
In the case of 1 read 1 writable, we still show the dialog
since there would otherwise be no way to view what data comes
from the read only raw contact.
The springboard does not handle legacy contact Uris and will throw
an exception if one is received.
Test:
Tested these scenarios:
1) Edit a single raw contact
2) Edit a single read only raw contact
3) Edit a contact made of >2 raws
4) Add new contact
5) Edit a contact made of one read only, one writable
6) Made edits and checked if quick contact continued to update
7) The relevant edit intents from the Test app
Bug: 31826229
Bug: 31088704
Change-Id: I4c1c44accc86521efce2081744189d25f00ec541
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 5c1bff2efa542ea112c3f2a1d1ed1e271c7691a7 |
|
01-Oct-2016 |
Gary Mai <garymai@google.com> |
Load all groups data from editor
GroupMembershipView needs all group data to determine which group
is favorites/default, so when we load from the editor use the old
selection string.
Test:
Followed steps in bug and made sure the contact wasn't booted from
the My Contacts list, and the selected labels were updated properly.
Also tested adding multiple new labels and saving those.
Bug: 31750797
Change-Id: I84b1be6c17f2acf46efc202fb81a2c180cc2bcae
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 363af60ea23e5a3b945005712a16564ab69db18b |
|
28-Sep-2016 |
Gary Mai <garymai@google.com> |
Rename editor files
Drop the Compact prefix since we only have one editor now.
Remove KindSectionDataList since it's now unused.
Test:
Tested build
Bug: 31088704
Change-Id: Ia5ac295804a14f79d0c837b151e33aabc60aa3d0
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 8bac28bebae51e53885a404cdf2dd4991000ba42 |
|
30-Aug-2016 |
Walter Jang <wjang@google.com> |
Remove full editor (1/2)
Test: Tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
Bug: 31088704
Change-Id: I1fce2873facefa39d7b468f1deda02acc674e3e1
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| dd7d456a080f48d93aa3a9f9b04da0f17a8833a7 |
|
08-Dec-2015 |
Wenyi Wang <wenyiw@google.com> |
Catch exception in starting ContactSaveService
This CL follows ag/798285 and adds try/catch blocks for all the places
that start ContactSaveService using static methods in ContactSaveService.
Bug: 23896510
Change-Id: Ie35cf0d213386a81a662777a5b37d6f3a3fc5633
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| e3373dceb689209533e95a2cfbfbf1d9008ab6f6 |
|
27-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't save editor before showing join suggestions
This requires us to pass the raw contact ID of the
contact to join to both the (new) confirmation
dialog and the contact save service so that we
have it to do the join after the save completes.
Bug 25314004
Bug 21956248
Change-Id: Icdcb2165a0e599dfa3745fe8a919b208d4a48b43
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2c7fdac948e7b815ff5ef3a6989b8f1f4eeba323 |
|
26-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't skip pending check when save to account changed
Bug 25231216
Change-Id: I342a25ce52735052c2b4d5a6620581067c68762a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c683d2273c4174c0e300ef2f4b17c77fb313da39 |
|
14-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bug when showing overflow menu in Compact editor.
Set default value for rawContact id to display alone.
BUG 24899070
Change-Id: Ibdb25080e62f669f9c466bf55e67dbbe63ff6afb
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ba6c41ca6da97f56f608a9ef92617f2401f8371e |
|
13-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Improve raw contact editor in Contact Editor.
1) When clicking save on raw contact editor, UI should return to
the quick contact UI.
2) Remove overflow menu on raw contact editor.
BUG 24899070
Change-Id: Iae6954744294fc48fe8dba02459f647f1764c48b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 91cee2852497e918e9e04a6fb549c1117ed47ae0 |
|
07-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bugs on Contact editor.
1) Remove primary photo checkbox in full editor. Primary photo should
be set in photo picker.
2) Remove save menu if there's only one read only contact in the full editor.
3) Add account type icon in account info when there's only one account
for a contact.
4) Return back to Compact editor after saving results in full editor.
BUG 24547289
Change-Id: I02f8ee01f7cc7d1b0b06ad338570dc4b17c55e31
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 655ad1a2eeb36171d5f6e407bf7704f56f5583ca |
|
06-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Show all merged accounts in Contact editor.
Show all merged rawContacts' accounts in Contact editor, not
just primary account.
Expand all accounts to a list.
Clicking each account (rawContact) will go to the full editor
to editor the rawContact.
BUG 24547289
Change-Id: I671a946f87b25d9393daccb600287e35826fa6eb
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d675315606e8be431e6e5487e0b1cc33036a6ed7 |
|
02-Oct-2015 |
Walter Jang <wjang@google.com> |
Delay loading groups until compact editors are bound (E14)
Bug 24533689
Bug 23589603
Change-Id: I517b61d116f2d91237c493dc8a18f09aed9ad48a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 3e5ae0db65e842d49d047568fb5d6f331298da32 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Show all aggreagate contact names on the editor
Stop copying the name from read only contacts
to the new raw contact created in order to enable
editing of read only contacts. We also don't need to
match the name displayed by quick contacts.
In the new design, we are showing multiple names with
read-only accounts marked with the account type icon
and name.
Bug 23589603
Change-Id: Ifd8d18b17fc9645c15814bbb1a649a82fe246bbd
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 28a27279554af7b1e5ff664d3da97954c462a797 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Revert moving between the compact and full editors (E5)
We are reverting most of the changes made to fix
b/19624360 in MNC. The reason to do this is to reduce
the massive complexity moving between the two editors
introduced.
Since the compact editor now expands in place, the full
editor will likely only used to view read-only raw
contacts now.
Bug 23589603
Change-Id: Idfcc07d8aae65295d4b3f0a0e3e7f5eb701a46c4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 708ea9e6f6f671178c0424f89e911000d4f330dc |
|
11-Sep-2015 |
Walter Jang <wjang@google.com> |
Add account selector to compact editor (E1)
But don't pass the account with dataset back and forth
between the compact and full editors since we will be
merging the two editors shortly.
Bug 23667287
Bug 23589603
Change-Id: I4cb6a79e6ee453cb171418b5ed317f43982dfac0
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 953cea238c9969fd7703fbce2bf8a915b5c38955 |
|
09-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't show aggregation suggestion for new me contacts
Bug 23353464
Change-Id: Ifb63c73b59153ff7bdc26b3f4f471d3521bed0b2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2d3f31c210ffc617e82e3b41fc32b54ec2a5011a |
|
19-Jun-2015 |
Walter Jang <wjang@google.com> |
Show account info for inserts and read-only contact edits
Bug 21637149
Change-Id: I224ab188230f119f49f4ab7ddef4b51c451aa892
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c90cc15b804fb00339a3b98e5c951549f9b03599 |
|
19-Jun-2015 |
Walter Jang <wjang@google.com> |
Make saving a contact less confusing
* Add always visible save menu item (a checkmark icon) on both
the compact and full editors. Selecting it saves changes
and closes the editor (what back does currently).
* On the compact editor, make back perform a discard,
including warning the user if there are unsaved changes.
* On the full editor, back still saves and goes back to
the full editor. This is not ideal but it's out of
scope to not save changes between the two editors
when editing an existing contact.
Bug 19983789
Change-Id: Ie23b75978db70f2b438a824e39f0ae8fb8aa99ec
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 06f73a15ed812d99ea28d836b02a5538bb1200c9 |
|
17-Jun-2015 |
Walter Jang <wjang@google.com> |
Ignore new raw contact display names when saving contacts
Now that we have logic to ignore the display name
we add to newly created raw contacts (when the
user wants to edit a read-only contact) when
determining whether the user made any edits,
we can enable changing the display on the compact
editor again.
Note, there is one glitch -- the name disappears
on the compact editor after you click more fields
(but only when editing read-only contacts).
Tested scenarios:
1) Edit read-only contact, more fields, back, back
No bogus contact is created and the read-only
name is displayed on both editors.
2) Edit read-only contact, change name on compact
editor, back, re-edit read-only contact, and split
The read-only contact is unchanged and a new
contact with the edited name is created.
3) Edit read-only contact, more fields, change name on
full editor, back, back, re-edit read-only contact,
and split
Same result as (2)
4) Edit read-only contact, add phone on compact
editor, back, re-edit read-only contact, and split
The read-only contact is unchanged and a new
contact with the read-only name and phone number is
created.
5) Edit read-only contact, more fields, add phone on full
editor, back, back, re-edit read-only contact, and split
Same result as (4)
Bug 21858251
Bug 21464081
Change-Id: I9028fee38b8ea7569968654a756eb98025318e69
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 6dd0d4e8e49ccff2ed57453c0ddd0735d6ec7a40 |
|
09-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't initially focus any contact editor input field
Bug 21644158
Change-Id: I84d1406b4db1646dcbf059ce84a2cc7534b0bd83
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 3593f2379784e2d89dd6c2430f8c2b944483a1f8 |
|
27-May-2015 |
Walter Jang <wjang@google.com> |
Only use one hint color on contact editors
Also, use the current 25% of black color which
already follows the material guideline.
Screenshots go/b21442589
Bug 21442589
Change-Id: I82c837fd9856c2165d3264a581165eb32702d807
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 3e76408e47ca135c092b5eee73ae49d8697b0a10 |
|
22-May-2015 |
Walter Jang <wjang@google.com> |
Distinguish between editor back button presses and framework stopage
We carry whether the editor fragment is being stopped
because of a back button press or because the framework
stopped the hosting Activity all the way through the various
editor fragment callbacks and the ContactSaveService because
it is not until ContactEditorBaseActivity.onSaveFinished
where we start the next Intent -- starting it causes a
"flash" if recents is clicked and follwed by an immediate
starting of the next editor Activity, which is the bug
that was filed.
With this change, we only use the ContactSaveService
resultIntent to go back to the compact editor on back
presses. The expected behavior/tested scenarios are
described at go/b21198041
Bug 21198041
Bug 19624360
Change-Id: Ic350e12aa447cff81747e003f504f25100bd5c60
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| bf63a6d6a888b3e1b5fb91accf2dadaab4384539 |
|
05-May-2015 |
Walter Jang <wjang@google.com> |
Fix contact name passing from compact to full editor on inserts
Bug 19624360
Change-Id: I50c415b59c4bad1d08f18f8c2bc7d57ddb73c418
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a69f58fcf5c143ac7dd6421a30004d56813e321a |
|
02-Apr-2015 |
Walter Jang <wjang@google.com> |
Don't add compact editor fragment if it's already there
Bug 20040887
Change-Id: Ib968203e0340cd442e5652376a9e2aa7347994b1
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 055c66d459732973f7341331b143d7ab9974c4ed |
|
12-Mar-2015 |
Walter Jang <wjang@google.com> |
Fixed some contact editor compiler warnings
Change-Id: I31deaeeedc4ae49da6b0326b128767785cd01852
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 1e8801bc9bc60bdd1c95f582c460590272cfad64 |
|
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Pass full res contact photos between the compact and full editors
Bug 19624360
Bug 19655206
Change-Id: I590ec7ecec75a9af95b824f5db9cda8f8aeda675
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 921287ef72ca601027bf2971b0733493adde16d2 |
|
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Fixes for returning to the compact editor from the expanded one
* Don't abort the save even if there are no unsaved changed
when returning the compact from the full editor
* No need to pass the material palette on insert intents.
It does, however, need to be passed back to the compact
editor when editing an existing contact w/o a picture.
* Fix returning to the compact editor repeatedly by
removing the Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET
on compact editor intents.
* Updated StructuredNameEditorView#getDisplayName to fall
back to the display name directly from the ValuesDelta.
This is required when the name is passed to the
contact editor, and the user does not change it, in which
case it will not be written to the underlying data
structure, and thus not passed subsequent expantions.
Bug 19624360
Change-Id: Ife285f3e411a869a76fbbff4d42939c866db617c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 5a7a23bdb698b8e741a425c9617c5e33e6314cdd |
|
06-Mar-2015 |
Walter Jang <wjang@google.com> |
Return to the compact contact editor on back from the fully expanded one
Bug 19624360
Change-Id: I249f1e456a2d85c5ecd831358692d56b09ee5a5b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d3946cae17273ed1c2fceb507990882e3f828ba9 |
|
03-Mar-2015 |
Brian Attwell <brianattwell@google.com> |
Batch join contacts
* Add new action to ContactSaveService to support joining more than
two contacts toghether.
* Add new dialog fragment for the join
Bug: 19549465
Change-Id: Ib0b1d5e7652e429f8e78d81dd3d98d03b3129e1e
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 151f3e6883e5785019f7b5083dc8baf3e305dc18 |
|
27-Feb-2015 |
Walter Jang <wjang@google.com> |
Try to show the "right" name on the compact contact editor
* If a super primary is set use it on the compact editor
* If a super primary is not set and the compact editor
name value is changed, set it as super primary. But
don't make an unchanged name super primary when expanding
to the full editor. Also unset super primary if
the name field becomes blank.
* On the full editor, set the last changed name to super
primary. Also unset super primary if
the name field becomes blank.
Bug 19124091
Change-Id: I1352f25f4decf31c5aeda20dbef133ce48d5d248
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d35e5eff8737e757a4179d49dfe9c7db999b4e9d |
|
24-Feb-2015 |
Walter Jang <wjang@google.com> |
Get join suggestions for the compact editor name field
Also fix photo height in portrait -- made a mistake in
ag/641233.
Bug 19124091
Change-Id: I988cbcf457002bc6f0996c87a8611fca82bdf78a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 3efae4aeae8715fbfcf67c56f123da49330ea01a |
|
18-Feb-2015 |
Walter Jang <wjang@google.com> |
First pass on photo support for compact contact editor
Only updates the primary photo for now.
Bug 19124091
Change-Id: I1886888b4cf249da4c483d570b9db6e05564518a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| e720fdeb3ef0892834d7ab9af8cc44dd9eb9be17 |
|
17-Feb-2015 |
Walter Jang <wjang@google.com> |
Always show email and phone fields
* This fixes showing an almost blank screen when
writing the "me" profile also when adding a new contact.
* Also fixed a bug when writing the "me" profile --
we weren't calling the RawContact.setAccountToLocal
in createNewRawContactDelta in the base editor fragment.
Bug 19124091
Change-Id: I93422047796189b4df060bfa39aa3c84ce47fa25
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 49ed2033f83005f92c30068ae33c3138d75e1825 |
|
12-Feb-2015 |
Walter Jang <wjang@google.com> |
Wire up saving edits using the compact contact editor
Also fix refreshing the edit activity data after joining
Bug 19124091
Change-Id: I161e38d9eaea89e3d090986d2b52cb6f8ee85422
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 92f8ccc1f15df787b7434224857c056721281046 |
|
06-Feb-2015 |
Walter Jang <wjang@google.com> |
Do setIntentExtras, on[Save|Join]Completed in base contact edit fragment
Do setGroupMetaData in the child classes since the layout will be
drastically different between the two.
Also moved a public Intent extra constant to the base.
Bug 19124091
Change-Id: Idd20ff39b91eb3584c69e406f1e3472bcb278f42
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 3e9a62449b8ca3a38b1d51019c6ea13972263bc2 |
|
05-Feb-2015 |
Walter Jang <wjang@google.com> |
Move suggest joins popup & activiy to BaseEditContactFragment
Bug 19124091
Change-Id: Ic5a6b8b6359dc9691cfcac2348ba895c542d05d9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 1eb21f12372b31794ef5a567013c1d2d98081120 |
|
04-Feb-2015 |
Walter Jang <wjang@google.com> |
Move join suggestion view to base contact edit fragment
So that we can keep setEnabled logic entirely within
the base fragment.
The rest of the join suggestion functionality will be
ported to the base so it can be shared with the compact
editor in a seperate CL.
Bug 19124091
Change-Id: I4d494c9b0c2db8a6dba6d9d752d049f48848f731
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| b55107303cc46906c265582a8931172f13d684b6 |
|
03-Feb-2015 |
Walter Jang <wjang@google.com> |
Handle reading loaded Contact data in the base edit fragment
This reduces the number of abstract methods sub classes
must implement and also keeps us from having to duplicate
the logic to set up the new/local/me/existing RawContactData
List (mState) in all sub edit fragments.
The crux of this CL is moving the "bindEditor" methods
into the base fragment.
Also renamed the various bindEditors methods which are
mostly reading fields the loaded Contact and settting up
mState to be "setState" since we it seemed more appropriate
to reserve the name bindEditors for setting up the actual
Views.
Bug 19124091
Change-Id: Ieb4a906ac372faa20694e546caa3bcba8c6b53b4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ed8f6c9744dd38e089598acfba6fb90446954e6e |
|
31-Jan-2015 |
Walter Jang <wjang@google.com> |
Add edit contact menu options to compact editor
* Also moved #setListener and #load from the sub contact editor
fragments to the base fragment
* Moved location of #setData in the base contact editor fragment
Bug 19124091
Change-Id: Icbe3d46e1bf60f3e79437db7bc6c05a7a95f824b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ba59deb669cf377bedf08af53c9196db3c1cc404 |
|
26-Jan-2015 |
Walter Jang <wjang@google.com> |
Move data loading and account creation to edit contact base class
While moving things from ContactEditorFragment to ContactEditorBaseFragment:
* The data loader callbacks, #onActivityCreated, #setData, and account
creation methods were not changed in any way
* For the restoration of contact editor state, one small change was made.
A new key, KEY_AUTO_ADD_TO_DEFAULT_GROUP, was added because the other
options passed in via intentExtras argument to #load are saved
so this looks like an oversight in the existing version.
Bug 19124091
Change-Id: I7973f9c5703082f6d8db53c9db22d08a230c5876
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| cf718aa47c11453925bb20f7970ca7c897f6e376 |
|
30-Jan-2015 |
Walter Jang <wjang@google.com> |
Re-order contact edit KEYS and state save/restore to match member order
This will make subsequent CLs which will move these to base classes
easier to read.
No KEYS or save/restore's were removed or added, except
KEY_SHOW_JOIN_SUGGESTIONS was renamed to more closely match the member that
it is backing.
Bug 19124091
Change-Id: I3557cffa37ee29fc5cd460a8e7358142c383967a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 3f990ba4e35a99078d831c041290e574a320caa5 |
|
27-Jan-2015 |
Walter Jang <wjang@google.com> |
Move some contact editor functionality into new base classes
To make room for a new "compact" contact editor.
The Status and SaveMode interfaces in ContactEditorFragment were
moved to ContactEditorBaseActivity but the Listener interface
was moved to the ContactEditorBaseFragment.
The logic in ContactEditorFragment to construct the result
Intent after successful saves was alos moved to the
ContactEditorBaseFragment.
This reverts commit 02375f1e45ade453c56810f32d63dfe8eebe4f44.
Change-Id: Ib0129d9ba4e4351677b6979c5f720df2094bf48d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| fb5dc6f857104c38ff49993d7498e8aa5fbc462e |
|
28-Jan-2015 |
Walter Jang <wjang@google.com> |
Reorder edit contact fragment members
Before (re) moving editor functionality into base classes
Bug 19124091
Change-Id: I8185b54f546f7e88893afbdeb4ff55cff3335711
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 92101e77238e450dedb56814cec80edc0adf79c0 |
|
28-Jan-2015 |
Walter Jang <wjang@google.com> |
Split EntityDeltaComparator out of contact editor fragment
Bug 19124091
Change-Id: I01ccf06bd2527ea5054843b30c100b2c7cc4a7f4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 4a1c574cd62eb7ca1e0fcc3a61e5378e5e0787fe |
|
27-Jan-2015 |
Brian Attwell <brianattwell@google.com> |
Add Insert.EXTRA_{ACCOUNT,DATA_SET} to API. P #2/2
Bug: 18777272
Change-Id: I17a5b7cb4d4c5a0ba48936a6fc829acaab73f31d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 02375f1e45ade453c56810f32d63dfe8eebe4f44 |
|
26-Jan-2015 |
Walter Jang <wjang@google.com> |
Revert "Move some contact editor functionality into new base classes"
This reverts commit 5d1c571dbe5b4a60aec6cb81d69e9e595813268e.
Change-Id: Ia9df02198b460529c157fbee6012349b0eca0bf3
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 5d1c571dbe5b4a60aec6cb81d69e9e595813268e |
|
22-Jan-2015 |
Walter Jang <wjang@google.com> |
Move some contact editor functionality into new base classes
To make room for a new "compact" contact editor.
The Status and SaveMode interfaces in ContactEditorFragment were
moved to ContactEditorBaseActivity but the Listener interface
was moved to the ContactEditorBaseFragment.
The logic in ContactEditorFragment to construct the result
Intent after successful saves was alos moved to the
ContactEditorBaseFragment.
Bug 19124091
Change-Id: I5dd0b64580026a72757025915ee59be0b7d1dcbc
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 67e83223e954ed54898daa5e32400dbff6d3831a |
|
09-Jan-2015 |
Jay Shrauner <shrauner@google.com> |
Local account handling cleanup
Clean up null account handling and update local account detection to allow
for a non-null account to represent a local account.
Bug: 18959158
Change-Id: I0d5f7acb7d9a8d1ba7b6d3a4e0b6584e3646934a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c3d202ccbaf93ddd8291672027e59f549c32eee3 |
|
09-Jan-2015 |
Brian Attwell <brianattwell@google.com> |
Unbundle from contacts contract part 3/3
* Remove some tests
* Move ContactsContract.Intents.UI into Contacts
* Remove references to ContactsContract.ProviderStatus.DATA1
and refactor to avoid usage of a new useless data object
Discussion: go/contacts-contact-intent-ui
Bug: 18777272
Change-Id: I9c6125cc30710e4637b38f3785608abb9928d1a2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d9bf3c2ddd46dbd2a3a45b2a171c2af55fe4c8e0 |
|
05-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Merge "Change text colors to reflect their state" into lmp-mr1-dev
|
| d690dff231dd5a81b9bd7563838455f24e49c75c |
|
03-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Change text colors to reflect their state
The editor's text color suffered from two conflicting
problems
1) It didn't all pass GAR
2) The difference between hint text and regular text
is too subtle to differentiate at a glance
Changes
1) Once a LabeledEditorView is non-empty, the text color of
the spinner should no longer be the hint text color
2) Once an editor field is focused, all fields in the same
EditKindSection get a slightly darker color. Since the various
name editors, don't actually belong to a EditKindSection
extra work needed to be done for them.
3) Drop down lists use non hint colors
Read only editor continues to use the darker hint color.
There is no need to strongly distinquish hint colors from
non hint colors in the read only editor.
Bug: 18004959
Change-Id: Ia6b16ab882b2fcb9113c2ac880e741f62115a1f9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 6b447ced28913da9f1961d678d957b348dc97fd7 |
|
03-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Merge "Don't save contact after deleting it" into lmp-mr1-dev
|
| afb025cfbcc1b6db48c6045a27387ce45e652a3a |
|
02-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Merge "In editor, use Up button instead of Save button" into lmp-mr1-dev
|
| 99c0c8519483dd187fa0dd21cb83065966253b7f |
|
01-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Merge "Collapse extra raw contact editors" into lmp-mr1-dev
|
| 47b17c83b981172bda672314385eb8920753ba25 |
|
26-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Use delete icon from go/icons
Bug: 18004959
Change-Id: Ia8a5fe6006f6caf313a0f2eb044a94535c43878c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2b24602f1b6661a669762cfc810cc76f51db6e16 |
|
26-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
In editor, use Up button instead of Save button
We can't yet delete the assets from editor_custom_action_bar
since they are used inside the group editor. And we aren't 100%
certain we want to delete all the groups.
Bug: 18004959
Change-Id: Id60515d2e5bbaab98498162707581730baca2d8b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| daa2058979fda84a0ce22e21edd53aa049e80aa0 |
|
26-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Collapse extra raw contact editors
There are now two different header styles
1) When creating a new raw contact: if there are multiple
accounts to create the raw contact under, then show a
header with an acconut selector
2) Otherwise, show a visually distinct account header without
a drop down account selector. If there are multiple raw
contacts, this header also lets you collapse raw contacts
Typical users, who only have a single writeable account, will
never see header (1). This is fortunate, since switching between
the two header styles is a bit visually inconsistent.
Bug: 18004959
Change-Id: I133a7355a220f20b55657a6c1a51ff44665ea3b9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| b4154e46dd98bcb4d85eb6fb210a048c8a7ff7aa |
|
25-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Don't save contact after deleting it
Bug: 18514447
Change-Id: I695aa41eb6870b7c256efb9f5eccf9e0eadefe4f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 7e67082d3f7c4ab56945040c0e4617b71c7e5f0b |
|
08-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
New design for photo editor
The photo editor field now looks like the mocks. It includes
a RadioButton that allows users to choose which photo is
primary. This RadioButton only appears if more than one raw
contact has a photo inside the contact.
Additional changes:
-fixed non-regression that made it impossible to
set some photos as primary
-fixed non-regression that made it possible for multiple
photos to appear as primary
-I fudged with a bunch of padding values in order to
compensate for View insets and paddings. This can't always
be done perfectly, since some insets/paddings vary based
on screen-configuration. I needed to start taking fudging
with these paddings in order to make the photo editor look
consistent with the other editor fields.
This CL doesn't bother ensuring the readonly photo edit
field looks good. This will be done in a later CL.
Bug: 18004959
Change-Id: I683f3ffa8e7f8683c2c083a2b4592b2b95c58c63
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c300521331c04767cd19dfe05ab77567514bbaa0 |
|
06-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Use larger photo in contact editor
Increase the size of the photo in the contact editor.
This means we can no longer rely on thumbnails. We
now need to load contact photos from Uris.
Bug: 18004959
Change-Id: Ice2099998194adad9336c5d90e9873a230ca4bd5
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 5d2e262ab3658118a12fbf6d0edab76484368c24 |
|
03-Nov-2014 |
Walter Jang <wjang@google.com> |
Make it easier to delete a contact
* Add delete menu item to quickcontact overflow menu
* Promote delete menu item on edit contact activity
from overflow menu to show as action
Bug 18061876
Change-Id: I3f99e1cd00151b968a157ff818bf977c0be15eb2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a3e498a1d189010791f98183c1267d869f0d941b |
|
27-Oct-2014 |
Brian Attwell <brianattwell@google.com> |
Fix analytics in Contacts app
Remove dependencies on old analytics code.
Initialize analytics inside ContactsApplication.
Improving analytics CL #3/4
Bug: 18039620
Change-Id: I115315519ad245ff199bcf532270f56b9a2d6b61
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| e4c2f549b6fe20ae65a8ae1097fabe5f22b5750d |
|
23-Oct-2014 |
Brian Attwell <brianattwell@google.com> |
Use analytics activities and fragments
All Contacts's activities and fragments now inherit from
analytics base classes.
Bug: 18039620
Change-Id: Ia550263640f60bc3f7daa7e85cd9f612f0dfc8a8
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| f19dda97bfdef84e3f39ba069a981004a5c797b1 |
|
16-Sep-2014 |
Paul Soulos <psoulos@google.com> |
Disables the delete menu option on "insert or edit" actions
bug: 17468225
Change-Id: I9c26279cbedfe773d6fbd39ad49470d39ac88f2e
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| bd127671f7fbcefb87a1b383140dee89cdb7039c |
|
20-Aug-2014 |
Brian Attwell <brianattwell@google.com> |
Save menu state on rotation, in contact editor
Bug: 17148558
Change-Id: I4f31ddd7a685b6bc6ea6d13e4c0d0f9be78df49a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 81cc3b3d09d9296e521ac3454ad01c6b6c2ba71b |
|
23-Jul-2014 |
Brian Attwell <brianattwell@google.com> |
Contact picker: add search icon & hide searchview
Hide/unhide the SearchView when you click a seach menu item.
This is the first and more important step for b/16190113.
In a later CL, I might remove the SearchView and replace it
with the custom actionbar view created by dialer & used
in PeopleActivity.
Also merged JoinContactActivity into ContactSelectionActivity.
Bug: 16190113
Change-Id: I04bf7d22dffbf7f104362b17c9064cb386a01abe
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 8a6f4ade05e5a8a89d91078ef9c22944450ac8ba |
|
07-Jun-2014 |
Brian Attwell <brianattwell@google.com> |
Bag of QuickContact improvements
* QuickContacts open full screen when inside the Contact app
* Status bar color (aka system bar)
* Added and animated shim
* Moving code off UI thread (without these, I was seeing ~20
frames dropped from the shim animation)
* QuickContacts now acts reasonably when re-entering QuickContacts
from the edit view
Change-Id: Idafc20b62b1d04f0a9c437b3708555ec6dddedf5
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a513f720d2a15be6a00894c9a2812355d0643fcf |
|
06-Jun-2014 |
Brian Attwell <brianattwell@google.com> |
Add delete button to Edit View
When a contact is deleted, QuickContacts is told by LoaderCallbacks
that it shouldn't be visible prior to onResume().
Change-Id: I5f9c84cbfefddca3722bd1de3c5a98760547ef0a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d257a90e1a9a439da44a97d328c3a933d54f2cae |
|
04-Jun-2014 |
Brian Attwell <brianattwell@google.com> |
Move phone menu options into edit screen
Currently, these options will only supported for existing contacts.
This is what UX's mocks show.
Change-Id: I97fd58c11aea1594052945cdfd956b6eff883b7c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| b8671d271e6a7c48aca785b867ef9a86c5012a85 |
|
15-May-2014 |
Brian Attwell <brianattwell@google.com> |
No "merge" and "seperate" actions on insert
Only show these actions for existing contacts. Not
when creating a new contact.
Change-Id: Iaf7dee665301e28841dc3c4a1bd7d5c1ce3297c5
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c26bc592c0e9a4587512a9677bc2dd9d311b0975 |
|
15-Apr-2014 |
Ben Gilad <gilad@google.com> |
Fix NPE in android.graphics.BitmapFactory.decodeFile
Change-Id: Iab8db2f1ae173f44cb12cf0376e8b53768c6d069
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d97719de77bc3758c34fe11301cf29651578e58d |
|
21-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Fix NPE when sorting accounts lacking type
Fix NPE when accountType is null in comparator.
Bug:12661115
Change-Id: I37d8b10a48f85f6a23e5761b7bf85a5f612c7379
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| cd321f65f1e50409812976380ad1f0fdb3fa35cb |
|
28-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Move ContactLoader related code to ContactsCommon
This CL simply moves classes from Contacts into ContactsCommon.
This is needed so that Dialer can use ContactLoader related code
for b/11294679. A ContactLoader will also be needed in the future
to allow InCallUI to download hi-res photos while in call.
Bug: 11294679
Change-Id: Ia033f3ea2406a907a4e71290c9ce810a5583dab8
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 637a38ec9de6b1f434d7a13105f2e747faae5107 |
|
14-Sep-2013 |
Yorke Lee <yorkelee@google.com> |
Make contacts photo pickers compatible with new documents UI
The old contacts photo picker code was using unguaranteed behavior
(that Intent.GET_CONTENT would support MediaStore.EXTRA_OUTPUT) and this
caused it to not work anymore with the new document picker.
This CL changes all usages of files to instead use URIs.
Also, a FileProvider has been added to Contacts, to allow us to pass in
URI pointing to our private cache in intent.setClipData with
Intent.FLAG_GRANT_WRITE_URI_PERMISSION and Intent.FLAG_GRANT_READ_URI_PERMISSION
so we no longer have to reply on the MediaStore.EXTRA_OUTPUT being parsed
and supported. The use of the FileProvider also prevents unauthorized access
to temporary files during the caching process.
Bug: 10745342
Change-Id: Iaee3d7d112dd124a2f5596c4b9704ea75d3b3419
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| cab161cfe8819200171ce0936050834d6694730e |
|
17-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Merge "Fix empty name field when adding contact from maps"
|
| 688c228b2d7cf0c812fb673451f24e7cb457d63b |
|
17-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Fix empty name field when adding contact from maps
Bug: 8026778
Change-Id: Id8ee1b7a02b2c9845258aca09f68ed9e1e4d3642
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 13d52b10fd720bb94ffe7a7e7ad1b37c1e06bb50 |
|
16-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Fix crash when adding a new contact
Check if mRawContacts is not null before trying to save it into
outState in onSaveInstanceState. If it is not null, save an
empty arraylist instead.
Bug: 8018115
Change-Id: I14db6bad22707b5154ffe016d2fd3b4391c13c85
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 44cfc56d1701629070384364416c1311b780535d |
|
13-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Allow read-only contacts to be editable.
- Automatically create new raw contact when editing a read-only contact.
- Refactored mState to be always initialized.
- Allow RawContactDeltaList to be instantiated with empty constructor.
Bug: 6406182
Change-Id: I7a58625485dae6957b4f9bcc446122f54551afa1
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 86625158bdc52855c37e96bf098ba7a213c810d7 |
|
20-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Close popup window before fragment is destroyed.
Bug: 5606937
Change-Id: Ibfcc2d0c110f333a6728141f77c21adfeceb7419
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| f3c73113f0882d79aece54bc8ad467a5d0660f62 |
|
13-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Hide discard menu option if there are no writable raw contacts
Bug: 5174543
Change-Id: I87dd24e160df60cb92522cc91adb4e47de942331
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 36184f630cdb97d0a642de25f69962ef2abfedb1 |
|
12-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Destroy mAggregationSuggestionEngine only on destroy
Bug: 5458280
Change-Id: Ifcb6f120d6e7961703434e8d97183c6a7a70feb5
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 87c71f43c70cd970e54eecbfa4c8d79259922c5d |
|
05-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Moving SelectAccountDialogFragment to ContactsCommon.
In preparation to move ImportExportDialogFragment to common.
Also moved a few more string resources left out from previous move.
Bug: 6993891
Change-Id: I2ddb6467732c53a70bc94c4cd0c702346ccb54fe
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 738ff8623dc77dd91a1b9023861e924ba5e4c27e |
|
30-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move ValuesDelta to ContactsCommon.
Bug: 6993891
Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| aa690d4949b8105e5bcf10569b7cf4fae36741de |
|
29-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Prefactor RawContactDelta.ValuesDelta into top level class.
Making ValuesDelta into top level class so we do not have to move
RawContactDelta into ContactsCommon. ValuesDelta is used by
CustomContactListFilterActivity which needs to be moved.
Bug: 6993891
Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 0d5588da244d0992c3ff8f25d0875fdf95a8c644 |
|
27-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move AccountTypeManager to ContactsCommon.
Moving AccountTypeManager to ContactsCommon so it can be shared by Contacts
and Dialer.
Bug: 6993891
Change-Id: I9526ac7cda758290caecabfcaebe620238d8dd6b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| df237ecf94a05a5cdc5d21a4ba6fabb5bbfbbee4 |
|
15-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
am f1689e3e: am 1cd2c24a: am f5d37174: Merge "Minor changes to validateAction()." into jb-mr1.1-dev
* commit 'f1689e3e99a95c61c0874f3f5057dd35040f1d7e':
Minor changes to validateAction().
|
| 428f008513d1591cc08fcfe2cf0c9237fb313241 |
|
14-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move dependencies of AccountTypeManager into ContactsCommon.
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| e8e94423b463688951f806419dbd73e10e7bf7b4 |
|
13-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Minor changes to validateAction().
- Make error message more accurate.
- Change action validation to be inline instead of relying on for loop.
Bug: 7122054
Change-Id: I4d9e3e2a18659bbe5ccc0e355d1e7d97f5d38e0f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 8477f7ab95ec2e70f98277f79f48495c13382321 |
|
08-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fix blank edit view after orientation change.
If an orientation change occurs before the contact data loads from the
database, the code fails to reload the data because it is checking
against saved state (which is always present on an orientation change).
This fix changes the check to look for the actual data to be present
in the saved state.
Bug: 7122054
Change-Id: I4373eca14ba447abc57493cf4c5af6b978d8b7a2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| cdc279de45da459b359254777a09ab630ce60fa9 |
|
19-Sep-2012 |
Yorke Lee <yorkelee@google.com> |
am f0aa3c9d: am 288532cd: Fix BadTokenException in ContactEditorFragment
* commit 'f0aa3c9d1fc09f25a3dbd250493d8119ce360aab':
Fix BadTokenException in ContactEditorFragment
|
| 288532cddfccdc3793dd748d1c75750e2f46cb53 |
|
19-Sep-2012 |
Yorke Lee <yorkelee@google.com> |
Fix BadTokenException in ContactEditorFragment
Bug: 7162486
Change-Id: I3b8fcf6cf2fd3f11368b5af643a9b69ce0890e84
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 47b6f70eadb118d815b4aaf5426c070bd75a38fb |
|
08-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Refactor RawContact to be parcelable.
- Re-work of RawContact to be a real data container and removed un-necessary
dependencies.
- Removed un-necessary circular dependency between RawContact and DataItem.
- Cleaned up and made DataItem more compartmentalized by removing un-related
account methods.
- Implemented Parcelable for RawContact and NamedDataItem.
Bug: 6406182
Change-Id: Icd84f34d85e1349a86e473708cc7f8fece12349f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 098f630c3dd0d993a423425e138f95dba0d7612c |
|
08-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fix blank edit view after orientation change.
If an orientation change occurs before the contact data loads from the
database, the code fails to reload the data because it is checking
against saved state (which is always present on an orientation change).
This fix changes the check to look for the actual data to be present
in the saved state.
Bug: 7122054
Change-Id: I4373eca14ba447abc57493cf4c5af6b978d8b7a2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| e813f5e56ddc6395c5e08e9245e2c5ad41e91724 |
|
23-Aug-2012 |
Daniel Lehmann <lehmannd@google.com> |
Guard JOIN in case the state machine gets into an erroneous state
Bug:7013287
Change-Id: Id4da1f02b00efcc02fe3ad6c277189ad96fcb67f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 5671c7e7718c3285dc0391807401083986fcfd51 |
|
14-Aug-2012 |
Maurice Chu <mochu@google.com> |
Fix binding editors when state is null
The bindEditors() can only bind views when there is
data, so this checks for a null state and returns
immediately if null.
Bug: 6601692
Change-Id: I1abfd75ce3bffb5c96a7b5cb609c6d1686581649
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 4bff8fb686f2ac5500109a32cca9270965c620d6 |
|
06-Jun-2012 |
Makoto Onuki <omakoto@google.com> |
Fix handling rotation while camera/gallery/crop is active
on contact editor.
mCurrentPhotoHandler needs to be restored after orientation change.
Bug 6610108
Change-Id: I2a2877856b8c682cce01195bbf9d80978f9ec175
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a2f9090cef25dfe4e13117db8c91a056a7d5f114 |
|
29-May-2012 |
Maurice Chu <mochu@google.com> |
Fix regression when editing contacts
Put a null pointer check when determining whether
a photo already exists.
Bug: 6574706
Change-Id: I21bdbc162910715d5792308a7cb8abdd18bf2eda
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a1fa4d5db33dc4431b2bb325f3a8b7f06ab5d072 |
|
23-May-2012 |
Maurice Chu <mochu@google.com> |
Merge "Fix pop-up menus for photos in contact editor" into jb-dev
|
| 91004b37683c15650eccde68ff04defcf94a1c84 |
|
22-May-2012 |
Maurice Chu <mochu@google.com> |
Fix pop-up menus for photos in contact editor
The hasMoreThanOnePhoto() has been re-implemented to
look directly at the entity deltas to determine whether
there are more than one photo in the set of raw contacts
rather than relying on whether a photo was set in a raw
contact editor view.
Also, calls to refresh the raw contact views are made if
any changes to raw contact photos are made.
Finally, fixed a regression where the photo handler is not
set correctly so that the wrong photo handler would handle
the callback onPhotoSelected which caused a newly taken
image or chosen image from the gallery would get set to the
wrong raw contact.
Bug: 6408705
Bug: 5850397
Change-Id: I94e3872ed3e0191f1ca845de0d01525aee3a5f5f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 45ee872fe7be69c6b3f0c59167eecd11af467812 |
|
22-May-2012 |
Makoto Onuki <omakoto@google.com> |
Don't send view notification before showing quick contact
Instead, do this in the second load. This directly affects the quick contact
startup time.
Bug 6529921
Change-Id: Ief7bda9bd32cb4be0c86c4b79efb35da812721dc
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ebc17929007ecf12f25b8e90023766e8a083d11e |
|
05-May-2012 |
Josh Gargus <jjosh@google.com> |
Don't stash cropped photos in /sdcard/DCIM.
Every time we choose a new contact photo (either an existing one from
the gallery or a new one from the camera), we write the cropped image
/sdcard/DCIM. As a result, the cropped image (eventually) appears in
the gallery, is uploaded to G+, etc.
The new behavior is to write the cropped photo to a temp directory,
and to clear it when we're done with it.
Revert some of the changes from Ib7037a66; we still need to persist
properties in onSaveInstanceState() in case ContactEditorFragment is
killed while the user interacts with the camera/gallery.
Bug: 6423139
Change-Id: Icf8cb5b4824e3d8757ff483ef128527ac9132e72
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 87270e1b58e669354bb1571ced686421c56deb7a |
|
03-May-2012 |
Josh Gargus <jjosh@google.com> |
Avoid crash when re-saving new contact with photo.
This bug was encountered when creating a new contact from Maps,
but could happen any time you:
- create a new contact
- set a contact photo, either from the gallery or a new photo
- save contact but don't leave ContactEditorFragment
(eg: "Join" cause the contact to be saved)
- edit another field
- save
The fix is to clear the list of photos-to-save after each save.
Bug: 6432438
Change-Id: I63e86bd82fd16b8177bdca741ecc7a1a90d22d18
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2828c48cc4537fe981918f80297d5408bedc87b5 |
|
28-Apr-2012 |
Makoto Onuki <omakoto@google.com> |
Prevent passing null context to AggregationSuggestionEngine
The monkey crash suggests we're creating this object when getActivity()
returns null, meaning after the fragment is destroyed.
I couldn't really find any path that could cause it, but let's make
sure we'll never pass null.
Bug 6340106
Change-Id: I38091b46a99821065e248c811ed2f974f2f47152
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 740552201d103b80bc49ea8a39a30536222672ea |
|
27-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Don't show triangle and on-press state if there is no action
Bug:5265514
Change-Id: Ifc1d3b765f909f0ec7cc7565b9d89de50c4a5549
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 55967b408f722a3e1d6c61f09618ddd310fb7693 |
|
27-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Make popup non-modal for contact aggregation suggestion.
When editing a contact's name, the aggregation-engine provides
potential contacts that the user may wish to aggregate the current
contact with. However, this popup was modal, which is bad UX.
Bug: 5438601
Change-Id: Ic8519c235af75d44cfa060f16107cd64aeef61b9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 692d46364f2f0e32fd481b977c9e16832e70de5c |
|
25-Apr-2012 |
Maurice Chu <mochu@google.com> |
Added help menu options to People app
This has been implemented with the idea to enable the creation of help
menu options in a standard way throughout the Android platform. One
particularly important feature is to hide the exact URL that is being
used to invoke the help pages via the browser via using vendor-specific
overlays of string resources.
Also, other standard context for the help like the preferred language and
app version code are incorporated automatically via the HelpUtils function.
Bug:6206323
Change-Id: I5a1fff4d99ac93d3a6aa05da91f465fad072cb8a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 9a409d474b2b4f2e4261657f864eeb866fcb8816 |
|
24-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Fix an NPE in PhotoSelectionHandler. mListener was always null
- Also fixed an independent crash when replacing a photo from Details
- Also renamed mListener in ContactEditorFragment to avoid name shadowing
Bug:6387900
Change-Id: I000009c6c8d4ea4a07168f99530e4ef1f648a333
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| e5d3f897689c8ba0f275c7679c72eacb190ae9b8 |
|
11-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Fix regression; once again we can apply Gallery photo to contact.
The changes to support hi-res photos in Ic0cabaa5 were not applied to
AttachPhotoActivity. This CL makes the analogous changes, and many other
cleanups besides.
In addition, applying the Gallery photo works even if the AttachPhotoActivity
is killed (eg: when selecting a contact, or when cropping the photo); this
didn't work even before the regression.
The save-contact Intent which invokes the ContactSaveService no longer
needs to specify a callback Activity (it is OK to pass null if you don't
care about getting a callback).
The subclasses of PhotoSelectionHandler have been significantly simplified,
partly by pushing common behavior to the superclass, and also by directly
accessing state in their outer class instead making their own copies.
ContactLoader.Result.getEntityDeltaList() is a new instance method that
replaces more verbose incantations.
New utility class, ContactPhotoUtils. Helps with compressing Bitmaps, and
generating temp-file names used when saving hi-res photos to a contact.
Bug: 6298601
Change-Id: I2fe90c33c9fa81716f263d82ed80c0d6f63c6a7e
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 764637aba745612a9fdc07adb99c615263916fa8 |
|
04-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Allow setting photo on otherwise-empty local contacts.
Fix bug in ContactEditorFragment where, after tapping "Done",
the contact's photo is still unset. This regression is due to
the changes to support high-res photos... now that we use a
side-channel to save the photo, the EntityDeltaList doesn't
know about the change. The fix is to also create a thumbnail
and add it to the delta-list. This allows us to avoid ugly
special-case code in the editor and save-service. The high-res
photo is still saved via the same side-channel.
Bug: 6109553
Change-Id: I59bb9885eeb0260861ee167d3b5f1c7319896488
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ba69014263332f2056263cddc41cc6d7cfd7b7ca |
|
23-Feb-2012 |
Daniel Lehmann <lehmannd@google.com> |
Fix empty contact
Bug:6023712
Change-Id: I0437eb5a010b392b840795d16d5b03411394b3ef
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| f30723782e801deaf159aea2443e9507596ef11d |
|
23-Feb-2012 |
Daniel Lehmann <lehmannd@google.com> |
Don't re-use the SaveMode in the group editor anymore.
As we only ever use SaveMode.CLOSE, I decided to remove this entirely.
We don't support re-loading at the moment, so it seems wrong to have
code in there that pretends to be able to do it.
Also I cleaned up some Eclipse warnings, so that the side-bar has fewer
yellow lines
Change-Id: I263b716c2edc98682bd5f5d1bc2b18ede15d7ced
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 28eadab78531e22a0d9fa22fbbcd61c451005890 |
|
22-Feb-2012 |
Josh Gargus <jjosh@google.com> |
Fix bugs in hi-res contact support.
Serialize updated photos and restore them upon device rotation; this
addresses bug 5999990.
Also, be sure to clear updated-photo entry when the user chooses
to remove the photo; otherwise it will still be saved when the user
exits the ContactEditorFragment via Back/"Done". This wasn't yet
reported as a bug.
Bug: 5999990
Change-Id: I9a01d4b9e40fec0e764156271a292588ed1b7154
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| e692e010ca02200087997280e7c239ebf94aa8f9 |
|
18-Jan-2012 |
Josh Gargus <jjosh@google.com> |
Support for high-resolution contact photos.
Rather than getting a bitmap directly from the gallery app, with
this change we create a temporary file and request that the photo
be stored there. This avoids running into bundle size limits when
passing large, uncompressed bitmaps back from the gallery.
After reading the photo out into the Contacts app, we use the
openAssetFile API to stream the large photo data into the
Contacts Provider. Note that we do this rather than having Gallery
write directly to the provider because we have no guarantee that
the Gallery (or substitute) app has WRITE_CONTACTS permission.
In the Contact Editor, the image is not permanently stored until
the contact is saved. This avoids needing special logic to handle
the case where the contact is newly-created.
Fix bug 5907233 en passant... the vestiges of some partially-
expunged code were causing the ContentEditorFragment to not
apply a selected photo.
Bug: 5786849
Bug: 5907233
Change-Id: Ic0cabaa50c08d6a9a0b730698c92f4092192438a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ced983d7a816256d93fdea1f81e63e4598c18875 |
|
10-Jan-2012 |
Josh Gargus <jjosh@google.com> |
Better wording when choosing photo from PhotoSelectionActivity.
When there is already a photo for a contact, "Take photo" and
"Select photo from Gallery" don't sound as good as "Take new photo"
and "Select new photo from Gallery".
Bug: 5738108
Change-Id: I43e13774079695b0ecebc5d67576e2ea831706a0
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 6fa7384a1a5576ace18159de61af91c8b7c34dc6 |
|
28-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Allow adding/replacing a photo from contact card.
This involves a large refactoring of the photo handling code that
previously lived in ContactEditorFragment. The bulk of that logic
has been extracted out into PhotoSelectionHandler and
PhotoSelectionActivity classes.
As part of this change, also removed the selection highlighting when
tapping on the current tab header in multi-tab views.
Bug 5294297
Bug 5379389
Change-Id: Ic929e4b4a730d91f768a34367bb76967228ded17
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 7cdbe5c0b11acb6128974f593b4ede86b01f95b2 |
|
22-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Remove titles in simple confirmation dialogs
Bug: 5476234
Change-Id: I7970c3378860e3521b55d248968a4710d8161c04
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2621c5bb7049401c8bce740005fa60bf1b304b86 |
|
03-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
ContactLoader: set requested URI to error/not found result
- Now both the "error" and "not found" results have the requested URI.
- NOT_FOUND is no longer a singleton; there's now "isNotFound()" method
in accordance with isError().
Bug 5350017
Bug 5201346
Change-Id: Icb9080d3885ea2217e73a59db3825984746c3eb3
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 52d5545e61a2410df979eff4fc8f9f566b263799 |
|
29-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Merge "Avoid showing error if contact removed on save."
|
| 36d24d7ede42a252c82c4aa783b2231c5e2eea79 |
|
26-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Avoid showing error if contact removed on save.
Because removing all data from a local contact can actually cause
the raw contact and contact to be deleted, we need to track that
case so that the caller does not consider the lack of a lookup
URI to be an error.
Also made "Me" header all-caps for no-profile case.
Bug 5346614
Bug 5354364
Change-Id: If1e1d67da9c14eb8782be05b2e39ece19b5ac026
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 6f74c0f3313cbb08ee8a8fbb79bfefc5b03fe215 |
|
27-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
Fix account list for group editing (for master)
- Don't use contact writable account list to populate the
account picker when creating new groups, instead check for
isGroupMembershipEditable() on the account type
- Repeat the same for determining whether the "new group"
button should appear in the PeopleActivity or not
Bug: 5360120
Change-Id: Ifd2fd1cf4ea7bf02d4dcba3e9c023bd7041fab83
Original-Id: Ia1ec62eff3fe4fd5b495548218c58f238ff49788
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 0353a24d97cc0266eb9bf0ee6c7d6821aeb1896e |
|
23-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
New editor flow (for master)
- Added dialog-themed activity that pops up on new contact creation
in 3 cases with a variation of message when there are:
* 0 writable accounts on the device
* 1 writable account
* 2+ writable accounts
- The dialog is displayed whenever a new account is added
to the device or the default account has been removed
- Once an account selection has been made by the user,
we store it in SharedPreferences using ContactEditorUtils
- Slight restyling of the account list adapter
Bug: 5355671
Original CL: Ib3343a5aea972b366a9df41b9419ad9561c2243d
Change-Id: I46f4c5687a5b6eaa68b55a568f0d737ad80dfc5c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2b3ee0f34801444c7d775ce747125459f69712bb |
|
22-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
Make third party sync adapters editable
- Already merged in factory rom branch under
https://android-git.corp.google.com/g/#/c/136996/
but marked as do not merge, so we submit it
here manually
Bug:3093621
Change-Id: If3bb34f7d29bea4bd873342232bea3c1a77bcd2a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 96e87fd6e808e9d853263ffeb5104f3253a18639 |
|
21-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
Use existence of editor as indicator whether source is editable.
Bug:3093621
Change-Id: I3ba344667ce1b0f2da6847d783c0ac90f36ebd8f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 48ed982e078de00f6be49319ccf09bbb2aaadf5e |
|
07-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Allow local profile editing with an existing profile
Bug: 5244792 Can not create local offline profile if
Google+ profile has already been synced in
Change-Id: Icb818098588f27bab54515d8a554fe77a08569ca
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 7a8cb1c78a2841d09cdc614db83c5444b4b86c0a |
|
30-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Merge "Contact editor assets and redlines"
|
| b9e60280603f2fa57083c13952e4b25e2585b833 |
|
29-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Silently give up split action when mState is null
mState may be null if the Fragment is recreated (or in the other
strange state) by the system during split confirmation, which is
really rare for users (while it may happen during automated
testing). Avoid NPE and give up the save action silently.
Bug: 5220440
Change-Id: I40c9a29ef1f3c1a3913beb9f3a8022b00d297102
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a3e69af03dd35124941a48c3bfaea87468d66863 |
|
25-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Contact editor assets and redlines
Change-Id: I08c11dce7f07155a919fec9989587af5f11a3220
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 681f36cc7cc49be781eedc4685eda2d1b2c0444c |
|
26-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix header when editing a profile
Bug: 5179920 Google+ profile should say "My Google+ profile"
Added a case to change the header name when editing a profile.
The editor now gets a boolean indicating if the contact edited is a profile.
If it is a profile, the editor sets the header with "My X profile" according
to the account name.
Change-Id: I62af5011061f61a6d1d3c60845a1746c99cda04a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| f9fa11c0867ec17742a1bc6b742d4a64a631962b |
|
26-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Don't print out bundle in ContactEditorFragment
On rotation change, we shouldn't print out the bundle because
it contains PII.
Bug: 5205563
Change-Id: I7965f4312a2769468ea17be6dadb7a988d46883a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 9e7b5da669fcf92a6a627fb720749e5cb627684a |
|
23-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Propagate original exception when throwing load exception
Bug 5198078
Change-Id: I941dc9b96d6c58eb1912d446c3c27ec4c4c2ffef
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2245870a1354df03512010e4968b144840894fb7 |
|
19-Aug-2011 |
Frank Sposaro <sposaro@google.com> |
Added new assets for contact editor.
Bug: 5070819
Change-Id: Id90fcf34a376f7d3d0a1dec3a0a76e4df4b5053c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 73fb1d01a718f8c92f1f653cf8f62f45ca244545 |
|
13-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Merge "Remove "suggested contacts" while editing profile"
|
| 2bbfae8f92d5c218c83a49621a4c8f98f4d7a394 |
|
12-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Remove "suggested contacts" while editing profile
Bug: 5155177 The "suggested contact" pop-up shouldn't
show up while editing a local profile
Added a check to remove the call to get suggestion when the contact
is the profile.
Did some cleanup and created a method for detecting if we editing
a user profile.
Change-Id: I54b3a009f9fe3dd5f899b8b903b6830e71835874
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 02a54ebd3185948e2c1c0f39b7718cb9abaea934 |
|
12-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Prevent monkey crash with aggregation suggestion popup
Bug 5153029
Change-Id: Ibcedddaf1d2b57e1399e483701fe76c50aec64dd
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 8ef558d147af3ea47fe67f2585fb24b97a2e1285 |
|
12-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Merge "Remove join/split buttons for profile"
|
| 1ba8b6fea4c3f82ded19305874e72a326612aed1 |
|
12-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Finish string changes
Bug: 5147284
Bug: 5144069
Bug: 5150725
Bug: 5149819
Bug: 5144900
Change-Id: Ib3495e1ef7847eb2c01d7609c1524024123c993c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 03587ecd46c0a524f3cdc5ffd2959be2bc30bb34 |
|
11-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Remove join/split buttons for profile
Bug: 5149871 There should not be a way to Join/Split profiles
Change-Id: I4c7782d67f04fe494ed1825e631d2b8c1ae5810b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 6c8c0777c823e2a2fef69299c0b36ca4a40e1fea |
|
08-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show popup for aggregation suggestion
- create ListPopupWindow instead of embedding Views into
the base layout.
- refrain AggregationSuggestionView from having focusable and
clickable capability, which will be automatically supplied from
ListView
- tweak layout xmls to show ListPopupWindow correctly. Include
some pixel-perfect designs
Bug: 5057400
Change-Id: I9ec8642c0864204747ee445da7ee0292171a8788
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| bec0e12648b7c90aab9eda5b2837faca2493e5c3 |
|
10-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Remove unused callback
Bug 5143491
Change-Id: I20b82551329f1beb05dc4039cf0d501fe9a9e676
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ead19c5eafee0ffb43b02a4ae75ac5244ad3f853 |
|
30-Jul-2011 |
Isaac Katzenelson <isaack@android.com> |
Support for local profile
Bug: 5121834 Support local profile
5086184 Account name is overlapped by number of contacts
5082317 Text is chopped on the top in contact list
1. New headers were added at the top of the contact list to
present an empty local profile.
2. Clicking the empty local profile opens the editor to allow
the user to create a local profile.
3. Profiles are shown at the top of the contacts list with the
"ME" header and the number of contatcs.
4. "Add to contacts" button and the starred button were removed
from the details view when it is a profile.
5. Fixed a problem with a header view that remained when you had
a profile or was in search mode.
6. Fixed problem with contacts count apearing in search mode
Change-Id: I45615616e03a603759888d9e7169a853b3328b14
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| fd70903236883f47b21f23b8cb49a1ccacdfcdf1 |
|
02-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Pixel perfect work for phone contact editor
- Always show account header for raw contacts
- Align text fields and titles along the left margin
- Align spinners
- Use "Add new" as the default text if there's no value
in Event or Groups field yet
- Restyle account header
- Use primary/secondary colors everywhere
- Non-editable contact fixes: remove "not editable on
this device" and replace it with a toast when the
user clicks on the header, restyle item_read_only_field
Bug: 5097095
Change-Id: I94a6c91b05344028b64c62735fb4559f9944529d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2293e55d550fbc9974d1185960715e59acb14a85 |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Clear field if try to delete last field in section of contact editor
- Don't remove the field if it's the last field in the section,
just clear all EditText fields in that editor
Bug: 4382255
Change-Id: I2b436fbe895e5cc52770eefedaa2bc5f9726605f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 9959f0c9a7ee91490ecc1f9023c0012855363fe8 |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Merge "Modify action bar for contact editor"
|
| 13cc7c59d540608a2f1c68be0a31a0560392e0ae |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Default fields in contact editor
- Remove website and notes as default fields that show when
you create a new contact
- Don't allow "Add another field" button to add fields for
sections that are already visible (i.e. if website section is
visible, then "website" won't show up in the popup menu)
- TODO: Handle the case where there are no more fields to
add, need mocks from UX
Change-Id: I3b0929ebf69c93b60220c75c0b00b72cf5b2aa83
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 9b3dfd0bc36568558bfdc32a5d4c30f2d0df5fed |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Modify action bar for contact editor
- Use custom action bar for "Done" button (hide app icon and
get rid of "up" affordance")
- Move "Cancel" into the overflow menu and rename it to "Discard"
- Remove "delete" button from overflow menu in editor as specified
by the UX mocks b/c the user can delete the contact in the
contact card already
Change-Id: Ic389983a08a7b03fa24e7f4c1c37c95bd6c1c9fa
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a94859f61c216d4e137a631995026d3ddefbbf70 |
|
20-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Contact editor fixes
- Bring back data kind titles
- "Delete" button should be invisible not gone
- Make field + spinner horizontally stacked instead of vertically
stacked on phone
- Don't show account header if editing an existing contact that
only consists of 1 raw contact
Change-Id: I7dd4bfdf273eeaccca8399d182c0a56a6e23a8c7
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 5649a12fe551855f00c8dbeacfc96511c2a5fb71 |
|
20-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Go to contact card after editing
- In PeopleActivity, get rid of startActivityForResult to launch editor
because the editor will take care of launching the
contact card itself (instead of relying on the PeopleActivity
in the tablet to reload the contact details)
Bug: 4769324
Change-Id: Ibbaaccb03ac7961784dfa7b15c246b8d6f6489a4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a7c3d4d726b91f645431af14d8cceadd2245f4ce |
|
15-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Restyle contact editor header
- Move account switcher to top of editor
- Make account header always displayed (even on existing contacts)
- Take out hack for font size of structured name and just
make it text appearance large
- Align photo side by side the structured name
- Move over honeycomb style of group membership item over to
phone resouces folder
- Center "Add another field" button on the phone
Change-Id: I548edc3f1a2a0c20e83e4a28a10e110e51f8c12c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 0a2a5db3b3633883388953dc98e30c2edd7cae62 |
|
29-Jun-2011 |
Dave Santoro <dsantoro@google.com> |
Contacts App modifications for large photos.
Most of the work is on the provider side - essentially, the
provider will now deal with any size photo, downsizing it as
necessary to fit in a display size and thumbnail size. So
on the client we just need to pass in a larger photo to get a
hi-res display image for the contact.
Also switched a few spots to use the PHOTO_URI (with
openAssetFile) instead of PHOTO_THUMB_URI - more likely
remain.
Change-Id: I6ff8dd5453a9ff787907ab113d6e8aa6a71fcae1
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 623932de8c18e9b83b6fd941afe415ab2e6c730b |
|
09-Jul-2011 |
Daniel Lehmann <lehmannd@google.com> |
Fix NPE when joining contacts on the phone
Bug:4355323
Change-Id: I0183bfacaf430202234a96a8dbcb5e9949489a43
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c6b8afe730255537978f2c938cca6986cae63c34 |
|
23-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Group editor on tablet
- Allow autocomplete to add new members which presents
the user with suggestions from the raw_contacts table
with the same account name and type as the group
- Hook up the "new" and "edit" group buttons on the tablet
- Once the user exits the editor, update the group list
and scroll the group list to the group that was just edited
- Allow rename of groups (make the names of read-only groups
not editable)
- Allow removal of members
- Hook up the done / cancel / up / back buttons
- TODO: Be able to create a new group + add new members
in the same transaction. Then the new group editor
will allow adding members at the same time. Currently
you can only add a name to a new group. Once it's created,
then you can go and edit the membership.
- TODO: Bulk add/remove members in one transaction when the
user exits the editor. Currently it's saving the change
after you modify the membership list (even before you hit
the "Done" button in the editor).
- TODO: Add member status message and chat presence
- TODO: Add UI for non-editable groups
Change-Id: I1f32a28862c358b8bd1469666743cd240d28f80b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 2aa09b9965fd22c4dd5536d0f576ac351a8eb00d |
|
29-Jun-2011 |
Frank Sposaro <sposaro@google.com> |
Fixed NPE Bug for joining Contacts on Tablet.
Bug: 4355323
Change-Id: Icb4802e0d2b67dc118818d98ea5e06d95dde3d25
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a6c8f2daa80f1816dd25237457d7f6287c6b1b7c |
|
15-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show the selected account first in account switcher
Bug: 4584712
Change-Id: Ib041d7aa3cca3fa8f5b4780eb7a76c5e41819b39
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| be18de05d6f6a107c552e369bce58f51c946fde7 |
|
07-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add group detail fragment on tablet
- Add action bar on GroupDetailActivity, title, and subtitle
- Make everything use the groupUri instead of passing around
account name, type, group Id, and group title
- Fix some of the callback listeners between the group fragments
and group activities
- Add factory methods to ContactListFilter
Change-Id: I63066ea6eefde1e57562b6396d6dc590ed023c84
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 51e8d634f2d16aeaed73b6fba42d02a1c2d48b20 |
|
20-May-2011 |
Daniel Lehmann <lehmannd@google.com> |
Remove an unneeded function and an unused callback function
Change-Id: Icb01f50ad12d19a019da04bc27fa0d6f6ec04dfe
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d37a891cb44cd17083c06d7be693c469403d16df |
|
27-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Enable account switcher in contact creation
- remove account selection step before contact creation
- (phone) put account info on the right side of photos
instead of having "header" for it
-- renamed header_* ids for account stuffs as they may not be
part of header any more.
- add migration functionality to EntityModifier
- add test for it
- no optimal layout
Bug: 4184675
Change-Id: I0e777f9aa37a7c9145bd430f897f8068b0bede56
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a10775d625339d168337e03de05d02f5e0a4f55d |
|
31-Mar-2011 |
Daniel Lehmann <lehmannd@google.com> |
Don't save the contact if the user accepts an edit-suggestion
Bug:4194346
Change-Id: I51afcea7e92ac3d2e595a72920dd4dbb59267912
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 1e2a0333712ed2d2cbfac633d2696e5e4572b6fb |
|
03-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Merge "Modernizing phonetic name support"
|
| 5ec40b04041818bc042c0671cb1a43b54f650e25 |
|
02-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Modernizing phonetic name support
Bug: 3497894
Change-Id: I5aaa77275bbe1921af2d7ef034d2319691f8abf7
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c76c2e872b4d8deb0e8ac26e9558fa360d525fde |
|
01-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE in contact editor
Bug: 3499233
Change-Id: I3dc95c4d1e16b9d764bd50a937a58c9401be07ab
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 11bb73bcdf4290ced99e3e06b1f76d4c37357aea |
|
26-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preserving name structured on expand/collapse operations
If the user does not change components of the structured
name, the expand and collapse operations in the editor
should not reparse or re-compose the name.
Bug: 3473362
Change-Id: I4fe5f0d06757b2fe098a5bd895c84108195049e9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| eeb68a341734ded343004d4eecb585420e70605b |
|
25-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Posting focus request after adding a new field in the contact editor.
Also, making the contact name selected on the activity start
Bug: 3403046
Change-Id: Ic6baf9d4404237d62bca3cdabc41a14422236a3c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| c863b0171f2a54a0ee71b34b33034aeea2464cca |
|
25-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Remove confirmation dialog when cancel empty new contact
Bug: 3487518
Change-Id: I3d47b9249efd634e2ce21e6fbea19fe68f3d3ccd
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| ce37f3017c666bcea483a75322e80d5cc1ba6f64 |
|
16-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preserving editor status on rotation
Bug: 3452739
Change-Id: I9127ad4b37ff2a50123cde5b4e3ae8b4021e14e9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| f9ca423c867ab2cd4f0d9025a95436489c41d405 |
|
16-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Simplifying status management when launching subactivities
Bug: 3460703
Change-Id: Ibeabe952b5f22f0ac9de0d0f770284535a847d62
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| cd1b9a29458d30ec74cf94dc9945cbdb6186a68e |
|
16-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preventing NPE in aggregation suggestion UI
Bug: 3438193
Change-Id: I0a30d99339268e388d310720b52137022a3a44fe
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a9333790f027d59a2edfd4a98c0392b144577416 |
|
15-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Disabling aggregation suggestions while contact is being saved
Bug: 3457627
Change-Id: Id3bce3540ca83166a9c4f795c9b4aeab07d7c8ae
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a011414b12955a91c8f3efe528f374654d930098 |
|
15-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Moving contact saving to the service
Bug: 3220304
Bug: 3452739
Change-Id: If4124096a24e5dd302feb5338efaaa8398b2cb6b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 248fba273e867616b1f8973dac6ce3e5ee1ba544 |
|
27-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE on attaching a photo in portrait mode
Bug: 3395746
Change-Id: I631276d4777fa7ffba76ebfb87939c07c066810e
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 4292dfa46123a6c0e1de9862b4d8694bfb87875a |
|
23-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing alert dialog icon.
Also fixing selector in the contact editor.
Bug: 3377396
Change-Id: I34ca2e419158fe7869ffda4679ea60fa3c5fdb00
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 300835057b93255412059f236b4df59c706091ed |
|
21-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE in contact aggregation suggestions
Bug: 3374369
Change-Id: I09e387e93673ce8e767f6c0ede4e279c6fe97733
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| dd0dee6c55ea83d541b28e90cd4ad87ffd026f68 |
|
19-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Treating Join request as a regular save/reload.
Bug: 3362504
Change-Id: I5b5d97ed07c25e3a349d47b812efeb113d52a685
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 150cf5d82bf8655fbd6934d98c4a8f374e429fb9 |
|
14-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE in ContactEditorFragment
Bug: 3351000
Change-Id: I4c16d6e4b1e6c40caca7b94c5a4ea9e4e060e2ba
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| a07fa5f37031e4c5cd2933de02d2db41ec153e2b |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming AccountTypes to AccountTypeManager.
The intent is to turn it into a "system service" of sorts.
Change-Id: I047d70a2e59978c05916965ef0c0d9f18abc55e6
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| b77be6d2ad06edfd8751f55043e4aa9fd9f36015 |
|
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing inflation levels from AccountType.
Also, fixing asynchronous update and concurrency issues.
Bug: 3140873
Change-Id: Ie9d342d23ee4a8d23405ef4145c54d7673b2cbe9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 69f9e6f0cd9b5401da55f251e9bd98e69643d7df |
|
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming fields and variables from "source" to "accountType"
Change-Id: Ie41036e35a45fc7d9a8c934a3cbe68399c567ad6
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| fff6f07a02d3e3bbeff2ecf94a703782b71aea66 |
|
22-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding support for 3rd party contact editing
Change-Id: I0379f7392a23aea68d0f59a9869bb72275f5bddb
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 73a45b4ad96b21f468dbacde0da213d190979835 |
|
21-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE on join contact activity.
The monkey hit Menu=>Join and then quickly Back.
By the time the async task was done and we were
ready to start the join activity, the editor activity
was already closed.
Bug: 3299389
Change-Id: Ib98f2dc9e815a123636f85972888f3b571841015
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 9d2bcfb40d0ee107886eb99eba13a840e944ba43 |
|
20-Dec-2010 |
Dianne Hackborn <hackbod@google.com> |
Update to new Loader APIs.
Change-Id: I4be23901304890e1d0237d81e6cfb3889d5b6591
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 4ef95cc3329b4ad9fa450e4090efaad9935d493f |
|
16-Dec-2010 |
Dianne Hackborn <hackbod@google.com> |
Prepare for some changes to LoaderManager/Loader.
Sorry it is a bit ugly, it is to allow this change to be
checked in prior to the first stage of the framework change
without breaking the build.
Change-Id: Ic781324da69a06ef30a0b34cd4e16d561c9c7df2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 4ecb7028746a36c4febb831ba30a07d353e89e16 |
|
16-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Making contact filter focusable
Change-Id: I6d4407074c407034db5292064091bea3c63c8189
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| d3eedfc5f518a081d76d6b9e31a39c5adf988bc0 |
|
16-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding a confirmation dialog for canceling out of contact editor
Bug: 3144593
Change-Id: Icd6c9f96d9d2fd4ad84ba38711d0af874258dba5
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 02bb1252aa990813fa9e86ad75c458acc15e6801 |
|
06-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing progress dialog when saving a contact
Bug: 3253127
Change-Id: Ifd3b58f202fea76596880fb6de9f8acc46a32d79
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|
| 18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
|
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages
Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorFragment.java
|