| 69c182afb0e6d82a341a28b4317aa703af768906 |
|
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| b9065ddb28a2040cabda251891be2062b5260217 |
|
08-Nov-2016 |
Gary Mai <garymai@google.com> |
Implement linked contact menu option
Remove unlink option from QuickContact.
Link now appears when the contact has only one raw contact.
Otherwise a new "View linked contacts" menu option appears.
This dialog shows all linked contacts (including read-only) and
has buttons for adding another contact or unlinking all of them.
Show progress dialogs for each of these actions.
Test: Manually verified:
* View linked contacts only appears when there are more than one
raw contacts
* Link appears otherwise
* Pressing add goes to the contact picker and correctly joins the
selected contact
* Pressing unlink opens the confirmation dialog
* Canceling or dismissing the confirmation closes everything
* Unlinking from the confirmation does the unlink
* Confirmed the above with rotating on each dialog and during the
progress dialogs
Bug: 32707898
Change-Id: I39435a07fefce4276e34ba302001ff3dab352516
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| f08e5d10205da403d518d533999ed48c395433d9 |
|
07-Nov-2016 |
Wenyi Wang <wenyiw@google.com> |
Remove an unused method
Bug: 32673993
Test: see ag/1605120
Change-Id: I697c7957f0f402474bdcbff47971aa165cca5ea9
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 678108ebb9926a79ad0d7ac4f11417dec1583d42 |
|
26-Oct-2016 |
Gary Mai <garymai@google.com> |
Change aggregation suggestions to be raw contacts
Each suggestion is a raw contact that belongs to the same account
of the currently edited raw contact.
Surfaced data is the raw contact's data.
Pass the current changes to the newly selected raw contact.
Remove a few unneeded methods.
Removed the join option for tapping on a suggestion since all raw
contacts selected from here will be editable.
Since QuickContact depends on the aggregation suggestion engine to
return contact level suggestions also removed everything related to
it there since it's currently disabled.
b/29216287 tracks plans bring it back but it probably won't be in the
form of using the suggestion engine to populate the card, so it felt
okay to remove the code. Layouts were left in case they can be reused
later.
Test:
Opened QuickContact
Tested the suggestions for a contact with multiple raw contacts both
in and out of the current account and made sure only ones in the
current accountwere shown.
Checked contact with raw contacts which have different names, made
sure those displayed correctly. CP2 doesn't store the alternative
versions of raw contact names so the primary one is always shown
which is a non-regression.
Bug: 32277025
Bug: 32278866
Bug: 31088704
Bug: 31704115
Change-Id: Ibd4bdaaf100ffd5524eebac300d23763bbe6a22d
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| f8f6f95154dc89700823813a27149210e91ce89d |
|
22-Oct-2016 |
John Shao <johnshao@google.com> |
Editor Insert or Edit intent helper
Add helper to start the insert or edit flow
from other places in the app.
Test: manual
Bug: 32081723
Change-Id: I3d8c2c4d4c6d25f3beae045941c10f6ba2b5f411
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| a6c80b378e03ebdf6b654dbdb12f2c665fe98a80 |
|
01-Oct-2016 |
Gary Mai <garymai@google.com> |
Implement editor springboard activity
Have the springboard handle edit intents.
Show a dialog if the contact is made of multiple raw contacts.
Go straight to editor if:
* Single raw contact
* Given a raw contact Uri
In the case of 1 read 1 writable, we still show the dialog
since there would otherwise be no way to view what data comes
from the read only raw contact.
The springboard does not handle legacy contact Uris and will throw
an exception if one is received.
Test:
Tested these scenarios:
1) Edit a single raw contact
2) Edit a single read only raw contact
3) Edit a contact made of >2 raws
4) Add new contact
5) Edit a contact made of one read only, one writable
6) Made edits and checked if quick contact continued to update
7) The relevant edit intents from the Test app
Bug: 31826229
Bug: 31088704
Change-Id: I4c1c44accc86521efce2081744189d25f00ec541
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 363af60ea23e5a3b945005712a16564ab69db18b |
|
28-Sep-2016 |
Gary Mai <garymai@google.com> |
Rename editor files
Drop the Compact prefix since we only have one editor now.
Remove KindSectionDataList since it's now unused.
Test:
Tested build
Bug: 31088704
Change-Id: Ia5ac295804a14f79d0c837b151e33aabc60aa3d0
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 7b0970fd1db1a97f1be915d66d07f4dc8499f96d |
|
01-Sep-2016 |
Walter Jang <wjang@google.com> |
Merge base and compact editor fragments
Base editor constants, inner classes, members,
and methods were moved to the compact fragment
unchanged except:
* isAggregationSuggestionRawContactId was unused so just
removed it.
* maybeConvertToLegacyLookupUri was moved to
ContactEditorUtils
Test: Manually tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
Bug: 31088704
Change-Id: If3652dffef6a428aa0534ffbc639ae66601d6ab4
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 8bac28bebae51e53885a404cdf2dd4991000ba42 |
|
30-Aug-2016 |
Walter Jang <wjang@google.com> |
Remove full editor (1/2)
Test: Tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
Bug: 31088704
Change-Id: I1fce2873facefa39d7b468f1deda02acc674e3e1
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 9a55237f705453caae1f8aa3576a9acd7596d5ec |
|
24-Aug-2016 |
Walter Jang <wjang@google.com> |
Change editor raw contact selector to open the compact editor
* Whe editing more than one raw contact, just show the
raw contact selector with no input fields.
Eventually we'll be displaying the raw contacts in
a list instead of a drop down.
* When a raw contact selector item is clicked, open
the compact editor instead of the full one.
* We do the same trickery that the full editor does
to render a single raw contact -- even though
ContactLoader loads the aggregate, we pass along
the raw contact ID in the Intent to start the compact
editor and ignore all the other raw contacts in the
RawContactDeltaList.
* The compact editor is updated to be able to render
read-only raw contacts.
Test: Tested the following editor scenarios:
1) new contact
2) edit writable raw contact
3) edit read-only raw contact (joins a new writable raw contact to it)
4) edit aggregate w/ 1 writable and 1 read-only raw contact
5) edit aggregate w/ 2 writable raw contacts
6) edit local me raw contact
7) edit local me raw contact joined with a read-only raw contact
Bug: 31088704
Change-Id: I86a7fde976af8b318c7fb3da4f74f29f08a69eef
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 41c6886cabf68370f160ccd68d173bd6a59a1a07 |
|
18-Aug-2016 |
John Shao <johnshao@google.com> |
Force intents to start in app wherever possible
Add class/package names wherever possible for intents that are
started within the app itself. This is to avoid the intents picker
dialog that makes the user choose which app to handle the intent.
Bug: 30601104
Change-Id: I98d3a5a5c2112f1ba0c944b37c9b6754837dfa9c
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| c41a1e5f5f4872c3a0da5dec7671b66d9d80eb4e |
|
29-Jan-2016 |
Wenyi Wang <wenyiw@google.com> |
Revert "Show check mark when none is primary in photo picker"
This reverts commit bb601f2d4a7ed4db46dd87a4d451d42c666f1591.
Change-Id: Ia7a677e7f5d5a28fc45a1e3b85da52d9b1382485
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| bb601f2d4a7ed4db46dd87a4d451d42c666f1591 |
|
14-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Show check mark when none is primary in photo picker
If there is a photo in photo picker that is marked as primary,
we will use check that photo in photo picker.
Otherwise, with this CL, we compare the photo URI passed from
QuickContact to editor with the photo URIs in photo picker to
decide where to add a check mark.
Bug: 25092609
Change-Id: I0ae77f9874a60f45dcfb305d058ade9de4fef4a4
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 91cee2852497e918e9e04a6fb549c1117ed47ae0 |
|
07-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bugs on Contact editor.
1) Remove primary photo checkbox in full editor. Primary photo should
be set in photo picker.
2) Remove save menu if there's only one read only contact in the full editor.
3) Add account type icon in account info when there's only one account
for a contact.
4) Return back to Compact editor after saving results in full editor.
BUG 24547289
Change-Id: I02f8ee01f7cc7d1b0b06ad338570dc4b17c55e31
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 79658e14360a4ec75530a9dcae338f48c9d5f043 |
|
24-Sep-2015 |
Walter Jang <wjang@google.com> |
Remember editor expansion state on rotates (E10)
* Prompt user about discarding changes when back pressed
on editor (regressed in E5)
* Show a toast and close when no editors (i.e. input
fields) can be bound.
* Try to clarify the different behavior of
CompactSectionSectionView for names and groups.
Bug 23589603
Change-Id: If045ddb6d839574dc4109195b0d8841cd6083561
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 3e5ae0db65e842d49d047568fb5d6f331298da32 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Show all aggreagate contact names on the editor
Stop copying the name from read only contacts
to the new raw contact created in order to enable
editing of read only contacts. We also don't need to
match the name displayed by quick contacts.
In the new design, we are showing multiple names with
read-only accounts marked with the account type icon
and name.
Bug 23589603
Change-Id: Ifd8d18b17fc9645c15814bbb1a649a82fe246bbd
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 28a27279554af7b1e5ff664d3da97954c462a797 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Revert moving between the compact and full editors (E5)
We are reverting most of the changes made to fix
b/19624360 in MNC. The reason to do this is to reduce
the massive complexity moving between the two editors
introduced.
Since the compact editor now expands in place, the full
editor will likely only used to view read-only raw
contacts now.
Bug 23589603
Change-Id: Idfcc07d8aae65295d4b3f0a0e3e7f5eb701a46c4
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 953cea238c9969fd7703fbce2bf8a915b5c38955 |
|
09-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't show aggregation suggestion for new me contacts
Bug 23353464
Change-Id: Ifb63c73b59153ff7bdc26b3f4f471d3521bed0b2
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 03debc685e254b85df07fc9d213f17967a5fca9a |
|
20-Jul-2015 |
Walter Jang <wjang@google.com> |
Pass MaterialPalete colors to contact editor as ints not Parcelable
The MaterialPalette class is not public and crashes the edit contact
app selector if any third party app also has a filter for
android.intent.action.EDIT in their manifest.
Bug 22564102
Change-Id: I0926108bf83431e4c80412571062f7bc561c3de5
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 398cd4b1fbfa7d2fabfc4addf6a156a841a5aa6a |
|
16-Jun-2015 |
Walter Jang <wjang@google.com> |
Pass the preferred name ID into the contact editor
Bug 21870691
Change-Id: I99cc6bf8d90f32469ca7cf105567dcc3edf48e9f
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| ac679af994faece43536f1e8b2613f30c50300e1 |
|
01-Jun-2015 |
Walter Jang <wjang@google.com> |
Pass the preferred photo ID into the contact editor
Bug 21498424
Change-Id: I35e8fa3cff4d963f8017bdd596132fe749479a17
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| bf63a6d6a888b3e1b5fb91accf2dadaab4384539 |
|
05-May-2015 |
Walter Jang <wjang@google.com> |
Fix contact name passing from compact to full editor on inserts
Bug 19624360
Change-Id: I50c415b59c4bad1d08f18f8c2bc7d57ddb73c418
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 1e8801bc9bc60bdd1c95f582c460590272cfad64 |
|
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Pass full res contact photos between the compact and full editors
Bug 19624360
Bug 19655206
Change-Id: I590ec7ecec75a9af95b824f5db9cda8f8aeda675
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 921287ef72ca601027bf2971b0733493adde16d2 |
|
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Fixes for returning to the compact editor from the expanded one
* Don't abort the save even if there are no unsaved changed
when returning the compact from the full editor
* No need to pass the material palette on insert intents.
It does, however, need to be passed back to the compact
editor when editing an existing contact w/o a picture.
* Fix returning to the compact editor repeatedly by
removing the Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET
on compact editor intents.
* Updated StructuredNameEditorView#getDisplayName to fall
back to the display name directly from the ValuesDelta.
This is required when the name is passed to the
contact editor, and the user does not change it, in which
case it will not be written to the underlying data
structure, and thus not passed subsequent expantions.
Bug 19624360
Change-Id: Ife285f3e411a869a76fbbff4d42939c866db617c
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|
| 5a7a23bdb698b8e741a425c9617c5e33e6314cdd |
|
06-Mar-2015 |
Walter Jang <wjang@google.com> |
Return to the compact contact editor on back from the fully expanded one
Bug 19624360
Change-Id: I249f1e456a2d85c5ecd831358692d56b09ee5a5b
/packages/apps/Contacts/src/com/android/contacts/editor/EditorIntents.java
|