| b0afa207a16d22f5d220dd2b18db756a0d159e09 |
|
15-May-2015 |
Brian Attwell <brianattwell@google.com> |
Remove compact PhotoActionPopup's "Remove Photo"
The "Remove Photo" option was causing problems. I was able to do the
following:
1) Remove a photo from a read only raw contact
2) Remove a single photo from a contact with multiple photos. This
removes the current photo and arbitrarily picks another photo
to be the current photo
Killing the "Remove Photo" option removes these problems and was
suggested by UX a couple months ago.
Bug: 19697372
Change-Id: I266b4bf671216f6c1a57e3954a0387a01c0c9574
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 0e72ce9d97e0133a5f7cc348eef363bef9395979 |
|
23-Feb-2015 |
Walter Jang <wjang@google.com> |
Show edit contact photo options is a dialog
* Instead of a ListPopupWindow. This is more consistent with
the behavior of the other edit contact menu options.
* Also add an option menu icon to change the photo to
make this feature more easily accessible and since
users may not realize they can click the photo to
launch the choices dialog.
Bug 19124091
Change-Id: Ia4c37b3093f39d55784323f9a6d7bcf49ee96d16
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 7e67082d3f7c4ab56945040c0e4617b71c7e5f0b |
|
08-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
New design for photo editor
The photo editor field now looks like the mocks. It includes
a RadioButton that allows users to choose which photo is
primary. This RadioButton only appears if more than one raw
contact has a photo inside the contact.
Additional changes:
-fixed non-regression that made it impossible to
set some photos as primary
-fixed non-regression that made it possible for multiple
photos to appear as primary
-I fudged with a bunch of padding values in order to
compensate for View insets and paddings. This can't always
be done perfectly, since some insets/paddings vary based
on screen-configuration. I needed to start taking fudging
with these paddings in order to make the photo editor look
consistent with the other editor fields.
This CL doesn't bother ensuring the readonly photo edit
field looks good. This will be done in a later CL.
Bug: 18004959
Change-Id: I683f3ffa8e7f8683c2c083a2b4592b2b95c58c63
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 619ac169e45bf547a2cbcd8a9775bb234f45c00f |
|
20-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Use single method to handle all popup.dismiss() logic.
Refactor to reduce duplicate code.
Bug: 7902358
Change-Id: I6395635eba435ef6ebe4a34125d9a310c18f7e93
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| c21751ddc1a91453a37273ace9e24907bb54cc99 |
|
06-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Don't show Take Photo option if device has no camera
Bug: 6470740
Change-Id: I652ce8c9da89901379c876d168ba497bf1aa5836
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 2d4632c2eb7d2dc3bb94bf64c14c471aafa67b0f |
|
10-May-2012 |
Maurice Chu <mochu@google.com> |
Fine-tuned enlarging of contact photos
When tapping a contact detail photo on any device, the
detail photo will attempt to expand as large as indicated
while still remaining fully on the screen and leaving some
space underneath to show the popup menu options.
If there is no photo, then there will be no expansion
although writable contacts will show a popup menu.
Bug: 6462711
Change-Id: I8f69a1c18dfa10ff0d02b9dbd3ba78043cc7eb4e
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| ced983d7a816256d93fdea1f81e63e4598c18875 |
|
10-Jan-2012 |
Josh Gargus <jjosh@google.com> |
Better wording when choosing photo from PhotoSelectionActivity.
When there is already a photo for a contact, "Take photo" and
"Select photo from Gallery" don't sound as good as "Take new photo"
and "Select new photo from Gallery".
Bug: 5738108
Change-Id: I43e13774079695b0ecebc5d67576e2ea831706a0
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 6fa7384a1a5576ace18159de61af91c8b7c34dc6 |
|
28-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Allow adding/replacing a photo from contact card.
This involves a large refactoring of the photo handling code that
previously lived in ContactEditorFragment. The bulk of that logic
has been extracted out into PhotoSelectionHandler and
PhotoSelectionActivity classes.
As part of this change, also removed the selection highlighting when
tapping on the current tab header in multi-tab views.
Bug 5294297
Bug 5379389
Change-Id: Ic929e4b4a730d91f768a34367bb76967228ded17
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 507d85177886bece6ac38870d0e4b6c4655abc55 |
|
08-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix misc font sizes and spacing issues
- Make contact name and status more closely spaced together
(vertically), which also helps the status to still be visible
in the extra large font accessibility case
- Use our own version of the select_dialog_item.xml so that
long dialog items (i.e. "Select photo from Gallery")
do not get cut-off on the phone (Framework can't change
the font size in their XML because it's public API)
Bug: 5255619
Change-Id: Ica6ba908b0cb143550e9cf7391524449008b20cb
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 2293e55d550fbc9974d1185960715e59acb14a85 |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Clear field if try to delete last field in section of contact editor
- Don't remove the field if it's the last field in the section,
just clear all EditText fields in that editor
Bug: 4382255
Change-Id: I2b436fbe895e5cc52770eefedaa2bc5f9726605f
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 832dc0e2d0f91a28166ea51a068ebaf339e09e0d |
|
14-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing display of the photo action menu
Bug: 3291482
Change-Id: I61c89542541ffcdfa0efe1235b7efdb2dd1b3c44
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|
| 18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
|
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages
Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoActionPopup.java
|