| eec6992932cc1b650211402a30650c5842cc8ad8 |
|
07-Mar-2017 |
Gary Mai <garymai@google.com> |
Photo view in editor fixes
Use the height/width returned from getHeight and getWidth to
resize the photo view. Since it takes up all available space
initially these two values essentially function as the content
view height/width.
Test: Manually verified photo view sizing on M, N, and O with
rotation.
Also verified editor alignment in multiwindow mode on N.
One caveat is when rotating to landscape with the keyboard up on
O only, there's still a little bit of space at the bottom of the
photo view. This doesn't repro when loading initially in landscape
or rotating into landscape without the keyboard up. So the bug
isn't fixed entirely but it handles the more common cases.
Bug: 33922016
Bug: 27887505
Change-Id: I89ad06bfb07d8891c6ecb57cc7cb0452a2112385
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 0a49afa2ad697307cc04ef4cb86570574fa720f2 |
|
06-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common package (2/2)
Ran optimize imports on the project as well to re-order everything
which would have changed because of removing common.
Test: Built GoogleContacts, GoogleContactsTests, Contacts,
ContactsTests and ran unit tests.
Bug: 33252370
Change-Id: I881f0ba8b8fef002b6eeefa9a16b34f15b2fd2a9
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 69c182afb0e6d82a341a28b4317aa703af768906 |
|
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| ef6ceb2714641eb70dcedddf6a18e6344fd7cbcc |
|
17-Nov-2016 |
Gary Mai <garymai@google.com> |
Update editor photo view green lines
Default photo reads "Add contact photo"
Existing photo reads "Change contact photo"
Test: Manually verified the above, including proper updates when
* adding a new photo
* removing the photo
Bug: 32976203
Bug: 32975967
Change-Id: Id10023998b177d0e5e86db1ca11bcf5dd9727a87
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 34047d2d076f5501ff958f0ef041b4e25c65bbed |
|
17-Nov-2016 |
Gary Mai <garymai@google.com> |
A11y bug fixes for editor
Set profile photo content description as "Contact photo" if
in read-only mode, otherwise it's still "Change photo"
Set the whole row for read-only data to be focusable so it
reads the entire thing in one go
Fix ordering of content description for account header.
Test:
Manually verified the above.
Bug:32952012
Bug:32952102
Bug:32952414
Change-Id: I845f020e805a7f715892690b59c4bc00a8435e63
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 363af60ea23e5a3b945005712a16564ab69db18b |
|
28-Sep-2016 |
Gary Mai <garymai@google.com> |
Rename editor files
Drop the Compact prefix since we only have one editor now.
Remove KindSectionDataList since it's now unused.
Test:
Tested build
Bug: 31088704
Change-Id: Ia5ac295804a14f79d0c837b151e33aabc60aa3d0
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 65971d0f87dbee0b5ff93a7d64cdaab0940f56f5 |
|
16-Sep-2016 |
Gary Mai <garymai@google.com> |
Remove more editor view classes
Got rid of KindSectionView and the base and read only editor views.
Moved most of the read-only editor field rendering logic to
CompactRawContactsEditorView.
Dropped the expandable functionality of the read only view.
Dropped the edit externally functionality as it doesn't look like
it's being used.
Test:
Viewed the single raw contact only view from the account list.
Bug: 31088704
Change-Id: I9ba0172f4002b2fe24cd397ea65298cf486f5873
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 23a34d10b03e8a713a2b93980ff7f4c696aff93d |
|
08-Jul-2015 |
Walter Jang <wjang@google.com> |
Mark Editors as deleted when entire KindSectionViews are removed.
Regression was introduce by ag/721564
Bug 22345338
Change-Id: I21ef3e94cc20c8cc10f06084ce350b626710bbfc
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 055c66d459732973f7341331b143d7ab9974c4ed |
|
12-Mar-2015 |
Walter Jang <wjang@google.com> |
Fixed some contact editor compiler warnings
Change-Id: I31deaeeedc4ae49da6b0326b128767785cd01852
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| f140227beb6d9e78955a7676dc0dd3f793f72017 |
|
17-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Don't directly reference hidden View fields
Remove references to hidden view properties and fields
where 100% analogous unhidden equivalents exist.
* isLayoutRtl()
* mContext
Bug: 18777272
Change-Id: I1cc69fd846893087787f5cf340bf2a0ee6571f42
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| da71919dcd16754cb378fc664967f4b278431c70 |
|
12-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Material design readonly editor
The readonly edit screen is a strange beast. At most, it
only shows fields for phones, emails, photos and
names even if more data is available. This CL updates
the appearance of these fields.
Bug: 18004959
Change-Id: I25847483cef36bb4c98f4b169970344b90e63add
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 7e67082d3f7c4ab56945040c0e4617b71c7e5f0b |
|
08-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
New design for photo editor
The photo editor field now looks like the mocks. It includes
a RadioButton that allows users to choose which photo is
primary. This RadioButton only appears if more than one raw
contact has a photo inside the contact.
Additional changes:
-fixed non-regression that made it impossible to
set some photos as primary
-fixed non-regression that made it possible for multiple
photos to appear as primary
-I fudged with a bunch of padding values in order to
compensate for View insets and paddings. This can't always
be done perfectly, since some insets/paddings vary based
on screen-configuration. I needed to start taking fudging
with these paddings in order to make the photo editor look
consistent with the other editor fields.
This CL doesn't bother ensuring the readonly photo edit
field looks good. This will be done in a later CL.
Bug: 18004959
Change-Id: I683f3ffa8e7f8683c2c083a2b4592b2b95c58c63
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| c300521331c04767cd19dfe05ab77567514bbaa0 |
|
06-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Use larger photo in contact editor
Increase the size of the photo in the contact editor.
This means we can no longer rely on thumbnails. We
now need to load contact photos from Uris.
Bug: 18004959
Change-Id: Ice2099998194adad9336c5d90e9873a230ca4bd5
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| f677450d82e7b961fda2a18fea2ad51e88437e8b |
|
20-Feb-2014 |
Yorke Lee <yorkelee@google.com> |
Use new ContactPhotoManager APIs for default avatars in Contacts
*Update the following uses of ContactPhotoManager.loadPhoto
and ContactPhotoManager.loadThumbnail
GroupEditorFragment
EmailAddressListAdapter
PostalAddressListAdapter
*Replace the following uses of R.drawable.ic_contact_picture_holo_light and
ContactPhotoManager.getDefaultAvatarResId with
ContactPhotoManager.getDefaultAvatarDrawableForContact
PhotoEditorView
AggregationSuggestionView
SuggestedMemberListAdapter
ConfirmAddDetailActivity
ImageViewDrawableSetter
*Protect against a null drawable in TransformableImageView()
*Add lookup fields to cursor projections in EmailAddressListAdapter
and PostalAddressListAdapter to correct construct a DefaultImageRequest
and assign LetterTileDrawables for contact photos
Bug: 13101785
Change-Id: I9c04ce81192913bf3c398a9a7a9368861bd93b59
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| cd321f65f1e50409812976380ad1f0fdb3fa35cb |
|
28-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Move ContactLoader related code to ContactsCommon
This CL simply moves classes from Contacts into ContactsCommon.
This is needed so that Dialer can use ContactLoader related code
for b/11294679. A ContactLoader will also be needed in the future
to allow InCallUI to download hi-res photos while in call.
Bug: 11294679
Change-Id: Ia033f3ea2406a907a4e71290c9ce810a5583dab8
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 738ff8623dc77dd91a1b9023861e924ba5e4c27e |
|
30-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move ValuesDelta to ContactsCommon.
Bug: 6993891
Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| aa690d4949b8105e5bcf10569b7cf4fae36741de |
|
29-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Prefactor RawContactDelta.ValuesDelta into top level class.
Making ValuesDelta into top level class so we do not have to move
RawContactDelta into ContactsCommon. ValuesDelta is used by
CustomContactListFilterActivity which needs to be moved.
Bug: 6993891
Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 428f008513d1591cc08fcfe2cf0c9237fb313241 |
|
14-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move dependencies of AccountTypeManager into ContactsCommon.
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 740552201d103b80bc49ea8a39a30536222672ea |
|
27-Apr-2012 |
Daniel Lehmann <lehmannd@google.com> |
Don't show triangle and on-press state if there is no action
Bug:5265514
Change-Id: Ifc1d3b765f909f0ec7cc7565b9d89de50c4a5549
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| e5d3f897689c8ba0f275c7679c72eacb190ae9b8 |
|
11-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Fix regression; once again we can apply Gallery photo to contact.
The changes to support hi-res photos in Ic0cabaa5 were not applied to
AttachPhotoActivity. This CL makes the analogous changes, and many other
cleanups besides.
In addition, applying the Gallery photo works even if the AttachPhotoActivity
is killed (eg: when selecting a contact, or when cropping the photo); this
didn't work even before the regression.
The save-contact Intent which invokes the ContactSaveService no longer
needs to specify a callback Activity (it is OK to pass null if you don't
care about getting a callback).
The subclasses of PhotoSelectionHandler have been significantly simplified,
partly by pushing common behavior to the superclass, and also by directly
accessing state in their outer class instead making their own copies.
ContactLoader.Result.getEntityDeltaList() is a new instance method that
replaces more verbose incantations.
New utility class, ContactPhotoUtils. Helps with compressing Bitmaps, and
generating temp-file names used when saving hi-res photos to a contact.
Bug: 6298601
Change-Id: I2fe90c33c9fa81716f263d82ed80c0d6f63c6a7e
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 764637aba745612a9fdc07adb99c615263916fa8 |
|
04-Apr-2012 |
Josh Gargus <jjosh@google.com> |
Allow setting photo on otherwise-empty local contacts.
Fix bug in ContactEditorFragment where, after tapping "Done",
the contact's photo is still unset. This regression is due to
the changes to support high-res photos... now that we use a
side-channel to save the photo, the EntityDeltaList doesn't
know about the change. The fix is to also create a thumbnail
and add it to the delta-list. This allows us to avoid ugly
special-case code in the editor and save-service. The high-res
photo is still saved via the same side-channel.
Bug: 6109553
Change-Id: I59bb9885eeb0260861ee167d3b5f1c7319896488
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 26918da1650c1ff7b6f92deb978ab976525c811a |
|
03-Feb-2012 |
Josh Gargus <jjosh@google.com> |
Contact-editor now immediately shows proper editor for new fields.
Previously, when adding a new field via "Add new" or "Add another
field", an empty field appeared, but the user couldn't edit its
contents without first tapping on it. Now the approperiate editor
UI pops up immediately (eg: when you add a new "event", a date-picker
pops up).
Bug: 5070818
Change-Id: I882a8202a6a76f73f3efd24734b0e0acdbcecac0
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| e692e010ca02200087997280e7c239ebf94aa8f9 |
|
18-Jan-2012 |
Josh Gargus <jjosh@google.com> |
Support for high-resolution contact photos.
Rather than getting a bitmap directly from the gallery app, with
this change we create a temporary file and request that the photo
be stored there. This avoids running into bundle size limits when
passing large, uncompressed bitmaps back from the gallery.
After reading the photo out into the Contacts app, we use the
openAssetFile API to stream the large photo data into the
Contacts Provider. Note that we do this rather than having Gallery
write directly to the provider because we have no guarantee that
the Gallery (or substitute) app has WRITE_CONTACTS permission.
In the Contact Editor, the image is not permanently stored until
the contact is saved. This avoids needing special logic to handle
the case where the contact is newly-created.
Fix bug 5907233 en passant... the vestiges of some partially-
expunged code were causing the ContentEditorFragment to not
apply a selected photo.
Bug: 5786849
Bug: 5907233
Change-Id: Ic0cabaa50c08d6a9a0b730698c92f4092192438a
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| ecfc26c3f9495f1a4efed69a1582ff2b0deb2c71 |
|
13-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
New avatars
Bug:5074147
Change-Id: I583d22c63a7b617567c523efeed292ae1e2be7e4
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 2293e55d550fbc9974d1185960715e59acb14a85 |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Clear field if try to delete last field in section of contact editor
- Don't remove the field if it's the last field in the section,
just clear all EditText fields in that editor
Bug: 4382255
Change-Id: I2b436fbe895e5cc52770eefedaa2bc5f9726605f
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 2591436971bad3050c85929c8e0c5a8d48111f88 |
|
30-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "add field" logic
- Only update "add field" footer when field goes empty --> non-empty
and vice versa, fix the case for 4 line addresses in Exchange contacts
- Add property in DataKind class for "add field" string
- Remove hash map of mime types --> string resource IDs in
KindSectionView
- Remove "add internet call" string
Bug: 4363151
Bug: 4371568
Change-Id: Id2fec743a7c3e68d8404591cc61de20487245b0a
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 1b22073590c1801c3e6c7bde2f4636632a049f6c |
|
29-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
"Add field" footer logic
- Instead of an explicit "+" button to add a new field (which
also allows adding multiple empty fields), only show a
"add field" footer to the KindSectionView if there are no
existing empty fields in the section.
- Make the whole footer a touch target and display a
custom message according to the DataKind mime type
Bug: 4363151
Change-Id: Ib7cef5ed5aaefa5b1269f95ed8fe89e7dd742f36
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 405671a7b42d97ebf7ae7c0eeb4721f881139673 |
|
29-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move DataKind outside AccountTypes
Bug: 4184675
Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 02bb1252aa990813fa9e86ad75c458acc15e6801 |
|
06-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing progress dialog when saving a contact
Bug: 3253127
Change-Id: Ifd3b58f202fea76596880fb6de9f8acc46a32d79
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|
| 18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
|
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages
Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/editor/PhotoEditorView.java
|