| 57a0e98eed836b72dd3dc3540b9cac029266ed7c |
|
25-Mar-2017 |
Wenyi Wang <wenyiw@google.com> |
Add isLoggable checks to all verbose and debug log outputs (1/2)
Bug: 6813854
Test: built apk and verified log is seen in logcat
Change-Id: Ib17cac0d2d9553276c4271221110305ab2d70a46
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 1e899dc127a212bfd2198fe7adba5c33eb4cd751 |
|
08-Feb-2017 |
Gary Mai <garymai@google.com> |
Handle revoked permissions when resuming the app (1/2)
The activities that create these fragments will request permissions
but if these fragments were created and the permissions were revoked
then Activity's super.onCreate() will recreate these fragments before
the permission activity is started, which causes a bunch of issues
since the original activity never finishes it's onCreate method so
many things aren't initialized for the fragments.
So in activities that maybe start the permission activity and have
visisble fragments, instead of returning, continue initializing
everything.
In the case of editor, not being able to select a raw contact delta
is a legit case so it should have been handled as a failure and in
general we shouldn't be attempting to bind the editors if we don't
have the permissions.
Test: Manually verified removing permissions and going back to the
app from the recent apps screen doesn't crash while viewing:
* main list
* groups view
* first level suggestions
* duplicates view
* account view
* editor
* settings
* pick group member to add view
* pick phone numbers to send to from group
* pick emails to send to from group
The behavior is permissions get requested and will go back to the
original activity (PeopleActivity with main list loaded or the
editor activity).
Bug: 34741297
Change-Id: Ie234b1f44e83372b9c0ad9658fa4a2e9b40572b0
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| befbd85aa820ed0d33ae5a3ec4a923e250d2b2f0 |
|
11-Jan-2017 |
Gary Mai <garymai@google.com> |
Focus on name field and show keyboard when inserting contact
Request name field focus when it's an insert.
Test: Manually verified:
* Inserting new contact with fab has keyboard and focus on name
field
* Inserting new contact from messenger app has keyboard and
focus on name field with phone number filled in
* Editing a contact has nothing focused
* Editing a read-only contact has the name field focused but no
keyboard
Bug: 31158231
Change-Id: Iff7e0df5059f5efa038d5f794065f76e38a21288
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 807e6208d6bc4ff1a6b0b4d8900229df27077246 |
|
21-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Use loaded accounts for editor account prompt
Test: ran GoogleContactsTests
Bug 33627801
Change-Id: Id8bdf1d5a2a13bb526118b104bae06138f0333ac
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 4bd50d69d2b8934dbd4cbd634ad83807d9b02735 |
|
16-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Use loader for accounts in editor fragment
Test: manually remove selected account in editor and verify that
it changes to the first account in list
Bug: 33627801
Change-Id: I6554f03c207fb761f7b8d971e0f07f7416efcd72
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| bd9ef3c60669d71543b3506d4959c1fe4be409dc |
|
15-Dec-2016 |
John Shao <johnshao@google.com> |
Standardize and replace assets with vectors
Standarize naming of vector drawables and replace png
assets with vector drawables.
Test: build and run GoogleContactsTests
manual side by side sanity check with previous version
Bug: 33251913
Change-Id: Iafea5c1bba738c57437888da999fc2909d0765fd
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 0a49afa2ad697307cc04ef4cb86570574fa720f2 |
|
06-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common package (2/2)
Ran optimize imports on the project as well to re-order everything
which would have changed because of removing common.
Test: Built GoogleContacts, GoogleContactsTests, Contacts,
ContactsTests and ran unit tests.
Bug: 33252370
Change-Id: I881f0ba8b8fef002b6eeefa9a16b34f15b2fd2a9
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 69c182afb0e6d82a341a28b4317aa703af768906 |
|
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 4b11232fdf9e11e73b2ffa41b40f3e153ec3912b |
|
18-Nov-2016 |
Marcus Hagerott <mhagerott@google.com> |
Add description to SIM import account dropdown arrow
Also make the same change for the account chooser in the editor.
test
manually verified that drop down arrow reads out "Show more" with
talkback on
Bug 32973740
Change-Id: I4050cbf37a6ba11300262716c5a6ab7c4f8d2a99
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 34047d2d076f5501ff958f0ef041b4e25c65bbed |
|
17-Nov-2016 |
Gary Mai <garymai@google.com> |
A11y bug fixes for editor
Set profile photo content description as "Contact photo" if
in read-only mode, otherwise it's still "Change photo"
Set the whole row for read-only data to be focusable so it
reads the entire thing in one go
Fix ordering of content description for account header.
Test:
Manually verified the above.
Bug:32952012
Bug:32952102
Bug:32952414
Change-Id: I845f020e805a7f715892690b59c4bc00a8435e63
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 079598fa2e09c22bb672715a9559b9d8973044d5 |
|
03-Nov-2016 |
Gary Mai <garymai@google.com> |
UX updates to read-only view of raw contact
Use back arrow for navigation icon.
Use "view only" string for title.
Change account header per screenshot in bug.
Test:
Manually checked and verified headers/navigation icons/titles of:
* view of read-only raw contact
* edit view of writable raw contact
* add new contact
Bug: 31868376
Change-Id: I1d390f785bf4c0de90102e6a9e02477a8c19ddee
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 5336e6ef1924162b94942cbd8f69202d553822da |
|
23-Oct-2016 |
Gary Mai <garymai@google.com> |
Forward intent extras to editor activity from springboard
Apply the extras once we have selected a raw contact to edit.
Test:
Selected an existing contact to add to and saw passed in
data was correctly applied.
Tested cases where editor auto loads, and picker dialog shows up.
In the case of the picker made sure that selecting any of them
would have the data passed through.
Bug: 32345528
Change-Id: I9a4088b3358ab532362c878394c657781965fb03
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 5a00de39004d298de4daee3e183add5eff17102c |
|
20-Oct-2016 |
Gary Mai <garymai@google.com> |
Update logic on when raw contact picker dialog is shown
Shouldn't be based on count of raw contacts, but whether writable
raw contacts exist.
Test:
Edit me profile that has 2 G+ accounts linked (where the me profile
has not already been created)
Edit an aggregate composed of 2 read-only accounts.
Edit aggregate of 1 write 1 read
Edit 1 read-only
Edit 1 write
Bug: 32289543
Bug: 31826229
Bug: 31088704
Change-Id: Ib01445b59fa9fc882a6d32d24f39917d726e6174
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| ac5bd644bcd2c27294a70774abfa9e24fb3d5c52 |
|
12-Oct-2016 |
Gary Mai <garymai@google.com> |
Skip psuedo name mimetype during delta parse
Missed this in ag/1527652, an extra name field was appearing
because of it.
Test:
Hit "more fields" and see no extra name fields.
Bug: 32023197
Bug: 21758689
Change-Id: I8b8f0cd1d8556dd79162a6c723b4bd108d1ed476
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| d7faa65c1349a7ded4d2d478822c07d024e5e792 |
|
03-Oct-2016 |
Gary Mai <garymai@google.com> |
Remove account selector when editing a raw contact
Keep the header, but remove the onClick drop down.
Remove the boolean for if the raw contact is read only,
and use the current state to determine if that's true.
Test:
Applied this commit on top of the spring board one and tested:
1) edit read only raw contact
2) edit writable raw contact
3) edit contact made of single read only raw contact still opens
the insert a new raw contact version
4) insert new contact
Bug: 31826229
Bug: 31088704
Change-Id: Ia8e5b0a5965b77b0c160336ce81ddac801b201ff
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 363af60ea23e5a3b945005712a16564ab69db18b |
|
28-Sep-2016 |
Gary Mai <garymai@google.com> |
Rename editor files
Drop the Compact prefix since we only have one editor now.
Remove KindSectionDataList since it's now unused.
Test:
Tested build
Bug: 31088704
Change-Id: Ia5ac295804a14f79d0c837b151e33aabc60aa3d0
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 8bac28bebae51e53885a404cdf2dd4991000ba42 |
|
30-Aug-2016 |
Walter Jang <wjang@google.com> |
Remove full editor (1/2)
Test: Tested the following editor scenarios:
1) new contact
2) edit other contact
3) edit writable raw contact
4) edit read-only raw contact (joins a new writable raw contact to it)
5) edit aggregate w/ 1 writable and 1 read-only raw contact
6) edit aggregate w/ 2 writable raw contacts
7) edit local me raw contact
8) edit local me raw contact joined with a read-only raw contact
Bug: 31088704
Change-Id: I1fce2873facefa39d7b468f1deda02acc674e3e1
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 3e8cc3545302155fdd262ab1935029247e82254d |
|
29-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Add account type icon to account info header and change style of
"Saving to"
Screenshots: https://drive.google.com/a/google.com/folderview?id=0BwSNbQ_IWQd2NUFqb21MUm11WU0&usp=sharing
The changes related with "Saving to" (b/25366902) are in:
- res/layout/editor_account_selector.xml
- src/com/android/contacts/editor/CompactRawContactsEditorView.java
The changes related with account type icon (b/25189655) are in the
other files. The account type icon is added to account info header
in both full editor and read-only editor.
Bug: 25189655
Bug: 25366902
Change-Id: I4f149f639debd31296da81f6678cda8d01007ea9
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| be5e1b109ce134c7f3f45cd4fc27b69454d7ad31 |
|
17-Oct-2015 |
Walter Jang <wjang@google.com> |
Show "local only" account name for me profile
Bug 24988734
Change-Id: Ief827757e148d240ec74b46c1dfbb11c1c68a18c
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 28a27279554af7b1e5ff664d3da97954c462a797 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Revert moving between the compact and full editors (E5)
We are reverting most of the changes made to fix
b/19624360 in MNC. The reason to do this is to reduce
the massive complexity moving between the two editors
introduced.
Since the compact editor now expands in place, the full
editor will likely only used to view read-only raw
contacts now.
Bug 23589603
Change-Id: Idfcc07d8aae65295d4b3f0a0e3e7f5eb701a46c4
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| defc69ce69b25daa4e3f41b7c7c6cbd1aa3e83ce |
|
26-Aug-2015 |
Walter Jang <wjang@google.com> |
Show proper label for phone only accounts
I broke the account label for phone only contacts
when I extracted the logic to set the account label
on the full editor to a utility method so that it
could also be used on the compact editor in ag/712716
Bug 22859536
Change-Id: I3e64f7f6834a1da83078cc783e04b3c2faa0702f
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 4a9351db3c8385469bad037544d4b60d76504f5e |
|
30-Jun-2015 |
Walter Jang <wjang@google.com> |
Fix showing all phone nums and emails for joined contacts
We must delete the entire KindSectionView for emails and
phone numbers for all but the last raw contact that is being
edited.
Also, icons must be updated whenever an editor housed in
a kindview is deleted since we only want to show the icon
once for all the kindviews added to the compact layout
for all the raw contacts in the delta list.
Bug 22203548
Change-Id: If12c4fc10a9c9c09cbcfb86c5bf1472d89f6b890
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| c4cecc7e7534c7f5d887222d9e6f1a43364f7665 |
|
25-Jun-2015 |
Walter Jang <wjang@google.com> |
Show google account types on editor as "account" instead of "contact"
Also, missed the copy of the account type display lable setting
logic for read-only contacts in ag/712716 so replacing that with
the static utility method.
Bug 18719390
Bug 21637149
Change-Id: I112b32a25d4d3682ca8e58ef327660bd163cb273
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 2d3f31c210ffc617e82e3b41fc32b54ec2a5011a |
|
19-Jun-2015 |
Walter Jang <wjang@google.com> |
Show account info for inserts and read-only contact edits
Bug 21637149
Change-Id: I224ab188230f119f49f4ab7ddef4b51c451aa892
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 88b0a8cc7c512c5f28dad958da276974c845355c |
|
08-Jun-2015 |
Walter Jang <wjang@google.com> |
Revert KindSectionView logic NOT show an empty input field
We don't need to make it optional to show an emtpy input
field since we've changed our minds on not allowing
users to add email and phone numbers on the compact editor.
Bug 21661221
Change-Id: Iec0d3a37a76c787d17922dbc184142dfca98a9de
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 1044645b9c2050436f4f0e0c7e5b8da2931879ba |
|
20-Feb-2015 |
Walter Jang <wjang@google.com> |
Hide extra empty kind editor on compact contact editor
* Also left align "More fields"
* Only show one structured name
* Be a bit smarter about the profile photo before
we have a real split screen
Bug 19124091
Change-Id: I046ea59437b035d43df045363677a3aaba0dca43
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| f140227beb6d9e78955a7676dc0dd3f793f72017 |
|
17-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Don't directly reference hidden View fields
Remove references to hidden view properties and fields
where 100% analogous unhidden equivalents exist.
* isLayoutRtl()
* mContext
Bug: 18777272
Change-Id: I1cc69fd846893087787f5cf340bf2a0ee6571f42
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 099046cfb5ede3a56cff494796e79d194bf81da6 |
|
12-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Support editable 3p accounts without nicknames
Fix a theoretical crash case.
We shouldn't assume the nickname field always exists.
All standard writable accounts have nickname fields.
But, it is possible to create an 3p account type with
an xml edit specification that omits the nickname
(I don't know if anyone does this).
Bug: 18004959
Change-Id: I9770e88891e5800ef56d2df8a0ddb8463e3e8815
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 7c8012090926070dc6bde1691341a2969996518c |
|
11-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
bugfix: don't show name in nickname field
Bug: 18004959
Change-Id: Ic0ba640cf83bd614c77d30bed3b02f08347b237d
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| d690dff231dd5a81b9bd7563838455f24e49c75c |
|
03-Dec-2014 |
Brian Attwell <brianattwell@google.com> |
Change text colors to reflect their state
The editor's text color suffered from two conflicting
problems
1) It didn't all pass GAR
2) The difference between hint text and regular text
is too subtle to differentiate at a glance
Changes
1) Once a LabeledEditorView is non-empty, the text color of
the spinner should no longer be the hint text color
2) Once an editor field is focused, all fields in the same
EditKindSection get a slightly darker color. Since the various
name editors, don't actually belong to a EditKindSection
extra work needed to be done for them.
3) Drop down lists use non hint colors
Read only editor continues to use the darker hint color.
There is no need to strongly distinquish hint colors from
non hint colors in the read only editor.
Bug: 18004959
Change-Id: Ia6b16ab882b2fcb9113c2ac880e741f62115a1f9
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| daa2058979fda84a0ce22e21edd53aa049e80aa0 |
|
26-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Collapse extra raw contact editors
There are now two different header styles
1) When creating a new raw contact: if there are multiple
accounts to create the raw contact under, then show a
header with an acconut selector
2) Otherwise, show a visually distinct account header without
a drop down account selector. If there are multiple raw
contacts, this header also lets you collapse raw contacts
Typical users, who only have a single writeable account, will
never see header (1). This is fortunate, since switching between
the two header styles is a bit visually inconsistent.
Bug: 18004959
Change-Id: I133a7355a220f20b55657a6c1a51ff44665ea3b9
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 2ebade8924bb6d2734b603938f418959cc79e2ad |
|
05-Nov-2014 |
Brian Attwell <brianattwell@google.com> |
Editor name fields
The mocks show all name fields collapsed into a single field.
After deeper inspection, this proved to be poor UX. Instead
we show the three name types inside a single name section.
Screenshot: go/ba_screen_captures/contacts/b18004959_edit_screen_material/name_fields.png
Bug: 18004959
Change-Id: Ic06abcd151a64746cce32832b27e8f47ec6b981d
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 043fba637b421dcd554c634f769f0e883fb5ff8b |
|
30-Oct-2014 |
Brian Attwell <brianattwell@google.com> |
Material design of common edit screen fields
The normal edit screen fields, such as phone number and location,
have been updated to look like the new Material design mocks. I expect
this to be the largest CL needed to finish b/18004959.
Aspects of the Editor that haven't been touched in this CL
- readonly editor
- collapse nickname and phonetic name into StructuredNameEditorView. Then make
sure the layout is correct
- photo editor
- Material insert/delete interpolators (maybe fast_out_slow_in)
- account header
Some complicated/weird parts of the CL:
-KindSectionView no longer displays an "Add details" button. Instead
it always shows an additional empty row for each mimeType. The logic
that handles this is mostly inside #updateEmptyEditors(). A lot of code
could be deleted from RawContactEditorView because of this.
-LabeledEditorView's adapter displays TextView's inside Spinner. In order
to make the TextViews look like EditTexts, I set the EditText's background
(so the 9patch padding is used) and then later remove the background.
-Instead of keeping an expansion_view_container in every single field,
I only kept it where it was needed. As a result, I needed to add
null checks into the TextFieldsEditorView base class.
-I made an effort to reduce the depth of the view hierarchy and reduce
the use of LinearLayout weights for performance reasons, when it was
easy to do so
Bug: 18004959
Change-Id: I5934ca189b66468834faf3bb995b172ae2f90bed
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| fbc6cdd5f9ed04f95e9d1ef565017c2208f61d20 |
|
22-Apr-2014 |
Yorke Lee <yorkelee@google.com> |
am 08afec7f: Merge "Move cursor to the right place when adding phonetic name"
* commit '08afec7f1251b6a337eda32762afd023fbe2ec95':
Move cursor to the right place when adding phonetic name
|
| 6ba58c7dc8d63e1a6f803f9c2dd1990d80567c59 |
|
06-Jun-2013 |
Puneet K Jain <puneet.k.jain@intel.com> |
Move cursor to the right place when adding phonetic name
When adding the phonetic name, the Editor fails to get the focus automatically.
Change-Id: I6371508ea595b83e10a89c7a647452bd969a9d17
Signed-off-by: guojingx <guojingx.wu@intel.com>
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| a8c9337bf6ca808382d6c4401b05ddc79929e9f5 |
|
10-Jan-2014 |
Jay Shrauner <shrauner@google.com> |
Handle null returns from insertChild
insertChild() returns null whenever kind is null. Don't crash in these cases.
Bug:12490438
Change-Id: Idf1cd8fa9d6dfe6a2f91f3ff656663f0692f4a3f
(cherry picked from commit f54c9f2c84a88e046e29123fa65b19040e5a457b)
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| cd321f65f1e50409812976380ad1f0fdb3fa35cb |
|
28-Oct-2013 |
Yorke Lee <yorkelee@google.com> |
Move ContactLoader related code to ContactsCommon
This CL simply moves classes from Contacts into ContactsCommon.
This is needed so that Dialer can use ContactLoader related code
for b/11294679. A ContactLoader will also be needed in the future
to allow InCallUI to download hi-res photos while in call.
Bug: 11294679
Change-Id: Ia033f3ea2406a907a4e71290c9ce810a5583dab8
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| eba2721a826e2edc78e37b2519aa5d5f06857cde |
|
15-Jan-2013 |
Yorke Lee <yorkelee@google.com> |
Fix monkey crash in RawContactEditorView
Bug: 8011818
Change-Id: I3c69f253aadfc94ee4bc7364d2943b9068efd394
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 44cfc56d1701629070384364416c1311b780535d |
|
13-Sep-2012 |
Chiao Cheng <chiaocheng@google.com> |
Allow read-only contacts to be editable.
- Automatically create new raw contact when editing a read-only contact.
- Refactored mState to be always initialized.
- Allow RawContactDeltaList to be instantiated with empty constructor.
Bug: 6406182
Change-Id: I7a58625485dae6957b4f9bcc446122f54551afa1
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 827b5d6611018497eb28a0776cb51226fb81ae23 |
|
07-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Don't hide organization fields on rotation if they are expanded
Keep track of whether or not organization fields are expanded so that
we can restore this property on rotation
Bug: 6009291
Change-Id: I525606c940ffa66458e689cfc6e376d8719de4d8
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 738ff8623dc77dd91a1b9023861e924ba5e4c27e |
|
30-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move ValuesDelta to ContactsCommon.
Bug: 6993891
Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| aa690d4949b8105e5bcf10569b7cf4fae36741de |
|
29-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Prefactor RawContactDelta.ValuesDelta into top level class.
Making ValuesDelta into top level class so we do not have to move
RawContactDelta into ContactsCommon. ValuesDelta is used by
CustomContactListFilterActivity which needs to be moved.
Bug: 6993891
Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| ba09d4cc21d55181c1760e7994f0225939f4999d |
|
15-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Use Objects from guava library.
Switch com.android.internal.util.Objects to com.google.common.base.Objects.
Bug: 6948882
Change-Id: I0adcff2e02e2dfbdfaa323ac72e0d42c1cbc979c
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 428f008513d1591cc08fcfe2cf0c9237fb313241 |
|
14-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move dependencies of AccountTypeManager into ContactsCommon.
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| ca87e9c598929b5b6a62da9b80d2114168e24274 |
|
06-Mar-2012 |
Daniel Lehmann <lehmannd@google.com> |
Added some smoother transitions to the editor
- Transition when removing a field
- Transition when pushing the "Add organization" button
- Transition for visibility of "Add xxx" when entering text
- Added pushed state on "Add organization" button
- Increased the height of "Add xxx" to match the expanded size for simple
Editors from 40dip to 48dip
Bug:6009430
Change-Id: Ia4524006b528f49d587c6277ecc98b11f77ddc0d
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 6ad4c72b65e752777ca9288b006f82eefa715b57 |
|
22-Nov-2011 |
Josh Gargus <jjosh@google.com> |
Hide "add field" button when it's unnecessary.
Modify RawContactEditorView to remove the "add field" button
when no more fields-types can be added, and replaces it if all
fields of a type are deleted. Adjust layout so that there is
still a margin even after the button is hidden.
Bug: 5104493
Change-Id: I50fb61ba9c5d212a1ceb67938d3d833aace987f1
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 50a27b70581b0191995969c63edd1f6a3db3d1b7 |
|
07-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Clean up account definition
Removed:
- DataKind.isList. Use typeOverallMax = 1 instead
- DataKind.textAppearanceResourceId. Always use medium
- EditField.isFullName. Wasn't used.
Bug 5381810
Change-Id: I5ff109c075a5edb80ff97737432c78589570a1ea
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 2ea2ebbd23320f09ed38bf22d053842cc244646c |
|
15-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Account header icon cut off in contact editor for local contacts
Bug: 5298440
Change-Id: I9dfe60ef1c2b81c96f9b785d734031839a62d758
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 3c6af944f1c2c64de3839809460b368b718a8f5a |
|
16-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Organization field should receive focus after selecting "Add organization"
- This is for the contact editor
Bug: 5159041
Change-Id: I75a2034df4c35a5414cbbe6785dc40b6faf21d15
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 2cb71bd0d6096f48d9d8c6d66a753b164468abb2 |
|
01-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix contact editor account header
Bug: 5179920 Google+ profile should say "My Google+ profile"
Reverted default account type name changes
Flipped account name and type usage that was wrong
Vertically aligned the headers.
Change-Id: Icc279fcba5d426d1afaf32b59bec30ed5d739907
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 681f36cc7cc49be781eedc4685eda2d1b2c0444c |
|
26-Aug-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix header when editing a profile
Bug: 5179920 Google+ profile should say "My Google+ profile"
Added a case to change the header name when editing a profile.
The editor now gets a boolean indicating if the contact edited is a profile.
If it is a profile, the editor sets the header with "My X profile" according
to the account name.
Change-Id: I62af5011061f61a6d1d3c60845a1746c99cda04a
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 1ebbd5bbe71814123b80df702b474bcd7196cbb7 |
|
05-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Pixel perfect for tablet contact editor
- Remove a bunch of files because now the tablet should
look like the phone layout
- Fix padding / margins
- Don't allow phonetic name to be deletable (it would
just clear the field) so that the structured name
and phonetic name now line up (UX decision)
- Make text in editable fields centered by
setting a specific height on the edit text field
if it's not multi-line text
Bug: 5096927
Change-Id: If5d27752d79680cd40316428c7aa9ec30af6e320
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| fd70903236883f47b21f23b8cb49a1ccacdfcdf1 |
|
02-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Pixel perfect work for phone contact editor
- Always show account header for raw contacts
- Align text fields and titles along the left margin
- Align spinners
- Use "Add new" as the default text if there's no value
in Event or Groups field yet
- Restyle account header
- Use primary/secondary colors everywhere
- Non-editable contact fixes: remove "not editable on
this device" and replace it with a toast when the
user clicks on the header, restyle item_read_only_field
Bug: 5097095
Change-Id: I94a6c91b05344028b64c62735fb4559f9944529d
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 6be61c5d351099f24904396e97d5954de7b771e1 |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Merge "Default fields in contact editor"
|
| 13cc7c59d540608a2f1c68be0a31a0560392e0ae |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Default fields in contact editor
- Remove website and notes as default fields that show when
you create a new contact
- Don't allow "Add another field" button to add fields for
sections that are already visible (i.e. if website section is
visible, then "website" won't show up in the popup menu)
- TODO: Handle the case where there are no more fields to
add, need mocks from UX
Change-Id: I3b0929ebf69c93b60220c75c0b00b72cf5b2aa83
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 3fa75acf99f5245eae00c77086ff130b3552ceec |
|
21-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Organization field expands when tapped
- In order to show as many fields as possible on the
contact editor, we collapse the editor into a button
that only expands the EditText fields when tapped
(collapsing is not possible unless the user exits
the editor).
- Add an isEmpty() method on the KindSectionView
so we can distinguish between a contact with existing
organization info versus a contact who has an empty
organization field
Change-Id: Iff818c30422c96d1acf6a03cbbcfb6f17bfed106
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| a94859f61c216d4e137a631995026d3ddefbbf70 |
|
20-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Contact editor fixes
- Bring back data kind titles
- "Delete" button should be invisible not gone
- Make field + spinner horizontally stacked instead of vertically
stacked on phone
- Don't show account header if editing an existing contact that
only consists of 1 raw contact
Change-Id: I7dd4bfdf273eeaccca8399d182c0a56a6e23a8c7
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| a7c3d4d726b91f645431af14d8cceadd2245f4ce |
|
15-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Restyle contact editor header
- Move account switcher to top of editor
- Make account header always displayed (even on existing contacts)
- Take out hack for font size of structured name and just
make it text appearance large
- Align photo side by side the structured name
- Move over honeycomb style of group membership item over to
phone resouces folder
- Center "Add another field" button on the phone
Change-Id: I548edc3f1a2a0c20e83e4a28a10e110e51f8c12c
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 769e5fed7af619d538da66adb926eeccdc159cd9 |
|
11-May-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
UI fix for account selector
- don't show account info when there's just one account
- modify layout for account selector
Bug: 4184675
Change-Id: I7e5a9527a2bcb2406a1bc377b063bb262b8f12de
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| d37a891cb44cd17083c06d7be693c469403d16df |
|
27-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Enable account switcher in contact creation
- remove account selection step before contact creation
- (phone) put account info on the right side of photos
instead of having "header" for it
-- renamed header_* ids for account stuffs as they may not be
part of header any more.
- add migration functionality to EntityModifier
- add test for it
- no optimal layout
Bug: 4184675
Change-Id: I0e777f9aa37a7c9145bd430f897f8068b0bede56
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| a2d4a9652fb4db9ee222abc7a637366c6c50427c |
|
07-May-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix font sizing and spacing in editor
- Remove name labels
- Remove extra divideres
Bug:4382255
Change-Id: I59c5b91e699b7386690e6df58e58b247d3086c99
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 405671a7b42d97ebf7ae7c0eeb4721f881139673 |
|
29-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move DataKind outside AccountTypes
Bug: 4184675
Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 5ec40b04041818bc042c0671cb1a43b54f650e25 |
|
02-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Modernizing phonetic name support
Bug: 3497894
Change-Id: I5aaa77275bbe1921af2d7ef034d2319691f8abf7
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| b18624f0cbca15e6a515316f7046ad814d54c970 |
|
22-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Changing horizontal dividers in contact editor.
Also, moving name editor up and changing
name editor font size.
Bug: 3378205
Change-Id: I3a0457d3e2e231fb58e4d46065ff8b4b692d5626
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 69f9e6f0cd9b5401da55f251e9bd98e69643d7df |
|
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming fields and variables from "source" to "accountType"
Change-Id: Ie41036e35a45fc7d9a8c934a3cbe68399c567ad6
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 02bb1252aa990813fa9e86ad75c458acc15e6801 |
|
06-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing progress dialog when saving a contact
Bug: 3253127
Change-Id: Ifd3b58f202fea76596880fb6de9f8acc46a32d79
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|
| 18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
|
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages
Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/editor/RawContactEditorView.java
|