| b8b86d1a272b313fd2b3ff9e324ce014f24aa44d |
|
08-Jan-2017 |
Wenyi Wang <wenyiw@google.com> |
Add loaders to DrawerFragment and make status bar transparent
- This CL addresses a TODO to load groups and filters from
DrawerFragment directly.
- Also, avoiding adding fragments to FragmentManager of a
Fragment works around a crash on LMP.
- Wrap RecyclerView with a FrameLayout to go full screen
with a ScrimDrawable
Bug: 34062530
Test: add and remove accounts and observe changes in side nav
Change-Id: I63943a9d596aa32301609d6ab1b9d49c0c784356
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 0a49afa2ad697307cc04ef4cb86570574fa720f2 |
|
06-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common package (2/2)
Ran optimize imports on the project as well to re-order everything
which would have changed because of removing common.
Test: Built GoogleContacts, GoogleContactsTests, Contacts,
ContactsTests and ran unit tests.
Bug: 33252370
Change-Id: I881f0ba8b8fef002b6eeefa9a16b34f15b2fd2a9
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 69c182afb0e6d82a341a28b4317aa703af768906 |
|
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 9970f301c1944c3d8155e1718ac34abbe8f69199 |
|
07-Nov-2016 |
Sean Midford <midfords@google.com> |
Changed picker to stay as long as chooser is shown
Changed behavior of the picker to remain visible behind
the viewer as long as the chooser is active. When the
chooser is dismissed or an option is selected the picker
will finish.
Test: Manual, verified that picker remains visible until
the chooser is acted upon.
Bug: 32413513
Change-Id: I520e25de19d2290b0e52ce2212856afd6e3ee06e
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 4b2ccd27dbb05d7cc1d340ce18182ccb2b9a3326 |
|
14-Oct-2016 |
Sean Midford <midfords@google.com> |
Item multi select now has defaults checked.
Added ability to send a list of ids to a
multi select picker to precheck defaults.
Defaults will preselect if the aggregate
contact has a single email/phone, or if
there is a super primary set for the contact.
Test: Verified all features are working as intended.
Picker now shows all contact methods for group/selection,
which fixes some strange selection behavior.
Bug: 31648014
Change-Id: I21ee4e79f8c1d08d41b4edcdef62aa5b2f2eb4b9
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| b460f44f6517f269bac35f339f57e603669f45d7 |
|
13-Oct-2016 |
Sean Midford <midfords@google.com> |
Added send button to group/selection picker.
Added send button for the picker fragments and
activity. All selected items will be added to
the send intent.
Test: Verified all features are working as intended.
Send button will only appear if at least one item is
selected
Bug: 31648014
Change-Id: Iaf51c9c750b4e824dfca455c2c3871fcbf4056cf
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| ff6f1bb6782fe92b8745ef4acb6c622fef3d0cbc |
|
12-Oct-2016 |
Sean Midford <midfords@google.com> |
Added group/selection email and sms sending.
Added options for user to send emails and sms texts to
all members of a group (or selection) at once. If there
are multiple emails/phones for a single contact, a picker
is displayed to specify which emails/phones to use.
Test: Verified all features are working as intended.
Menu options are only visible when relevant and edge
case of some or all users not having emails/phones
are handled by showing a toast to the user.
Bug: 31648014
Change-Id: I38066cf3be57bf205f7a3721d0064bb716e8a43f
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 5c1bff2efa542ea112c3f2a1d1ed1e271c7691a7 |
|
01-Oct-2016 |
Gary Mai <garymai@google.com> |
Load all groups data from editor
GroupMembershipView needs all group data to determine which group
is favorites/default, so when we load from the editor use the old
selection string.
Test:
Followed steps in bug and made sure the contact wasn't booted from
the My Contacts list, and the selected labels were updated properly.
Also tested adding multiple new labels and saving those.
Bug: 31750797
Change-Id: I84b1be6c17f2acf46efc202fb81a2c180cc2bcae
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 5a49696d7f82a395980ed918f3e86c93222734d4 |
|
10-Sep-2016 |
Walter Jang <wjang@google.com> |
Merge commit '428824eaca7ed60c14add0a1d45edfe4535059bb' into manual_merge_428824e
Change-Id: I049ee9066aaa7ccd29cd9efddc46850f7fa3f018
|
| 428824eaca7ed60c14add0a1d45edfe4535059bb |
|
09-Sep-2016 |
Walter Jang <wjang@google.com> |
Consolidate the two group metadata classes
* group.GroupMetadata is renamed to GroupMetaData
* The defaultGroup and favorites fields from
common.GroupMetaData are added to group.GroupMetaData.
Test: manual tests
- Add and edit a group
- Load quick contacts w/ and w/o groups
- Add invisible and directory contacts to default group
Change-Id: I7f53ae6e4409c414918ffc5615fb5e3bd25d116d
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 453a110b63aa3d7d9672a4f600db6733d75e51c1 |
|
09-Sep-2016 |
Walter Jang <wjang@google.com> |
Merge commit 'dd2d8e27d8548893122c469bd1b68d5117fc5318' into manual_merge_dd2d8e2
Change-Id: I438cc9613c527bd0ca14caa8a08dbff6a7c0aa9d
|
| dd2d8e27d8548893122c469bd1b68d5117fc5318 |
|
09-Sep-2016 |
Walter Jang <wjang@google.com> |
Rename GroupMemberPickerFragment rawContactsIds
... and all associated ARG and KEY constants to
contactsIds, since that's what it really is. Also
* Share the selection clause between GroupMetaDataLoader
and GroupListLoader -- we were inconsistent in filtering
out auto add and favorites groups.
* Remove unsued groups methods:
- GroupMemberPicker.Listener#onGroupMembersSelected
- GroupUtil#bindPhoto
* Remove some obsolete comments, fix some others
Test: Manually create and edit editable and read-only groups
Change-Id: I9607225d1a61f8673b7d1461149ae30e253c781d
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 3e05750864383d55157fc535981fc8568cda756e |
|
09-Sep-2016 |
TreeHugger Robot <treehugger-gerrit@google.com> |
Merge "Second pass on fragments navigation"
|
| cc8f272af38bd46710b8186424caf515215f2582 |
|
07-Sep-2016 |
Wenyi Wang <wenyiw@google.com> |
Second pass on fragments navigation
1. Fix some janky animation when opening or updating groups.
a. Use FragmentTransaction#replace instead of FragmentTransaction#add
so that mAllFragment will not appear before group members are loaded.
b. Change group URI and reuse existing group fragment to reload group
members, instead of popping old group fragment and adding new group
fragment, when user opens another group from a group view.
2. Fix an error in ContactsDrawerActivity#updateFilterMenu.
3. Move code to handle new Intent from PeopleActivity to group fragment.
4. Initialize ContactListFilterController in
DefaultContactBrowseListFragment#onCreate rather than onActivityCreated.
Because onActivityCreated will be called when fragment is removed and
added back, and we don't want to set filter again and again.
5. Fix a bug where activity title is not updated when nagivating from
account A --> group X --> account A.
6. Move all group actions from GroupUtil to ContactSaveService.
7. Other minor refactoring and cleanup.
Bug: 30944495
Test: manual - navigate between fragments, rotate, press Back/Home/Recent
button, search, multi-select, modify group members,
add/delete groups, view/edit/add groups from
ContactsTests.apk and when no contacts view is shown.
Change-Id: I27c89b4125e55b67921a37f2092fde839a9f8ed4
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| e472b50865ef5fef3ad6186e7f1f79c8c16b8d3e |
|
08-Sep-2016 |
John Shao <johnshao@google.com> |
Hide empty FFC groups for non Google accounts
am: f9dd12948a
Change-Id: I1852187bdfaa83f194cbf3162c21160e0429bf98
|
| f9dd12948a7844ddcf5edb8778d7edbf50dd0e82 |
|
08-Sep-2016 |
John Shao <johnshao@google.com> |
Hide empty FFC groups for non Google accounts
OEM devices are creating system FFC groups that are not
being hidden because of a check for Google account. Relaxing
that check to allow account account type label to be hidden
if its an empty FFC.
Bug:30575974
Change-Id: I85b312bfb6a6904cd2236d2ee5cbe07d9a724ee6
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 7967545e62b473503473b2c9e127cef405f67201 |
|
17-Aug-2016 |
Wenyi Wang <wenyiw@google.com> |
Open group fragment and duplicates fragment from PeopleActivity
* Also handle some side nav menu logic
Bug: 30944495
Test: manual - navigate between fragments, rotation, press Back/Home/Recent
button, search, multi-select, modify group members,
add/delete groups.
Change-Id: I4feeed89557a5c07852a1e2d2a39306cfa59c918
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| eb2f93a475203683fc0505e158460f71e6f514cd |
|
29-Aug-2016 |
Wenyi Wang <wenyiw@google.com> |
Fix intent to pick group members
Bug: 31148217
Bug: 30601104
Change-Id: If4a451ca5bbaa6ad986eb344a57e1edaaf58062c
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 3ab1178953480c7eaaeb9d9795ca4e72646474f6 |
|
22-Aug-2016 |
Walter Jang <wjang@google.com> |
resolve merge conflicts of 6bb8718 to master
Change-Id: I62258095e91ad4874e403e35142fbc1cedd1b120
|
| 6bb8718b04da174f3642fbdcefea0fee6086db3d |
|
22-Aug-2016 |
Walter Jang <wjang@google.com> |
Replace @NeededForTesting w/ proguard keep flags (1/2)
* Replace -keep of entire c.a.c.common package
with individual classes
* Remove all use of @NeededForTesting annotations
(and the file itself since @VisibleForTesting
accomplishes the same thing)
Test: Ran user build ContactsTests on Nexus 5 MOB30H
Bug: 30976481
Change-Id: I8d9a4d6b3409a159a108b39c1c4837a19e2325ca
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 6927bf35fa2d1b4261e25c46bcd4951cd7b3208a |
|
16-Aug-2016 |
Wenyi Wang <wenyiw@google.com> |
Let GroupMembersFragment control actionbar, menu and more.
* Create mActionBarAdapter from GroupMembersFragment and remove
mActionBarAdapter from GroupMembersActivity.
* Move creation of group-related menu to GroupMembersFragment.
* Move the following listeners to GroupMembersFragment:
- ActionBarAdapter.Listener
- MultiSelectContactsListFragment.OnCheckBoxListActionListener
* Move UpdateGroupMembersAsyncTask a new class.
* Remove mGroupMetadata from GroupMembersActivity and get it from
GroupMembersFragment instead.
* Remove GroupMembersListener, since the actions can be done within
GroupMembersFragment now.
Bug 30944495
Change-Id: Ie6a7c51afecdc67f953f185369f64f2192c46bc1
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 41c6886cabf68370f160ccd68d173bd6a59a1a07 |
|
18-Aug-2016 |
John Shao <johnshao@google.com> |
Force intents to start in app wherever possible
Add class/package names wherever possible for intents that are
started within the app itself. This is to avoid the intents picker
dialog that makes the user choose which app to handle the intent.
Bug: 30601104
Change-Id: I98d3a5a5c2112f1ba0c944b37c9b6754837dfa9c
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 2d97b5f89ae1ae1b5e782e40b82ba60f0588f964 |
|
11-Aug-2016 |
Marcus Hagerott <mhagerott@google.com> |
Allow creation of duplicates of empty system groups
Empty system groups are not shown in the nav drawer so showing an error that
they already exist when a user tries to create them is confusing.
Bug 28718604
Change-Id: I5f96ef862272cc35ad25ac028b785a4ecf07e6e7
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 1110d678aee0b1967898e83334a63df49a7e30f6 |
|
25-Jul-2016 |
Walter Jang <wjang@google.com> |
Revert "Revert "Handle group insert, view, and edit intents (1/2)""
This reverts commit 6bf9394371218adfc81123c236b81cdb6b855639.
Bug 29902305
Change-Id: I0e6f23a3ac4be8d7a6785aece0cfe0db37287308
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 6bf9394371218adfc81123c236b81cdb6b855639 |
|
25-Jul-2016 |
Walter Jang <wjang@google.com> |
Revert "Handle group insert, view, and edit intents (1/2)"
This reverts commit 01c2f7f2e324dbf7ce70229ecb29f9c33542be0e.
Change-Id: I161c7a2277979f281d7579894b8f64e918082e7f
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 01c2f7f2e324dbf7ce70229ecb29f9c33542be0e |
|
24-Jul-2016 |
Walter Jang <wjang@google.com> |
Handle group insert, view, and edit intents (1/2)
Bug 29902305
Change-Id: I59ddb4bf55cd28943f31aeaed6c2f3c0adba1403
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| d8effeb5adf3fc9d81e552c41450400eb86076c7 |
|
29-Jun-2016 |
yaolu <yaolu@google.com> |
Add empty view for empty groups
Bug 28982874
Change-Id: I757651e3fd2897d65609ab233722160e0b267b01
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 13710d5d60ad9edd3aae73db3551065160645aa8 |
|
08-Jul-2016 |
Walter Jang <wjang@google.com> |
Move add group dialogs to base drawer activity
Bug 29537664
Change-Id: I678a5a7dbcb28eb5860fdb90f43d0b440af684e8
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 5289a29b88f436e6061c49e90fea8266437714ab |
|
27-Jun-2016 |
Wenyi Wang <wenyiw@google.com> |
Merge src-N/ and src-pre-N/ and target API 24 (1/3)
Bug 29725318
Bug 29328819
Bug 29536552
Change-Id: I21854806fbf5c9a6e0fff3d12702bfaa96e04b26
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 8607705d53732bb046573697550d688855696335 |
|
30-Jun-2016 |
Wenyi Wang <wenyiw@google.com> |
Pass group name to group activity
Bug 29455543
Change-Id: I167b1232846d2d58312ef0ebba701e938d3ae275
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 38860a58d52eacbeb922412bbfc31905cdd8bdc1 |
|
25-Jun-2016 |
Wenyi Wang <wenyiw@google.com> |
Update section indexer in group member list
Fixes 29159876
Change-Id: I0fcb9435052d78fcc41de1f74594b6e49b68d7f6
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 9afaddec062bc1c9f3d7bb30992d70198fbe0840 |
|
17-Jun-2016 |
Wenyi Wang <wenyiw@google.com> |
Sort group metadata in a localized way
Bug 28936603
Bug 28946142
Change-Id: I1aa5a3bbcc9e53cfa67f5c12497eb95ff2114436
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 3fafbb29c949ba998af2104451859ed81b06f663 |
|
03-Jun-2016 |
Wenyi Wang <wenyiw@google.com> |
Sort groups across accounts and hide empty FFC groups
Bug 28426020
Bug 28946142
Change-Id: Ic56fe75ae3e29daf0c7c3cd4875edb14de0c590b
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 5dde93f6c73cfc3ac362bbc1641b216dfe2b1add |
|
26-May-2016 |
Walter Jang <wjang@google.com> |
Remove old groups browse, editor, and detail activities (1/3)
Bug 18641067
Change-Id: I51182dee9afa9c95f3ad0bffb5c6909a8ff37a95
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 72f9988a76fcc06e68b9ffa9fc9075b58fc7302f |
|
26-May-2016 |
Walter Jang <wjang@google.com> |
Address various groups TODOs and small bug fixes
* Style the group name edit dialog with standard min
width style. Also restrict names to be a single
line and add a hint to the EditText. Finally,
bring up the keyboard when the dialog is first created.
* Change the "edit" group menu option name to "rename",
remove the icon, and keep it under the overflow.
* Sort groups consistently on the main list and contact
editor spinnner.
* Don't load deleted groups. We don't need to handle
deleted groups in the members loader because the metadata
loader omits them in the selection clause.
* Show a toast after deleting a group. Also don't prompt
for confirmation when deleting if the group is empty.
* Remove some unnecessary header binding in the group member
list adapter.
Bug 28955365
Bug 28936603
Bug 18641067
Change-Id: Icec1e1d3bbafb7e1e94a7e841860836d256177f1
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 0680a31c87d083eca56ef6093de54bbb3b5c2d27 |
|
18-May-2016 |
Walter Jang <wjang@google.com> |
Incremental work on the group edit flow
* Extract group metadata class from members list fragment
* Move metadata loading up to the Activity so it can be
shared between the members list and editor fragments
* Move options menu creation in the members list fragment
up to the Activity and remove the obsolete members list
callbacks (also rename the members list callbacks
interface to "Listener" to match the rest of Contacts).
* Use a custom ViewPager that disabled swipes to move
between the members list and editor fragments (also added
a TODO to rename GroupMembersListActivity since it houses
the editor now too).
* Update the group editor fragment to have group metadata
passed in as an argument rather than loading it internally
since we need it for the group members list view and it's
already being loaded by the group members activity.
Bug 28707265
Bug 18641067
Change-Id: If662abd720533827e3e719fde4dd10cdfb1ba64e
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 46f9006c837b0fdc2794887e6b4c483f242e3e79 |
|
14-Apr-2016 |
Walter Jang <wjang@google.com> |
Load members count when members list is loaded
Instead of trying to pass it in.
Bug 18641067
Change-Id: I56c212b7b799185e638b0ad83931d1a934234a51
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 4715c04e95d59a06c90a9022eb80717e120f9f72 |
|
07-Apr-2016 |
Walter Jang <wjang@google.com> |
First pass on group members list activity
Still missing first letter index so we're
stilling using the legacy GroupDetailActivity.
Bug 18641067
Change-Id: Ia726460edbaaa28e4017f51b4e6e016c8c9010c7
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| cdbcd88e90e8e9283808ea57aa5d250227d02c97 |
|
03-Apr-2016 |
Walter Jang <wjang@google.com> |
Add a menu item to add new groups
Bug 18641067
Change-Id: I458f72a86cf02c0ed564c799dcf1a22880a429ba
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|
| 758f56580b973894213569b61b1ae23b293071c2 |
|
05-Apr-2016 |
Walter Jang <wjang@google.com> |
Add groups to the side navigation bar
Just launch the old group details Activity for now.
Bug 18641067
Change-Id: I213c88213240d5281edfeda1bc5da9180506520b
/packages/apps/Contacts/src/com/android/contacts/group/GroupUtil.java
|