History log of /packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
4b0c1c158c0dd6854ca10b09e7028faec9a7f398 04-Jan-2017 Walter Jang <wjang@google.com> Fix logging successful search events

Test: manually test that success and abandon
search events are logged to clearcut
Bug: 34080070

Change-Id: Ic699f707f9faa53351713ffbaaaeeff30a82b20f
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
0a49afa2ad697307cc04ef4cb86570574fa720f2 06-Dec-2016 Gary Mai <garymai@google.com> Collapse common package (2/2)

Ran optimize imports on the project as well to re-order everything
which would have changed because of removing common.

Test: Built GoogleContacts, GoogleContactsTests, Contacts,
ContactsTests and ran unit tests.

Bug: 33252370
Change-Id: I881f0ba8b8fef002b6eeefa9a16b34f15b2fd2a9
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
69c182afb0e6d82a341a28b4317aa703af768906 05-Dec-2016 Gary Mai <garymai@google.com> Collapse common packages (1/?)

Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.

Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.

Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
6c46e5b3b49e807e9806ae84186f64e0cf7d38c9 17-Nov-2016 Wenyi Wang <wenyiw@google.com> Make checkboxes not clickable

Bug: 30443581
Bug: 32950580

Test:
1. manually verified the following lists work well:
- all contacts / account view
- group view
- send-to view
- contact selection view (for adding contacts to group)
2. unit test

Change-Id: Ife4a31725ca31125c901ca9f9f1621422066342b
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
96fb8b5ec9e6917bdc07f3d52110e92e52b9d178 07-Nov-2016 Wenyi Wang <wenyiw@google.com> Show account name in label view if account is group writable

Bug: 32116555

Test: manual - verify account name shows up in labels of
an Exchange account and Google account.

Change-Id: I17fb2ce8538984660b439a4667261b19367fc3c4
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
7967545e62b473503473b2c9e127cef405f67201 17-Aug-2016 Wenyi Wang <wenyiw@google.com> Open group fragment and duplicates fragment from PeopleActivity

* Also handle some side nav menu logic

Bug: 30944495

Test: manual - navigate between fragments, rotation, press Back/Home/Recent
button, search, multi-select, modify group members,
add/delete groups.

Change-Id: I4feeed89557a5c07852a1e2d2a39306cfa59c918
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
6927bf35fa2d1b4261e25c46bcd4951cd7b3208a 16-Aug-2016 Wenyi Wang <wenyiw@google.com> Let GroupMembersFragment control actionbar, menu and more.

* Create mActionBarAdapter from GroupMembersFragment and remove
mActionBarAdapter from GroupMembersActivity.
* Move creation of group-related menu to GroupMembersFragment.
* Move the following listeners to GroupMembersFragment:
- ActionBarAdapter.Listener
- MultiSelectContactsListFragment.OnCheckBoxListActionListener
* Move UpdateGroupMembersAsyncTask a new class.
* Remove mGroupMetadata from GroupMembersActivity and get it from
GroupMembersFragment instead.
* Remove GroupMembersListener, since the actions can be done within
GroupMembersFragment now.

Bug 30944495

Change-Id: Ie6a7c51afecdc67f953f185369f64f2192c46bc1
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
141b837b5e8ad1509f9f3990b10048ba2c90b751 03-Aug-2016 Wenyi Wang <wenyiw@google.com> Set elevation when the first item is not completely visible

* This CL fixes a bug where elevation is not seen in group view when the
first item is not completely visible.
* The bug is only seen in group view and not in account view, because
there is a "search_header" in account view. The "search_header" is an
item in list view but is not a visible contact. So the first contact
in account view is actually the second item in the list view.

Bug 30358448

Change-Id: I04b9d7f54a154f8aea9515f376886abe13781df0
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
967cffda17f453721dc863992d1d2b3474c02fb6 02-Aug-2016 Gary Mai <garymai@google.com> Change initial load animation of main list

Make each row slide up and fade in

Bug: 30318643

Change-Id: Ie05352a92142cbfb15c942896abf8d479f4e915d
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
81067f503bca35b866663f737dd411c6372a33c1 27-Jul-2016 Wenyi Wang <wenyiw@google.com> Bring account view up to spec (E2)

* Use elevation instead of divider for list header
* Change icon size and margin programmatically.

Bug 30358448

Change-Id: Ib707c116c23ee39d43c265a5c26184d6944bedc0
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
20db985dea84a3ce30dd328e0ac2381b9cc050b7 19-Jul-2016 Wenyi Wang <wenyiw@google.com> [DO NOT MERGE] Contacts to display UI improvements (2/2)

* Make icon image view gone for custom filter

Bug 30198034

Change-Id: I4eaa9d8edf0b11ae8a5aa8e4b7d2e071a2accd9f
(cherry picked from commit b66f4ac0a441d7e020a12c398cb06151c1a8607d)
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
3d8803e4d597da33275b4a67271cb74fed2cdea8 18-Jul-2016 Wenyi Wang <wenyiw@google.com> Use different strings for list header

Bug 30189545

Change-Id: Iddcacad2af15b09083e7da1692ceaddb10db20e6
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
7cd9af38ceb0e6ab3a61f1068e87f18d6b628d9f 18-Jul-2016 Wenyi Wang <wenyiw@google.com> Avoid changing list view padding to zero

When we set top padding, we also set other paddings to zero,
which caused the layout of list view on tablets to be wrong.

Bug 30180750
Bug 29190106

Change-Id: Ief1519e20df403d83b0682081b0160144890383b
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
9294263258a44d6ee42ac1dba964eb3765d2f494 14-Jul-2016 Walter Jang <wjang@google.com> Restore the "Contacts to display" custom filter (1/3)

* Revert "Remove AccountFilterActivity and its usage (Contacts)"
This reverts commit 1fc8847aa6bef1b6ceb017870d3de90f5960757e.
* But we don't restore the changes to DefaultContactBrowseListFragment
since we won't be starting the "Contacts to display" filter
from an overflow menu option on PeopleActivity.
* In DrawerActivity and PeopleActivity, everywhere we check for
FITLER_TYPE_ALL_ACCOUNTS, we must also accept FILTER_TYPE_CUSTOM,
since either of those can be used for the default/main contacts
list again.

Bug 29185471

Change-Id: Ie77e8acb16980b9015bd1f1f4af9fb7a014f3c51
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
1114fde42037be1cf83c577bbbc9eaaa5cb46369 12-Jul-2016 Wenyi Wang <wenyiw@google.com> Show count of contacts in account and group view

* Change contact list item height from 64dp to 56dp per b/29831679.
* Move name view in contact list item up by 2dp, per UX.
* Change the top padding to 8dp per b/29831679.

* Show the header in: account view, group member view and group member
picker view.
* Set top padding for list view only when there's no account header.
* Change action bar title to "From <account>" in account view.
* Override onScrollListener to hide and show header divider.

Bug 29190106
Bug 29831679

Change-Id: I36a2083c91b6b052bf887a8e7c639085d2bf4691
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
2b943999c5f182d7bfc3e67976330d6a935bc1c7 21-May-2016 Wenyi Wang <wenyiw@google.com> Add list event clearcut logging (1/3)

- Update logging previous screen when QuickContact is opened.
- Log various list events.
- All actions are logged when finished.
- "Load" action is logged when load is finished and when account
filter is changed, so as to avoid unnecessary repeated logging.
- Some of the "/*...*/" comments are omitted if the variable
name is the same as the parameter name.

Bug 28718104

Change-Id: Ib59d8d40eb9e9d68b8ad418c1a83ffba1d7ef7de
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
e9ea4f0f04919348ac3ad9d3338bdeca12922485 10-May-2016 Walter Jang <wjang@google.com> Move MultiSelect classes up the list hierarchies (1/2)

And have the GroupMembersListFragment extend the
MultiSelectContactsListFragment

Bug 18641067

Change-Id: I6773c4da89c744af8301b65f822cda07a18010de
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
9c1fa5db2caafc1d9e6f8ea23309a84a2c450143 17-May-2016 Walter Jang <wjang@google.com> Make the MulitSelect contact ID column configurable

* So that the MultiSelectAdapter can support different kinds of contact
lists (e.g. aggregate contacts or raw contacts).
* Also move utility method to convert a MultiSelected contact IDs TreeSet
into an array to the MultiSelectAdapter class since more than just
the PeopleActivity will need to do it when there are more MulitSelect
lists.

Bug 18641067

Change-Id: I136137b3f7d3c7a7faa0f381eb66d9648a46cf5c
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
aad30f55ab3dc6c2e2085b4b6bae149132ce9e77 12-May-2016 Wenyi Wang <wenyiw@google.com> Hide favorties in account view and stop loading ME (1/2)

Bug 28494082
Bug 28499410

Change-Id: I44964e5fb46e8f3244586dab60b9779380ac167f
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
82c9033a8f17470a335dd85936479669b50e5877 25-Feb-2016 Walter Jang <wjang@google.com> Don't log search events when not in search mode

Bug 26697731

Change-Id: I482f1b8c18196b9f4b51bde9db3203f0f4f1fb87
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
9ff6a7caf65540c00e456e4d4a7354f8939ffd0c 06-Feb-2016 Walter Jang <wjang@google.com> Add factory to create overlays

Bug 26985491

Change-Id: I57ce006e75524ea5b986b6ae90ca1cfdc966fb4e
(cherry picked from commit a0ca04d565806f3fa12034fce057775a516af14d)
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
a84fe61b45522d3beeabdc6de9eaa05697df2281 14-Jan-2016 Walter Jang <wjang@google.com> Log when a search result is selected or search is abandoned (1/3)

* Populate a SearchState from the MultiSelectContactEntryListAdapter
to with information about the number of results and partitions
displayed to the user. If a selection was made, record additional
details.

Bug 26697731

Change-Id: I96de87ea1d297045421604ee0cd13c51c6c13dc4
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
19ea52b1cc84b76f3dff9bfe824291be8524bec1 04-Oct-2015 Wenyi Wang <wenyiw@google.com> Correct the way of avoiding crash

Bug: 24098561
Change-Id: I38374eaeef0d26b2f3b3963d0e36f77947463e41
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
e04ea602a62848757da4860d23716499f31b7dfe 04-Oct-2015 Wenyi Wang <wenyiw@google.com> Changes in comments

Bug: 24098561
Change-Id: Ib357d13a75f063d4aef7a2800a42b8ad3221807f
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
eeae887738d3e9b16a3942b758f4f1fd05b079ae 03-Oct-2015 Wenyi Wang <wenyiw@google.com> Enable Talkback for long clicking contacts

Bug: 24098561
Change-Id: I3630b739a6b618b8e4fd9f10c6a3c77896d02fff
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
80dfab3763247aa6bac989ac534dc874443be0d8 29-Jul-2015 Tingting Wang <tingtingw@google.com> Disable multi select for directory contacts on search.

BUG 22821481

Change-Id: Iff796f0bd6a2f5ae7ad986138c647d9ac8bc3ab1
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
8f8937f9b33d220a4ca4f17fc334ad21cdd6fe8a 05-Mar-2015 Brian Attwell <brianattwell@google.com> Tweaks requested for multi select

UX requested two tweaks:
1. Unchecking the last check box exits selection mode
2. Selection count should be inset 72dp

Bug: 19549465
Change-Id: Icae0109e54317463cf224e41fc851bff8a512c53
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
48cea17ce347d6ff9ab3a59b99ad63dde70ce9c3 03-Mar-2015 Brian Attwell <brianattwell@google.com> Don't allow entering selection from search mode

Bug: 19549465
Change-Id: Ie33a676f64e30e437ca712a24bab17830d4c7868
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
d2962a3bb669a381d31a586df3b906033a8fa571 02-Mar-2015 Brian Attwell <brianattwell@google.com> Batch deletion

Also: when re-opening the Activity from the launcher, clear the
mIsInSelectionMode variable in memory.

Bug: 19549465
Change-Id: If589983d3d84c9c18066da08f9879c22db1a75ed
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
c00112f667c70df6ce6791c799b11a477392e3af 03-Mar-2015 Brian Attwell <brianattwell@google.com> Show checkboxes for all entries except for Me

Bug: 19549465
Change-Id: I676baf82162e09904940f860fce4220f93857454
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java
20510ec0a26e7eeb7f3a321deb755e984445fe74 28-Feb-2015 Brian Attwell <brianattwell@google.com> Multi-select to share Part 2

UI work to supprot multi-select. Long pressing starts selection mode.
For now, you can only share the contacts that you have selected.

Manual tests:
* Starting selection mode
* starting selection mode by long pressing the Me Profile
* RTL layout
* rotation in search mode
* rotation in selection mode
* typing on keyboard while in selection mode:
$ adb shell input keyboard text 'this%sis%san%sexample' (should do nothing)
* press search key while in selection mode:
$ adb shell input keyevent 84 (should do nothing)
* sharing contacts via multi selection

Bug: 19549465
Change-Id: If438bddfaaee1f69e4c888716f926abcd00ddbc6
/packages/apps/Contacts/src/com/android/contacts/list/MultiSelectContactsListFragment.java