| 107cd7a225eccad56dfe12ca6d32908e651b27ac |
|
22-Dec-2016 |
Marcus Hagerott <mhagerott@google.com> |
Replace getAccounts method with blockForWritableAccounts
This makes it more explicit that the method may block and should be
avoided.
Test: ran GoogleContactsTests
Bug 33627801
Change-Id: Idaffc3f0f6c986e21701f661d46b39ee8cbcc0a1
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 0a49afa2ad697307cc04ef4cb86570574fa720f2 |
|
06-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common package (2/2)
Ran optimize imports on the project as well to re-order everything
which would have changed because of removing common.
Test: Built GoogleContacts, GoogleContactsTests, Contacts,
ContactsTests and ran unit tests.
Bug: 33252370
Change-Id: I881f0ba8b8fef002b6eeefa9a16b34f15b2fd2a9
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 3f6a2444e0134b7380cdb2e13abf4bf1163336d0 |
|
05-Dec-2016 |
Arthur Wang <wuwang@google.com> |
Collapse res-aosp and res-icons into res folder for AOSP Contacts (1/2)
bug:31022536
Change-Id: I0434710d92027e59ccd97e27ebd09f1668346684
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 69c182afb0e6d82a341a28b4317aa703af768906 |
|
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| e98d54ede8201d441125d4bbb2851952c4272d10 |
|
04-Dec-2012 |
Chiao Cheng <chiaocheng@google.com> |
Moving vcard UI to ContactsCommon.
Moving all class in vcard directory in preparation to move
ImportExportDialogFragment.
Bug: 6993891
Change-Id: I5a321892f86f788e874cd6ca0d29f3136645b495
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| afb0bd11db79ba07921fa0685fb885861bc907fe |
|
03-Dec-2012 |
Yorke Lee <yorkelee@google.com> |
Fix forced portrait mode in ImportVCardActivity
Bug: 6154958
Change-Id: Ie7044861aa3b1aa979a6a6d49b7b18731f7c074f
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 0d5588da244d0992c3ff8f25d0875fdf95a8c644 |
|
27-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move AccountTypeManager to ContactsCommon.
Moving AccountTypeManager to ContactsCommon so it can be shared by Contacts
and Dialer.
Bug: 6993891
Change-Id: I9526ac7cda758290caecabfcaebe620238d8dd6b
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 428f008513d1591cc08fcfe2cf0c9237fb313241 |
|
14-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Move dependencies of AccountTypeManager into ContactsCommon.
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 9dabdc8161d1658de80065b865eab3b279bba8c6 |
|
15-Sep-2012 |
Yorke Lee <yorkelee@google.com> |
Fix BadTokenException crash by ImportVCardActivity
Make sure ImportVCardActivity isn't currently in the process
of finishing so that a dialog isn't spawned when it is not running.
Bug: 6899053
Change-Id: I0b5dc797c5ce37518b239b18cfea266401981820
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 7cdbe5c0b11acb6128974f593b4ede86b01f95b2 |
|
22-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Remove titles in simple confirmation dialogs
Bug: 5476234
Change-Id: I7970c3378860e3521b55d248968a4710d8161c04
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 3fa53400cebd5973a49457e1c643e82d7df9a9c0 |
|
12-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use OpenableColumns.DISPLAY_NAME for import message
Previously we've used the last path segment of a given URI,
which may not be correct. DISPLAY_NAME will be more appropriate
especially when vCard view intent is sent from the other apps.
Note that a display name can be available only when the external
apps support OPENABLE category, while we are using DEFAULT category
for VIEW vCard intent. In the future we should change the category
too, but for now this change leaves it as is.
TESTED:
- import from SDCard
- import from Email apps
- import via BT contact share
Bug: 5287116
Change-Id: Iad572eb48b6756246b15d992a8d4231a1b4cb31d
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 6e99c39b45d87c84a64a201efcde5fc5e6b4bb61 |
|
26-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Stop showing dialog when the Activity is already gone
Actually showDialog() is deprecated method and this whole
Activity should be rewritten using DialogFragment. This is
just for preventing unnecessary crash during automated testing
Bug: 5166487
Change-Id: I94fcabf1b916d86cdc9333f337b43dafacae4f72
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 1167da421b68952a590b050c32def7e0eff7cca6 |
|
03-Aug-2011 |
Jeff Hamilton <jham@android.com> |
Move the notification logic out to a listener
so there can be an Activity based version
of the listener as well for NFC VCARD imports.
Removed the now unused showImmediatley from
ImportRequest.
Change-Id: I37292676239444516bcc11486fc53e69b869dfa6
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| e967f7cb12e02f7c852670c315a284aed1310dc1 |
|
30-Jun-2011 |
Jeff Hamilton <jham@android.com> |
Allow importing vcards directly from NFC.
There is no longer a need for a content provider
to hold the vcard data, it is processed directly
from the inbound NFC intent.
Upon successful import the contact is opened.
Change-Id: Ib49305d36d2448097af60206eab49133ebca655f
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 53d4b8eef85ccdc2e750a36307492c97cfbb225c |
|
01-Jul-2011 |
Flavio Lerda <flerda@google.com> |
Uses a tag for vCard-related notifications.
Currently, we are adding notifications for vCard events using an
identifier. However, these identifiers need to be unique within the
application, which is not easy in this case since an unbounded number of
identifier can be used (i.e., they are based on the job id of the vCard
being imported).
Instead, add a tag to the notification, so that notifications for vCard
cannot conflict (and replace) notifications coming from somewhere else
in the application.
Change-Id: Ia544fc4e11c43799222c30cece9330478208fd46
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 6d42e4933d42fc2805f921adf3a5e65d64e16238 |
|
07-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Make multi import one request
VCardService may exit after processing the first request for
multiple imports, in which the user may see strange "rejected"
messages. We should pack those multiple import into one message,
which forces VCardService to process after all the requests.
Bug: 4540627
Change-Id: I4d645eb3a04e35da465b0c4181cbff5bf7ebf029
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 0e38be03c78137194d4bc9d3df8b7c2a63f72d69 |
|
01-Apr-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Remove dependency toward VCardInterpreterCollection.
It is now deprecated.
Bug: 4066223
Change-Id: I699de45b6ba035a518b3f63ba6197b514a459b87
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 4292dfa46123a6c0e1de9862b4d8694bfb87875a |
|
23-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing alert dialog icon.
Also fixing selector in the contact editor.
Bug: 3377396
Change-Id: I34ca2e419158fe7869ffda4679ea60fa3c5fdb00
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| ddf4270c7c09562dc4eff6f66940ceb89ac8995f |
|
10-Jan-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show Notification when parsing vCard failed.
Bug: 3330767
Change-Id: Ide850c72a49deef50b8ab547abb33ff8738adc22
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 179c9960e50019608d91661cfbcbb3cc8bc48093 |
|
10-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing NPE in ImportVCardActivity
Change-Id: I29312bede3f02dc5849ec7bdd75d4fc9ac88c91c
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| a07fa5f37031e4c5cd2933de02d2db41ec153e2b |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming AccountTypes to AccountTypeManager.
The intent is to turn it into a "system service" of sorts.
Change-Id: I047d70a2e59978c05916965ef0c0d9f18abc55e6
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 69f9e6f0cd9b5401da55f251e9bd98e69643d7df |
|
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming fields and variables from "source" to "accountType"
Change-Id: Ie41036e35a45fc7d9a8c934a3cbe68399c567ad6
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 783a09a8770f4322a45cee456adefbbc71218ece |
|
22-Nov-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix bugs around vCard export and use new APIs
1) let vCard exporter select correct destination.
Multiple vCard exports don't select different destination:
if users request "export", "import" and "export", they will have
just one exported vCard with imported data, not two (one without
import result and another with the result). This is because
each vCard exporter independently refers to existing files in USB
storage.
This changes make vCard service check available files and remember
file names already reserved.
2) use new Notification.Builder API
3) show user-friendly message when there's no vCard on USB storage
Bug: 3219880
Bug: 3219906
Change-Id: I159d25439023eb10934729a00f4da6d157e44b09
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| ab59660a17e896593f2a07c2e1191c2c23e3e353 |
|
19-Nov-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Allow users to cancel each import/export.
- add cancel capability for vCard export.
- use jobId for Notification id, so that users can cancel each
vCard import/export request.
Note:
As for Notification id, it may conflict with each other when
VCardService is shutdown.
Minor changes:
- add file name to each notification: users can see "xxx.vcf
is successfully imported" instead of "vcard is successfully
imported"
- rename mCancelled to mCanceled. strings.xml has "canceled",
so inconsistent inside the app. Ignore the inconsistency
between the spell in the app and Future#isCancelled().
Bug: 3215008
Change-Id: I7532e3d1b35a8bbeb694e47077554e36190482ed
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 7c819a1a434e02c54f6d216aa3b1a0d08cc93f50 |
|
09-Nov-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Rewrite vCard importer/exporter.
- stop using ServiceConnection inside ImportProcessor/ExportProcessor.
Just using methods in VCardService would be much less complicated.
- make VCardService responsible for concurrent import/export requests.
Previously ImportProcessor/ExportProcessor were responsible for them,
which made the code unnecessary complex.
- use Java concurrent library instead of manually managing requests.
- remove immature test. We need to rewrite it in the future.
- add logs.
Bug: 3064531
Bug: 3188526
Change-Id: I2565d91fb7557d786df42da4b8755cd5311434b9
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| aba4353bcf77ba91463cfd079feec3b6c6f59c5c |
|
03-Nov-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix vCard importer flow.
- call startService() before bindService() to suppress connection
leakage
- make cancel operation work properly
- take care of cache files appropriately
- add useful logs
- show Toast every time when import started
Note: I still see some connection leakage in ImportVCardActivity.
Bug: 3150402
Bug: 3159855
Change-Id: Iaec6d4e5d8ebcda84e2df5571f87bd3c59e5b264
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| a9ba485ac82e8b5170f2b264a27f2dc0a6d18dec |
|
03-Nov-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Change the code around vCard import + Service.
Bug: 3150402
Change-Id: I8f51478b2449800b71932f8bbf8c99bf864baf02
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 74d59da9b04bdb913ee0a13a7c938e02f2c49d50 |
|
28-Oct-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix broken behavior around ImportVCardActivity.
The Activity doesn't work when called from Activities outside
the app context (e.g. opening vCard file as an Email attachment).
I808129cf uses onStop() to detect screen orientation, which is
just wrong.
Bug: 3140101
Change-Id: Id4a67d4f1c4a763fdaca38f5301e6d661a5096b3
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 35769b804fbfd5a1fc0b2c36cd0a786d662c4334 |
|
19-Oct-2010 |
Daniel Lehmann <lehmannd@google.com> |
Renamed Sources to AccountTypes
Change-Id: I088c7d9cd66fd4d38e93bc97a6644247f72037ef
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 4ba6c0fe0b581aa15c2b9d7a97be0a5f5449e7ea |
|
08-Oct-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Add a variable detecting illegal unbinding.
Change-Id: Ib7faba494cd04a01f5a32ac97364d5cadaae3245
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 18b5190d6ed37be04d153a5d6f205076b38ac479 |
|
19-Aug-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Add Cancel capability toward vCard import procedure.
Bug: 2801638
Change-Id: Ia563fa4aed48ad01a6fbb29b350a35c46b7085a3
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| e8b5775b19129033a72991982e2d89ce9907061a |
|
18-Aug-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Make vCard importer ignore secure directory.
Make vCard importer call finish() at appropriate timing.
Change-Id: Idd1a6df7ca3de3d038d763d5a45b06927aafbd19
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 69f09d7c7a2ecfde5031ffd17c526ddade95f81f |
|
24-Jun-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Make ImportVCardActivity tolerate screen orientation during caching
vCard to be imported.
Bug: 2450447
Change-Id: Iaa24209f920a257b8d9289ae358f8d8b9b33ba73
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| b73b880e35221d994c1dd739268741baeabe3f9c |
|
22-Jun-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Notification fix 2.
Bug: 2733143
Change-Id: I369ca66f4fdb4d29fb20b8d8c451e6f1cf1e5f22
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| d8fb81a0024d30c027ea6ebf57d29d3ff10453fb |
|
09-Jun-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Refactoring vCard importer/exporter.
Rename ImportVCardService to VCardService and make it responsible for all the import/export works.
The service itself asks ImportProcessor/ExportProcessor to handle each request.
This implementation seems much more easier to be tested than the previous ones.
Bug: 2733143
Change-Id: I7b7d391e4ba294f74c8bbcdfb053368b61b498ca
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|
| 1b918e58f4a3ae8d32af83f6f69bbf2de57a94f9 |
|
08-Jun-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move vCard related codes to com.android.contacts.vcard.
Bug: 2733143
Change-Id: I35ddb7473a78131b21311e16583390f5f799c195
/packages/apps/Contacts/src/com/android/contacts/vcard/ImportVCardActivity.java
|