| 69c182afb0e6d82a341a28b4317aa703af768906 |
|
05-Dec-2016 |
Gary Mai <garymai@google.com> |
Collapse common packages (1/?)
Move the majority of packages out of common. When trying to move
common.activity to activities every file switched from a rename to
separated deletes and adds. Will move tests and the rest of common
in a separate CL.
Test: Built GoogleContacts, Contacts, GoogleContactsTests,
ContactsTests.
Bug: 33252370
Change-Id: I9ffb20038dee255ef5f83002b7870265771b08c5
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| a0233a048858f1593ea4924e9c5036f39aedbcdd |
|
02-Nov-2012 |
Chiao Cheng <chiaocheng@google.com> |
Moving ContactListItemView and dependent classes.
Further clean-up of PhoneFavoriteFragment in Dialer app to move all necessary
dependencies into Contacts Common package.
Bug: 6993891
Change-Id: I3dfce84ad01932450dc09588c22903e7307d7da0
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| c8dd78c595cfaf9766e59a2df012b16d6c05b213 |
|
31-Oct-2012 |
Chiao Cheng <chiaocheng@google.com> |
Moving dependencies of PhoneFavoriteFragment.
Move common classes from Contacts to Contacts Common.
Bug: 6993891
Change-Id: Icff2a57875c47a5141842ca3ab980cfc76931cb6
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| 5c3603deaf07b00d842606479da8a77c747612d0 |
|
22-Oct-2012 |
Chiao Cheng <chiaocheng@google.com> |
Fixing unit test to not rely on html markup.
These unit tests broke due to a change in the framework Html class and markup.
https://googleplex-android-review.googlesource.com/#/c/236067/
Since the unit tests have nothing to do with html, it is better to
change the unit tests so they do not rely on the html markup.
Bug: 7352945
Change-Id: I3340575c08687fe481e91b3897037960911b1bbb
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| a2180f32d3c5d6842c421adb5aa2f85c69caccfb |
|
18-Aug-2012 |
Chiao Cheng <chiaocheng@google.com> |
Initial removal of dialer features.
- Moved main activities and classes out including all necessary dependencies
for a first working version.
- There are still dialer dependencies in contacts after this check-in. Further
separation coming.
Bug: 6993891
Change-Id: I1761b554fe5daf29acddbb43532f571191db2eaf
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| c78606d21aed268a48e177d3ae81d06c97d04638 |
|
26-Jun-2012 |
Makoto Onuki <omakoto@google.com> |
Fix test
Update the snippet color code.
Change-Id: I2f8912016f236e01a5d1eed6417d247892daf4eb
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| ed90ea54323f212d87b27b04d7d627192afa6665 |
|
31-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Stop using DisplayNameFormatter and reduce a query column
setDisplayName()'s 3rd param "highlightingEnabled" never becomes
true in the current implementation and thus using the entire class
seems less meaningful. After removing the formatter class, we can be
sure one of primary and alternative name column won't be needed and
can be conditionally removed.
Per the observation above, this change removes the column for Phone
UI. Note that this does *not* optimize People side yet, since it has
quite different and more complicated configuration there.
Other fixes:
- replace getMarqueeText() with setMarqueeText(), since the former
implicitly requires unconditional "new String()", while the latter
doesn't.
- Use SpannableString instead of SpannableStringBuilder. Our prefix
highlighter is already using SpannableString, and we can expect
less GC by using exactly same classes for constructing spanned
CharSequence.
- Group query constants like I5ad0876ce469fbf86334e3f77b15cd240d9f761b
for cleaning our code and make it more consistent.
-- Legacy adapters aren't modified since they are legacy anyway. We
probably don't want to touch those files as much as possible.
TESTED:
- Phone UI and People UI work with display/sort order changes
- "(No name)" is shown correctly (mUnknownNameText is working)
- Prefix highlighting works correctly (in search screens)
- Pickers work with sort order change (primary/alternative)
- no performance regression at least (no visible performance improve
will occur)
Bug: 5550672
Change-Id: Ie69b74bbabcc7211cf2b107c93980172da2d744e
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| e86b753ca40e1db03f97f82ba218b7c236584acb |
|
08-Sep-2011 |
Hugo Hudson <hugohudson@google.com> |
Fixing up the tests.
- Recent change b35ab01 changed the prefix highlight colour but didn't
update the test. This fixes the test.
- ContactUtils.areObjectsEqual() method is no longer in use, so was being
removed by Proguard, causing the test to fail. The method may be useful
in the future, annotated it with @NeededForTesting.
- Some setTextWithHighlightingFactory... methods in both
DisplayNameFormatter and ContactListItemView were not being used any
longer, only by the unit tests that tested them. Proguard was therefore
removing them, causing the tests to fail.
Change-Id: I8e52a6d4dc7eac398777897b38cad4ef44d4fa7d
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| cea3c9146a81959d0317b5dba13ac909a226ce7a |
|
25-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Fix tests that require the screen to be on.
Acquire the wake lock as the tests needs the screen to be on.
Previously the test blocked until I pressed the power button on the
device, unless the device was already on or set to keep the screen on
while plugged in.
Change-Id: I61ccbcc1b18bb954128c832b67efddd23dae5f08
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| be15e0997ff7559d1c58abfcf45bcb1332dfc5eb |
|
10-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Partial fix for tests.
Change Ia0eb5bdd33c5bcebcf6267ce01f7d36c53396c30 added a new field to
the CallLogQuery: add it in the tests as well.
Change I45615616e03a603759888d9e7169a853b3328b14 added a new field to
ContactLoader: add it in the tests as well.
Change Ife8d494c19e2daef7e59d819ded52638dc9f2b6f removed bold first
names: remove from the tests the checks for bold in the names.
This helps getting further, but it does not actually fix all the tests.
The other errors might need a bit more investigation.
In the meanwhile this should not hurt.
Change-Id: Ib116b9a24002f1ee05b9246cbe985302b88a955b
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| 1acc0769aadb341950d3b08fb5bfc0fe3aaaf637 |
|
06-Jun-2011 |
Flavio Lerda <flerda@google.com> |
Use PeopleActivity for running tests.
The ContactListItemViewTests need an activity to run in. I had initially
chosen DialtactsActivity, but that does not work on the tablet.
Since what is really matters is that this is an activity defining the
proper style, PeopleActivity works just fine.
Change-Id: I198a284d5a41904cccfea3a5e67ab49a37975e90
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| c9a9cdb5741e5e3190063f7744db7e332f63ec72 |
|
03-Jun-2011 |
Flavio Lerda <flerda@google.com> |
Fixes highlighting of prefix.
Highlighting of a prefix (from a search) in contacts name was not done
correctly when the name was also set to be in bold. This commit changes
the logic to separate the two aspects and combines them in a way that
makes things easier to use.
Change-Id: Ibdf12d8478b7ab44ca0be82353c43ed9118d29cd
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| aade99aa5553fdb6ebdcca8a6275b1eba69a4958 |
|
03-Jun-2011 |
Flavio Lerda <flerda@google.com> |
Mark test as large.
Since it uses ActivityInstrumentationTestCase2, this is a large test as
it requires to start the entire activity.
Change-Id: I6ea38b9b8e41f2289e44416e6371c44ac6b8ead6
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|
| 3d7311f76f3f41a5794b01536498c634b3ff2a69 |
|
01-Jun-2011 |
Flavio Lerda <flerda@google.com> |
Extract a couple of utility classes for formatting.
The PrefixHighlighter class handles highlighting of a prefix in a text
view.
The DisplayNameFormatter handles both the bold of the first name and the
highlight needed when searching (using the PrefixHighlighter above).
Change-Id: Ibd1d3ecd6a88ce40de6dbc591af21c1e7260511e
/packages/apps/Contacts/tests/src/com/android/contacts/list/ContactListItemViewTest.java
|