History log of /packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
84b60fe3a95f07ee793d880ca754389159b4929e 12-Dec-2016 James Lemieux <jplemieux@google.com> Avoid setting default home timezone to an illegal value

Bug: 33418631
Test: Flash device. Open Clock. Verify the home timezone is absent.

Adjusting the default home timezone via Settings presents a subset
of all available TimeZones. After a fresh install of Android, it is possible
for Clock to launch before setup wizard completes and the timezone
of the device becomes known. In these cases, attempts to write an
illegal TimeZone (absent from the set of TimeZones to choose from in
Settings) may occur. These attempts are now ignored.

Change-Id: I0e9db67f2fc3250487d11899a36aa867f894a0b5
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
ef0635176bcfc9b64f8790c487f63ee81433d295 15-Nov-2016 Christine Franks <christyfranks@google.com> Improve settings dialogs appearance

Bug: 32173467
Test: manual - grays are consistent throughout app, and on KK the
dialogs are material rather than holo.

Change-Id: Idd9ff8dc658441b77bc7b80f0efa8cf2c7764c83
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
029e7169cf17fff470caa91ba59c2b49edc352ce 15-Nov-2016 James Lemieux <jplemieux@google.com> Avoid exceptions when clicks perform fragment transactions

Bug: 32881255
Test: Manual testing of label/alarm time dialogs

It is possible when clicks are handled that the parent activity has been
destroyed and with it the fragment manager. Attempting to commit
fragment transactions on a destroyed fragment manager will cause
exceptions. If FragmentManager.isDestroyed() returns true, the click
logic is now effectively ignored.

Change-Id: Ia12fbd98c0c895ca5dabb1ca451dec7efa7410e0
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
baed4fe9b41db74d9c428a377a630ee2010d5126 10-Nov-2016 James Lemieux <jplemieux@google.com> Support no selection in ringtone picker

Bug: 32703296

If the picker is created with an initial selection that is absent
in the list of options, clear the selection and avoid altering the
ringtone unless the user explicitly selects a new one.

Change-Id: If86f04bfa8777039412c1e1767bbaa252f93ac30
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
33781c882e4229f4ec1a8fafbabb9d4b8b8e2932 14-Oct-2016 James Lemieux <jplemieux@google.com> Implementing fullscreen ringtone picker

Bug: 27856432

Ringtone picker now looks more like the rest of the app. Also allows
the user to pick a file chosen from their file system using the built-in
file browser.

Change-Id: I8ce9dbc28e414d188f52b3885960a475a16061d8
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
7b852b43db6d9e50814dd07366b025b3f9f9b758 08-Sep-2016 Christine Franks <christyfranks@google.com> Add seconds option for main clock

Bug: 18594326
Test: Manual - go to settings, toggle setting for displaying seconds,
toggle between analog and digital clocks and toggle display seconds
setting again. Close the app and reopen to test persistence of setting.
On upgrade from old version, current defaults are respected.
Change-Id: I21391929e59f5e8ada77efe446acbc13145478ee
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
c2cb7cc412cdb7b090dc07842d45de8a584483cd 13-Oct-2016 Sean Stout <sstout@google.com> Converting some preferences to simple menus.

Bug: 18470452
Test: manual - Confirm preferences work as expected

Changed the following preferences to use simple menus:
- Style (Digital or Analog)
- Volume buttons (Snooze, Dismiss, Do nothing)
- Start week on (Saturday, Sunday, Monday)

Change-Id: Iccfd144673e8f19ad34e015c64f0ed2946c61343
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
8fde4f2491a534a48f74eb79ff996bb86f4756d1 30-Sep-2016 Sean Stout <sstout@google.com> Use ListPreference for Gradually increase volume and snooze.

Bug: 26442008
Test: Manually make sure preferences work
Change-Id: I2748e502fdc665d797ab1d9c4f47dd99904cbc5e
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
4024d6160e3981a4c0effdb91a1025502f915d10 16-Aug-2016 Sean Stout <sstout@google.com> Only show timer vibrate option if device is capable of vibrating.

Bug: 30879827
Change-Id: Ib28dd9e1afa1627462407bb62401b690a2aca28c
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
ff17acface9b98eba868fff0e2d70ddc85c5e4db 31-Jul-2016 James Lemieux <jplemieux@google.com> Replace DaysOfWeek with Weekdays

Bug: 27915335

Weekdays is designed to be immutable, as are all other data model objects.

Change-Id: I9a12bdb17e439dbe79b735e9ed7e04940ea93048
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
458aa8b4ebb8b7c6fdc0680a1b687ea21a61bf35 28-Jul-2016 James Lemieux <jplemieux@google.com> Create FormattedStringsModel, a delegate of UiDataModel

FormattedStringsModel now builds and caches locale-specific Strings
including numbers and days of the week.

UtilsTest was removed because it does not execute correctly under
robolectric (because of its dependency on ICU).

Change-Id: Ife4611e1e8988c61f5eda88fddec59983f2ab6bc
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
b7b5e6f2b203ac9df5d8fa748f6aafd160270f9b 21-May-2016 Justin Klaassen <justinklaassen@google.com> resolve merge conflicts of 270e0e3 to ub-deskclock-fantasy

Change-Id: I46701d5f4b60b3856f77ffde5c2ef588ea9f7245
270e0e33f661dc7a726b0c64d4227a54d3068946 20-May-2016 Justin Klaassen <justinklaassen@google.com> Material Settings on pre-M devices

Bug: 28848704
Bug: 28870690

- Fixed a crash caused by using getChildFragmentManager() in
PrefsFragment.
- Fixed an issue where the timer ringtone summary would not update
immediately.
- Fixed an issue where the back button would remove the PrefsFragment
instead of closing the SettingsActivity.

Change-Id: I1a82010b975fe159dd40d96fafbdea4a3bb86183
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
272cba265101a33e7cd0586fc1f2a7f5d70666d9 19-May-2016 Justin Klaassen <justinklaassen@google.com> Custom ringtone picker v2
am: b2e7e16232

* commit 'b2e7e162327b1992aa74721a8847c7f7a579e049':
Custom ringtone picker v2

Change-Id: I9327bab257156ccfc80c7ca369c9536068076493
b2e7e162327b1992aa74721a8847c7f7a579e049 18-May-2016 Justin Klaassen <justinklaassen@google.com> Custom ringtone picker v2

Bug: 28667387

- Request the READ_EXTERNAL_STORAGE permission if it isn't already
granted when launching the ringtone picker. This allows the listing
of external ringtones stored in the alarms/ folder.
- Allow the volume rockers to control the alarm stream volume while the
ringtone picker is showing.
- Load the RingtoneManager's cursor off the main thread to prevent
potential ANRs and jank.
- Use Theme.AppCompat.Dialog to more closely match the styling of the
platform version.
- Disable the "OK" button if the selection is invalid.

Change-Id: I1ec6b0b744a3a19b3f289e33c24db982543862bc
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
f66b6c3138165945e32655bd6298f05b360e828b 31-Mar-2016 Justin Klaassen <justinklaassen@google.com> Use PreferenceManager#setStorageDeviceProtected()

Bug: 27767396
Change-Id: I69fae2dfc57cb328e3ad910d0ee4e53e3700ae36
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
59a110ba7df2699b50328520a2b400bc74965915 22-Mar-2016 Justin Klaassen <justinklaassen@google.com> Refactor MenuItemControllers

Bug: 27484313

Resolves an issue where lazy initialization of the menu would sometimes
result in incorrectly inferred text alignment.

Change-Id: I3f9d7395175544d7301a225272ba31f3d94cacdb
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
6f9fdf4610f22ee6b592d1c60410c68193a0790d 22-Mar-2016 Justin Klaassen <justinklaassen@google.com> Use updated FBE APIs

Bug: 27767396
Change-Id: I96783b19c258d32e9b1324b8bcba939053a31553
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
4e7ee09e878178873241846757b178535da3dd76 02-Feb-2016 James Lemieux <jplemieux@google.com> Add drop shadows beneath the app bars

Bug: 26014484

Activities that gained drop shadows:
- DeskClock
- SettingsActivity
- CitySelectionActivity

Note: the drop shadows are drawn manually rather than using
elevation in order to be backward compatible to KK.

Change-Id: I0b1b95b594f80a60dd6696f149451611c34af354
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
09c1f0e96743fcde110ecd1160ab55cdfaec12c0 20-Jan-2016 Annie Chin <afchin@google.com> Add timer vibrate option.

Bug: 23980150

User can en/disable vibration for all timers from the Settings page.
Vibration is off by default.

Change-Id: I0ae81583c73e54f44fca6262359ed2d46aaba498
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
8737d037a77f0ae1ffc144e5289904efda14c9f2 21-Dec-2015 Justin Klaassen <justinklaassen@google.com> Remove unused 'Help' menu item

Bug: 26291852
Change-Id: I2bb1641d6df698d87d85046dad20ce0f9906a3f8
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
1daf1d26e883c225b26ceed5ff50a6a856b97cce 08-Dec-2015 Dylan Phan <lerp@google.com> Make volume rocker change ringer volume instead of alarm

Bug: 23727258
Change-Id: I744ce0aed5c0d63563860d61c9fb8a29ec3d98ad
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
065a844bb195cb5453f2112a31433f0ea693ea4a 20-Nov-2015 Dylan Phan <lerp@google.com> Merge "Add alarm volume slider in preferences." into ub-deskclock-escargatoire
e84dc3edceb9cc5e272816ed53cc31ad59eb16dc 19-Nov-2015 Dylan Phan <lerp@google.com> Add alarm volume slider in preferences.

Bug: 23940822
Change-Id: I138d7932902e0df5d90110f3282ddc6ec3fcf32e
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
08bb3cf6eaaf8a7dd240120881519cd64b592928 18-Nov-2015 Justin Klaassen <justinklaassen@google.com> resolve merge conflicts of 1cf96ee5a1 to ub-deskclock-escargatoire.

Change-Id: I38a50e55e85aff0a23476da5cd7bdee2dbf7b084
557573da5583aa5c6d6da7110bfa26e73106ba0e 17-Nov-2015 Justin Klaassen <justinklaassen@google.com> Load TimeZone list in PrefsFragment#onCreate

Bug: 25706729
Change-Id: Idf41102e733c5056f98ac4873a5b1dde442ffefe
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
c52298dd2aee1b34d52dd2cf7270532655942582 11-Nov-2015 Dylan Phan <lerp@google.com> Adopt android.support.preference-v14 library

Bug: 22879020
Change-Id: Idc4f8bf5ee07b8abdb0f80ee1b53f58a9f99736d
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
3101fcf76ff5c228d2e643395be03d6cbf97d47e 27-Oct-2015 Dylan Phan <lerp@google.com> Implement custom ringtone picker for timers and alarms.

Bug: 23996371
Change-Id: I6515da60f2811d7fd03b8a41d9bd724dc959fd0f
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
1b8d83a86a13a144cb50be7c0663d9a828b99f94 01-Sep-2015 James Lemieux <jplemieux@google.com> am ea9f0d60: Merge "Simplify code that adds None as a valid timer ringtone" into ub-deskclock-charm

* commit 'ea9f0d606e72c4e00baac15fdf0eb0abd3da286e':
Simplify code that adds None as a valid timer ringtone
f8faca1961278db2797d122351885ce6e32e4f3d 01-Sep-2015 James Lemieux <jplemieux@google.com> Simplify code that adds None as a valid timer ringtone

- None option is added to picker by default, remove code that
manually added it
- Replace NO_RINGTONE_URI constant in TimerRingtonePreference
with test method: DataModel.isSilentTimerRingtoneUri(uri)

Bug: 23499698
Change-Id: Id45a24bee607edd8295c2a31785e55d67b44e8b0
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
478e310d02fcba4008c82f4c43fa662b713d756b 22-Aug-2015 Fan Zhang <zhfan@google.com> Let MenuItem factory create multiple controllers at once.

Bug: 21032049
Change-Id: If5bf78f19e95aaa30926a08b6299187ee721dea3
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
2ddf7a583828ecb3534e8fcac7392e6e2c7cf5b4 22-Aug-2015 Fan Zhang <zhfan@google.com> Revamp help menuitem.

Bug: 21032049
Change-Id: I8b43b801ad4128f3ef49a45f7577b3d91fbe56c4
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
811626f2f55a6bd88bcaed766f9c9911ccf6b7d8 21-Aug-2015 Fan Zhang <zhfan@google.com> Use actionbar menu component in SettingsActivity.

Bug: 23351503
Change-Id: I4815d80f268e35079d4478c0747b3f5c0381f5c3
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java
bd9eae10b13e015d1997d06f13e9abe06a7f306b 21-Aug-2015 James Lemieux <jplemieux@google.com> Present Clock's timer beep as the default ringtone

A "settings" package was introduced as a byproduct of this CL.

When choosing the preferred ringtone for timers, the default
selection should play timer_expired.ogg which ships with the
application. This is the only sound played on all prior version of
the application.

Known Issue: the dialog will label the default as
"Default alarm sound". This will be fixed in a later CL.

Change-Id: I4e9c6663c597038ec273b699cdda3a036b376350
/packages/apps/DeskClock/src/com/android/deskclock/settings/SettingsActivity.java