History log of /packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
21aed344fc1836de952b3ce7e4bee0d046f2def4 17-Aug-2017 Matthew Fritze <mfritze@google.com> Prevent race condition between SavedQuery and Query Loader

SearchFragment and SavedQueryLoader share a loader manager
and had been using the same loader id for different
loaders.

Occaisionally (in monkey tests) two loaders with the same
IDs would be started and crash when they finished.

The loaders now have different IDs.

Change-Id: I11e9b7365605fbcef44cf7d2323183415422f5c8
Fixes: 64756515
Test: robotests
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
e3535d9998363cbf352b5f8feb9277475e380944 03-Aug-2017 Fan Zhang <zhfan@google.com> Delete DynamicindexableContentMonitor & all refs to it

Convert input device search into a search query loader

And remove old logic from DynamicIndexableContentMonitor

Change-Id: If652b1ea7c8add9185bbd025055e14925d3a8eec
Bug: 64310452
Bug: 63831980
Test: robotests
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
5035f8c5590a8eea7bf372a325a4aa0ee1e96149 03-Aug-2017 Fan Zhang <zhfan@google.com> Move a11y indexing from DynamicContentMonitor to loader

This is necessary to kill DynamicContentMonitor later

- Removed all logic related to indexing accesiblitysetting from the
monitor class and AccessibilitySetting page itself
- Created a loader to search against A11yServices at runtime

I noticed adding a loader in SearchResultsAdapter is rather manual. It's
something we should consider refactor in the future.

Bug: 64310452
Test: robotests
Change-Id: Iff31aff65ce000991229433f294e2ec69af99da2
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
e651ddf9e6c00a62338ef8c7114b5e5e9cd307ec 20-Jul-2017 Fan Zhang <zhfan@google.com> Add shadow to searchbar when user scrolls vertically

Bug: 63528057
Test: robotests

Change-Id: Ib85676d78b43be38aab1eacd0820d0755a601f60
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
465d79776f0e731b04e1976d736eda7036a27c5f 17-Jul-2017 Fan Zhang <zhfan@google.com> Improve search indexing time.

- Some import clean up.
- Add timing log to track indexing time breakdown.
- Remove isAvailable() from UserDictionaryPreferenceController.

Bug: 36391685
Test: rebuild
Change-Id: If154c5dafba5d21cb1020497c44fbf67f03ad820
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
4e7bd693b20b471f1d170909e9609fe5c97a72f0 14-Jul-2017 Fan Zhang <zhfan@google.com> Misc search fix

- Remove incorrect summary from set date/time
- Remove some unused resources
- Remove ability to clear individual search history
- Add remove all query history menu item

Change-Id: I4383d075310297163fd2206d1a5b9c8f4ed94078
Fix: 62741488
Fix: 31589605
Test: robotests
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
892d65fd1eaccae914bd8282ff30fa1f307d0801 01-Jul-2017 Soroosh Mariooryad <soroosh@google.com> Adding warmup call API for Settings search ranking.

- This allows the ranking implementations to prepare for predictions and
avoids latency on the first prediction call.

Bug: 38197948
Bug: 37312700

Test: RunSettingsRoboTests

Change-Id: I1878b14765ad7cede5648fa1c7f29c419c2e5535
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
1bc4a459fb00c03a79af660fff1feeabe256b5e7 07-Jul-2017 Andrew Sapperstein <asapperstein@google.com> Merge "Search bar polish" into oc-dr1-dev am: d10a1af258
am: e0c01c6605

Change-Id: I39bae9af6032e392bfcb96eaab1af281bc705273
a22768cc1e1239f0eb361bf8b6409c925dfcf156 07-Jul-2017 Andrew Sapperstein <asapperstein@google.com> Search bar polish

Updated main page text color, text size, and search bar height.
Also updated results page text size.

Change-Id: Ic4a390136b854741a73e99431b8dd9452871dd2c
Fixes: 63397599
Fixes: 63394285
Test: robotests and manual
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
55bb0c258d4f66dde2834f9be0c454b33afcc49b 30-Jun-2017 Soroosh Mariooryad <soroosh@google.com> Log async ranking state in Settings search ranking

Bug: 62072727
Test: RunSettingsRoboTests

Change-Id: I2140c41d01f18a1e4b9e3f505e0afa4a8757d049
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
b2c69878d1eeeeff8e0d9cbea0e5cf3146630083 30-Jun-2017 Andrew Sapperstein <asapperstein@google.com> Merge "Fix robotests." into oc-dr1-dev am: db72caf3ea
am: 8e1c3b9b1b

Change-Id: I2990a108691e8123df1eeefc50f650d0b8d318a6
51e4a66446e5f3e957014c5a93a654c447236978 30-Jun-2017 Andrew Sapperstein <asapperstein@google.com> Fix robotests.

Change-Id: Ia0615bfdd303a19b145ead44979a03ccdd29bf41
Fixes: 63141368
Test: robotest
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
f050ab93d1e73085af82b5b71bc0f27f951d6d0a 28-Jun-2017 Matthew Fritze <mfritze@google.com> Merge "Add synchronous indexing api to SearchFeatureProvider" into oc-dr1-dev am: e2e54e17c7
am: d4075ea983

Change-Id: Ie93718a9af3b3bb4e53dfbf7f43da31c1ee9404a
98a9e42c93deaf5bb5f3028971065cc910e8d51f 25-Jun-2017 Matthew Fritze <mfritze@google.com> Add synchronous indexing api to SearchFeatureProvider

- Opens the database indexing to be synchronous for the
external settings api.
- Adds logging to track synchronous and async indexing
times.

Bug: 62826872
Test: make RunSettingsRoboTests
Change-Id: I28b69f3952946c0ae5dd7ea7da66f7a5fd485637
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
dd1dc22dcc48309ee44ebf7ce0f9f3649108584a 27-Jun-2017 Andrew Sapperstein <asapperstein@google.com> Merge "Search results page polish" into oc-dr1-dev am: 692a4b5514
am: a35b49a17d

Change-Id: I74370bad4f49ad1e9464e377057b5aebc74696aa
ab0c049bc258e6bc31ffca1b0f226955e651236b 26-Jun-2017 Andrew Sapperstein <asapperstein@google.com> Search results page polish

Changes made:
- up button added and in correct place
- text color correct when entering query
- query text aligned with results
- grey background around searchbar

Fixes: 37477506
Test: robotests
Change-Id: Ieb135f81f684032f3d5e4102304e617088c88117
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
9861c95577f7aa202060dab4005db9c13adf36f3 26-Jun-2017 Fan Zhang <zhfan@google.com> Fix typo in metrics constants

Change-Id: If73ca178c6f3f5544ae2f5a0cc030e307d7df8c5
Fix: 62955794
Test: robotests
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
9aad1cd48b3b8d87eda59baa9ac193fec8be98ef 02-Jun-2017 Soroosh Mariooryad <soroosh@google.com> Increase visibilities in SearchFragment and SearchResutlsAdapter for testing

Test: RunSettingsRoboTests
Bug: 36867802

Change-Id: I9102d02a5500330ce53e742ecd2084f0e714b830
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
0ca782ab18d0669227e0d7f168a01c1c863698d0 06-Jun-2017 Fan Zhang <zhfan@google.com> Add logging to track search no-result case

Change-Id: Iea95468c33e6663c0dad374954468947575bb3df
Fix: 37211659
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
9011a67431b22fa794e84202363b4966ed4534d1 01-Jun-2017 Fan Zhang <zhfan@google.com> Add a suggestion: showing new device features

- New suggestion activity
- Removed useless api SuggestionFeatureProvider.isPresent().

- Also updated support activity search indexing icon and summary

Change-Id: Ib52cf26a985f57bf0aac918606b10f75bd024639
Fix: 62034077
Fix: 62196070
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
733bbf7c347d35866668205e5faf24db874f633a 20-Apr-2017 Soroosh Mariooryad <soroosh@google.com> Updating the search ranking API and some improvements:

- Ranking API is modified to run the ranking asynchronous to the main thread.
Therefore, it can now run in parallel to loading the results from DB
which decreases the overall latency.
- Ranking API now supports reporting failure from the ranker
implementation side.
- Settings that are not ranked by the ranker algorithm are now ranked at
the end of the list. This is added for dynamic settings (e.g., apps).
- Failure handling mechanism is added for cases that ranker catches an
exception or it takes a long time to respond.

Bug: 37312700
Fixes: 36866337
Fixes: 36867476
Fixes: 36866736
Fixes: 36866838

Test: RunSettingsRoboTests

Change-Id: I3a2a97e3a07a8d4afbb090061d92172a27588ee7
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
893cb0987a021a3a42d9a56fe0a7a3c688f5dee4 29-May-2017 Andrew Sapperstein <asapperstein@google.com> Add search bar to SearchActivity.

Styling doesn't look exactly right yet but there's a bar.
Creates an ItemDecoration to add a spacer above the first view.

Removes the action bar and replaces it with a SearchView
inside of a CardView.

Remaining work: pixel pushing

Bug: 37477506
Test: make RunSettingsRoboTests
Change-Id: I4a0f0c91c51ff5820b61a596520d80a3337c3466
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
ee991f4956347ba9cc84ce78217984d0ce843cd8 26-May-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Misc logging changes"
012028e3a320dd3eeca3c39f0e47c1c40697bdf6 26-May-2017 Fan Zhang <zhfan@google.com> Misc logging changes

- log search result count, rank when clicking search result.
- log app package when default app is changed

Change-Id: Idd11bd67caba2beaa59c65839c40db8c71787388
Fix: 62072727
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
683ccdf97bd8b3ed30b7014f2df17227cff92561 25-May-2017 Soroosh Mariooryad <soroosh@google.com> Move static search ranking from DatabaseResultLoader to Search Adapter.

This will avoid unnecessary static ranking if smart ranking is used.

Since loader does not need to provided sorted collection of results,
the loading data type has changed from List<> to Set<>. This will also
faster lookup in the Adapter.

Fixes: 38447799
Test: make RunSettingsRoboTests

Change-Id: I448b29bd4e8700c8ec4b5766cbeab4b3087ae39a
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java
2078bc2358031ef3a191900d9036daf4251911c1 22-May-2017 Matthew Fritze <mfritze@google.com> Remove search2 package and put everything into search

Change-Id: Ie8651c79ef023f154cd7120a88a20f3481abce2b
Fixes: 38502743
Test: make RunSettingsRoboTests
/packages/apps/Settings/src/com/android/settings/search/SearchFragment.java