e3aefdc32035ec544ac491008656e477e634741d |
|
25-May-2017 |
Lei Yu <jackqdyulei@google.com> |
Merge "Add NPE check for refreshUi" into oc-dev am: 1a8c2dd899 am: 9e56dd44cd Change-Id: Id487b717c57c211f9a80f584bd518b6b5267d480
|
0b83954f1c86a5269b4b863e6ad0958dba03fed9 |
|
24-May-2017 |
jackqdyulei <jackqdyulei@google.com> |
Add NPE check for refreshUi The reason for NPE is that callback is registered too early, so one callback is invoked before controller is fully inited. This cl fix it in two ways: 1. Add NPE check in refreshUi, since this method in InstalledAppDetail is robost to NPE 2. Move the callback to the end of constructor. Bug: 37913054 Test: RunSettingsRoboTests Change-Id: I54b03fb51a958a8e63bfe8a7ccfda79be1fa1956
/packages/apps/Settings/tests/robotests/src/com/android/settings/fuelgauge/AppButtonsPreferenceControllerTest.java
|
777ed2535a7fd6f618a0d12f381af99252283574 |
|
10-May-2017 |
Juan Lang <juanlang@google.com> |
Depend on SettingsLib's version of lifecycle and FooterMixin. The implementations have been imported into SettingsLib. Setting's copy can now be removed, which this change also does. Test: Manually check battery status, which uses FooterMixin, looks OK. make RunSettingsLibRobotTests && make RunSettingsRoboTests && make RunSettingsGoogleRoboTests Change-Id: I6539605fdad80d156ff5ff249e68df4a1c412067
/packages/apps/Settings/tests/robotests/src/com/android/settings/fuelgauge/AppButtonsPreferenceControllerTest.java
|
0d7854aa43c7d8debc8daf1390625803fb56e9ba |
|
01-May-2017 |
Jesse Evans <jsje@google.com> |
Hides app buttons for instant apps Hides the app buttons when the app is an instant app. Added a todo to remove this functionality when instant apps are properly supported by this controller. Test: make RunSettingsRoboTests Bug: 37313605 Change-Id: I3fca106a8e72c41b626e1182f5ba1089b90e8e2a
/packages/apps/Settings/tests/robotests/src/com/android/settings/fuelgauge/AppButtonsPreferenceControllerTest.java
|
31b8de1e215f6f0dcd694024c617f9f185e510ae |
|
15-Mar-2017 |
jackqdyulei <jackqdyulei@google.com> |
Create Controller for app buttons These two buttons(uninstall + forcestop) are used in both battery page and app page, we should move the logic for these two buttons into one place. This cl creates the AppButtonsPreferenceController for the above purpose. This cl only copies the logic to controller but hasn't make InstalledAppDetails use this controller. Since DialogFragment could not use function in controller directly, the controller expose DialogListener and all the fragments must implement this interface. Then they can delegate the method call to controller directly. The following cl will: 1. Make the InstalledAppDetails be compatible to controller 2. Make the InstalledAppDetails use this controller. Bug: 35810915 Test: RunSettingsRoboTests Change-Id: Ie2aa8064bcec3003233896c18be772825b12930a (cherry picked from commit 82d07983b46b4c6a1b7a3c431c57ff45e84e72be)
/packages/apps/Settings/tests/robotests/src/com/android/settings/fuelgauge/AppButtonsPreferenceControllerTest.java
|