History log of /packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
dc0723e2d95967060885c3266d2c3b09aa3319a1 17-Jul-2017 Daniel Nishi <dhnishi@google.com> Don't put app preferences too high up.

By incrementing the order, we ensure the order is always greater than 0.
This should mean there will be no contention between the app deletion
preferences and the other deletion preference categories in the
nothreshold mode.

Change-Id: I219593d796b9c1645fc932f489ae707ef4482fa9
Fixes: 63713409
Test: Robotest
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
828974f55fa2aae46d8137747e284a7861d8086c 25-Apr-2017 Salvador Martinez <dehboxturtle@google.com> Use Intermediary state in deletion types

Having only a loaded content/no content state
was making so that the DeletionHelperActivity
would occasionally change states when it
shouldn't. This CL changes the states to
'unfinished', 'done with no content', and
'done with content.' This will allow the
activity to know for sure if the
DeletionTypes are done loading and found
nothing, or if they are still just searching
for content.

Test: Robotests
Bug: 37434948
Change-Id: If7cfb09e94e2710bc1293455caeafd3a627ee2c4
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
33d4cb4fd65e6846e0db80abd8b4ae3f242c04ac 04-Apr-2017 Salvador Martinez <dehboxturtle@google.com> Add empty state animations, no threshold link

This CL adds some animations to the empty state
where it slides in instead of just appearing. It
also adds the link that allows users to switch the
filter to no threshold, which will show them all apps
instead of just unused apps.

Test: make RunStorageManagerRoboTests
Bug: 32581398, 34395589
Change-Id: I2d7505301e3f1ec987b6e9017af7f7c23fa201fc
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
a077e8d3f8c99fd3769d93c4094d434115072a9c 28-Mar-2017 Salvador Martinez <dehboxturtle@google.com> Update UI to match mocks

tldr; UI revamp for OC. see bug for links to mocks
and redlines. Follow up CL will introduce animation
and additional empty state content.

Detailed info:
-Size of specific items will now turn blue when selected.
-Added empty state for when no items are able to be
deleted.
-Updated text layout for preferences to move size of
item next to the checkbox. Also moved dropdown arrow
to the left side of the preference.
-Added progress spinners to categories to let the
user know when loading is done.
-Added "empty state" to color of preferences so they
appear greyed out when nothing can be deleted.
-Added logic to automatically transition to empty state.

Test: Robotests
Bug: 32581398
Change-Id: I7f0115297b5b777cfb545bd02989d449e853f117
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
0b30611cd33805255a7538cc16cf203a761b6978 14-Mar-2017 Daniel Nishi <dhnishi@google.com> Add new strings.

Bug: 36197674
Test: Manual
Change-Id: I57840e767f97acd5eb6772256808a6dbfb59a6b3
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
dee882c960b4db9bae9f2c9144b84c6ba001a051 02-Feb-2017 Salvador Martinez <dehboxturtle@google.com> Switched DeletionHelper backend to use loader

Application state is slow because it does so many
things so the backend for DeletionHelper has been
switched to use a loader specific to this screen.

Test: make RunStorageManagerRoboTests
Bug: 34768442
Change-Id: I1123f64e57d04a08cee90e98f3f05216acf35c7e
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
9385b673317060523b66a40780d5ad1df1530a56 17-Jan-2017 Salvador Martinez <dehboxturtle@google.com> Added different thresholds to DeletionHelperActivity

Added the ability to change the threshold for what
deletion helper should show to the user as deletable
content. An additional filter was added to show
all content on the device regardless of age.

Test: robotests
Bug: 32581398
Change-Id: Idb87169b64209d8abb7c360f6e3ad5b65001111f
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
1efe581749de7f50de41bac1e31b1389ac964615 04-Jul-2016 Tamas Berghammer <tberghammer@google.com> Update package names to work with the proto3 compiler

Bug: b/28974522
Change-Id: I2e6b77e73e71a873ac2815147d503626ff56c25d
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
9df16b0531a5d16aee3731628af7a6580966e70b 18-Aug-2016 Daniel Nishi <dhnishi@google.com> AppDeletionPreference used app name instead of package name.

Using the label name can cause conflicts if multiple apps have the
same label. Package names must be unique.

Prior to this change, AppDeletionPreference used the app label as its
key. Because the key was not unique, this caused a bad interactions with
the other Deletion Helper parts. It causes duplicated entries in the
Deletion Helper and invalid behavior when selecting which packages to
delete.

Bug: 31089224
Test: m -j32 RunStorageManagerRoboTests
Change-Id: I6dd9627818d5a154d04d17ae2324bb65865148a7
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
80f8ec612704639f209346f09c208eb3fc8cab56 19-Aug-2016 Daniel Nishi <dhnishi@google.com> Add tests for the PreferenceListCache.

This patch also moves the PreferenceListCache into the utils
package.

Bug: 30900642
Test: m -j32 RunStorageManagerRobotests
Change-Id: I32a33a1720622bf5204841830e22f14f6e2c8f10
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
42969bebbe57c4505890007d5f51762a6e014b8d 20-Jul-2016 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Fix a bug where the apps deletion type no longer populated." into nyc-mr1-dev
46afa46254906b9ba370841527066f8c5c58adb4 20-Jul-2016 Daniel Nishi <dhnishi@google.com> Fix a bug where the apps deletion type no longer populated.

This bug resulted from a recent change to how the ApplicationsState
works. It used to return a list of apps synchronously, but now only
works asynchronously after ag/1225943. The item title was populated
once we got the list of apps, but since we no longer received it,
the item title was no longer populated.

This patch does two things:
1. Use ApplicationsState asynchronously to properly populate.
2. Default to 0 clearable apps w/ 0 freeable bytes on initialization.

Bug: 30220563
Change-Id: I92ef1ca40b74b3d62673b828d6b8143680dd760a
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
cd65f0119e6ef2e282e19b200c07ae42ff9efe5f 20-Jul-2016 Daniel Nishi <dhnishi@google.com> Fix a bug where duplicate package names caused many dupes.

By ignoring apps which have a different user id than the querying
user, we can avoid the problem of many duped applications in the
Deletion Helper.

Change-Id: Ia1452c6597d2861b6d297600a057174f8147ef01
Fixes: 30231207
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
c950058526c77f9e6a2cb3635ceb0d6b55fab45f 30-Jun-2016 Daniel Nishi <dhnishi@google.com> Retain checked and collapsed statuses on rotation in Deletion Helper.

Because the CollapsibleCheckboxPreferenceGroup does not derive from the
CheckBoxPreference, it did not inherit its checked retaining status.
Furthermore, we need to add functionality to retain if the group is collapsed.

Bug: 29872587
Change-Id: I1d8a95a3fe1466bae7f58daecd37fde1c6af62b5
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
f6bd7706da6cd676ee767ba7c7b7524ba5bc914a 16-Jun-2016 Daniel Nishi <dhnishi@google.com> Merge "Update the app deletion preferences to match the mocks." into nyc-mr1-dev
2ace931586ac5ee3d0633c051bc276690975f3ea 11-Jun-2016 Daniel Nishi <dhnishi@google.com> Add logging to the Deletion Helper.

This adds telemetry for when preferences are checked/unchecked,
when a group preference is expanded or unexpanded, responses to
deletion helper dialogs, and finally logging when deletion fails.

Bug: 28918007
Change-Id: I4b2392f46d18d4ff9a5e718360a8ebe97252ff79
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
5e2460bb808460c37e9409e0735a95998457647c 08-Jun-2016 Daniel Nishi <dhnishi@google.com> Update the app deletion preferences to match the mocks.

In the latest mocks, there are several changes.

1. The nested preferences align with the title/summary text of the parent.
2. The app icon is 24dp.
3. The strings have been updated slightly.

Bug: 28884396
Change-Id: I1edb5019acd42a32d1014718267fa436cc699e5a
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java
09fa1388d090666e631f9d764f935604a2c753e9 01-Jun-2016 Daniel Nishi <dhnishi@google.com> Initial commit of the Storage Manager app.

This patch ports over the Deletion Helper from Settings with the
app deletion and downloads deletion functionality. The functionality
is now inside of a new APK in a new activity which can be accessed
using the android.settings.DELETION_HELPER_SETTINGS intent.

Future CLs will add the following behavior:
1. Port over ability to delete photos.
2. Add overlay facilities for extending the storage manager behavior.
3. Port over the existing unit tests for the storage manager.

Bug: 28822584

Change-Id: I3084f29ab43d5f46202f0cdafcc11ff33d3bbf0f
/packages/apps/StorageManager/src/com/android/storagemanager/deletionhelper/AppDeletionPreferenceGroup.java