History log of /packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
99e1a7555a9521c33203b68c5ab5bd1c039ee712 25-Aug-2017 Pavel Maltsev <pavelm@google.com> Merge Vehicle HAL 2.1 iface to 2.0

Vehicle HAL is property based and all properties are considered
optional. It is quite a bit of pain to create new versions of VHAL only
to extend properties.

Bug: 64303350

Test: verified system works stable

Change-Id: I4c5c891236912651ca1341f7fd515e533a6b4506
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
25e89468119cd0b109f62c751446dfdd8e903143 02-Aug-2017 Enrico Granata <egranata@google.com> Move the Diagnostics API classes to android.car.diagnostic

Bug: 64024685
Test: build, flash + runtest CarDiagnosticManagerTest
Change-Id: I73e079be8910e550ae52f78162680d585949d022
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
6af10a482b37a809733fd800625a14c697558a1a 28-Jul-2017 Enrico Granata <egranata@google.com> Merge "CarService changes necessary to support the diagnostic enums rename on the Vehicle HAL side" into oc-mr1-dev
976cee4a3583c66599e364badf9024df5022ee7a 26-Jul-2017 Enrico Granata <egranata@google.com> CarService changes necessary to support the diagnostic enums rename on the Vehicle HAL side

Test: clean build and flash, then
runtest -x packages/services/Car/tests/android_car_api_test/src/android/car/apitest/CarDiagnosticManagerTest.java
runtest -x packages/services/Car/tests/carservice_test/src/com/android/car/test/CarDiagnosticManagerTest.java
runtest -x packages/services/Car/tests/vehiclehal_test/src/com/android/car/vehiclehal/test/Obd2FreezeFrameTest.java
runtest -x packages/services/Car/tests/vehiclehal_test/src/com/android/car/vehiclehal/test/Obd2LiveFrameTest.java

Bug: 64024685
Change-Id: Ie6615dc84fcddbb108ad1c58b7a569b8e6ce37d6
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
20f13f7b883e4df807e1614f167cef21cc88ff1c 27-Jul-2017 Enrico Granata <egranata@google.com> Enhance documentation comments for Car Diagnostic APIs

Bug: 64024685
Test: build
Change-Id: I3a7ec0fcf752eb4cd7138a470d81d551a44a0481
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
41c5ac61eaf4ad26c7fe16ee3fe961b843e5f1e1 12-Jul-2017 Enrico Granata <egranata@google.com> Remove a few left-over @FutureFeature markers from diagnostics API

Test: build & sync
Change-Id: I37fcfda1e4db38929ddce08e7ed1f4a5781a292d
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
5e075dac94101efe1bdcde105b8c4194eb9e70d0 29-Apr-2017 Enrico Granata <egranata@google.com> s/FRAME_TYPE_FLAG/FRAME_TYPE/

FLAG is misleading because these are not bitwise masks, but
just identifiers of frame types.

Test: manual in KitchenSink
Change-Id: Ieed237ad6cb36bcec36c77d9a4ec5bc89edeaaba
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
3b44fb3256780a94b1934793b247caef348295bb 27-Apr-2017 Enrico Granata <egranata@google.com> Fix a few typos in the diagnostics code

Test: build
Change-Id: I10788e565a39c3be6462b13f454fbea41ca6b7e8
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
0f4c4f390c50da4326c01efde19f6693aace8959 24-Apr-2017 Enrico Granata <egranata@google.com> Do not double-subscribe to diagnostic properties.

CarDiagnosticService will initiate a subscription to the OBD2_
properties when asked to startDiagnostic(). At the same time,
DiagnosticHalService was subscribing itself at init(). That
caused a race condition in CarDiagnosticManagerTest w.r.t. the
relative timing of unsubscription vs. delivery of events.

The second subscription serves no useful purpose, hence remove.

Change-Id: If099c54d655fa19f36dc4ccc525a9e4d7c3b325e
Fixes: 7347786
Test: runtest CarDiagnosticManagerTest + manual in KitchenSink
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
3539eeac1cc560825369b1e4a0641d8288605889 04-Apr-2017 Enrico Granata <egranata@google.com> Subscribe to the diagnostic properties in DiagnosticHalService

This fixes an issue where changing the values of those properties via the emulator would not cause an event to bubble up via VehicleHal

Test: manual with vhal_emulator.py

Change-Id: Iac692b06ac4f39b0869296ad75d666d6e56a401d
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
4f8f01740294612bb9f0a6beff3510d402cdad60 02-Mar-2017 Enrico Granata <egranata@google.com> Prevent DiagnosticHalService from crashing if the OBD2_*_FRAME configuration array is empty.

Test: TARGET_USES_CAR_FUTURE_FEATURES=true runtest -x packages/services/Car/tests/carservice_test/src/com/android/car/test/CarDiagnosticManagerTest.java
For O-MR1

Change-Id: I15fa0ebc15ea8302f971b3ec38cd563a8fe2b646
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
14b5d561eade5964288da907a4cf21b17dfd1381 21-Feb-2017 Enrico Granata <egranata@google.com> Post-O. Move OBD2 support to Vehicle HAL 2.1.

Test: build
Change-Id: Ia1fd2e3057d3a4d35e6be00b7e5a11440027a575
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
2a68e45ab6964476df94df04643512cb556c91a2 16-Feb-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Post-O. Provide smart accessors for sensors that describe structured/enumerated data."
0b7559c7f6ea24cec679c310c7a320905222f843 14-Feb-2017 Enrico Granata <egranata@google.com> Post-O. Provide smart accessors for sensors that describe structured/enumerated data.

Some sensors describe purely numerical information (e.g. ENGINE_RPM).
For those, the sensor value itself is the entirety of the information.

In other cases, however, sensor values are either elements of an enumerated type, or bitmasks representing aggregate data.
In those situations, provide smart accessors that return a more structured view of the data.

Test: .
Change-Id: I619eb671d52b378b249ebb396f18eca6a5ecc3db
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
24790343363bd29814b28e5eacfd43216863bee3 15-Feb-2017 Enrico Granata <egranata@google.com> Properly handle implementations of Vehicle HAL that do not support diagnostic properties.

OBD2_* properties are not required of a HAL, but DiagnosticHalService was treating them as such.
Handle this more reasonably, by providing a DiagnosticCapabilities to clients.

Test: runtest -x packages/services/Car/tests/carservice_test/src/com/android/car/test/CarInfoManagerTest.java
Bug: 35388742
Change-Id: Ia38b5dd8d7d2d3c64c17696eadeac1f6285ad37d
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java
5c56d2a3a5bc4ef5b46a58fa56b7f4a657b0827e 08-Feb-2017 Enrico Granata <egranata@google.com> Post-O. Sketch out CarDiagnosticManager API surface

Provide an implementation of all layers required to plumb CarDiagnosticManager through:
* CarDiagnosticEvent
* DiagnosticHalService
* CarDiagnosticService
* CarDiagnosticManager

If FutureFeatures are enabled, this is integrated end-to-end enough to run trivial tests of the API

Test: build with TARGET_USES_CAR_FUTURE_FEATURES=true then at a shell runtest -x packages/services/Car/tests/android_car_api_test/ -c android.car.apitest.CarDiagnosticManagerTest
Change-Id: I0f2aafd039d26fec15182dd7029cf8c7995ce85b
/packages/services/Car/service/src/com/android/car/hal/DiagnosticHalService.java