| bd8505b73ee2a86c64ea7a25f59611259efeb05b |
|
29-Sep-2017 |
Pavlin Radoslavov <pavlin@google.com> |
Remove casts to (tBTA_GATTC*) unions to avoid unaligned accesses
Bug: 65381426
Test: unit tests
Change-Id: I37e89ec7187ab1c61be4c736385a9fc5ec88d737
(cherry picked from commit b147c652e90c60daa7113933c48a465491707213)
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 9e030fde05352ec4385d7baf6cc2af89e95e039c |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3)
Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/bta/gatt/bta_gattc_act.cc
|
| c752e135d66f80c0b2efc35292ab8ddfd8227d61 |
|
16-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Replace BT_ADDR with bd_addr_t in bta_sys related code
Test: compilation test
Change-Id: Idab6e9c03621c5540b4a3a7fa537dff71a25ce3f
/system/bt/bta/gatt/bta_gattc_act.cc
|
| c2276b06572ab6fc1f900fbb1f41087e77d47e2a |
|
10-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bt_bdaddr_t instead of BD_ADDR
Test: compilation test, sl4a GattReadTest
Change-Id: I8d1bd6914aec55bb53495b1d0d5e3d37b86865e6
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 14d08604848a430871d30853894add7a3facee7b |
|
31-May-2017 |
jruthe <jruthe@google.com> |
bta: Update APPL_TRACE_* logs and call parameter
Also update messages to use __func__ rather than hard-coding
function names in log messages.
Test: Pair two devices
Change-Id: I8d3a9e293c71775caee420b8da6bc3e4385a46dd
/system/bt/bta/gatt/bta_gattc_act.cc
|
| d7ee6f2e85a1a8837b0b1e2e8ba1c72b53650cd8 |
|
05-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of BTA_GATTC_API_REFRESH_EVT
Test: compilation test
Change-Id: I631962183ac63d2b168005060bb1f0d4964b0884
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 31a6bf4f11b7f5483af93d9ded49f979167a0ccb |
|
05-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of trivial BTA_GATTC_ events
Test: compilation test
Change-Id: I8c705d1bb0532cbe0dd69b1f3b0b5d1a63534a23
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 16bb48b320cde54a1a06a525f4d9be1421689649 |
|
25-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Fix GATT Server disconnecting for no reason
Connections created by GAP profile should be ephemeral, and not
interfere with the connection timeout.
When a device is bonded, listing services through DM would cause a
DM APP to create a connection, and later to disconnect. This causes
connection to timeout. In case a device was already connected, this
should not happen.
Bug: 34951749
Test: manual
Change-Id: Iad04fd9eed4c664f35131442e3f83a704497a067
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 7dd34f52bc950bae2fb1b30b17da0ff34ee016aa |
|
14-Apr-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Read by UUID for PTS tests (4/5)
Add a hidden api for reading characteristic by UUID for PTS.
Bug: 35150313
Test: sl4a GattReadTest.byUuid
Change-Id: I072473c5f7b761707774efd89f8a22bfdf012135
/system/bt/bta/gatt/bta_gattc_act.cc
|
| f271c9109e5608acb393c9bef0bca9d2b0177f5d |
|
17-Apr-2017 |
Jacky Cheung <jackyc@google.com> |
Do not GATT_ERROR on MTU change
Bug: 37305498
Test: manual on MSM8909
Change-Id: I07389620efc914d0ece52262edc2c35b498d5564
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 96fb273d92a31204edcf43ab2594a19876d14056 |
|
25-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Add option to specify initial LE connection PHY (1/3)
For whitelist connections we always use all possible PHYs, for direct
connection use PHY specified by client.
Test: manual
Bug: 30622771
Change-Id: I720f134e2800dc3d282135bb7ffbe3882117c680
/system/bt/bta/gatt/bta_gattc_act.cc
|
| b5ba4fdbc433544de3806f8e82976898e444b491 |
|
24-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Expose connection update callback (1/3)
Test: manual
Bug: 30622771
Change-Id: I94d25f6f22b42fb1432a9288c97b82503d57db86
/system/bt/bta/gatt/bta_gattc_act.cc
|
| eafd45d08653bb1621c82a2f3cf922a43a0b1bc5 |
|
23-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Set preferred PHY and read PHY implementation (3/3)
Test: manual
Bug: 30622771
Change-Id: I4267238a0b5c7bc373ae1846ebd19a716881a4ec
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 8843cc830b522cfe6f1e361297fc28fd331a1378 |
|
17-Apr-2014 |
Hemant Gupta <hemantg@codeaurora.org> |
HIDD: Add support for HID Device Role
This patch adds support for HID Device role in bluedroid stack allowing
DUT to be used as Keyboard or Mouse.
Bug: 33011576
Change-Id: I45b581a54f6c7bbc1f25226715a7ea23e34255c0
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 221e9bf6c9e9f974efd92ea4f054dbdba248d2db |
|
15-Dec-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
BTA Application registration refactor
This patch replace BTA state machine state associated with registration
of new application, together with BTA_GATTC_API_REG_EVT, and
tBTA_GATTC_API_REG. Instead, it uses closure to post registration task,
and callback for registration event.
Bug: 30622771
Test: sl4a ConcurrentBleAdvertiserTest GattConnectTest
Change-Id: I62d68485170ef5472237d62b285353f2c9bc8250
/system/bt/bta/gatt/bta_gattc_act.cc
|
| ee96a3c60fca590d38025925c072d264e06493c4 |
|
23-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Fix asterisks in block quotes
Remove double asterisks from block quotes.
git grep -lP '^[*][*]' | xargs sed 's/^[*][*]/ \*/' -i
Fix asterisk line lengths
git grep -l '^[ /][*]\{79,\}[*/]' | \
xargs sed -i s,"^\([ /]\)[*]\([*]\{78\}\)[*]*\([*/]\)","\1\2\3",
Test: mma -j32
Change-Id: Ie3fd375ac2f804cb0f53bf1314a005e85973b3d7
/system/bt/bta/gatt/bta_gattc_act.cc
|
| f33b6f434f086b20fabe5913016bc423ac975057 |
|
23-Nov-2016 |
Marie Janssen <jamuraa@google.com> |
readability fix: No assigns in if conditionals
Coccinelle-assisted:
@@
variable i;
expression E;
statement S1, S2;
@@
+ i = E;
if (
(
- (i = E)
+ i
!= ...
|
- (i = E)
+ i
== ...
|
- (i = E)
+ i
< ...
|
- (i = E)
+ i
> ...
|
- (i = E)
+ i
<= ...
|
- (i = E)
+ i
>= ...
|
- (i = E)
+ i
)
) S1 else S2
for file in $(find . -name "*.cc"); do
spatch --sp no-if-assigns.cocci --in-place $file
done
clang-format --style=file -i bta/**/*.cc
Test: mma -j37 and basic sanity testing on angler, sailfish
Change-Id: I41a2964afac347c24e13869b6c172e321e646091
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 9979121f0865e07432215529f9b157792ae3ef21 |
|
18-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Remove BTA_GATT_INCLUDED
Test: Connect to a BLE Keyboard
Change-Id: I00393e2bf09fb65533e953896563e69aab5a22dc
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 84baa7f16e830394408278dbb8c508dd9fa02887 |
|
14-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Remove BLE_INCLUDED define
Test: Connect to a BLE Keyboard
Change-Id: I5f8f4017c90c3c404004632fd10e6c2b93bd7783
/system/bt/bta/gatt/bta_gattc_act.cc
|
| a1e7e5561026e32c5f4d51bf6102fd275061b80f |
|
22-Nov-2016 |
Marie Janssen <jamuraa@google.com> |
Constant Cleanup: Remove BT_TRACE_VERBOSE
BT_TRACE_VERBOSE turned on constants-as-strings in
logs in many parts of the stack, which is preferable
to obscure numbers.
Test: m -j37, check logspam is not worse than normal on a device
Change-Id: I1d24f1c1337290a8a2bcd9a0d937c9e0f1f1c611
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 1baaae3f34a667058e7f0c5f778357d98320cf38 |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Fix comment formatting after clang-format
Test: mma -j32
Change-Id: Ic945ac421b1918527105c59674eda89afd3d4126
/system/bt/bta/gatt/bta_gattc_act.cc
|
| cd1fd07f1306e08fe048682dd5918987e579f937 |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Apply clang-format
clang-format -i --style=file bta/*/*
(twice)
Test: mma -j32
Change-Id: Ib118b1dfb6a34f9a5bfe153d65841e9041165264
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 8af480e24549ba51a3f6858d9d9af504715e0bea |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Remove double asterisks in comments
Double asterisks at the beginning of the line
sed -i s,"^[*][*]"," *", bta/*/*
Double asterisks after a space
sed -i s,"^ [*][*]\([^*]\)"," *\1", bta/*/*
sed -i s,"^ [*][*]$"," *", bta/*/*
Test: mma -j32
Change-Id: Ib83b802c7000176683b4e7f24d1255b3c2c6c01c
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 4918648dd55ded3135aad68c866520cf2b5e1c3e |
|
31-Oct-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Simplify BTA_GATTC_Listen
It is necessary to make BTA_GATTC_Listen not dependent on client_if
before it is moved to advertising interface, where it belongs.
Bug: 30622771
Bug: 24099160
Test: no tests necessary
Change-Id: I75dc7e0fcd64fd3437474933069941b52740f0b5
/system/bt/bta/gatt/bta_gattc_act.cc
|
| e68dc31025067bcd288128ac1e37b8bf18de756e |
|
29-Oct-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Make bta_gattc_listen only start listening
The bta_gattc_listen method is used only to start advertising on devices
not using Vendor-Specific Callbacks. It should not notify the client
calling it of all connected devices.
It is also unnecessary to add the gatt client as listening for background
connections. No such thing is done for multi advertising.
Bug: 30622771
Bug: 24099160
Test: code is still compiling
Change-Id: Ia11a247b8416f77543087cd3f18331fcfe7bd207
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 2e8c421ddce1dae511a39b8e89415e8eb1944bfd |
|
29-Oct-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove advertise whitelist functionality
Advertise filtering is never used. It is not finished - adding device to
whitelist can never succed. It is also making advertising API unification
hard.
Bug: 30622771
Test: no tests necessary
Change-Id: I9df9ea18b265a580c2fcdb28a6d6ce4be43f0a24
/system/bt/bta/gatt/bta_gattc_act.cc
|
| d7ffd64accbd50a27289a388856e56244ccbb5da |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (5/5)
Include osi.h for UNUSED_ATTR.
Test: mma -j32
Change-Id: I43260669dc1f54639e46cc9620093d727ee86276
/system/bt/bta/gatt/bta_gattc_act.cc
|
| d35a648d39710bbc5ac59f8add85166455af5af7 |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (1/5)
Generated automatically with coccinelle
/* This rule matches functions with arguments
* that have an UNUSED(arg) in the body.
*/
@r1@
identifier arg;
identifier fn;
type t;
parameter list[n] P;
@@
fn(P, const t arg) { ...
UNUSED(arg);
...
}
/* This rule removes the UNUSED line, and adds
* UNUSED_ATTR to the parameter list.
*/
@depends on r1@
identifier r1.arg;
identifier r1.fn;
type r1.t;
parameter list[r1.n] r1.P;
typedef UNUSED_ATTR;
@@
fn(P,
- const t arg
+ UNUSED_ATTR GETRIDOFTHISCOMMA, const t arg
) { ...
-UNUSED(arg);
...
}
Test: mma -j32
Change-Id: Idcaadd688d669d484e557becd050e69454508f3c
/system/bt/bta/gatt/bta_gattc_act.cc
|
| e54c2e584876416523c1f2fa2136a9f7f880557a |
|
23-Sep-2016 |
IHLHO KIM <ih0923.kim@samsung.com> |
Fix the GATT re-discovery failure when GATT service discovery is ongoing
If 'BTA_GATTC_Refresh' is called when GATT service discovery is ongoing, GATT service discovery should be restarted after GATT service discovery is completed.
But it cannot be restarted actually because of missing set 'auto_update' state.
This patch set 'auto_update' state to start discovery again correctly.
Change-Id: Id18f04705fef253261e52836849e4e6020e42a05
/system/bt/bta/gatt/bta_gattc_act.cc
|
| a77f2e9020d32dc3d7906c4b72763dd54e91a8c0 |
|
03-Oct-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Fix bad GATT client state machine state after successfull cache load
If the GATT service cache was successfully loaded from a file, the
state must be reset to idle.
Bug: 31175159
Change-Id: I92ebf1bec9d2e7467d7412b41923614ec5a13b6d
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 109891d07f7946c69070a01e0ebef56ee3eb7707 |
|
18-Jul-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Make gatt_attr use opportunistic connection
This patch creates new connection mode - opportunistic connection. When
such connection is made, no call to gatt_update_app_hold_link_status
will be made when it's started.
This means that connecting and disconnecting in this mode won't trigger
disconnect timer. When other, app creates regular connection and then
disconnects, the physical connection might get disconnected.
Opportunistic connection is used only for code setting CCC right now.
Bug: 30186455
Change-Id: Ia5be7682b6c3dcb4993060f818dee603aef3e19e
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 24ea892320ca85c7f6cdd77343da50818fe29002 |
|
14-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Add callbacks to GATT read/write operation
There is no need for read/write callback to be a global event. It should
execute local callback instead.
Change-Id: Id7e915af9d30092d2f754eddc7c3aed4970eeb2f
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 3c5451da9db18062af1c19e1f780c1de5bd88b31 |
|
25-Jun-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Simplify GATT characteristic read memory handling
Pass read result in a fixed sized array instead of a pointer.
This eliminates the need for any special memory management in btif.
Change-Id: I2a33d74b12f3059050855c9fc90fff785cc985ba
/system/bt/bta/gatt/bta_gattc_act.cc
|
| a05734c69c611567374c7d9a7c9184f60afaed06 |
|
24-Jun-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bta_gattc_cb directly, not through aliases
Right now, bta_gattc_cb is not used directly, instead it's passed as
argument to methods that can use it directly.
Change-Id: I54fef4b8b1e11b3289e7961f70bea187173e9804
/system/bt/bta/gatt/bta_gattc_act.cc
|
| e9e58ced195ec2c983c7723c9cbdabd45eb0f2fd |
|
17-Jun-2016 |
Marie Janssen <jamuraa@google.com> |
bta: use standard types
Use standard types everywhere.
Use standard style for #if statements:
- #if (VAR_NAME == TRUE)
- #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE)
Use __func__ instead of __FUNCTION__
Fix some debug statements to use __func__
Change-Id: Ib86de4de9f14529ecaa4f71597260e3b5785360b
/system/bt/bta/gatt/bta_gattc_act.cc
|
| 19117701657073f3b8ba03620c081a8976b318a6 |
|
26-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Convert GATT related BTA code to C++
Change-Id: I9c36d0ebeb1143395b3b38b3d179d12a9503d28a
/system/bt/bta/gatt/bta_gattc_act.cc
|