| aaa50649b95c0ab2cd84e67fab77596bbb24d095 |
|
04-Jul-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Make RawAddress into a class (1/3)
* Add libbluetooth-types - library containing types implementation, that
is common between stystem/bt and packages/apps/Bluetooth. It must be
included in every project using btif interface.
* Put Raw Address implementation into libbluetooth-types
* Unify all "to/from string" helper methods into ToString and FromString
* bd_addr_empty -> RawAddress::kEmpty
* bd_addr_any -> RawAddress::kAny
Also fix leaks in jni str2addr by adding ReleaseStringUTFChars
Test: types_unittest
Change-Id: Ie0694843ad5fbd2a80b310c5f532e5e5a9548043
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| 9e030fde05352ec4385d7baf6cc2af89e95e039c |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3)
Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| 78b81c6db0aed32eb595ce4de7eb22fc24800058 |
|
16-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of bdcpy, bdcmp and other BD_ADDR helpers
Test: compilation test
Change-Id: I37f17bfb3826b59797373645691c61bfbaefdbfd
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| 1979fa31d2e9aa7dfe7380327fbddebfffd0cda4 |
|
16-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Replace BD_ADDR with bt_bdaddr_t in RFCOMM related code
Test: compilation test
Change-Id: I591049f0f4ea9fa60b1b9f0271e1a906a2a06f30
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| 744eeca761b6d52d4e5fbbfa49c2d2adde0e6981 |
|
16-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Replace BD_ADDR with bt_bdaddr_t in hf client related code
Test: compilation test
Change-Id: Iee6b07b6a919e5d061a04cb3d919166661e673e8
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| 6664b2ccbbf0240524bc23c5dc81c690cf4daffa |
|
15-Dec-2016 |
Sanket Agarwal <sanketa@google.com> |
Incoming HF connection: CB interaction between BTA <-> BTIF
For incoming connections we are not storing the handles in BTIF which
implies that BTIF ignores the message (and so does jni -> java). This is
fixed by sending the handle as part of BTA message on incoming accept.
Other bugs include connection from remote (incoming) and disconnecting
from host. They also depended on not storing the handle properly in
first place.
Bug: b/33555377
Bug: b/30984220
Test: Manual testing of incoming connections
Change-Id: I84950d42aba2d2c975ea86cc8217fd0129cc90e9
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| bd3ae7cbf195caf91693046147b34d25b6317485 |
|
07-Dec-2016 |
Sanket Agarwal <sanketa@google.com> |
Write unit test for bta/btif HF client role
Also fix a bug discovered by unit tests:
bdcmp returns 0 on success hence use negation
Bug: b/30984220
Test: Unit test
Change-Id: I37f7c71c5dd809e4df3d8c2c79906a74c2b19d34
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| 5eccd90936d606e0070872b247fd3462e9c9c19b |
|
01-Dec-2016 |
Sanket Agarwal <sanketa@google.com> |
Implement multiple control blocks for HF Client in BTA/BTIF
Test: Manual test for multiple incoming/outgoing HF connections
Bug: b/30984220
Change-Id: If66cad7c9bbc92051ebb7efb2b352c10e7514af3
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| bdcfc045f9d21afc1510cdad4fddd97a93c26477 |
|
01-Dec-2016 |
Sanket Agarwal <sanketa@google.com> |
BTA HF Client should use dynamic control block
Most of the functions in bta_hf_client_at.cc are
currently using a static field for passing callbacks to
BTIF layer. In order to support multi device we need to make
the functions have a parameter which denotes the device.
In order to pass all the required information we choose to
pass the control block for the device instead.
Bug: b/30984220
Test: Manual regression test
Change-Id: Iac692d7e28df3955ddbd28707c323c41714bd86a
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| cd1fd07f1306e08fe048682dd5918987e579f937 |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Apply clang-format
clang-format -i --style=file bta/*/*
(twice)
Test: mma -j32
Change-Id: Ib118b1dfb6a34f9a5bfe153d65841e9041165264
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| f355ef5a4d7fb667fc57a0dfb60f738d870e252e |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Prepare include statements for clang-format
bta: Separate includes of different types
Include "bta_sys.h" in bta/dm/bta_dm_int.h
Test: mma -j32
Change-Id: I292bc6518230201e1175937b9c6766c19709c9d5
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| 8af480e24549ba51a3f6858d9d9af504715e0bea |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Remove double asterisks in comments
Double asterisks at the beginning of the line
sed -i s,"^[*][*]"," *", bta/*/*
Double asterisks after a space
sed -i s,"^ [*][*]\([^*]\)"," *\1", bta/*/*
sed -i s,"^ [*][*]$"," *", bta/*/*
Test: mma -j32
Change-Id: Ib83b802c7000176683b4e7f24d1255b3c2c6c01c
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| d7ffd64accbd50a27289a388856e56244ccbb5da |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (5/5)
Include osi.h for UNUSED_ATTR.
Test: mma -j32
Change-Id: I43260669dc1f54639e46cc9620093d727ee86276
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| d35a648d39710bbc5ac59f8add85166455af5af7 |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (1/5)
Generated automatically with coccinelle
/* This rule matches functions with arguments
* that have an UNUSED(arg) in the body.
*/
@r1@
identifier arg;
identifier fn;
type t;
parameter list[n] P;
@@
fn(P, const t arg) { ...
UNUSED(arg);
...
}
/* This rule removes the UNUSED line, and adds
* UNUSED_ATTR to the parameter list.
*/
@depends on r1@
identifier r1.arg;
identifier r1.fn;
type r1.t;
parameter list[r1.n] r1.P;
typedef UNUSED_ATTR;
@@
fn(P,
- const t arg
+ UNUSED_ATTR GETRIDOFTHISCOMMA, const t arg
) { ...
-UNUSED(arg);
...
}
Test: mma -j32
Change-Id: Idcaadd688d669d484e557becd050e69454508f3c
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|
| b2a292b5d8df2f359c38b0787bc01181225a9bc9 |
|
15-Oct-2016 |
Pavlin Radoslavov <pavlin@google.com> |
Renamed most C files to C++: *.c to *.cc
Also:
- Fixed C++ related compilation errors.
- Added missing 'extern "C"' guards in some of the header files.
- Added missing LOCAL_CPP_EXTENSION to Android.mk files.
- Added-back btif/src/btif_mce.cc and bta/mce/bta_mce_* to
btif/Android.mk and bta/Android.mk respectively.
- Fixed the alphabetical ordering of the *.cc files in some
of the Android.mk files.
- Added missing Copyright header to "osi/include/list.h"
- Updated "osi/src/wakelock.cc" to use C++ std::string
instead of dynamic allocation of C-style strings.
Test: code compilation, unit tests, and A2DP streaming
Change-Id: Ia2f7215ed9df32775c701b68fc86b09875b942c7
/system/bt/bta/hf_client/bta_hf_client_rfc.cc
|