| 9e030fde05352ec4385d7baf6cc2af89e95e039c |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3)
Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/bta/hh/bta_hh_le.cc
|
| 78b81c6db0aed32eb595ce4de7eb22fc24800058 |
|
16-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of bdcpy, bdcmp and other BD_ADDR helpers
Test: compilation test
Change-Id: I37f17bfb3826b59797373645691c61bfbaefdbfd
/system/bt/bta/hh/bta_hh_le.cc
|
| 011a61951975849b23a10d2be87e5268008d3407 |
|
10-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bt_bdaddr_t instead of BD_ADDR in HID related code
Test: compilation test, sl4a GattReadTest
Change-Id: I4e91375746fbd966608a830ff71de79be2b99e6c
/system/bt/bta/hh/bta_hh_le.cc
|
| 378f095217da3e37f23156c53789bb9f760708d2 |
|
13-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Fix HID crashing on no descriptor
Bug: 62461796
Test: compilation test
Change-Id: Ic7b1fcc4b6f3c8680f1810679ed609f2691fa4aa
/system/bt/bta/hh/bta_hh_le.cc
|
| c2276b06572ab6fc1f900fbb1f41087e77d47e2a |
|
10-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bt_bdaddr_t instead of BD_ADDR
Test: compilation test, sl4a GattReadTest
Change-Id: I8d1bd6914aec55bb53495b1d0d5e3d37b86865e6
/system/bt/bta/hh/bta_hh_le.cc
|
| 16bb48b320cde54a1a06a525f4d9be1421689649 |
|
25-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Fix GATT Server disconnecting for no reason
Connections created by GAP profile should be ephemeral, and not
interfere with the connection timeout.
When a device is bonded, listing services through DM would cause a
DM APP to create a connection, and later to disconnect. This causes
connection to timeout. In case a device was already connected, this
should not happen.
Bug: 34951749
Test: manual
Change-Id: Iad04fd9eed4c664f35131442e3f83a704497a067
/system/bt/bta/hh/bta_hh_le.cc
|
| 9e6747537a4a2c0143c26ab31e4597a017372e5f |
|
28-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Add supervision timeout workaround for Nexus Remote
The Nexus Remote would report 100ms supervision timeout in its preferred
connection parameters. In some noisy environments, this might cause
connection to be dropped. As a workaround, set the timeout to 3s for the
remote.
Test: manual
Bug: 36645397
Bug: 37717216
Change-Id: I665a854e9d55067ec1aca273c31d06c6114c48be
/system/bt/bta/hh/bta_hh_le.cc
|
| bdd2f5001ffc7c53f0e38c2a98e393b1855f9ce6 |
|
09-Feb-2017 |
Myles Watson <mylesgw@google.com> |
Clean up some more #defines
true -> TRUE
false -> FALSE
Test: builds
Change-Id: I2573b6ab81aa384cc6d20bb8beb84303aba06a66
/system/bt/bta/hh/bta_hh_le.cc
|
| 221e9bf6c9e9f974efd92ea4f054dbdba248d2db |
|
15-Dec-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
BTA Application registration refactor
This patch replace BTA state machine state associated with registration
of new application, together with BTA_GATTC_API_REG_EVT, and
tBTA_GATTC_API_REG. Instead, it uses closure to post registration task,
and callback for registration event.
Bug: 30622771
Test: sl4a ConcurrentBleAdvertiserTest GattConnectTest
Change-Id: I62d68485170ef5472237d62b285353f2c9bc8250
/system/bt/bta/hh/bta_hh_le.cc
|
| 83211b0ccceb53586ac651a4d67ded7443b2f222 |
|
07-Dec-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of selective connection procedure
Bug: 30622771
Test: compilation test
Change-Id: I1a7e4c49f93f11a350b96ffe7b2e69974ed82f46
/system/bt/bta/hh/bta_hh_le.cc
|
| 33c633ee6e9797e077ae618f223550af74ac1fbe |
|
10-Dec-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Fix UUID comparision when enabling HID protocol mode for LE devices
Change-Id: Ie635b3b763db5da25e58d7366c2438df67438a81
/system/bt/bta/hh/bta_hh_le.cc
|
| b7cfd05e917a4c426d7fa24d6d05ed233421409a |
|
05-Dec-2016 |
Myles Watson <mylesgw@google.com> |
Remove double includes
Test: mma -j32
Change-Id: I0df664eaadf06af0881c1f55c826ecab52239526
/system/bt/bta/hh/bta_hh_le.cc
|
| ecff82227b23befc1ccdbae47880692ca1736ac4 |
|
05-Dec-2016 |
liuchao <liuchao741@huawei.com> |
Remove redundant added bta_hh_find_cb call in read_rpt_clt_cfg
This fixes an redundant call to bta_hh_find_cb to get a bta_hh_index
Test: mm -j 8
Change-Id: I455837d00d992248db8d8432b85227d1f92b3b02
/system/bt/bta/hh/bta_hh_le.cc
|
| f33b6f434f086b20fabe5913016bc423ac975057 |
|
23-Nov-2016 |
Marie Janssen <jamuraa@google.com> |
readability fix: No assigns in if conditionals
Coccinelle-assisted:
@@
variable i;
expression E;
statement S1, S2;
@@
+ i = E;
if (
(
- (i = E)
+ i
!= ...
|
- (i = E)
+ i
== ...
|
- (i = E)
+ i
< ...
|
- (i = E)
+ i
> ...
|
- (i = E)
+ i
<= ...
|
- (i = E)
+ i
>= ...
|
- (i = E)
+ i
)
) S1 else S2
for file in $(find . -name "*.cc"); do
spatch --sp no-if-assigns.cocci --in-place $file
done
clang-format --style=file -i bta/**/*.cc
Test: mma -j37 and basic sanity testing on angler, sailfish
Change-Id: I41a2964afac347c24e13869b6c172e321e646091
/system/bt/bta/hh/bta_hh_le.cc
|
| 1baaae3f34a667058e7f0c5f778357d98320cf38 |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Fix comment formatting after clang-format
Test: mma -j32
Change-Id: Ic945ac421b1918527105c59674eda89afd3d4126
/system/bt/bta/hh/bta_hh_le.cc
|
| cd1fd07f1306e08fe048682dd5918987e579f937 |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Apply clang-format
clang-format -i --style=file bta/*/*
(twice)
Test: mma -j32
Change-Id: Ib118b1dfb6a34f9a5bfe153d65841e9041165264
/system/bt/bta/hh/bta_hh_le.cc
|
| 8af480e24549ba51a3f6858d9d9af504715e0bea |
|
09-Nov-2016 |
Myles Watson <mylesgw@google.com> |
bta: Remove double asterisks in comments
Double asterisks at the beginning of the line
sed -i s,"^[*][*]"," *", bta/*/*
Double asterisks after a space
sed -i s,"^ [*][*]\([^*]\)"," *\1", bta/*/*
sed -i s,"^ [*][*]$"," *", bta/*/*
Test: mma -j32
Change-Id: Ib83b802c7000176683b4e7f24d1255b3c2c6c01c
/system/bt/bta/hh/bta_hh_le.cc
|
| 9e6f5ad992060fe91dbacc302417a30ddf5e7a57 |
|
04-Oct-2016 |
Lawrance Liu <lawrance.liu@mediatek.com> |
Improve HOGP input report error handling
This fixes com.android.bluetooth crash when receiving HOGP input report
for unknown characteristic.
Test: Pair/Unpair BLE mouse/keyboard devices.
/system/bt/bta/hh/bta_hh_le.cc
|
| d7ffd64accbd50a27289a388856e56244ccbb5da |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (5/5)
Include osi.h for UNUSED_ATTR.
Test: mma -j32
Change-Id: I43260669dc1f54639e46cc9620093d727ee86276
/system/bt/bta/hh/bta_hh_le.cc
|
| d35a648d39710bbc5ac59f8add85166455af5af7 |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (1/5)
Generated automatically with coccinelle
/* This rule matches functions with arguments
* that have an UNUSED(arg) in the body.
*/
@r1@
identifier arg;
identifier fn;
type t;
parameter list[n] P;
@@
fn(P, const t arg) { ...
UNUSED(arg);
...
}
/* This rule removes the UNUSED line, and adds
* UNUSED_ATTR to the parameter list.
*/
@depends on r1@
identifier r1.arg;
identifier r1.fn;
type r1.t;
parameter list[r1.n] r1.P;
typedef UNUSED_ATTR;
@@
fn(P,
- const t arg
+ UNUSED_ATTR GETRIDOFTHISCOMMA, const t arg
) { ...
-UNUSED(arg);
...
}
Test: mma -j32
Change-Id: Idcaadd688d669d484e557becd050e69454508f3c
/system/bt/bta/hh/bta_hh_le.cc
|
| d8f09d077d9017a522c17f4b9a49328b0ed3e91e |
|
25-Oct-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Fix random crashes in HID related code
Operation on characteristics/descriptors shouldn't access GATT database
when it's executed. This could happen while service rediscovery is in
progress.
Bug: 32240759
Test: connect to HID device
Change-Id: Ie2b6e6b451456204b1cea1e500df9a0ff949a9ef
/system/bt/bta/hh/bta_hh_le.cc
|
| 96e397a1474b149778078c5205e4c1c7650e2610 |
|
18-Oct-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Use the default LE connection timeout if the remote device has no preference
Change-Id: I03f022b6f18c7d1ec7f139a7d67fd60ec6f15ba2
/system/bt/bta/hh/bta_hh_le.cc
|
| 4689e1e3cb2c4ba5697f25d46f0531f901c59572 |
|
16-Aug-2016 |
IHLHO KIM <ih0923.kim@samsung.com> |
Deregister from notifications when an HOGP background connection is cancelled
Bug: 29111689
Change-Id: I5b57da9e08dea372e9b236b360ffeeae4f6b49af
/system/bt/bta/hh/bta_hh_le.cc
|
| 5e10e74ce324bb445b9188858e61bd2e39133da6 |
|
03-Jun-2016 |
ugo_yu <ugo_yu@htc.com> |
GATT: Deregister notification when a GATT connection is closed
Precondition:
1. Pair with specific HOGP mouse.
Steps:
1. Pair with HOGP mouse (iBuffalo BSMBB09DS)
2. Unpair the mouse.
3. Pair the mouse again.
Failure:
Pairing is successful, but the mouse won't connect.
Root Cause:
Some HOGP mice send notifications before the stack writes the
client characteristic configuration descriptor.
The Bluetooth stack doesn't deregister these notifiactions
when disconnecting.
Fix:
Deregister notifications when the GATT connection closes.
Fixes: 29111689
Change-Id: I520faeaa5fc396381cb248d3a2c49efbffa12261
(cherry picked from commit 7592bcfe7a0be9dc4ffdfc3f29bf68fd68950418)
/system/bt/bta/hh/bta_hh_le.cc
|
| d19e0785e662e640191a075eda07acce61c2aeda |
|
15-Jul-2016 |
Marie Janssen <jamuraa@google.com> |
Use standard types, consistent ifdef style everywhere
Remove the typedefs in stack/include/bt_types.h
Use standard types everywhere.
Use standard style for #if statements:
- #if (VAR_NAME == TRUE)
- #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE)
Use __func__ instead of __FUNCTION__
Fix some debug statements to use __func__
Update script to be less disruptive to aligned assignment blocks.
Change-Id: I8f8f068e6c26ce74fd3b3707e1e31fd0b919cdd0
/system/bt/bta/hh/bta_hh_le.cc
|
| bb920a65b959fbb593403587f89bc3fc7e831732 |
|
22-Jun-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Rmove write type from GATT descriptor writes (4/4)
According to the Bluetooth Core specification v4.2, Vol 3, Part G,
section 4.12.3: "The Attribute Protocol WRITE REQUEST is used
for this sub-procedure".
Change-Id: I60bb0b1489b417af96975265a023c356ace293bd
/system/bt/bta/hh/bta_hh_le.cc
|
| 24ea892320ca85c7f6cdd77343da50818fe29002 |
|
14-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Add callbacks to GATT read/write operation
There is no need for read/write callback to be a global event. It should
execute local callback instead.
Change-Id: Id7e915af9d30092d2f754eddc7c3aed4970eeb2f
/system/bt/bta/hh/bta_hh_le.cc
|
| 3c5451da9db18062af1c19e1f780c1de5bd88b31 |
|
25-Jun-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Simplify GATT characteristic read memory handling
Pass read result in a fixed sized array instead of a pointer.
This eliminates the need for any special memory management in btif.
Change-Id: I2a33d74b12f3059050855c9fc90fff785cc985ba
/system/bt/bta/hh/bta_hh_le.cc
|
| e9e58ced195ec2c983c7723c9cbdabd45eb0f2fd |
|
17-Jun-2016 |
Marie Janssen <jamuraa@google.com> |
bta: use standard types
Use standard types everywhere.
Use standard style for #if statements:
- #if (VAR_NAME == TRUE)
- #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE)
Use __func__ instead of __FUNCTION__
Fix some debug statements to use __func__
Change-Id: Ib86de4de9f14529ecaa4f71597260e3b5785360b
/system/bt/bta/hh/bta_hh_le.cc
|
| 26ecec06be48502eba1c24a6b1fdbb66eafa8032 |
|
27-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Use vector instead of C arrays in bta_gatt_api
This changes are covered in test cases:
GattReadTest.*
GattWriteTest.*
Bug: 28485365
Change-Id: I0bb098b4d5e991ed53d3276ac6f7174723c59444
/system/bt/bta/hh/bta_hh_le.cc
|
| 7c172b7df7d8cd6d0802e87b31fd85b69453e01f |
|
13-Jun-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
HOGP: Clear pending operations for a given device on connect
If there are any HID operations scheduled after disconnect, mark the
device as no longer executing after establishing connection. Otherwise
we'll be unable to send any HID commands to it.
Change-Id: Ie1bb622388a3bcb574dec3dde76ef4518ee1102f
(cherry picked from commit 4362b8c559575a83897a5af55202ce2c1d19925c)
/system/bt/bta/hh/bta_hh_le.cc
|
| 4f7602868052a6316d1237918c1332e6aab8a0b3 |
|
14-Jun-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
HOGP: Preffer write command over write requests
Some HID devices will accept both write request and write command.
Prefer write commands when possible.
This is due to bug in some hardware, that will not send write response
when too many commands are queued.
Bug: 29184976
Change-Id: I5bafc067f044a48f152c60b8e17722067bc1453e
(cherry picked from commit af77225c0d7bec06d2417b0305ebcbab04144caa)
/system/bt/bta/hh/bta_hh_le.cc
|
| b7938c1866dd8b92977e3ba3632de77fd877bace |
|
27-May-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Convert HID and Device Manager BTA code to C++
These are the only places that use BTA GATTC API. After this change it's
possible to change GATT API to use C++ types as arguments.
Bug: 28485365
Change-Id: Idf83396f4bc3a2cc8a9b41f69da5d033af1be678
/system/bt/bta/hh/bta_hh_le.cc
|