| 6de527247e606222d5f600d1d8f37ed7f1581b9f |
|
05-Aug-2017 |
Pavlin Radoslavov <pavlin@google.com> |
Protect the btif config state with a lock during cleanup
am: ecadb0d01d
Change-Id: I279e7a496ec3742b19073a0610953c4a68cd37d1
|
| ecadb0d01d305f717e01d03391e3062fbaa2b42e |
|
04-Aug-2017 |
Pavlin Radoslavov <pavlin@google.com> |
Protect the btif config state with a lock during cleanup
Bug: 64186300
Test: Code compilation, enable/disable Bluetooth
Change-Id: Ic2397a128d59c9cc69cbd8252734b69eb7c02501
(cherry picked from commit a4febd6d0460ee0f5834822ca406a4b8bab28cf1)
/system/bt/btif/src/btif_config.cc
|
| aaa50649b95c0ab2cd84e67fab77596bbb24d095 |
|
04-Jul-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Make RawAddress into a class (1/3)
* Add libbluetooth-types - library containing types implementation, that
is common between stystem/bt and packages/apps/Bluetooth. It must be
included in every project using btif interface.
* Put Raw Address implementation into libbluetooth-types
* Unify all "to/from string" helper methods into ToString and FromString
* bd_addr_empty -> RawAddress::kEmpty
* bd_addr_any -> RawAddress::kAny
Also fix leaks in jni str2addr by adding ReleaseStringUTFChars
Test: types_unittest
Change-Id: Ie0694843ad5fbd2a80b310c5f532e5e5a9548043
/system/bt/btif/src/btif_config.cc
|
| 9e030fde05352ec4385d7baf6cc2af89e95e039c |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3)
Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/btif/src/btif_config.cc
|
| c2276b06572ab6fc1f900fbb1f41087e77d47e2a |
|
10-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bt_bdaddr_t instead of BD_ADDR
Test: compilation test, sl4a GattReadTest
Change-Id: I8d1bd6914aec55bb53495b1d0d5e3d37b86865e6
/system/bt/btif/src/btif_config.cc
|
| f2af1c42ccb2f642b241c2261b42d0be61d45438 |
|
13-Dec-2016 |
Jack He <siyuanh@google.com> |
Replace assert with CHECK from base/logging.h
* Replace assert with CHECK
* Remove all NDEBUG definitions
* Remove hacks for BT_LIBCHROME_NDEBUG
* Removed some removed directories from Makefile such as hcis, brcm, rpc
Coccinelle-assisted:
@@
@@
- #include "base/logging.h"
+ #include <base/logging.h>
@ assert_included @
@@
@ base_logging_included @
@@
@ depends on (assert_included && !(base_logging_included)) @
@@
- #include <assert.h>
+ #include <base/logging.h>
@ depends on (assert_included && base_logging_included) @
@@
- #include <assert.h>
@@
expression E;
@@
- assert(E);
+ CHECK(E);
And a bash script:
for file in $(find . -name "*.cc"); do
spatch --sp-file replace_assert_with_CHECK.cocci --in-place $file
done
The following files are maually edited:
btif/src/btif_config.cc
btif/src/btif_avrcp_audio_track.cc
btif/src/btif_gatt_client.cc
osi/src/data_dispatcher.cc
osi/src/reactor.cc
osi/src/thread.cc
osi/src/fixed_queue.cc
osi/src/list.cc
osi/src/allocation_tracker.cc
osi/src/alarm.cc
osi/test/wakelock_test.cc
Bug: 31781465
Test: Code compilation, Unit Tests, BtStressTest, BtFunhausMetricsTest
Change-Id: I21dc10a45be31665e41441b75b0515ed87523988
/system/bt/btif/src/btif_config.cc
|
| b7cfd05e917a4c426d7fa24d6d05ed233421409a |
|
05-Dec-2016 |
Myles Watson <mylesgw@google.com> |
Remove double includes
Test: mma -j32
Change-Id: I0df664eaadf06af0881c1f55c826ecab52239526
/system/bt/btif/src/btif_config.cc
|
| 6bd442f543972b072ef2cbbcf2f7c91202de1045 |
|
19-Oct-2016 |
Myles Watson <mylesgw@google.com> |
btif: Apply clang-format
clang-format doesn't understand block quotes of this form:
/* This is not handled well
** because there are two asterisks
**/
cd btif/
# Replace '**' at the beginning of the line with ' *'
sed 's/^[*][*]/ \*/' -i include/* src/* test/* co/*
clang-format --style=file -i src/* include/* test/* co/*
Test: mma -j32
Change-Id: I2477eae5480602d5b2fee5ec89c9ed7888022341
/system/bt/btif/src/btif_config.cc
|
| a5764686f719d8d779d8a5ff8cc64010b7893e36 |
|
10-Oct-2016 |
Marie Janssen <jamuraa@google.com> |
btif: migrate from pthread locks to std::mutex
Test: run unit tests / sanity connection to devices
Change-Id: I293c3600affd229fea67cdd6624eba7f186cbcb7
/system/bt/btif/src/btif_config.cc
|
| e909ff50ffae0612fc0434cd2130469868b81ae4 |
|
23-May-2016 |
Jacky Cheung <jackyc@google.com> |
Add BT_HCI_TIMEOUT and BT_CONFIG_SOURCE log events.
These events are used to track HCI timeout and configuration file
usage respectively.
Change-Id: I5c8b6ef20b61f03b9ccb74f3b1c9784e4653b770
/system/bt/btif/src/btif_config.cc
|
| b7f64bc45dec7f7fec74ceb04874f322b9434bbf |
|
22-Jun-2016 |
Marie Janssen <jamuraa@google.com> |
btif: standardize types, #ifs
Use standard types everywhere.
Use standard style for #if statements:
- #if (VAR_NAME == TRUE)
- #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE)
Use __func__ instead of __FUNCTION__
Change-Id: Ic29d1d0b32c3ca9953752a4e5da6c28f45ec8895
/system/bt/btif/src/btif_config.cc
|
| 95dbe03a693f4a920204b8c6acbba5269915a59f |
|
19-May-2016 |
Jacky Cheung <jackyc@google.com> |
Improve config file sync during configuration save.
Add fsync() calls to force sync to disk while saving configuration
file. It is necessary to do a sync on the temp file before rename,
and to sync again on its parent directory to ensure both the
file content and the directory are up-to-date.
Change-Id: I3a862ad59c8ae5beb8ea2c727eb5f275a2d5823e
/system/bt/btif/src/btif_config.cc
|
| f24f5eff41968dda6f97333c9b4c09ec4c5a8597 |
|
13-May-2016 |
Ajay Panicker <apanicke@google.com> |
Add sync to write the backup file to the filesystem
Bug: 27354612
Change-Id: I5a7751b6f08831d43647391774501f211336e9eb
/system/bt/btif/src/btif_config.cc
|
| 72a183d00c7534c80a4deb9fb41d38fd9e9455f6 |
|
12-May-2016 |
Ajay Panicker <apanicke@google.com> |
Add config logging, make parsing stricter, and move sync
The functions that parse the config file will report failure if
the config file is improperly formatted or is missing the necessary
Adapter section. Also moved sync to sync the filesystem after the
config file is saved.
Bug: 27354612
Change-Id: Ia75ff628d83bdc933c4bc16761d6c55eef19b757
/system/bt/btif/src/btif_config.cc
|
| 713993d1784ab7c23aee1fa3cf1ab8676cc0aa69 |
|
21-Apr-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Convert BTIF code from C to C++
Modifications required:
* added proper casting
* moved variable definitions before goto statements
* added 'extern "C"' markers where needed
* renamed 'operator' to 'operator_name'
Bug: 28485365
Change-Id: I903357967387207e678866c02e008f047f8263f6
/system/bt/btif/src/btif_config.cc
|