History log of /system/bt/btif/src/btif_gatt_server.cc
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
9e030fde05352ec4385d7baf6cc2af89e95e039c 25-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Rename bt_bdaddr_t into RawAddress (3/3)

Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/btif/src/btif_gatt_server.cc
96ac0a3c16a4a9f98169baf158bae16528cde79b 21-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Use references in GATT client/server API (2/3)

This allows to get rid of some unnecessary null checks, and guarantee
proper values are passed.

Test: compilation test
Change-Id: I1b790dba0cfc3ab02984c3911d83a6f413a1e7e6
/system/bt/btif/src/btif_gatt_server.cc
73ed5d2f655b3c591be3a0df9498b90bb100fd8c 20-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Make GATT client and server assumption about addres type in open identical

When attempting to open GATT server to device of unknown type, it should
make same assumption about the type as GATT client, which is LE device.

Test: compilation test
Bug: 62827460
Change-Id: Ic96de97445a843ef3c482fd5b54098b325fb0f9c
/system/bt/btif/src/btif_gatt_server.cc
5a475e71a01322367a2ba591aecd62781902cfc2 13-Apr-2017 Avish Shah <avish.shah@broadcom.com> Bluetooth 5: Update LE2M implementation through DM (3/3)

This patch moves LE2M implementation to the DM instead of tied to GATT.

Below are the reasons to make this change:
1) Per link setting usually be done under DM, such as link policy etc.
2) In the future, if LECOC is coming to use in more profile/apps,
we can not rely on GATT API for these. Separate API should be required.
3) we could have multiple logical GATT user on top of the same link.
4) Also this will avoid duplicating all the APIs on GATTC and GATTS.

Bug: 37586939
Test: sl4a PhyTest passed
Change-Id: I7330be85d1bb98a4cc66b69462b01c23c9375362
/system/bt/btif/src/btif_gatt_server.cc
c2276b06572ab6fc1f900fbb1f41087e77d47e2a 10-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Use bt_bdaddr_t instead of BD_ADDR

Test: compilation test, sl4a GattReadTest
Change-Id: I8d1bd6914aec55bb53495b1d0d5e3d37b86865e6
/system/bt/btif/src/btif_gatt_server.cc
b5ba4fdbc433544de3806f8e82976898e444b491 24-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Expose connection update callback (1/3)

Test: manual
Bug: 30622771
Change-Id: I94d25f6f22b42fb1432a9288c97b82503d57db86
/system/bt/btif/src/btif_gatt_server.cc
eafd45d08653bb1621c82a2f3cf922a43a0b1bc5 23-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Set preferred PHY and read PHY implementation (3/3)

Test: manual
Bug: 30622771
Change-Id: I4267238a0b5c7bc373ae1846ebd19a716881a4ec
/system/bt/btif/src/btif_gatt_server.cc
96ad0d2596ce468fa8ef6fa74c822124c845e7b2 17-Feb-2017 Jakub Pawlowski <jpawlowski@google.com> Remove unnecessary extern declarations

Test: manual
Change-Id: I21bdb5952fff359a9ee7091d740ecac13aad640a
/system/bt/btif/src/btif_gatt_server.cc
c176ff364e12bc9fd9a09b83a4a4bed9bd818144 13-Jan-2017 IHLHO KIM <ih0923.kim@samsung.com> Fix the GATT server and HOGP disconnect

GATT server disconnect and HOGP disconnect are not working after the
following commit: a62adcab30929566b435891611232566bd69204a.

‘BTA_GATTS_CancelOpen’ makes ‘gatt_update_app_hold_link_status’
return FALSE value. As a result, ‘BTA_GATTS_Close’ cannot disconnect
the link. The sequence has to be changed like GATT client.

And the above mentioned fix removed ‘found’ checking routine in
‘gatt_update_app_hold_link_status’.

It makes two app hold links with same gatt_if when HOGP is connected and
background connection is added. But HOGP disconnect removes only one held
link. So HOGP is never disconnected.

The ‘found’ checking routine has to be rolled back.

Test: manual
Change-Id: Ibea825b5cc844195f0cf4a30cbcca831880c9088
/system/bt/btif/src/btif_gatt_server.cc
33f424d493adcf7c0cff38bfb87ddcbe8ddff74a 19-Jan-2017 Jakub Pawlowski <jpawlowski@google.com> Fix bad UUID comparison when adding GATT service

This patch fixes bad comparison in add_service_impl. Instead of checking
wether service is one of two excluded services, it was excluding all
services.

Test: sl4a GatReadTest
Bug: 34280184
Change-Id: I3195e94b6fafe4d2e3c61fc7bfd7398c2855b78e
/system/bt/btif/src/btif_gatt_server.cc
8a06ff5ce2d73c06411c22f97056f3ae8f0b9b04 16-Jan-2017 Jakub Pawlowski <jpawlowski@google.com> Don't allow GATT and GAP service override

Those services are automatically added by the stack, and overriding them
results in invalid GATT database being created.

Bug: 34280184
Test: Manual test
Change-Id: Ie6a09e9d606e40066bef6f6a2c934eacd17bf53b
/system/bt/btif/src/btif_gatt_server.cc
83211b0ccceb53586ac651a4d67ded7443b2f222 07-Dec-2016 Jakub Pawlowski <jpawlowski@google.com> Get rid of selective connection procedure

Bug: 30622771
Test: compilation test
Change-Id: I1a7e4c49f93f11a350b96ffe7b2e69974ed82f46
/system/bt/btif/src/btif_gatt_server.cc
ee96a3c60fca590d38025925c072d264e06493c4 23-Nov-2016 Myles Watson <mylesgw@google.com> Fix asterisks in block quotes

Remove double asterisks from block quotes.

git grep -lP '^[*][*]' | xargs sed 's/^[*][*]/ \*/' -i

Fix asterisk line lengths

git grep -l '^[ /][*]\{79,\}[*/]' | \
xargs sed -i s,"^\([ /]\)[*]\([*]\{78\}\)[*]*\([*/]\)","\1\2\3",

Test: mma -j32
Change-Id: Ie3fd375ac2f804cb0f53bf1314a005e85973b3d7
/system/bt/btif/src/btif_gatt_server.cc
9008888d24407541aa383aa4bd363a40abbf954b 16-Nov-2016 Myles Watson <mylesgw@google.com> Fix formatting after removing defines

clang-format -i --style=file bta/*/* btif/*/* include/*

Test: mma -j32
Change-Id: I9ebb32f0cc5bd24a7cb2ae25699999aab5036b13
/system/bt/btif/src/btif_gatt_server.cc
84baa7f16e830394408278dbb8c508dd9fa02887 14-Nov-2016 Myles Watson <mylesgw@google.com> Remove BLE_INCLUDED define

Test: Connect to a BLE Keyboard
Change-Id: I5f8f4017c90c3c404004632fd10e6c2b93bd7783
/system/bt/btif/src/btif_gatt_server.cc
40cde56d28ab9751ba76bded0b7ac5974c750a97 21-Oct-2016 Myles Watson <mylesgw@google.com> btif: Add do-while blocks to macros

Test: mma -j32
Change-Id: Ie82465b8cef6c4f527fad13892abb365e15dad7c
/system/bt/btif/src/btif_gatt_server.cc
6bd442f543972b072ef2cbbcf2f7c91202de1045 19-Oct-2016 Myles Watson <mylesgw@google.com> btif: Apply clang-format

clang-format doesn't understand block quotes of this form:

/* This is not handled well
** because there are two asterisks
**/

cd btif/

# Replace '**' at the beginning of the line with ' *'

sed 's/^[*][*]/ \*/' -i include/* src/* test/* co/*
clang-format --style=file -i src/* include/* test/* co/*

Test: mma -j32
Change-Id: I2477eae5480602d5b2fee5ec89c9ed7888022341
/system/bt/btif/src/btif_gatt_server.cc
a641b6fa2a25e1b5382945d13c4fa49d36084a78 26-Mar-2016 Jakub Pawlowski <jpawlowski@google.com> GATT Server refactoring (4/4)

Right now in order to add gatt service, we need to add it piece by
piece - each characteristic and descriptor separately. This causes lots
of concurrency errors in higher layers. Instead accept whole service
definition and start whole service at once.

Also, use handles to identify GATT server attributes. It's already done
on clinet side.

Bug: 27999121
Change-Id: I42c796809423d116fe6755ef8b1c40da270427a5
/system/bt/btif/src/btif_gatt_server.cc
b7f64bc45dec7f7fec74ceb04874f322b9434bbf 22-Jun-2016 Marie Janssen <jamuraa@google.com> btif: standardize types, #ifs

Use standard types everywhere.
Use standard style for #if statements:
- #if (VAR_NAME == TRUE)
- #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE)
Use __func__ instead of __FUNCTION__

Change-Id: Ic29d1d0b32c3ca9953752a4e5da6c28f45ec8895
/system/bt/btif/src/btif_gatt_server.cc
16102de0866a51b523143b681e72db8e0ff441c4 31-May-2016 Jakub Pawlowski <jpawlowski@google.com> Vectors as parameters to GATT (1/3)

Bug: 29005882
Bug: 28485365
Change-Id: I0a5041073a39977c4fbc29879c383fa6720da641
/system/bt/btif/src/btif_gatt_server.cc
ec79baaaed83529dae14d492ea2f73aedee9e4d0 28-May-2016 Jakub Pawlowski <jpawlowski@google.com> Vectors as parameters to GATT write/indicate (1/3)

This changes are covered in test cases:
GattReadTest.*
GattWriteTest.*

Bug: 29005882
Bug: 28485365
Change-Id: I1409e6ead22ff691190f9ea4c3ffe2267bd3bf33
/system/bt/btif/src/btif_gatt_server.cc
26ecec06be48502eba1c24a6b1fdbb66eafa8032 27-May-2016 Jakub Pawlowski <jpawlowski@google.com> Use vector instead of C arrays in bta_gatt_api

This changes are covered in test cases:
GattReadTest.*
GattWriteTest.*

Bug: 28485365
Change-Id: I0bb098b4d5e991ed53d3276ac6f7174723c59444
/system/bt/btif/src/btif_gatt_server.cc
aa39d20a60a56a1528af0ed726e2effa90e08fb5 13-May-2016 Jakub Pawlowski <jpawlowski@google.com> Build fix for feldspar-dev

Bug: 28485365
Change-Id: I25db2fe7577e98715eb10e105176c536fddb043a
/system/bt/btif/src/btif_gatt_server.cc
d71bc1732fc0ed095a95dd625ff4080a0a1b44f3 05-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rewrite btif_gatts_register_app to new style

Bug: 28485365
Change-Id: I5b9bd5a807492b254a5486c80dfb56769e95943f
/system/bt/btif/src/btif_gatt_server.cc
3c79a3b7caf12d9b182afc2da071be3a5615a0dd 05-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rewrite btif_gatts_open to new style

Bug: 28485365
Change-Id: I20fdb5ffe6d52db291e9862f7e24fb43e060950f
/system/bt/btif/src/btif_gatt_server.cc
b333ae2e69d652b42a7c02500f35ec781df4178c 05-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rewrite btif_gatts_close to new style

Bug: 28485365
Change-Id: Ib8d7ed81cf958ab3dd5403c46409cbd506ac3dc1
/system/bt/btif/src/btif_gatt_server.cc
0cd448fe8f7bf57bb1530d0216b2e18e322e3b3c 05-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rewrite btif_gatts_add_included_service to new style

Bug: 28485365
Change-Id: I4465493532578942045b979e542608972c5fa2ec
/system/bt/btif/src/btif_gatt_server.cc
b14f76be6e859a796d64d083b78e6816f415de20 05-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rewrite btif_gatts_start_service to new style

Bug: 28485365
Change-Id: I2c8b02ce42fd2bde3a4c448f6fb19ef8e3eb169a
/system/bt/btif/src/btif_gatt_server.cc
7ce14cc65ea3796da3e12811e7bc07b529a2f9fa 05-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rewrite btif_gatts_stop_service to new style

Bug: 28485365
Change-Id: I79aaaa57139dca373fdf7c0424353cd5de0cb48f
/system/bt/btif/src/btif_gatt_server.cc
858cf9468bb402ddf806087461aed5f4ea865f6b 05-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rewrite btif_gatts_send_indication to new style

Bug: 28485365
Change-Id: I1d3221be272e53245e09077dad9d291829350b45
/system/bt/btif/src/btif_gatt_server.cc
757109e31404689f1769522637425bcc11edc074 05-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rewrite btif_gatts_send_response to new style

Bug: 28485365
Change-Id: Id0dbfe28b0f77f542cd6961c041e70f90d0aa78b
/system/bt/btif/src/btif_gatt_server.cc
713993d1784ab7c23aee1fa3cf1ab8676cc0aa69 21-Apr-2016 Jakub Pawlowski <jpawlowski@google.com> Convert BTIF code from C to C++

Modifications required:
* added proper casting
* moved variable definitions before goto statements
* added 'extern "C"' markers where needed
* renamed 'operator' to 'operator_name'

Bug: 28485365
Change-Id: I903357967387207e678866c02e008f047f8263f6
/system/bt/btif/src/btif_gatt_server.cc