eb50aa96ca050bb76636401f81965df12be7e21b |
|
15-Sep-2017 |
Jack He <siyuanh@google.com> |
Clean-up BTIF profile queue on profile shutdown * Add btif_profile_cleanup(uuid) method to remove pending connection requests for individual UUIDs * Call the above method in each profile's clean-up method * Add unit tests for btif_profile_queue Bug: 63790458 Test: make, unit tests, pair and connect car kits Change-Id: I28288c295b7ca0259b2112c11b4e5a81d6f2e33c (cherry picked from commit d366807102bce97e494e83570d757ebcb6a33b3c)
/system/bt/btif/src/btif_profile_queue.cc
|
45ffde121d2803483418c84a1b16240b5964670b |
|
30-Aug-2017 |
Jack He <siyuanh@google.com> |
BTIF: Add meaningful logging to btif_profile_queue * Add INFO logging to add/advance/execute functions in btif_profile_queue * Add ERROR logging to add failures Bug: 65051171 Test: Try connection to multiple profiles Change-Id: I058ad06a45eeceb4d160af472f317d08843ca6bf (cherry picked from commit f42cf2b48f4c73fa2e6e6511b20d98a9ab665a7e)
/system/bt/btif/src/btif_profile_queue.cc
|
5f6ecfac764e2fd95fe266b2c25f9fafa4a4e405 |
|
15-Aug-2017 |
Jack He <siyuanh@google.com> |
Fix errors in handling RawAddresses * In change I8d1bd6914aec55bb53495b1d0d5e3d37b86865e6 memcmp(a, b, LEN) != 0 should be translated to A != B * memcpy should not be applied to RawAddress objects. Assignment operator should be used instead. * memset should not be applied to RawAddress objects. Assignment to RawAddress::kEmpty should be used. * Fixed a crash in GATT Bug: 64316340 Test: Unit test, pair with device and transmit Change-Id: Iceefab821c1d45a88194d87a43a192afa5f263fd (cherry picked from commit 882aec320e88b0860a3d53db828bb099c7ca2409)
/system/bt/btif/src/btif_profile_queue.cc
|
9e030fde05352ec4385d7baf6cc2af89e95e039c |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3) Test: compilation test Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/btif/src/btif_profile_queue.cc
|
f2af1c42ccb2f642b241c2261b42d0be61d45438 |
|
13-Dec-2016 |
Jack He <siyuanh@google.com> |
Replace assert with CHECK from base/logging.h * Replace assert with CHECK * Remove all NDEBUG definitions * Remove hacks for BT_LIBCHROME_NDEBUG * Removed some removed directories from Makefile such as hcis, brcm, rpc Coccinelle-assisted: @@ @@ - #include "base/logging.h" + #include <base/logging.h> @ assert_included @ @@ @ base_logging_included @ @@ @ depends on (assert_included && !(base_logging_included)) @ @@ - #include <assert.h> + #include <base/logging.h> @ depends on (assert_included && base_logging_included) @ @@ - #include <assert.h> @@ expression E; @@ - assert(E); + CHECK(E); And a bash script: for file in $(find . -name "*.cc"); do spatch --sp-file replace_assert_with_CHECK.cocci --in-place $file done The following files are maually edited: btif/src/btif_config.cc btif/src/btif_avrcp_audio_track.cc btif/src/btif_gatt_client.cc osi/src/data_dispatcher.cc osi/src/reactor.cc osi/src/thread.cc osi/src/fixed_queue.cc osi/src/list.cc osi/src/allocation_tracker.cc osi/src/alarm.cc osi/test/wakelock_test.cc Bug: 31781465 Test: Code compilation, Unit Tests, BtStressTest, BtFunhausMetricsTest Change-Id: I21dc10a45be31665e41441b75b0515ed87523988
/system/bt/btif/src/btif_profile_queue.cc
|
6bd442f543972b072ef2cbbcf2f7c91202de1045 |
|
19-Oct-2016 |
Myles Watson <mylesgw@google.com> |
btif: Apply clang-format clang-format doesn't understand block quotes of this form: /* This is not handled well ** because there are two asterisks **/ cd btif/ # Replace '**' at the beginning of the line with ' *' sed 's/^[*][*]/ \*/' -i include/* src/* test/* co/* clang-format --style=file -i src/* include/* test/* co/* Test: mma -j32 Change-Id: I2477eae5480602d5b2fee5ec89c9ed7888022341
/system/bt/btif/src/btif_profile_queue.cc
|
b7f64bc45dec7f7fec74ceb04874f322b9434bbf |
|
22-Jun-2016 |
Marie Janssen <jamuraa@google.com> |
btif: standardize types, #ifs Use standard types everywhere. Use standard style for #if statements: - #if (VAR_NAME == TRUE) - #if (VAR_NAME1 == TRUE && VAR_NAME2 == TRUE) Use __func__ instead of __FUNCTION__ Change-Id: Ic29d1d0b32c3ca9953752a4e5da6c28f45ec8895
/system/bt/btif/src/btif_profile_queue.cc
|
713993d1784ab7c23aee1fa3cf1ab8676cc0aa69 |
|
21-Apr-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Convert BTIF code from C to C++ Modifications required: * added proper casting * moved variable definitions before goto statements * added 'extern "C"' markers where needed * renamed 'operator' to 'operator_name' Bug: 28485365 Change-Id: I903357967387207e678866c02e008f047f8263f6
/system/bt/btif/src/btif_profile_queue.cc
|