| ec728d3136aabcd7675aba4a672d932e0709c509 |
|
21-Mar-2017 |
Myles Watson <mylesgw@google.com> |
hci: Update error messages
Test: builds
Change-Id: I33544572122a166523a40dde090f276b102df247
/system/bt/hci/src/btsnoop_net.cc
|
| f2af1c42ccb2f642b241c2261b42d0be61d45438 |
|
13-Dec-2016 |
Jack He <siyuanh@google.com> |
Replace assert with CHECK from base/logging.h
* Replace assert with CHECK
* Remove all NDEBUG definitions
* Remove hacks for BT_LIBCHROME_NDEBUG
* Removed some removed directories from Makefile such as hcis, brcm, rpc
Coccinelle-assisted:
@@
@@
- #include "base/logging.h"
+ #include <base/logging.h>
@ assert_included @
@@
@ base_logging_included @
@@
@ depends on (assert_included && !(base_logging_included)) @
@@
- #include <assert.h>
+ #include <base/logging.h>
@ depends on (assert_included && base_logging_included) @
@@
- #include <assert.h>
@@
expression E;
@@
- assert(E);
+ CHECK(E);
And a bash script:
for file in $(find . -name "*.cc"); do
spatch --sp-file replace_assert_with_CHECK.cocci --in-place $file
done
The following files are maually edited:
btif/src/btif_config.cc
btif/src/btif_avrcp_audio_track.cc
btif/src/btif_gatt_client.cc
osi/src/data_dispatcher.cc
osi/src/reactor.cc
osi/src/thread.cc
osi/src/fixed_queue.cc
osi/src/list.cc
osi/src/allocation_tracker.cc
osi/src/alarm.cc
osi/test/wakelock_test.cc
Bug: 31781465
Test: Code compilation, Unit Tests, BtStressTest, BtFunhausMetricsTest
Change-Id: I21dc10a45be31665e41441b75b0515ed87523988
/system/bt/hci/src/btsnoop_net.cc
|
| 21da63773cb7734e699a4dad662b5b84d2f3dfa8 |
|
03-Nov-2016 |
Marie Janssen <jamuraa@google.com> |
Replace pthread_mutex with std::mutex
In an effort to simplify and reduce errors, replace pthread_mutexes
with std equivalents.
Test: run unit tests & manual sanity checks
Change-Id: I5c33e0b4f4c85133ae4f7415cd19372fc4c7ca1a
/system/bt/hci/src/btsnoop_net.cc
|
| dbf75f1762c91ec93179b8d630acbd2e3f9d3dd4 |
|
08-Nov-2016 |
Pavlin Radoslavov <pavlin@google.com> |
Revert "Replace pthread_mutex with std::mutex"
This reverts commit 4b801825bd90b826fb53d51f497aba87d6d00d8c.
Change-Id: I862272c682409778dce356c8cba497ea4b78b14d
/system/bt/hci/src/btsnoop_net.cc
|
| 4b801825bd90b826fb53d51f497aba87d6d00d8c |
|
03-Nov-2016 |
Marie Janssen <jamuraa@google.com> |
Replace pthread_mutex with std::mutex
In an effort to simplify and reduce errors, replace pthread_mutexes
with std equivalents.
Test: run unit tests & manual sanity checks
Change-Id: Ia6492b0007dca311ebd1579f52b206993b7535fd
/system/bt/hci/src/btsnoop_net.cc
|
| 29483137606d358f72ee544127ec8d052afe0ab0 |
|
31-Oct-2016 |
Myles Watson <mylesgw@google.com> |
hci: Fix multi-line comments after clang-format
Test: mma -j32
Change-Id: I041856c2a9f17948650387dd9c952365bcca033d
/system/bt/hci/src/btsnoop_net.cc
|
| 5ff20a23661695abb1cff6d01d71a8cad4cc7890 |
|
31-Oct-2016 |
Myles Watson <mylesgw@google.com> |
hci: Apply clang-format
Remove double asterisks:
cd hci/
find . | grep "\.cc\|\.h\|\.c" | \
xargs -I REPLACE sed 's/^[*][*]/ \*/' -i REPLACE
Run clang-format:
find . | grep "\.cc\|\.h\|\.c" | xargs -I REPLACE \
clang-format --style=file -i REPLACE
Test: mma -j32
Change-Id: Ie74244127c8a264dd087d199155274d4655ccf65
/system/bt/hci/src/btsnoop_net.cc
|
| b2a292b5d8df2f359c38b0787bc01181225a9bc9 |
|
15-Oct-2016 |
Pavlin Radoslavov <pavlin@google.com> |
Renamed most C files to C++: *.c to *.cc
Also:
- Fixed C++ related compilation errors.
- Added missing 'extern "C"' guards in some of the header files.
- Added missing LOCAL_CPP_EXTENSION to Android.mk files.
- Added-back btif/src/btif_mce.cc and bta/mce/bta_mce_* to
btif/Android.mk and bta/Android.mk respectively.
- Fixed the alphabetical ordering of the *.cc files in some
of the Android.mk files.
- Added missing Copyright header to "osi/include/list.h"
- Updated "osi/src/wakelock.cc" to use C++ std::string
instead of dynamic allocation of C-style strings.
Test: code compilation, unit tests, and A2DP streaming
Change-Id: Ia2f7215ed9df32775c701b68fc86b09875b942c7
/system/bt/hci/src/btsnoop_net.cc
|