History log of /system/bt/service/hal/bluetooth_gatt_interface.cc
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
9e030fde05352ec4385d7baf6cc2af89e95e039c 25-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Rename bt_bdaddr_t into RawAddress (3/3)

Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/service/hal/bluetooth_gatt_interface.cc
96ac0a3c16a4a9f98169baf158bae16528cde79b 21-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Use references in GATT client/server API (2/3)

This allows to get rid of some unnecessary null checks, and guarantee
proper values are passed.

Test: compilation test
Change-Id: I1b790dba0cfc3ab02984c3911d83a6f413a1e7e6
/system/bt/service/hal/bluetooth_gatt_interface.cc
b5ba4fdbc433544de3806f8e82976898e444b491 24-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Expose connection update callback (1/3)

Test: manual
Bug: 30622771
Change-Id: I94d25f6f22b42fb1432a9288c97b82503d57db86
/system/bt/service/hal/bluetooth_gatt_interface.cc
eafd45d08653bb1621c82a2f3cf922a43a0b1bc5 23-Mar-2017 Jakub Pawlowski <jpawlowski@google.com> Set preferred PHY and read PHY implementation (3/3)

Test: manual
Bug: 30622771
Change-Id: I4267238a0b5c7bc373ae1846ebd19a716881a4ec
/system/bt/service/hal/bluetooth_gatt_interface.cc
119f32a7e85801f15c30dd5e874dc4bff0311d54 16-Feb-2017 Jakub Pawlowski <jpawlowski@google.com> Use base::Callbacks in BleScannerInterface (2/3)

The remaining four native callbacks need more internal refactoring
before they can be turned into a callbacks.

Bug: 30622771
Test: sl4a FilteringTest

Change-Id: I8e1532bdfa2b0f22545f095eb427fd5ac1a75b56
/system/bt/service/hal/bluetooth_gatt_interface.cc
7de0f9b78fb38fcb02cbcd3c1c7c005947b9e291 27-Jan-2017 Jakub Pawlowski <jpawlowski@google.com> Propagate BT5 specific scan result properties up the stack (2/3)

Bug: 30622771
Test: sl4a FilteringTest
Change-Id: Ib9d18ea3a1fc7d95300415a04b551d66767b04d2
/system/bt/service/hal/bluetooth_gatt_interface.cc
83f1d967df168f862cf733cabbab76f7c52587f4 14-Dec-2016 Jakub Pawlowski <jpawlowski@google.com> Refactor LE scanning HAL (2/3)

This patch converts btgatt_scanner_interface_t struct into
BleScannerInterface class. It also refactors three most important
methods from this interface: RegisterAdvertiser, Scan, and Unregister.
Rest of this interface will be updated in following patches.

Bug: 30622771
Test: sl4a BleScanApiTest
Change-Id: Ie35356f6c3c4f5488514ef55a48a32c93fb21b83
/system/bt/service/hal/bluetooth_gatt_interface.cc
b324a8d0b719065cec10379ad6855852724d9004 10-Dec-2016 Pavlin Radoslavov <pavlin@google.com> Replace usage of "vector<>" with "std::vector<>"

This change is needed so we can remove the last instances
of "using std::vector" statements in hardware/libhardware.

Test: code compilation
Change-Id: I6a9fc62152371d1bba6ead71e7ff8c2610799637
/system/bt/service/hal/bluetooth_gatt_interface.cc
911d1ae03efec2d54c3b1b605589d790d1745488 29-Nov-2016 Myles Watson <mylesgw@google.com> Apply clang-format to the rest of the tree

find * | grep "\.[ch]" | xargs clang-format --style=file -i

Test: mma -j32
Change-Id: I6fcc9862bb7bc07c2a367ca58fef2b3cd27a6f05
/system/bt/service/hal/bluetooth_gatt_interface.cc
1f60d2def863f5c58c731f2db6f29f9c1ee5af6f 22-Nov-2016 Jack He <siyuanh@google.com> Fix x86_64 compilation on Ubuntu 14.04

* Add necessary includes in bt_trace.h
* Add toolchain specific configs
* Add libc++ import for clang
* Add libc++abi include for clang
* Add ipc_handler_linux.cc in service/BUILD.gn
* Use shared_mutex when _LIBCPP_VERSION < 3500
* Updated the build instructions

Test: ninja -C out/Default
Change-Id: I362ebf33f62910be817339cc6bdc62830f57db30
/system/bt/service/hal/bluetooth_gatt_interface.cc
a8d73ef2f3d2c9b344162cb15e9dd054c28761de 31-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Move start advertise method to advertising interface (3/3)

Advertising related code should be exposed through
BleAdvertiserInterface. Move client.listen function into this interface.
Remove reduntant clientif parameter.

Bug: 30622771
Bug: 24099160
Test: no tests necessary
Change-Id: Icc865c062e3d7c4b83bbeea6ff5b08bd2c1c4d9a
/system/bt/service/hal/bluetooth_gatt_interface.cc
c3f6a51615c4f26bce0b8b6e16757610dbd0b45b 27-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Separate LE scanner and GATT client BTIF interfaces (3/3)

In order to properly separate low level structures associated with LE
scanner and GATT client, their interfaces must be separated first.

Test: sl4a BleScanApiTest
Bug: 30622771
Change-Id: If804632c8e4b08fd15d5b847c7838822cf98d79f
/system/bt/service/hal/bluetooth_gatt_interface.cc
f3246f1c563391b7415f0e2bf881c99bdc535df7 27-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Separate LE scanner from GATT client (4/4)

Right now, LE scanning functionality is combined with the GATT client.
This is the source of various bugs, like scans suddenly stoppinging when
a GATT client is killed. It also increases memory consumption, because
we associate many structures with a GATT client, which are not necessary
when just scanning.

Test: sl4a BleScanApiTest ConcurrentBleScanTest
Bug: 30622771
Change-Id: I23b71255c459b185257654f68ea251b41ed2a14b
/system/bt/service/hal/bluetooth_gatt_interface.cc
74ef54b440dc50bb25f587783d80fe5a37070e4a 07-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Convert advertising HAL from struct into class (3/3)

Bug: 30622771
Test: all related tests were updated
Change-Id: I9695284ae249fa427ae4b2f3e9649da951102c6c
/system/bt/service/hal/bluetooth_gatt_interface.cc
10c37e63c1a20ee6c86d829ce6268c2b3603b747 15-Sep-2016 Jakub Pawlowski <jpawlowski@google.com> Don't use move in FOR_EACH_* macro

FOR_EACH_* macros are resolved to for loop. Using std::move inside it
will cause already moved object to be used when more than one observer
is registered. This patch fixes that.

This issue was already fixed in commit e84c4bd, but was reintroduced in
a641b6fa.

Change-Id: I14b72371d369e4bdcaf3a6e30045bf8a1e8c3e1b
/system/bt/service/hal/bluetooth_gatt_interface.cc
73679d01c70fe84921fc4718e99d4b02af8cc5a9 18-Aug-2016 Jakub Pawlowski <jpawlowski@google.com> Bluetooth: split setting params and enabling advertising (3/3)

Proper order of commands when starting advertising:
* set parameters
* set data
* enable advertising

This cannot be achieved when setting advertising parameters and enabling
advertising is put together in one function. Enabling before setting
data might cause first advertisements to be empty. If a device with
hardware filter pick up such advertisement, it might fail to properly
recognize our device.

Bug: 30622771
Bug: 19372779
Change-Id: I3a2c1171e301ecfd7cbf1cb8b86cfda0e5fc2382
/system/bt/service/hal/bluetooth_gatt_interface.cc
67d5a2523314d9757b2472c3e828dbc1015df4fe 13-Jul-2016 Jakub Pawlowski <jpawlowski@google.com> Separate advertiser from GATT client (4/4)

Bug: 30622771
Change-Id: I761f0bff09aec1047bd512915960021e4fbdc0c8
/system/bt/service/hal/bluetooth_gatt_interface.cc
5dc0d15e7865104d13be75c06de4b9158ce7dff4 17-Aug-2016 Chih-Hung Hsieh <chh@google.com> Fix clang-tidy warnings in bt.

* Add explicit keyword to conversion constructors,
or add NOLINT to implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters,
or add NOLINT to keep same callback function signature.
Bug: 30407689
* Use const reference type for loop index variables to avoid unnecessary copy.
Bug: 30413223
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1

Change-Id: I8237d332f32d7be09ab72a8de82160fdb776dcd1
/system/bt/service/hal/bluetooth_gatt_interface.cc
a641b6fa2a25e1b5382945d13c4fa49d36084a78 26-Mar-2016 Jakub Pawlowski <jpawlowski@google.com> GATT Server refactoring (4/4)

Right now in order to add gatt service, we need to add it piece by
piece - each characteristic and descriptor separately. This causes lots
of concurrency errors in higher layers. Instead accept whole service
definition and start whole service at once.

Also, use handles to identify GATT server attributes. It's already done
on clinet side.

Bug: 27999121
Change-Id: I42c796809423d116fe6755ef8b1c40da270427a5
/system/bt/service/hal/bluetooth_gatt_interface.cc
e84c4bdb5f9d1459af06c558ff1636383fcacbfe 20-Jul-2016 Jakub Pawlowski <jpawlowski@google.com> Don't use move in FOR_EACH_* macro

FOR_EACH_* macros are resolved to for loop. Using std::move inside it
will cause already moved object to be used when more than one observer
is registered. This patch fixes that.

Change-Id: Iaaa314f5eeed4094d1e0fc951d3664fb1514ba15
/system/bt/service/hal/bluetooth_gatt_interface.cc
16102de0866a51b523143b681e72db8e0ff441c4 31-May-2016 Jakub Pawlowski <jpawlowski@google.com> Vectors as parameters to GATT (1/3)

Bug: 29005882
Bug: 28485365
Change-Id: I0a5041073a39977c4fbc29879c383fa6720da641
/system/bt/service/hal/bluetooth_gatt_interface.cc
e6d1202990e0ede65db4470b4eaa20fc4b1f791e 12-May-2016 Jakub Pawlowski <jpawlowski@google.com> Rename all *.cpp files to *.cc to follow new style

Change-Id: Ia79ee09348e67ff4a1712ee11a1e8480180a2623
/system/bt/service/hal/bluetooth_gatt_interface.cc