History log of /system/bt/service/hal/bluetooth_gatt_interface.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
9e030fde05352ec4385d7baf6cc2af89e95e039c 25-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Rename bt_bdaddr_t into RawAddress (3/3)

Test: compilation test
Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/service/hal/bluetooth_gatt_interface.h
96ac0a3c16a4a9f98169baf158bae16528cde79b 21-Jun-2017 Jakub Pawlowski <jpawlowski@google.com> Use references in GATT client/server API (2/3)

This allows to get rid of some unnecessary null checks, and guarantee
proper values are passed.

Test: compilation test
Change-Id: I1b790dba0cfc3ab02984c3911d83a6f413a1e7e6
/system/bt/service/hal/bluetooth_gatt_interface.h
83f1d967df168f862cf733cabbab76f7c52587f4 14-Dec-2016 Jakub Pawlowski <jpawlowski@google.com> Refactor LE scanning HAL (2/3)

This patch converts btgatt_scanner_interface_t struct into
BleScannerInterface class. It also refactors three most important
methods from this interface: RegisterAdvertiser, Scan, and Unregister.
Rest of this interface will be updated in following patches.

Bug: 30622771
Test: sl4a BleScanApiTest
Change-Id: Ie35356f6c3c4f5488514ef55a48a32c93fb21b83
/system/bt/service/hal/bluetooth_gatt_interface.h
b324a8d0b719065cec10379ad6855852724d9004 10-Dec-2016 Pavlin Radoslavov <pavlin@google.com> Replace usage of "vector<>" with "std::vector<>"

This change is needed so we can remove the last instances
of "using std::vector" statements in hardware/libhardware.

Test: code compilation
Change-Id: I6a9fc62152371d1bba6ead71e7ff8c2610799637
/system/bt/service/hal/bluetooth_gatt_interface.h
911d1ae03efec2d54c3b1b605589d790d1745488 29-Nov-2016 Myles Watson <mylesgw@google.com> Apply clang-format to the rest of the tree

find * | grep "\.[ch]" | xargs clang-format --style=file -i

Test: mma -j32
Change-Id: I6fcc9862bb7bc07c2a367ca58fef2b3cd27a6f05
/system/bt/service/hal/bluetooth_gatt_interface.h
a8d73ef2f3d2c9b344162cb15e9dd054c28761de 31-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Move start advertise method to advertising interface (3/3)

Advertising related code should be exposed through
BleAdvertiserInterface. Move client.listen function into this interface.
Remove reduntant clientif parameter.

Bug: 30622771
Bug: 24099160
Test: no tests necessary
Change-Id: Icc865c062e3d7c4b83bbeea6ff5b08bd2c1c4d9a
/system/bt/service/hal/bluetooth_gatt_interface.h
c3f6a51615c4f26bce0b8b6e16757610dbd0b45b 27-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Separate LE scanner and GATT client BTIF interfaces (3/3)

In order to properly separate low level structures associated with LE
scanner and GATT client, their interfaces must be separated first.

Test: sl4a BleScanApiTest
Bug: 30622771
Change-Id: If804632c8e4b08fd15d5b847c7838822cf98d79f
/system/bt/service/hal/bluetooth_gatt_interface.h
f3246f1c563391b7415f0e2bf881c99bdc535df7 27-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Separate LE scanner from GATT client (4/4)

Right now, LE scanning functionality is combined with the GATT client.
This is the source of various bugs, like scans suddenly stoppinging when
a GATT client is killed. It also increases memory consumption, because
we associate many structures with a GATT client, which are not necessary
when just scanning.

Test: sl4a BleScanApiTest ConcurrentBleScanTest
Bug: 30622771
Change-Id: I23b71255c459b185257654f68ea251b41ed2a14b
/system/bt/service/hal/bluetooth_gatt_interface.h
74ef54b440dc50bb25f587783d80fe5a37070e4a 07-Oct-2016 Jakub Pawlowski <jpawlowski@google.com> Convert advertising HAL from struct into class (3/3)

Bug: 30622771
Test: all related tests were updated
Change-Id: I9695284ae249fa427ae4b2f3e9649da951102c6c
/system/bt/service/hal/bluetooth_gatt_interface.h
73679d01c70fe84921fc4718e99d4b02af8cc5a9 18-Aug-2016 Jakub Pawlowski <jpawlowski@google.com> Bluetooth: split setting params and enabling advertising (3/3)

Proper order of commands when starting advertising:
* set parameters
* set data
* enable advertising

This cannot be achieved when setting advertising parameters and enabling
advertising is put together in one function. Enabling before setting
data might cause first advertisements to be empty. If a device with
hardware filter pick up such advertisement, it might fail to properly
recognize our device.

Bug: 30622771
Bug: 19372779
Change-Id: I3a2c1171e301ecfd7cbf1cb8b86cfda0e5fc2382
/system/bt/service/hal/bluetooth_gatt_interface.h
67d5a2523314d9757b2472c3e828dbc1015df4fe 13-Jul-2016 Jakub Pawlowski <jpawlowski@google.com> Separate advertiser from GATT client (4/4)

Bug: 30622771
Change-Id: I761f0bff09aec1047bd512915960021e4fbdc0c8
/system/bt/service/hal/bluetooth_gatt_interface.h
5dc0d15e7865104d13be75c06de4b9158ce7dff4 17-Aug-2016 Chih-Hung Hsieh <chh@google.com> Fix clang-tidy warnings in bt.

* Add explicit keyword to conversion constructors,
or add NOLINT to implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters,
or add NOLINT to keep same callback function signature.
Bug: 30407689
* Use const reference type for loop index variables to avoid unnecessary copy.
Bug: 30413223
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1

Change-Id: I8237d332f32d7be09ab72a8de82160fdb776dcd1
/system/bt/service/hal/bluetooth_gatt_interface.h
a641b6fa2a25e1b5382945d13c4fa49d36084a78 26-Mar-2016 Jakub Pawlowski <jpawlowski@google.com> GATT Server refactoring (4/4)

Right now in order to add gatt service, we need to add it piece by
piece - each characteristic and descriptor separately. This causes lots
of concurrency errors in higher layers. Instead accept whole service
definition and start whole service at once.

Also, use handles to identify GATT server attributes. It's already done
on clinet side.

Bug: 27999121
Change-Id: I42c796809423d116fe6755ef8b1c40da270427a5
/system/bt/service/hal/bluetooth_gatt_interface.h
16102de0866a51b523143b681e72db8e0ff441c4 31-May-2016 Jakub Pawlowski <jpawlowski@google.com> Vectors as parameters to GATT (1/3)

Bug: 29005882
Bug: 28485365
Change-Id: I0a5041073a39977c4fbc29879c383fa6720da641
/system/bt/service/hal/bluetooth_gatt_interface.h
9dc998503590163068845827d951fc2f05a17bda 17-Mar-2016 Jakub Pawlowski <jpawlowski@google.com> Use handles to identify GATT attributes (1/4)

Bug: 27778668
Change-Id: Id7454450c1ce2164001a1f9ca0b91f18d84e3fd6
/system/bt/service/hal/bluetooth_gatt_interface.h
b937cc00105838d71d1393d20cbdbff4771506a5 11-Feb-2016 Jakub Pawlowski <jpawlowski@google.com> service: Add services removed/added handlers

Change-Id: Ida3f232b4e77bfb95dec78ea4af7677c9c12b411
/system/bt/service/hal/bluetooth_gatt_interface.h
6859e0c7e3e20b1d1725b360378b546dd73dcb90 22-Jan-2016 Jakub Pawlowski <jpawlowski@google.com> service: add get_gatt_db and it's callback to HAL

Change-Id: I6412b464c4299ea351446f384b539ffa2e6111b2
/system/bt/service/hal/bluetooth_gatt_interface.h
326b602c1571bcc9b49036fa9353f0ed55e6610e 27-Jan-2016 Jakub Pawlowski <jpawlowski@google.com> service: MTU changed callback for GATT server

Change-Id: I8431e970004f9b96cc40c3a5ca7878815d4d53bb
/system/bt/service/hal/bluetooth_gatt_interface.h
c0b16987d55447ae52c9b8c8bb2548d9b74463ed 26-Jan-2016 Jakub Pawlowski <jpawlowski@google.com> service: add bunch of GATT callback handlers

RegisterForNotificationCallback
NotifyCallback
WriteCharacteristicCallback
WriteDescriptorCallback

Change-Id: Ic92104e427d153b5b6567fcd7fe4d967df2b3b61
/system/bt/service/hal/bluetooth_gatt_interface.h
d023549e2a111b55aaa25ac9a76f8ae318f28c1c 26-Jan-2016 Jakub Pawlowski <jpawlowski@google.com> service: implement HAL callback for response confirmation

Change-Id: Iec1c33574cef49053cf1f8eb3835b20047cb96eb
/system/bt/service/hal/bluetooth_gatt_interface.h
9c68cdfcbf2220b7c1f30d1d0521775c238ba823 22-Jan-2016 Jakub Pawlowski <jpawlowski@google.com> service: Handle configure_mtu_cb, search_complete_cb and search_result_cb events

This patch adds HAL wrappers for those three events in preparation to
triggering MTU exchange and service discovery.

search_result_cb will not be propagated above HAL, new method will be
implemented to get GATT database content when it's ready.

Change-Id: Id25699879923ff64c8bdb8942581ea32c2390dac
/system/bt/service/hal/bluetooth_gatt_interface.h
25689c1676ab911fa7887ec87b730b00325e4b90 21-Jan-2016 Jakub Pawlowski <jpawlowski@google.com> service: Solve locking issues inside GATT interface

ObserverList class handles adding/removing elements during iteration
by itself, therefore we don't need to do any locking.
Additionally, change lock type to shared for better performance, and
to avoid possible deadlocks that might be caused by calling HAL from
observers.

Change-Id: I4c372f1e03bd27a96bc6c036ab8ce34f5501c0a7
/system/bt/service/hal/bluetooth_gatt_interface.h
ce021ddaafea0cdb78005fe08bc8510f9c75aca4 20-Jan-2016 Jakub Pawlowski <jpawlowski@google.com> service: add HAL for connect/disconnect

Change-Id: I05b86af68e05433241d0206b0952d859483dee80
/system/bt/service/hal/bluetooth_gatt_interface.h
3f6aa07299fd9db634274fd22821b349f18b5e0f 30-Nov-2015 Arman Uguray <armansito@google.com> service/hal: Add per-client Scan interface

Added a new per-client scan function to hal::BluetoothGattInterface.
The intention here is to push most of the per-client reference counting,
scan settings and filter coalescence below the HAL. This CL does this
first inside the Bluetooth daemon's HAL wrappers in a way that
represents what the future HAL scan API might look like.

This implements a basic reference counting scheme to share the global
controller scan session among different clients.

Bug: 25744656
Change-Id: I20c5cfc291be70d72576ebee014cc13544d5a299
/system/bt/service/hal/bluetooth_gatt_interface.h
f261cf86466c61cfbbaffecd82586855614d48c9 07-Dec-2015 Ajay Panicker <apanicke@google.com> net_test_bluetooth: GATT test refactor

Properly integrating the GATT tests in net_test_bluetooth to utilize GUnit
correctly. Contains all the GATT tests and the base class the GATT tests use.
Also reorganized the files.

Bug: 25793348
Change-Id: I5a547a2528c20d6baa9b1fb6d0b956f718d736cc
/system/bt/service/hal/bluetooth_gatt_interface.h
cd644e3c54a4321b7626b52531c59f88e24e87be 02-Oct-2015 Arman Uguray <armansito@google.com> service: Support GattServer notifications/indications

Added outgoing notification/indication support to
bluetooth::GattServer and implemented the related Binder API.

Bug: 24245347
Change-Id: I2d5cea90137e5d771f969163591b50aee1ad171c
/system/bt/service/hal/bluetooth_gatt_interface.h
4ebcbd9ede4006500c3ead0685befe0a8e4aadc2 30-Sep-2015 Arman Uguray <armansito@google.com> service: Support GATT server async write requests.

Added support for incoming characteristic/descriptor read requests
to bluetooth::GattServer and implemented the related Binder API.

Bug: 24245347
Change-Id: I18202c3255f0fb8fc5338b1139c375e1439b6568
/system/bt/service/hal/bluetooth_gatt_interface.h
b10f96fa25266b69d0d31af166e93afe14134be7 29-Sep-2015 Arman Uguray <armansito@google.com> service: Add HAL wrappers for read_request_cb and connection_cb

Added HAL wrappers for GATT server callbacks for incoming read
requests, GATT connection state, and the send_response function.

Bug: 24245347
Change-Id: I8605fc6548294f9e09416ca8474cf13619463c40
/system/bt/service/hal/bluetooth_gatt_interface.h
d9b0552a7f75737b5c8c60cb87f892b1b9323acf 26-Sep-2015 Arman Uguray <armansito@google.com> service: Implement IBluetoothGattServer.addDescriptor

Declared and implemented the IBluetoothGattServer.addDescriptor
API.

Bug: 24245347
Change-Id: I7d1e992321c260b9d77521b1c8d7a1e7737b35cc
/system/bt/service/hal/bluetooth_gatt_interface.h
91613743c9db02dbe05d93d2afa163b78068d054 25-Sep-2015 Arman Uguray <armansito@google.com> service: Implement IBluetoothGattServer.addCharacteristic

Declared and implemented the IBluetoothGattServer.addCharacteristic
Binder API.

Bug: 24245347
Change-Id: I8baaed8d6dbf8ac2209b8fd0c918cade78dcba64
/system/bt/service/hal/bluetooth_gatt_interface.h
78a44cdb25616892087af2c92abd382878c2ccb4 24-Sep-2015 Arman Uguray <armansito@google.com> service: Add HAL wrappers for adding a service

Added wrappers for HAL functions for adding and starting a service
declaration.

Bug: 24245347
Change-Id: Ie9bd09abb443abdfdc31f3439d563c58066961f2
/system/bt/service/hal/bluetooth_gatt_interface.h
9e5205368d61adf11e75c9e2bd9f6ff26b375bac 22-Sep-2015 Arman Uguray <armansito@google.com> service: Add server support to BluetoothGattInterface

Added HAL GATT server interface wrappers to
hal::BluetoothGattInterface. Extended the fake implementation to
allow mocking server calls.

Bug: 24245347
Change-Id: Ic3436b8a82ecd93fed3b61579662fe776eebef58
/system/bt/service/hal/bluetooth_gatt_interface.h
d1ed1f53a5c0cce5ecb8d784acf5bef53211a20f 17-Sep-2015 Arman Uguray <armansito@google.com> service: Add HAL wrappers for multi-advertising

This CL adds the fake and real HAL wrappers for the multi-advertising
APIs in hardware/bluetooth/bt_gatt_client.h.

Bug: 23793954
Change-Id: I485e7cf87c4b6f42c3a702c62230a287443a75c1
/system/bt/service/hal/bluetooth_gatt_interface.h
9ded7b6175825afdac0e2cebef8755e4d7b03103 01-Sep-2015 Arman Uguray <armansito@google.com> service: Add hal::BluetoothGattInterface

Added hal::BluetoothGattInterface which is a C++ wrapper around the
HAL Bluetooth GATT interfaces. This follows the current pattern of hal/*
wrappers and is meant to be fakeable.

Bug: 23395353
Change-Id: Ib11afba9fe2f4632591d5db384edf32ca788bf2c
/system/bt/service/hal/bluetooth_gatt_interface.h