9e030fde05352ec4385d7baf6cc2af89e95e039c |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3) Test: compilation test Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/stack/gatt/gatt_auth.cc
|
c2276b06572ab6fc1f900fbb1f41087e77d47e2a |
|
10-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bt_bdaddr_t instead of BD_ADDR Test: compilation test, sl4a GattReadTest Change-Id: I8d1bd6914aec55bb53495b1d0d5e3d37b86865e6
/system/bt/stack/gatt/gatt_auth.cc
|
d8be0e590aa1efe1c33a8acfea0d7e14fd1a8030 |
|
09-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of GATT_TRACE_* logs in favour of base/logging.h Change-Id: Id77d313c5bff5e611441599da351a766d0ce5916
/system/bt/stack/gatt/gatt_auth.cc
|
ed55662b4885a5247bb499fa887b0e77a8cab881 |
|
03-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Simplify read/write start When read or write is started with insuficcient encryption, and the encryption fails, it will either return immediate error GATT_NO_RESOURCES, or the operation will be enqueued. In case the enqueued operation fails again on the BTM_SetEncryption, no callback will never be called, and no operation error will be returned. The gatt_end_operation will never get called for the CLCB, and it will never be freed, causing memory leak. This patch fixes this by making sure that the call to gatt_security_check_start always consumes the CLCB - either by executing operation, queuing it, or returning error. This also ensures that if BTM_SetEncryption fails, it will always be handled the same way - by calling the callback. Test: manual Change-Id: Ibc20c1101cc7b5b6043e75df93b23a5b24b791e9
/system/bt/stack/gatt/gatt_auth.cc
|
f4c0292c63085cd4d0f5c001974b6503aeaf8ed3 |
|
30-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Pass GATT cb's by reference and other style fixes Test: compilation test Change-Id: I410d0d0a0bf49b9f3ca5e034c66fe8e82661cee7
/system/bt/stack/gatt/gatt_auth.cc
|
eb3ab848f8361d54faa3a997fbecfe48af9de731 |
|
30-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use std::queue for pending_enc_clcb Test: 62188929 Change-Id: Ide07f15c5e5b6bc8b93ac350081b7bef7c7b3938
/system/bt/stack/gatt/gatt_auth.cc
|
911d1ae03efec2d54c3b1b605589d790d1745488 |
|
29-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Apply clang-format to the rest of the tree find * | grep "\.[ch]" | xargs clang-format --style=file -i Test: mma -j32 Change-Id: I6fcc9862bb7bc07c2a367ca58fef2b3cd27a6f05
/system/bt/stack/gatt/gatt_auth.cc
|
9ca07091a1f07ea201cee0504dab6a1d7073d429 |
|
29-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Reformat long comments before clang-format Test: mma -j32 Change-Id: I86a2a4af9dcd22d675ca1f764bb2c9623d63edcc
/system/bt/stack/gatt/gatt_auth.cc
|
ee96a3c60fca590d38025925c072d264e06493c4 |
|
23-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Fix asterisks in block quotes Remove double asterisks from block quotes. git grep -lP '^[*][*]' | xargs sed 's/^[*][*]/ \*/' -i Fix asterisk line lengths git grep -l '^[ /][*]\{79,\}[*/]' | \ xargs sed -i s,"^\([ /]\)[*]\([*]\{78\}\)[*]*\([*/]\)","\1\2\3", Test: mma -j32 Change-Id: Ie3fd375ac2f804cb0f53bf1314a005e85973b3d7
/system/bt/stack/gatt/gatt_auth.cc
|
f33b6f434f086b20fabe5913016bc423ac975057 |
|
23-Nov-2016 |
Marie Janssen <jamuraa@google.com> |
readability fix: No assigns in if conditionals Coccinelle-assisted: @@ variable i; expression E; statement S1, S2; @@ + i = E; if ( ( - (i = E) + i != ... | - (i = E) + i == ... | - (i = E) + i < ... | - (i = E) + i > ... | - (i = E) + i <= ... | - (i = E) + i >= ... | - (i = E) + i ) ) S1 else S2 for file in $(find . -name "*.cc"); do spatch --sp no-if-assigns.cocci --in-place $file done clang-format --style=file -i bta/**/*.cc Test: mma -j37 and basic sanity testing on angler, sailfish Change-Id: I41a2964afac347c24e13869b6c172e321e646091
/system/bt/stack/gatt/gatt_auth.cc
|
84baa7f16e830394408278dbb8c508dd9fa02887 |
|
14-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Remove BLE_INCLUDED define Test: Connect to a BLE Keyboard Change-Id: I5f8f4017c90c3c404004632fd10e6c2b93bd7783
/system/bt/stack/gatt/gatt_auth.cc
|
d7ffd64accbd50a27289a388856e56244ccbb5da |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (5/5) Include osi.h for UNUSED_ATTR. Test: mma -j32 Change-Id: I43260669dc1f54639e46cc9620093d727ee86276
/system/bt/stack/gatt/gatt_auth.cc
|
d35a648d39710bbc5ac59f8add85166455af5af7 |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (1/5) Generated automatically with coccinelle /* This rule matches functions with arguments * that have an UNUSED(arg) in the body. */ @r1@ identifier arg; identifier fn; type t; parameter list[n] P; @@ fn(P, const t arg) { ... UNUSED(arg); ... } /* This rule removes the UNUSED line, and adds * UNUSED_ATTR to the parameter list. */ @depends on r1@ identifier r1.arg; identifier r1.fn; type r1.t; parameter list[r1.n] r1.P; typedef UNUSED_ATTR; @@ fn(P, - const t arg + UNUSED_ATTR GETRIDOFTHISCOMMA, const t arg ) { ... -UNUSED(arg); ... } Test: mma -j32 Change-Id: Idcaadd688d669d484e557becd050e69454508f3c
/system/bt/stack/gatt/gatt_auth.cc
|
b2a292b5d8df2f359c38b0787bc01181225a9bc9 |
|
15-Oct-2016 |
Pavlin Radoslavov <pavlin@google.com> |
Renamed most C files to C++: *.c to *.cc Also: - Fixed C++ related compilation errors. - Added missing 'extern "C"' guards in some of the header files. - Added missing LOCAL_CPP_EXTENSION to Android.mk files. - Added-back btif/src/btif_mce.cc and bta/mce/bta_mce_* to btif/Android.mk and bta/Android.mk respectively. - Fixed the alphabetical ordering of the *.cc files in some of the Android.mk files. - Added missing Copyright header to "osi/include/list.h" - Updated "osi/src/wakelock.cc" to use C++ std::string instead of dynamic allocation of C-style strings. Test: code compilation, unit tests, and A2DP streaming Change-Id: Ia2f7215ed9df32775c701b68fc86b09875b942c7
/system/bt/stack/gatt/gatt_auth.cc
|