8e89469b5e223a48e1915f16862e81a3f4581259 |
|
19-Sep-2017 |
Myles Watson <mylesgw@google.com> |
Remove casts to unions to avoid unaligned accesses Bug: 65392204 Test: sanity Change-Id: I2886cc02289b68710e83147ba4d7715a32a4fc55 (cherry picked from commit 8d749047a084b2d8a18fcaaac5c585e97a16f58d) Merged-In: I2886cc02289b68710e83147ba4d7715a32a4fc55
/system/bt/stack/gatt/gatt_utils.cc
|
47616530ceea2ea6432ffb35cd8a3fc0a56365b5 |
|
08-Sep-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Fix alarms being posted on wrong thread Alarms from btu_bta_alarm_queue and btu_generic_alarm_queue should be processed on the main MessageLoop thread. Replaced obsoleted alarm_set_on_queue() alarm API with the new alarm_set_on_mloop() API Test: manual Bug: 65078753 Change-Id: I54b472b39b44a6c541dbdcdad7414056d0dd4163 Merged-In: I54b472b39b44a6c541dbdcdad7414056d0dd4163 (cherry picked from commit be8bbd7a83ec8bc900fac58a03010fbcb74956c9)
/system/bt/stack/gatt/gatt_utils.cc
|
9e030fde05352ec4385d7baf6cc2af89e95e039c |
|
25-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Rename bt_bdaddr_t into RawAddress (3/3) Test: compilation test Change-Id: I4571721a0c6165a66450ee157a53d8d15bfc45d0
/system/bt/stack/gatt/gatt_utils.cc
|
c2276b06572ab6fc1f900fbb1f41087e77d47e2a |
|
10-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use bt_bdaddr_t instead of BD_ADDR Test: compilation test, sl4a GattReadTest Change-Id: I8d1bd6914aec55bb53495b1d0d5e3d37b86865e6
/system/bt/stack/gatt/gatt_utils.cc
|
d8be0e590aa1efe1c33a8acfea0d7e14fd1a8030 |
|
09-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of GATT_TRACE_* logs in favour of base/logging.h Change-Id: Id77d313c5bff5e611441599da351a766d0ce5916
/system/bt/stack/gatt/gatt_utils.cc
|
8463560c803bcf879fe1511239e5d12b15582c2e |
|
08-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
GATT write improvements When doing GATT write, crash if p_clcb->p_attr_buf is null, or if op_subtype is unknown. Both of this cases signal possible memory corruption, and should be treated as fatal. Properly handle GATT_CONGESTED error when doing long write. Test: compilation test Change-Id: Ia56f3bbd06cde2978b0ce2210ebe58042504938c
/system/bt/stack/gatt/gatt_utils.cc
|
3f177e0addc35bb39b6688d0059592b161a6bac1 |
|
08-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
gatt_cleanup_upon_disc refactor gatt_end_operation internally always call gatt_clcb_dealloc. Make sure both those methods don't get called in gatt_cleanup_upon_disc. Also minor style fixes. Test: compilation test Change-Id: If7a360bfd1ac2ccd7bb1565e8efe459333f8f025
/system/bt/stack/gatt/gatt_utils.cc
|
bb95a1d62243dc3f4ce7c208d68f50cb57713eab |
|
07-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Fix loops iteration The erase() already increment the iterator. If the loop additionally do "it++", it will skip some elements, and might iterate over the end. Test: compilation test Change-Id: Ibd9c993d8e80d807f5d7bc920da36ee538477438
/system/bt/stack/gatt/gatt_utils.cc
|
3dda89880b66b0f04f684d138e7c3dc9a0e61597 |
|
06-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use std::unordered_set for keeping app_hold_link Change-Id: Ia8a0c9a2264979c1ff89faa5ddf17a83fcb7c7ce
/system/bt/stack/gatt/gatt_utils.cc
|
e4f42abab339b3329aec07502199e11d3d8b3d80 |
|
31-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Get rid of clcb_idx in favour of pointers Test: compilation test Change-Id: Ib2c4b13b85343693e6cff4a94eed49382e3aec00
/system/bt/stack/gatt/gatt_utils.cc
|
d1a9313471ed5290ca560305978c3107020272c2 |
|
31-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
use std::queue for keeping tGATT_CMD_Q Test: compilation Change-Id: I4df9a075d27a306067c48c652f5da1fb156c4a9b
/system/bt/stack/gatt/gatt_utils.cc
|
7cfd8391f6db2d387ea556ca2b7be0a7e4791e5d |
|
06-Jun-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Refactor tGATT_BG_CONN_DEV * Use list for keeping the devices instead of fixes array, get rid of the in_use field. * Use unordered_set instead of array to keep gatt_if of apps interested in specific device. * the in_use flag was never cleared before, this had the potential to fill the whole array when multiple devices were addred/removed to the whitelist. This issue is fixed now. Test: compilation test Change-Id: Id87c2ae9c5b0ce0887a4fa9be50e34d646d22a13
/system/bt/stack/gatt/gatt_utils.cc
|
f4c0292c63085cd4d0f5c001974b6503aeaf8ed3 |
|
30-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Pass GATT cb's by reference and other style fixes Test: compilation test Change-Id: I410d0d0a0bf49b9f3ca5e034c66fe8e82661cee7
/system/bt/stack/gatt/gatt_utils.cc
|
eb3ab848f8361d54faa3a997fbecfe48af9de731 |
|
30-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Use std::queue for pending_enc_clcb Test: 62188929 Change-Id: Ide07f15c5e5b6bc8b93ac350081b7bef7c7b3938
/system/bt/stack/gatt/gatt_utils.cc
|
6395f1547ed6179dcdeed392bd9909d18772fb25 |
|
09-May-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Improve GATT Server database handling. - use references instead of pointers where possible. Thanks to it we can remove some reduntant null checks and simplify the code. - use directly allocated memory instead of own buffers. Thanks to it the stack uses around 12kb less of memory after startup. - use list and vector from std library, instead of some hand-written implementations. This patch is a prerequisite for further server refactoring, that will further reduce the space used, make unit-testing possible, and enable proper handling of PTS GATT tests. Test: sl4a GattReadTest Bug: 38225928 Change-Id: I1620be682259ccb8f0c02754806e355e3f1ad0c1
/system/bt/stack/gatt/gatt_utils.cc
|
bdd2f5001ffc7c53f0e38c2a98e393b1855f9ce6 |
|
09-Feb-2017 |
Myles Watson <mylesgw@google.com> |
Clean up some more #defines true -> TRUE false -> FALSE Test: builds Change-Id: I2573b6ab81aa384cc6d20bb8beb84303aba06a66
/system/bt/stack/gatt/gatt_utils.cc
|
911d1ae03efec2d54c3b1b605589d790d1745488 |
|
29-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Apply clang-format to the rest of the tree find * | grep "\.[ch]" | xargs clang-format --style=file -i Test: mma -j32 Change-Id: I6fcc9862bb7bc07c2a367ca58fef2b3cd27a6f05
/system/bt/stack/gatt/gatt_utils.cc
|
9ca07091a1f07ea201cee0504dab6a1d7073d429 |
|
29-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Reformat long comments before clang-format Test: mma -j32 Change-Id: I86a2a4af9dcd22d675ca1f764bb2c9623d63edcc
/system/bt/stack/gatt/gatt_utils.cc
|
ee96a3c60fca590d38025925c072d264e06493c4 |
|
23-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Fix asterisks in block quotes Remove double asterisks from block quotes. git grep -lP '^[*][*]' | xargs sed 's/^[*][*]/ \*/' -i Fix asterisk line lengths git grep -l '^[ /][*]\{79,\}[*/]' | \ xargs sed -i s,"^\([ /]\)[*]\([*]\{78\}\)[*]*\([*/]\)","\1\2\3", Test: mma -j32 Change-Id: Ie3fd375ac2f804cb0f53bf1314a005e85973b3d7
/system/bt/stack/gatt/gatt_utils.cc
|
f33b6f434f086b20fabe5913016bc423ac975057 |
|
23-Nov-2016 |
Marie Janssen <jamuraa@google.com> |
readability fix: No assigns in if conditionals Coccinelle-assisted: @@ variable i; expression E; statement S1, S2; @@ + i = E; if ( ( - (i = E) + i != ... | - (i = E) + i == ... | - (i = E) + i < ... | - (i = E) + i > ... | - (i = E) + i <= ... | - (i = E) + i >= ... | - (i = E) + i ) ) S1 else S2 for file in $(find . -name "*.cc"); do spatch --sp no-if-assigns.cocci --in-place $file done clang-format --style=file -i bta/**/*.cc Test: mma -j37 and basic sanity testing on angler, sailfish Change-Id: I41a2964afac347c24e13869b6c172e321e646091
/system/bt/stack/gatt/gatt_utils.cc
|
84baa7f16e830394408278dbb8c508dd9fa02887 |
|
14-Nov-2016 |
Myles Watson <mylesgw@google.com> |
Remove BLE_INCLUDED define Test: Connect to a BLE Keyboard Change-Id: I5f8f4017c90c3c404004632fd10e6c2b93bd7783
/system/bt/stack/gatt/gatt_utils.cc
|
a60c5fdaa2e22bd0a65139353b346f43ca2c6dd7 |
|
15-Nov-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove unused GATT_Listen Bug: 30622771 Test: still builds Change-Id: I4003a1241e611c9c1f2a21090ea3ba7530b0643a
/system/bt/stack/gatt/gatt_utils.cc
|
2e8c421ddce1dae511a39b8e89415e8eb1944bfd |
|
29-Oct-2016 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove advertise whitelist functionality Advertise filtering is never used. It is not finished - adding device to whitelist can never succed. It is also making advertising API unification hard. Bug: 30622771 Test: no tests necessary Change-Id: I9df9ea18b265a580c2fcdb28a6d6ce4be43f0a24
/system/bt/stack/gatt/gatt_utils.cc
|
d7ffd64accbd50a27289a388856e56244ccbb5da |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (5/5) Include osi.h for UNUSED_ATTR. Test: mma -j32 Change-Id: I43260669dc1f54639e46cc9620093d727ee86276
/system/bt/stack/gatt/gatt_utils.cc
|
d35a648d39710bbc5ac59f8add85166455af5af7 |
|
27-Oct-2016 |
Myles Watson <mylesgw@google.com> |
Remove deprecated UNUSED macro (1/5) Generated automatically with coccinelle /* This rule matches functions with arguments * that have an UNUSED(arg) in the body. */ @r1@ identifier arg; identifier fn; type t; parameter list[n] P; @@ fn(P, const t arg) { ... UNUSED(arg); ... } /* This rule removes the UNUSED line, and adds * UNUSED_ATTR to the parameter list. */ @depends on r1@ identifier r1.arg; identifier r1.fn; type r1.t; parameter list[r1.n] r1.P; typedef UNUSED_ATTR; @@ fn(P, - const t arg + UNUSED_ATTR GETRIDOFTHISCOMMA, const t arg ) { ... -UNUSED(arg); ... } Test: mma -j32 Change-Id: Idcaadd688d669d484e557becd050e69454508f3c
/system/bt/stack/gatt/gatt_utils.cc
|
3ff34be9fac7908c41ce84f94c44b2c4d5e2ad2e |
|
18-Oct-2016 |
Pavlin Radoslavov <pavlin@google.com> |
Add the appropriate statement to "case:" without "break" Test: code compilation Change-Id: Ia43d7530a598a526764023c47bb20fdedda6fe64
/system/bt/stack/gatt/gatt_utils.cc
|
b2a292b5d8df2f359c38b0787bc01181225a9bc9 |
|
15-Oct-2016 |
Pavlin Radoslavov <pavlin@google.com> |
Renamed most C files to C++: *.c to *.cc Also: - Fixed C++ related compilation errors. - Added missing 'extern "C"' guards in some of the header files. - Added missing LOCAL_CPP_EXTENSION to Android.mk files. - Added-back btif/src/btif_mce.cc and bta/mce/bta_mce_* to btif/Android.mk and bta/Android.mk respectively. - Fixed the alphabetical ordering of the *.cc files in some of the Android.mk files. - Added missing Copyright header to "osi/include/list.h" - Updated "osi/src/wakelock.cc" to use C++ std::string instead of dynamic allocation of C-style strings. Test: code compilation, unit tests, and A2DP streaming Change-Id: Ia2f7215ed9df32775c701b68fc86b09875b942c7
/system/bt/stack/gatt/gatt_utils.cc
|