History log of /system/chre/util/include/chre/util/optional_impl.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
2d7d24a7bb72c9c3b4ff1af5f7fef8b303fd8c0e 17-Apr-2017 Brian Duddie <bduddie@google.com> Updates to Optional for safety and consistency

After the destructor is invoked via Optional::reset(), the underlying
object is invalid and cannot be safely used for assignment. Avoid this
by performing move/copy construction in the Optional assignment
implementations if the underlying storage is uninitialized.

Also, bring chre::Optional in-line with std::optional by removing the
requirement for the contained object to have a default constructor
(instead leaving the object storage uninitialized after default
construction of Optional), and making the semantics of move assignment
the same (only the underlying object is moved, not the "ownership" of
the object, i.e. the moved-from Optional can still have has_value() set
to true).

Test: ./run_tests.sh
Change-Id: Ie3627838aee10acf89d3cf609aebf8fc6694ebea
/system/chre/util/include/chre/util/optional_impl.h
5104fb101aaea4793daa061b160fbc3feb051b0d 31-Mar-2017 Andrew Rossignol <aarossig@google.com> Adds a GnssRequest class compliant with the RequestMultiplexer

Test: Run simulator and tests.
Change-Id: I3d1ed01c492e4c37d320138de2c02f7c5798750f
/system/chre/util/include/chre/util/optional_impl.h
e62f9949c5aa827e175cfb239d9840d7517e8052 02-Mar-2017 Meng-hsuan Chung <menghsuan@google.com> Adds and populates sensor oneShot, onChange and minInterval properties

Change-Id: Iec1962cc95a949ecfbe99661e8ae87d7333792a5
/system/chre/util/include/chre/util/optional_impl.h
39993a0032116a71eb51cbf14186eec6bab328f2 01-Feb-2017 Andrew Rossignol <aarossig@google.com> Adds an std::move-based Optional constructor

Change-Id: I2ca5cd1ae4f50eed1d99e4ea35703ede9942f7eb
/system/chre/util/include/chre/util/optional_impl.h
1bbcacadd7331e0db5cf17f01e8ba7f451ff6740 27-Jan-2017 Andrew Rossignol <aarossig@google.com> Adds a copy-assignment operator to Optional

Change-Id: Iea24e175e0b0aae273d0022b624723554cf45d01
/system/chre/util/include/chre/util/optional_impl.h
a168da9318a8d996ffd82beacb69a248b11d8569 26-Jan-2017 Andrew Rossignol <aarossig@google.com> Adds a move-assignment operator to the Optional container

Change-Id: Ic3cb52605e37b08f70ee4d9da73ece98c040e875
/system/chre/util/include/chre/util/optional_impl.h
35577195df7ab14e9f58443c2e59293499fe7a8f 26-Jan-2017 Andrew Rossignol <aarossig@google.com> Adds a default constructor with inital value to Optional

Change-Id: Ife274c1b539db7413a321d5b515faabcb2221da4
/system/chre/util/include/chre/util/optional_impl.h
fe38dd8c9780b599cf2eff09ff6fbf60fbe9ab76 18-Jan-2017 Andrew Rossignol <aarossig@google.com> Adds an Optional container to util and tests

Change-Id: I12d6144baeaa66f5cbbee414d3be8c48b641fceb
/system/chre/util/include/chre/util/optional_impl.h