| 5d1b1a8b91a35f465e5af146bcfd5d7b4346854c |
|
14-Sep-2016 |
Josh Gao <jmgao@google.com> |
base: rename unique_fd::clear() to unique_fd::reset().
unique_fd is modeled on unique_ptr, so make this consistent.
Test: m checkbuild
Change-Id: Ia6a77095dc18746fbb432e96bb8dccfc049c57f6
/system/core/base/include/android-base/unique_fd.h
|
| 6496c4bf6f31bd0714a341d51c1cff7f15938e84 |
|
29-Aug-2016 |
Josh Gao <jmgao@google.com> |
base: disallow close() on unique_fd.
unique_fd's implicit conversion to int allows it to be passed to
close(2), which is dangerous because unique_fd will think that it still
has ownership of the now-closed fd. Disallow this by providing an
overload for close that's tagged with an attribute that gives a
compile-time error.
Test: m
Change-Id: I514591335b337f2f57c1df371cf3979304aea17c
/system/core/base/include/android-base/unique_fd.h
|
| 13ea01db451b3993d175110a3336a58482be883d |
|
13-May-2016 |
Josh Gao <jmgao@google.com> |
adb/base: allow use of unique_fd inside adb.
adb implements its own file descriptor emulation layer on Windows,
which requires the use of adb_close instead of close throughout the
codebase. Add a template argument to unique_fd that allows for this.
Bug: http://b/28347842
Change-Id: I6397261f4973d49f2f8e04257bf67b348585bb63
/system/core/base/include/android-base/unique_fd.h
|
| 2a7b86337f7b149887588e4df532272abe3e931c |
|
19-Apr-2016 |
Christopher Wiley <wiley@google.com> |
Don't include android-base/macros.h from android-base/unique_fd.h
This prevents a ton of macro collisions when libfoo includes libbinder
includes unique_fd.h.
Bug: 27804373
Change-Id: Ide834afb1052b32e86fad3fcba10cff3dafeb899
/system/core/base/include/android-base/unique_fd.h
|
| 2c5d1d7cd914ec8ebf76c8a59d0889ebf5b538cd |
|
28-Mar-2016 |
Elliott Hughes <enh@google.com> |
Add operator int() to unique_fd.
Change-Id: I7512559be7befbb8772d5529e06550267a2f1543
/system/core/base/include/android-base/unique_fd.h
|
| 3761365735de4cbc3c8581f0a5e972ad01f8378c |
|
26-Mar-2016 |
Elliott Hughes <enh@google.com> |
Merge "Fix <android-base/*.h> header guards."
|
| 54c72aaccc45edf4832cfdc5053d9ae6acc9bcdf |
|
23-Mar-2016 |
Elliott Hughes <enh@google.com> |
Fix <android-base/*.h> header guards.
I've been meaning to do this for a while, and it came up on the bug below
that there have been conflicts with similar-named files in <base/*.h>,
so let's rule out one possible explanation.
Bug: http://b/27804373
Change-Id: I69e5d52b6260c573c308513420aee0e281426bd4
/system/core/base/include/android-base/unique_fd.h
|
| c0e6e40cc916747a0a22c2538874348cda0ef607 |
|
23-Mar-2016 |
Elliott Hughes <enh@google.com> |
Copy the good comment and warn_unused_result from ScopedFd to unique_fd.
Also list all known aliases of this class to increase the chances that
anyone searching for it by another name finds it anyway.
Change-Id: I58ea0a5421987fb69f93cc56252a771e9c34147e
/system/core/base/include/android-base/unique_fd.h
|
| f2584be414037aaab9e344bc9f65872da624d9f0 |
|
07-Dec-2015 |
Elliott Hughes <enh@google.com> |
Rename base/ to android-base/.
Bug: http://b/26023797
Change-Id: Ie6c63bf86bed05faab87d290de6f34d9af3532a8
/system/core/base/include/android-base/unique_fd.h
|