| 8b70a0266d42297e9b38e6209588eb3621843e95 |
|
07-Mar-2018 |
Christopher Ferris <cferris@google.com> |
Refactor malloc debug.
Changes
- Refactor the code so that only guards require creating a special header
for every pointer allocated.
- Store only a single copy of every backtrace. This saves memory so that
turning on the backtrace option doesn't result in 10X memory usage.
- Added new option track_allocs that only verifies pointers are valid for
free/malloc_usable_size/realloc.
- Remove suffix from test names.
- Add the TRACK_ALLOCS options to all guard options.
- Add new option verify_pointers that is a lightweight way to verify
pointers that are passed to allocation routines.
- Do auto-formatting of the code.
- Updated documentation for all of these changes.
Bug: 74361929
Test: Ran unit tests.
Test: Ran libmemunreachable unit tests.
Test: Ran an app with backtrace enabled.
Change-Id: I3246c48ae4f9811f64622d90d0a9b4d9d818702c
(cherry picked from commit 4da2503d70dc4bc1444454876e3794b69227d90d)
|
| 1724535fb4ebf6b6ff1b3ac06f7dcaf5cb36da78 |
|
20-Feb-2016 |
Christopher Ferris <cferris@google.com> |
Fix incorrect size of array.
When using sscanf and "%4s", the array passed in must include space for
a nul terminator.
Bug: 26739265
(cherry picked from commit f499dc91e774db4cb9d21f9a7c34704fa9b7ed39)
Change-Id: I8aac6fca3e5bc7a6399e2ed9c6ba4140a55ffdee
|
| b7ff533ed28f82c0981b83ae80e8bc8e3f350d0f |
|
08-Feb-2016 |
Colin Cross <ccross@android.com> |
malloc_debug: reread /proc/pid/maps when entry is missing
Reread /proc/pid/maps on demand in case a new library has been loaded.
Bug: 27208635
(cherry picked from commit d75d4bea54a788dada3f2538a33cc491e4c56ed4)
Change-Id: I80140cf57fa3b3e93d51dbe7b7a27595b72ee694
|
| 6deb3042df87f8569fb430dbf5f140f6a694ddfd |
|
06-Feb-2016 |
Colin Cross <ccross@android.com> |
Add backtrace_string and export to libmemunreachable
Add backtrace_string to convert a malloc_debug backtrace to a string.
Also move the backtrace functions to libc_malloc_debug_backtrace so that
libmemunreachable can reuse them.
Bug: 27208635
(cherry picked from commit 2c75991359df165ca7cc7a6213fb227c0b5ed87c)
Change-Id: Ia93aaf010fbce1ace058439427066ea2dfd8bd13
|
| f499dc91e774db4cb9d21f9a7c34704fa9b7ed39 |
|
20-Feb-2016 |
Christopher Ferris <cferris@google.com> |
Fix incorrect size of array.
When using sscanf and "%4s", the array passed in must include space for
a nul terminator.
Bug: 26739265
Change-Id: I0140a6100ca370666ae61689087ba41b4914789d
|
| d75d4bea54a788dada3f2538a33cc491e4c56ed4 |
|
08-Feb-2016 |
Colin Cross <ccross@android.com> |
malloc_debug: reread /proc/pid/maps when entry is missing
Reread /proc/pid/maps on demand in case a new library has been loaded.
Change-Id: Iac8109b3e6a07bf02c38300b21eecabf4bcd54df
|
| 2c75991359df165ca7cc7a6213fb227c0b5ed87c |
|
06-Feb-2016 |
Colin Cross <ccross@android.com> |
Add backtrace_string and export to libmemunreachable
Add backtrace_string to convert a malloc_debug backtrace to a string.
Also move the backtrace functions to libc_malloc_debug_backtrace so that
libmemunreachable can reuse them.
Change-Id: I5ad67001c0b4d184903c762863a8588181d4873b
|
| 63860cb8fd1adf3f679b9b4ad876323a8d65cd9d |
|
17-Nov-2015 |
Christopher Ferris <cferris@google.com> |
Malloc debug rewrite.
The major components of the rewrite:
- Completely remove the qemu shared library code. Nobody was using it
and it appears to have broken at some point.
- Adds the ability to enable/disable different options independently.
- Adds a new option that can enable the backtrace on alloc/free when
a process gets a specific signal.
- Adds a new way to enable malloc debug. If a special property is
set, and the process has an environment variable set, then debug
malloc will be enabled. This allows something that might be
a derivative of app_process to be started with an environment variable
being enabled.
- get_malloc_leak_info() used to return one element for each pointer that
had the exact same backtrace. The new version returns information for
every one of the pointers with same backtrace. It turns out ddms already
automatically coalesces these, so the old method simply hid the fact
that there where multiple pointers with the same amount of backtrace.
- Moved all of the malloc debug specific code into the library.
Nothing related to the malloc debug data structures remains in libc.
- Removed the calls to the debug malloc cleanup routine. Instead, I
added an atexit call with the debug malloc cleanup routine. This gets
around most problems related to the timing of doing the cleanup.
The new properties and environment variables:
libc.debug.malloc.options
Set by option name (such as "backtrace"). Setting this to a bad value
will cause a usage statement to be printed to the log.
libc.debug.malloc.program
Same as before. If this is set, then only the program named will
be launched with malloc debug enabled. This is not a complete match,
but if any part of the property is in the program name, malloc debug is
enabled.
libc.debug.malloc.env_enabled
If set, then malloc debug is only enabled if the running process has the
environment variable LIBC_DEBUG_MALLOC_ENABLE set.
Bug: 19145921
Change-Id: I7b0e58cc85cc6d4118173fe1f8627a391b64c0d7
|