History log of /bootable/recovery/roots.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
3e18f2bf4004e9df2f7fcee0d2035552404ff715 30-Sep-2017 Tao Bao <tbao@google.com> roots: Fix an issue with volume_for_path().

The earlier commit in 2dfc1a38982c4052bb32bc7fc06edeadf3908fb9
unintentionally changed the behavior. It gives a different result when
looking up non-existent mount points (e.g. /cache on marlin).

The logic behind volume_for_path("/xyz") is unclear:
- It's fine to return non-null value if it's called by
ensure_path_mounted() before accessing that file "/xyz". (Just based
on the function name, we're not actually having this case.)
- It should return nullptr if the caller is interested in the existence
of that particular mount point "/xyz".

This CL renames the function to volume_for_mount_point(), which does an
exact match by querying the given mount point from libfs_mgr. The former
volume_for_path() has been moved down to function scope for serving
ensure_path_mounted() only.

Test: Build and boot into recovery on bullhead and marlin respectively.
'View recovery logs'.
Test: 'Mount /system'
Test: 'Apply update from ADB'
Change-Id: I1a16390f57540cae08a2b8f3d439d17886975217
/bootable/recovery/roots.h
ac9d94d19c5f0e8c769d2368790df679c665ea34 03-Nov-2016 Tao Bao <tbao@google.com> Revert "Revert "Some cleanups to recovery.""

This reverts commit 8584fcf677dd45b30121bd0490b06297e6be1871.

This CL re-lands commit c0319b60f56d445c2d1c74f551e01f069b028fe6.
The "stage" and "reason" variables are now declared as global by
dropping the static qualifier, because they may be used by vendor
recovery libraries.

Test: lunch aosp_angler-userdebug; mmma bootable/recovery
Test: lunch aosp_dragon-userdebug; mmma bootable/recovery

Change-Id: I252c346f450079478cff22bbff01590b8ab2e2b3
/bootable/recovery/roots.h
8584fcf677dd45b30121bd0490b06297e6be1871 27-Oct-2016 Dan Albert <danalbert@google.com> Revert "Some cleanups to recovery."

This reverts commit c0319b60f56d445c2d1c74f551e01f069b028fe6.

Reason for revert: Broke builds.

Change-Id: I82aa880b83de5ae6c36fd7567cb001920559a972
/bootable/recovery/roots.h
c0319b60f56d445c2d1c74f551e01f069b028fe6 14-Oct-2016 Tao Bao <tbao@google.com> Some cleanups to recovery.

- Remove the duplicate gCurrentUI variable in recovery.cpp;
- Refactor the load/save of locale functions;
- Clean up ui_print() to get rid of 256-byte buffer limit;
- Declare ui in common.h;
- Move the typedef of Volume into roots.h.

Test: Build and boot into recovery image.

Change-Id: Ia28c116858ca754133127a5ff9c722af67ad55b7
/bootable/recovery/roots.h
d0db337d727707977fa562bcc492b27270e67937 05-Nov-2015 Paul Lawrence <paullawrence@google.com> Create convert_fbe breadcrumb file to support conversion to FBE

Change-Id: I38b29e1e34ea793e4b87cd27a1d39fa905fddf7a
/bootable/recovery/roots.h
abb8f7785ee24eac42f6d28dbfef37872a06c7e9 30-Jul-2015 Tao Bao <tbao@google.com> recovery: Allow "Mount /system" for system_root_image.

When system images contain the root directory, there is no entry of
"/system" in the fstab. Change it to look for "/" instead if
ro.build.system_root_image is true. We actually mount the partition
to /system_root instead, and create a symlink to /system_root/system
for /system. This allows "adb shell" to work properly.

Bug: 22855115
Change-Id: Ibac493a5a9320c98ee3b60bd2cc635b925f5454a
/bootable/recovery/roots.h
c277762de13653f73451e1a21fe73eafc51f918e 30-Mar-2015 Andres Morales <anmorales@google.com> Revert "Erase PST partition if its marked to be erased."

This now gets done at the framework level.
Doing it here breaks the signature on the partition.

This reverts commit ee19387905650cab5da7dd97ada5502cd17ac93d.

Bug: 19967123
Change-Id: I2a977cb0f0ba94defa1bf9091219398ddc1d3528
(cherry picked from commit 037444642bc32d8fed3bb996823b6a62faa57195)
/bootable/recovery/roots.h
ee19387905650cab5da7dd97ada5502cd17ac93d 06-Aug-2014 Andres Morales <anmorales@google.com> Erase PST partition if its marked to be erased.

We need to wipe the challenges on this partition
if OEM unlock is enabled, as this is a signal that
the user has opted out of factory reset protection.

go/factory-reset

Bug: 16633064
Change-Id: Icb8f1433bf99ca57813f5b72d5a3dd15fa94a263
/bootable/recovery/roots.h
239ac6abac4524be93fce710360c0512c6cc2ab3 21-Aug-2013 Doug Zongker <dougz@google.com> recovery: install packages in a known mount environment

When installing a package, we should have /tmp and /cache mounted and
nothing else. Ensure this is true by explicitly mounting them and
unmounting everything else as the first step of every install.

Also fix an error in the progress bar that crops up when you do
multiple package installs in one instance of recovery.

Change-Id: I4837ed707cb419ddd3d9f6188b6355ba1bcfe2b2
/bootable/recovery/roots.h
28ce47cfa6919518a8c298088bf08b03bb374c0f 28-Oct-2011 Doug Zongker <dougz@android.com> turn recovery into a C++ binary

Change-Id: I423a23581048d451d53eef46e5f5eac485b77555
/bootable/recovery/roots.h
cc8cd3f3cac07f6927ead277ef390c000ae798d9 20-Sep-2010 Doug Zongker <dougz@android.com> remove the notion of "root path"; support mixed flash types

Remove the wacky notion of "roots" and "root paths" (those things that
look like "FOO:some/path" instead of just "/foo/some/path"). Let each
device specify its own table of available partitions and how to mount
them (needed for devices that use both MTD/yaffs2 and EMMC/ext4
partitions).

(Cherrypicked from gingerbread w/slight edits.)

Change-Id: I2479ce76b13e73f1d12035c89386c3a82b3edf51
/bootable/recovery/roots.h
d7d4208976125d114d0b8e44438e2417d5275098 17-Sep-2010 Doug Zongker <dougz@android.com> remove unneeded partition roots

Recovery itself no longer needs to access all these partitions;
manipulation of them is done by the updater binary. This is a small
first step towards removing roots entirely.

Change-Id: I3fbcada32079a37db4cc097861dfa91e0a08da30
/bootable/recovery/roots.h
c24a8e688a6312764254beac2b2520bb0c5e998d 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/bootable/recovery/roots.h
ffb48f64fec674c6dd923eb8b1eb3f743e05a8ba 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/bootable/recovery/roots.h
23580ca27a0a8109312fdd36cc363ad1f4719889 21-Oct-2008 The Android Open Source Project <initial-contribution@android.com> Initial Contribution
/bootable/recovery/roots.h