| 767543a6598a3aa92b023ca9d97e6a5c6fb526ec |
|
01-Mar-2018 |
Tao Bao <tbao@google.com> |
releasetools: Call Cleanup() in check_target_files_signatures.py.
Also minor cleanups to make it pylint clean.
Test: Run check_target_files_signatures.py with a target-files.zip.
Test: pylint --rcfile=pylintrc check_target_files_signatures.py
Change-Id: Ife3b54c7805c2f2562e87e91ab4b4de355782012
/build/make/tools/releasetools/check_target_files_signatures.py
|
| dba59eeabd21c91d67d6a6ce365141deb56ed0f7 |
|
09-Jan-2018 |
Tao Bao <tbao@google.com> |
releasetools: Don't return ZipFile from common.UnzipTemp().
In addition to the unzipping work, common.UnzipTemp() kindly bundles an
open ZipFile object as part of the return value. It doesn't look very
helpful to the callers though. It also looks less obvious that the
caller needs to properly close the handle (missing the close here is
benign though). This CL just removes the ZipFile object out of the
return value, and leaves the work to callers.
Test: `m dist` on both of A/B and non-A/B target.
Test: python -m unittest test_add_img_to_target_files
Test: python -m unittest test_common
Test: python -m unittest test_ota_from_target_files
Test: Check the callers to common.UnzipTemp() in code search.
Change-Id: Id47da3fd42a0e76d6ae8851f05780db319ee48cf
/build/make/tools/releasetools/check_target_files_signatures.py
|
| d32e78fd3c447278cf5539164f8764fbe5ae1cca |
|
17-Jan-2018 |
Tao Bao <tbao@google.com> |
releasetools: Add a note for the ZipInfo._decodeExtra() workaround.
Test: N/A
Change-Id: I9e84fc27230182f17c2fda0df57a2c149281dcda
/build/make/tools/releasetools/check_target_files_signatures.py
|
| a07bf049b9ac92b9c4f82092ac0b10f78c762998 |
|
14-Aug-2017 |
Narayan Kamath <narayan@google.com> |
releasetools: Add support for compressed APKs.
Compressed APKs can be identified by a "compressed=<ext>" entry in
the apkcerts.txt file. When we encounter such an entry, we need to
decompress the file to a temporary location before we process its
certs. When we're signing, we should also recompress the package
after it's signed.
Bug: 64531948
Test: ./build/tools/releasetools/check_target_files_signatures.py
Test: ./build/tools/releasetools/sign_target_files_apks.py
Test: compared signed output before / after this change, verify that
it's bitwise identical when no compressed APKs are present.
Change-Id: Id32e52f9c11023955330c113117daaf6b73bd8c2
/build/make/tools/releasetools/check_target_files_signatures.py
|
| 6b0b2f9db0c7d89a678e5b0cb9dbffbec3d96f0b |
|
05-Mar-2017 |
Tao Bao <tbao@google.com> |
Revert "Revert "releasetools: Use pattern filter when unzipping.""
This reverts commit a7316ce094d4635fa027a99840714af8e579184b.
This CL differs from the original CL by not unzipping RADIO/*. This is
because: a) AOSP targets don't have RADIO/ entries in the TF.zip; b)
we're not using the unzipped RADIO files (but reading them from the zip
files directly) - checked all the device-specific releasetools for
angler, bullhead, ryu, shamu, volantis, fugu, marlin and sailfish.
Test: `m dist` with AOSP targets (tested fugu and bullhead).
Change-Id: I4d0c67214ddd6202fc27c71bb79f52b5f4d40c64
/build/make/tools/releasetools/check_target_files_signatures.py
|
| a7316ce094d4635fa027a99840714af8e579184b |
|
05-Mar-2017 |
Tao Bao <tbao@google.com> |
Revert "releasetools: Use pattern filter when unzipping."
This reverts commit aa3a04f19de6b888be7f58d5e8cf37fe2725e949.
Reason for revert: Some AOSP targets don't include RADIO/ in the TF.zip. We may possibly skip unzipping RADIO/, or by always creating a dummy RADIO folder in TF.zip. Revert this CL for now.
Change-Id: I8e90d322706a4fe82129bdfab5ffa1eab989c648
/build/make/tools/releasetools/check_target_files_signatures.py
|
| aa3a04f19de6b888be7f58d5e8cf37fe2725e949 |
|
04-Mar-2017 |
Tao Bao <tbao@google.com> |
releasetools: Use pattern filter when unzipping.
When building BBOTAs, it only needs *some* unzipped entries in the given
target_files zip(s). In particular, it needs 'IMAGES/*', 'META/*',
'RADIO/*'. (It also reads 'SYSTEM/build.prop' and 'OTA/bin/updater', but
directly from the zip file.)
This CL specifies the entries to unzip. It saves the I/O cost, as well as
the temporary storage.
Test: ota_from_target_files.py gives the same package w/ and w/o the CL.
Test: check_target_files_signatures.py still works.
Change-Id: I728428aa0e138879e49f9efbdb46a85892fc7038
/build/make/tools/releasetools/check_target_files_signatures.py
|
| 6a54299fbd16a3bd2051f08d5dbdaf94b95bf485 |
|
28-Jul-2016 |
Tao Bao <tbao@google.com> |
Handle multiple APKs from the same package in check_target_files_signatures.py.
We were using the package name as the key to index APKs. APKs from the
same package got messed up and gave wrong signature summary. Switch to
using the package filename as the key, which is identical in a given build.
Also fix the trailing space when printing the signature summary.
Bug: 30418268
Test: Run with a target_files.zip that has multiple APKs from the same package.
Change-Id: I6317e8c05e987c5690915e05c294153d10e2f0ab
/build/make/tools/releasetools/check_target_files_signatures.py
|
| 726b7f338f32ca6d18e9961b0a2da3ef385f7e34 |
|
04-Jun-2015 |
Tao Bao <tbao@google.com> |
Fix the broken signing script
check_target_files_signatures.py was accidentally broken due to the
renaming of a variable in last commit. It escaped the checking from
pylint because it was a keyword ('all').
Bug: 21611858
Change-Id: I58c983e59c4a3e0018481d3c9ba328ed76f5c08a
/build/make/tools/releasetools/check_target_files_signatures.py
|
| 8b72aefb5a8ed4da28c6f83854e8babf53b9cb53 |
|
24-Mar-2015 |
Dan Albert <danalbert@google.com> |
Make releasetools pylint clean.
This caught a few bugs/syntax errors (a few character classes were not
escaped properly in regex patterns, some indentation was illegal,
etc).
Change-Id: I50637607524e68c4fb9cad7167f58a46b8d26b2c
/build/make/tools/releasetools/check_target_files_signatures.py
|