History log of /device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
e1ce92801a18f6f620b9b06bedb66d4d96c1a4b7 23-Feb-2018 huans <huans@google.com> Add availableHotPixelModes

Bug: 73826877
Test: run cts -m CtsCameraTestCases -t
android.hardware.camera2.cts.CameraDeviceTest#testCameraDevicePreviewTemplate
Change-Id: I86e0d1d2a2423476f9f2303132516a9a7a299938
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
df6c378383cb408c29e4efdd1c2d3af3996167ba 24-Jan-2018 huans <huans@google.com> Add Altitude entry for default GPS settings.

Bug: 72320253
Test: Manual
Change-Id: Iad0fff552e15cc4053c0b3cae921318500737e89
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
03f8d09be1e4d48d2093df9f79058de6c04aafcb 12-Jan-2018 huans <huans@google.com> Camera HAL3 supports multiple dimensions

Bug: 70507102, 70507373
Test: run cts -m CameraTestCases
run cts -m CtsMediaStressTestCases -t
android.mediastress.cts.MediaRecorderStressTest#testStressRecordVideoAndPlayback
run cts -m CtsNNAPITestCases -t GeneratedTests#mobilenet
run cts -m CtsMediaTestCases -t
android.media.cts.CamcorderProfileTest#testGetWithId
run cts -m CtsMediaTestCases -t
android.media.cts.CamcorderProfileTest#testGet

Change-Id: I969701f8afddcf6cfbc1138bc6574daf0d429b91
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
3c529efd62a4cd4057a588769af51ec4a652b784 20-Dec-2017 Lingfeng Yang <lfy@google.com> Add 176x144 as supported resolution for camera3

Required by framework.

bug: 70507373

Test: Pass all android.media.cts.MediaRecorderTest
Specifically to fix
android.media.cts.MediaRecorderTest#testSetMaxFileSize
android.media.cts.MediaRecorderTest#testSetOutputFile

Change-Id: Id66364eb400f08bb5afb6fd2f8aee7f3401f6ceb
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
ab33034269950c1bfd121f4d3855b5b3f9bd4f8a 08-Nov-2017 huans <huans@google.com> Add check for width, height and rotation in stream configuration.

Bug: 69002477, 69002512, 69002554, 69002570
Test: run vts -m VtsHalCameraProviderV2_4Target -t
CameraHidlTest.configureStreamsInvalidOutputs_32bit

Change-Id: Ifa384832433e37ab4f39c607257f85fc51e4d443
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
a0c2d35904b979205e1a47131a2bc2528d1e9894 06-Nov-2017 huans <huans@google.com> Update 3A control region, add black/white levels.

Bug: 68388225
Test: run cts -m CameraTestCases -t
android.hardware.camera2.cts.CaptureRequestTest#testDigitalZoom
Change-Id: I9852744bac8fcfdf8210a3d9bb54ea859d27e8d1
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
0555a2ffa1009863a9a9e50f99e4f071ce6de1c7 01-Nov-2017 huans <huans@google.com> Disable RAW, AeCompensation; add missing properties

RAW cause multiple CTS failure, disable it so far;
HAL3 does not have AeCompensation implemented, disable it;

Bug: 68723953, 68388405, 68148374
Test: Run Camera CTS
Change-Id: I67d09f44c3fd65d8db4c5e7f311d81b8a5f24b89
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
da4478658a8402646d3365a2b2b7c99f2dac1795 31-Oct-2017 huans <huans@google.com> Set default fps 30 for both Camera HAL1 and HAL3.

HAL1 used 24, while HAL3 chose 30 as default fps. When switching between
HAL1 and HAL3, need update the fps in media_profile. Setting the same
fps avoid this issue.

Bug: 68388303, 68388341, 68388474
Test: CTS for HAL1 and HAL3
Change-Id: Iac274811e6f1280b022ee22e7ed93ba9ecbfc627
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
19355397a1761a28ded6212e841bf7219eb4fc6d 30-Oct-2017 huans <huans@google.com> Set the Camera buffer format, inline with gralloc implementation.

Bug: 67632784
Test: run cts -m CameraTestCases -t
android.hardware.camera2.cts.RecordingTest#testSupportedVideoSizes

Change-Id: I5afd6ef7021b7d756144ec6d7ae3bb7289543449
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
b8ba9ca1fc891b41b440bafce03bfd2dbaee1488 28-Oct-2017 huans <huans@google.com> Set android.colorCorrection.aberrationMode HIGH_QUALITY for still
template

Bug: 68388189
Test: run cts -m CameraTestCases -t
android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceStillTemplate

Change-Id: I64f8bf68401c4cc6b0b3c9f9b54d3a5b8ba407f5
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
01852b7d2279e42e262656b88c2f01efdb0a1436 13-Oct-2017 huans <huans@google.com> Add and attach Exif/Thumbnail for Camera Jpeg image

Bug: 67678657
Test: Manual

Change-Id: I4b5d602177cf24bd23a17d14820ed64a88f8e80f
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
77477baae2dc778ab25fee20c3c91bc770b8fdce 11-Oct-2017 huans <huans@google.com> Fix android.hardware.camera2.cts.RecordingTest#testBasicRecording
Assign YUV or RGBA format to camera stream buffer, inline with gralloc
implementation.

Bug: 67511092
Test: Manual
Change-Id: I0f6dfa041d2f31b5f8cbb13a35a278adaf63e6a8
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
4099ed40cf271c9b0c1f2c3b8aa19ca11fbf38e6 28-Jul-2017 huans <huans@google.com> O-CTS android.hardware.camera2.cts.PerformanceTest#testMultipleCapture

CTS tries 100 times to check the ANDROID_CONTROL_AE_STATE_CONVERGED.
If Emulated Camera starts with ANDROID_CONTROL_AE_STATE_INACTIVE, it
will consume the 100 tries to arrive at CONVERGED.

BUG: 63902023

Test: CTS testMultipleCapture passes
Change-Id: Iabb56369f7da22fdde816b9800a700fbca23153a
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
1c05f520f885211f8f590f363fb211379dbe8e0c 27-Mar-2017 Eino-Ville Talvala <etalvala@google.com> Camera: v2/v3: Fix deadlock in sensor / result thread communication

Sometimes, the HAL locks up in a situation where
android::Sensor::waitForNewFrame and android::Sensor::threadLoop are
both waiting on the other to signal; specifically on lines
Sensor.cpp:294 and Sensor.cpp:198.

This results in FastBasicsTest#testCamera2 fail at a ~8% rate in
presubmit testing (assuming this is the only source of failures).

After some staring at the code, the likely issue is that
waitForNewFrame only signals on mReadoutComplete when it didn't wait
for mReadoutAvailable. This isn't actually foolproof, if the sensor
threadloop manages to execute twice (and ends up waiting for
mReadoutComplete) before the readout thread is woken up from its wait
on mReadoutAvailable.

So make the signaling unconditional in waitForNewFrame.

Additionally switch to "HAL_PIXEL_FORMAT_YCBCR_420_888" for NV12 stream
case.

Test: Lots of local iterations of CTS
android.hardware.camera2.cts.FastBasicsTest
Bug: 36233279

Change-Id: Ia64af66d1c5d908b8c081d0bb00adce282226924
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
2ea5ca4a8c12142cf75d5e2d333b39788aea7448 21-Mar-2017 Eino-Ville Talvala <etalvala@google.com> Camera: Fix assorted HALv3 bugs to pass more CTS

- Fill out all fields of camera_result_t for JPEG capture
- Use AF OFF for front camera default focus mode for all templates
- Rework sensor sizing to be consistent across capture stack, to avoid
attempting to write big buffers into small spaces, or reporting the
same size multiple times.
- Fix 'scaling' math so that writing to output buffers doesn't overflow
More specifically, downscaling is done by simply skipping N pixels;
the rounding of the increment variable was wrong.
- Fix JPEG encoder being used in two requests in a row by reserving it
for use earlier in the pipeline.
- Fix some basic issues with autoexposure and auto-white balance to
correctly follow changes to control modes and states.
- Cut down on the per-frame logging.

Test: Now passing android.hardware.camera2.cts.FastBasicsTest, along
with many other camera CTS tests. Failures mostly in timing checks,
recording, and flakiness. Pass: 181 / Fail: 39
Bug: 36233279
Change-Id: If0a77a697de5659c35dd64f3fa3a70115c8d082c
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
fefb9fcf82347b698b345c2b8ff8d6bff3ceb0a1 15-Mar-2017 Eino-Ville Talvala <etalvala@google.com> Camera: Remove references to goldfish gralloc private details

Both v2 and v3 camera HALs were assuming that gralloc handles
contained private details only available on the goldfish emulator
gralloc. Remove these references, and map IMPLEMENTATION_DEFINED
to RGBA_8888.

Test: Camera app produces non-black output when started
Bug: 36233279
Change-Id: I3769be05f881532702efeaec672781dc3e670165
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
cfd093cb74496b657a40463de530a28dcb3ac926 04-Mar-2017 Ping-Hao Wu <pinghao@google.com> Replace GraphicBufferMapper with gralloc module.

BUG: 35036220
Test: Local
Change-Id: I117c1874f721141506b35aeea17a28dbe4131938
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
2cbbe5ffb511337b815f83aa8d3e6a29907cd4de 20-May-2016 Adam Buchbinder <abuchbinder@google.com> Fix memory-handling issues in EmulatedFakeCameras under goldfish/.

This fixes the following cppcheck reports:
[device/generic/goldfish/camera/EmulatedFakeCamera2.cpp:1121]: (error)
Mismatching allocation and deallocation: ReadoutThread::mInFlightQueue
[device/generic/goldfish/camera/EmulatedFakeCamera3.cpp:928]: (error)
Memory leak: sensorBuffers
[device/generic/goldfish/camera/EmulatedFakeCamera3.cpp:928]: (error)
Memory leak: buffers

Change-Id: Iad49d0a4760fcddbe73f25b2504331e8f2a690ae
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
dc1c14fefacc744c5e11aea7a0874ef9f0639583 12-Feb-2016 Christopher Wiley <wiley@google.com> Support generic buffers in EmulatedFakeCamera3

When we're using a gralloc HAL other than the goldfish version (e.g.
gralloc.default, which gralloc.goldfish will fall back on), we
are not given cb_handle_t. Check for this and fall back appropriately.

Bug: 26936651
Test: brilloemulator stops complaining about a format of 0.

Change-Id: I7a84c775ee6c49e23c82afb8f8b1f490505a55c5
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
4a91c438b37988bf2faaaa1fd8d827d2b3a894dd 20-Aug-2015 Eino-Ville Talvala <etalvala@google.com> Camera: Fix poseRotation quaternion

Order is x,y,z,w; not w,x,y,z.
Also, the conditional should not be double-flipped.

Bug: 20537722
Change-Id: I25a671c7b7b94160321a654e08bf918628e9edd2
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
c52b876faea09e94b69fee865e249cb3a2b0bfb1 06-Aug-2015 Eino-Ville Talvala <etalvala@google.com> Camera/gralloc: Add basic capability handling, support DEPTH

Also fix bug with AE not correctly overriding sensor values
when ON but still INACTIVE.

- Add Y16 support to gralloc (treat exactly as RAW16)
- Add Y16 output support to camera
- Adds depth static and dynamic fields to camera:
- poseRotation
- poseTranslation
- intrinsicCalibration
- radialDistortion
- availableDepthStreamConfigurations
- availableDepthMinFrameDurations
- availableDepthStallDurations
- depthIsExclusive

Bug: 20537722
Change-Id: If64bb2a698a8a49777f848cfc6401d8fba299541
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
79f8dcdb2da221f2e6992f53a83c36b95332fc2e 14-Jul-2015 Eino-Ville Talvala <etalvala@google.com> Camera: Update emulator camera v3 HAL to v3.3, module to v2.3

Many updates to meet requirements of v3.3, including quite a few
of metadata updates.

Not all features promised by the metadata are actually wired up,
though.

Also adds initial support for capability selection based on system
properties, though the selection isn't reflected in behavior
outside the capability field for the most part.

Sufficient to make the AOSP camera app run (and even record video),
but not sufficient to pass all the CTS tests yet.

Bug: 20537722

Change-Id: I0776fe361492402189569b7ab5c2f37b6900ffc5
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
847be6a44c7bd1ea7ba5231033a0ca6bf13b0254 11-Apr-2015 Eino-Ville Talvala <etalvala@google.com> Fix build: Remove LENS_POSITION from both HALv2 and HALv3

Change-Id: Iffde8b14d3937808ce367d60d34fa638cea13497
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
8eccde3f85742a7872f92a2a9c362e956609bb94 06-Mar-2015 Eino-Ville Talvala <etalvala@google.com> Remove one more RAW_SENSOR enum

Change-Id: Id5e0f5e7a02f7c2ab1442e8be65a019bf8cbe359
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
0f56d89863f3afbc782a44ae4b6df314cf74e9c1 18-Jun-2014 Colin Cross <ccross@android.com> am 765b8b4b: am 7ea757df: Merge "goldfish: camera: fix 64-bit warnings"

* commit '765b8b4bf218560acc79f665d5c6c56e0351469a':
goldfish: camera: fix 64-bit warnings
3725c7c982eac52ec64a625e82f306822452941c 18-Jun-2014 Colin Cross <ccross@android.com> goldfish: camera: fix 64-bit warnings

Change-Id: If15f27505e3849406769b7f03cb77ea8dec86e70
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
e0de435aed8d68abaa7e148710520f45a2087986 02-Apr-2014 Igor Murashkin <iam@google.com> camera3: Add missing android.sensor.orientation static info

* This also fixes camera2 api from not being able to create new requests

Bug: 12002757
Change-Id: Iad55381add850e92b8eb97f9c5cdf84455cda999
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
936bc2c55899c0bd97792032ea09684e9ea11ecf 10-Feb-2014 Ruben Brunk <rubenbrunk@google.com> camera3: Remove geometric correction tags.

Change-Id: I01d70e06540862f7f30df570cb447c4411d9e4d4
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
982e58da1a0c67a9cba552cd0d069f87b83cf9df 24-Jan-2014 Ruben Brunk <rubenbrunk@google.com> camera3: Update maxRegions tag.

Change-Id: I22501cbf7f941d9626b88182e2dda8a13a620d01
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
c653d1c8455317956955c9a633018be4e15a113d 18-Jan-2014 Ruben Brunk <rubenbrunk@google.com> camera3: Update sceneMode tag spec.

Change-Id: I495435397086a295280c556d94fe8efd442a12c3
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
0049ee8925212a3a5ff095a8a66cab184adf8f1b 18-Jul-2013 Zhijun He <zhijunhe@google.com> Camera2/3: Update static metadata

Change-Id: I795d30f236a65d610e0801f5c98f1191d18f0a21
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
07a4c8b42f561c05893e98f3d9feb7dc5f35a0ae 26-Jun-2013 Eino-Ville Talvala <etalvala@google.com> Camera3: Fix default AE mode

Change-Id: I70682e86f849feafc3cfafabace126c09f5df600
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
30717de92454be87aa55ac91d2b94a7872a0fcfb 24-May-2013 Igor Murashkin <iam@google.com> camera3: Make front cameras limited mode, back cameras full mode

Bug: 9111852
Change-Id: Iad7ba75adf603a7c2eda1fa07c10ce4aab1aa51b
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
7cb87e43550cae1e051530994a2c30e89a268862 09-May-2013 Eino-Ville Talvala <etalvala@google.com> Merge "Gralloc/Camera3: Support new HAL_PIXEL_FORMAT_YCbCr_420_888 format" into jb-mr2-dev
4a0a02bebf7c3b0b79df6635b8129d7a54b38da2 08-May-2013 Igor Murashkin <iam@google.com> camera: Fix availableMaxDigitalZoom property to be float

Bug: 8840802
Change-Id: I80e0d0fc2b5145597b09445f166bc998093ef603
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
ec38324c23d4865ec4b6f368f12814328771b4af 05-May-2013 Eino-Ville Talvala <etalvala@google.com> Gralloc/Camera3: Support new HAL_PIXEL_FORMAT_YCbCr_420_888 format

Enable flexible YUV format buffers from the camera.

- Add gralloc alloc support for YCbCr_420_888, mapped to NV21
- Add gralloc lock_ycbcr method
- Add new format to list supported by camera HAL
- Fix minor compilation warnings

Bug: 8734880
Change-Id: I68a8cc126985c7d5ae100a87b31c60ee59074cd3
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
303c7c2d5fd4041235fe35f2027ff63b210a80fa 26-Apr-2013 Igor Murashkin <iam@google.com> Various bug fixes to make ZSL work.

Bug: 8563838
Change-Id: I92385e06df235f7020970229c1a035c7410a2eb7
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
57ac67ad91c44ffd875b186f124234c2ab1958f3 12-Apr-2013 Eino-Ville Talvala <etalvala@google.com> Camera3: Add asynchronous JPEG

- Rework JpegCompressor to have generic async operation mode
- Wire up new JpegCompressor interface to FakeCamera2 and 3.

Bug: 8565103
Change-Id: Iba8cfa84a02434e73f4eeb2167ae0e400c29defb
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
4e8dfb1f38cb0f0ed72f05452d26f6b271e20419 10-Apr-2013 Eino-Ville Talvala <etalvala@google.com> Camera3: Add shutter notification

Mandatory now due to fragmented process_capture_result calls.

Bug: 8565103
Change-Id: I4e815e99a5220cc61650157894869189ceaf883d
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
899e89214055bed173e86b6c9e1113cd871f81c3 03-Apr-2013 Igor Murashkin <iam@google.com> Camera: Handle AF state transitions

Change-Id: Iac1f08ed9e0d0f4fc3e5a1c8974576f5f1febb74
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
199f6026e74e857fa7edbc3fe2cd78aebf94afc1 03-Apr-2013 Igor Murashkin <iam@google.com> Camera3: Allow register_stream_buffers while requests are in flight

Change-Id: I6dba0d282887c20ee683d8eaafd8bf81241f4767
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
e0400c6914fb7b8ab4fbdcf9348ccb97b551a6e0 02-Apr-2013 Igor Murashkin <iam@google.com> Camera3: Trigger IDs now received from framework

Before: Trigger IDs would increment internally in the HAL

After: Trigger IDs are read from the framework when the accompanying trigger
is explicitly set in the request.

Rationale:
Since the framework tracks its trigger completion based on the IDs it sends to
the HAL, we need the HAL to use the framework IDs instead of generating its own.

Change-Id: I0a4343c1f12b62c9432478a3bb8e0921a2da93c2
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
03a28bba9dcf5276cdf64408a648e1dddd2945ba 22-Mar-2013 Eino-Ville Talvala <etalvala@google.com> Camera3: Support for still capture

- Basic 3A routine with AE precapture support
- JPEG compression

Change-Id: I329bb6d2c5315e13ed657b096b8bb573c14a3738
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp
2de81ad1fbadb0b2dd26830f6bb97c19c783969f 12-Mar-2013 Eino-Ville Talvala <etalvala@google.com> Bare-bones emulated fake camera for HAL version 3

- Uses same backend as HAL version 2 fake camera.
- No fake 3A yet
- No reprocessing support
- No JPEG support

Change-Id: I9b55b05fbeac9d42340eb988021e65491d13a2f9
/device/generic/goldfish/camera/EmulatedFakeCamera3.cpp