| 2cc1786fb52b6c5e2d5666da710ea8db7724ad0d |
|
26-Jan-2018 |
Manoj Gupta <manojgupta@google.com> |
crasher: Rewrite to avoid C++ STL dependencies.
crasher.cc is mostly C code but was using iostream to write to
cerr. Use fprintf instead so that it can be linked without using
C++ libraries. This removes one of the last libstdc++ dependencies.
CQ-DEPEND=CL:*555608
BUG=chromium:803280
TEST=cheets_NativeCrash builds. logging_UserCrash passed.
Change-Id: I9c003cc1ba15218a761a451112f061ac3acfc929
Reviewed-on: https://chromium-review.googlesource.com/888320
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
/external/autotest/client/cros/crash/crasher/crasher.cc
|
| d8ee0cef72613e059e1a2a901e278df987d072d8 |
|
09-Dec-2016 |
Dominik Laskowski <domlaskowski@google.com> |
crash: Generalize crash testing library
In a previous CL, the reusable logic in logging_UserCrash was extracted
into library code. This CL adds optional parameters for customizing that
logic when the crasher process is running in a container.
For example, the test requires the PID of the crasher process. The
crasher may be running under su, so it prints its PID and the test
parses it. However, when the crasher is running in a different PID
namespace, the printed PID is incorrect. With this CL, the crasher
can be instructed to send its PID over a Unix domain socket, which
converts it to the receiver's PID namespace. The testing logic can
also be customized with a closure to replace the default crasher
invocation, which will be used by the cheets_NativeCrash test to
receive the PID before the crash.
BUG=b:27503472
TEST=cheets_NativeCrash
TEST=logging_UserCrash
Change-Id: Ia44bf0f5cef8fd54fb2d71ea20c42fbf278e27e0
Reviewed-on: https://chromium-review.googlesource.com/416358
Commit-Ready: Dominik Laskowski <domlaskowski@google.com>
Tested-by: Dominik Laskowski <domlaskowski@google.com>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
/external/autotest/client/cros/crash/crasher/crasher.cc
|
| 4074e1617d93530d30f8a27cc8895beb38e50c66 |
|
14-Apr-2016 |
Dominik Laskowski <domlaskowski@google.com> |
crash: Refactor test for user crash reporting
The logging_UserCrash test contains code that should be shared with the
ARC counterpart, specifically the crasher executable and Python helpers.
This CL pulls this into a UserCrashTest base class. The only functional
change is that the crasher executable is copied if an alternate path is
passed to _run_crasher_process. The ARC test needs a copy in the chroot.
This CL also fixes several lint errors.
BUG=b:27503472
TEST=logging_UserCrash
Change-Id: Ia8d92d1041b97624a369a7731a7fa927abeb9b0e
Reviewed-on: https://chromium-review.googlesource.com/338846
Commit-Ready: Dominik Laskowski <domlaskowski@google.com>
Tested-by: Dominik Laskowski <domlaskowski@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
/external/autotest/client/cros/crash/crasher/crasher.cc
|