018730814bafdd4647a8370721960cb1f3d2c6d3 |
|
13-Feb-2018 |
Wai-Hong Tam <waihong@google.com> |
Chameleon: Split extension into two for audio and display APIs Chrome display APIs require the autotestPrivate permission which can only be applied to an extension. But the audio APIs can only be used in an app, not an extension. We need to split the current single extension/app into two: one as an extension for display APIs and one as an app for audio APIs. The display test extension inherits the original multimedia test extension (whitelisted for autotestPrivate) and the audio test extension is new. BUG=chromium:810519 TEST=Ran suite:chameleon_hdmi_perbuild and suite:chameleon_audio_perbuild Change-Id: I7f9660ad25121f208aed7fa7b40882f90076382f Reviewed-on: https://chromium-review.googlesource.com/917008 Commit-Ready: Wai-Hong Tam <waihong@google.com> Tested-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
92bb409ba93356d341fbc25735d2ec9fe114514e |
|
08-May-2017 |
Hirokazu Honda <hiroh@chromium.org> |
Enable logs for video autotests Make verbose video logs enable before each video autotest and make them diable after the test. The function to enable verbose printk log for elm/oak is not implemented yet. BUG=chromium:697733 TEST=video autotests on exynos and an intel device. Change-Id: I2a89076b66c541467699cbdad56e19cac41ad07d Reviewed-on: https://chromium-review.googlesource.com/499827 Commit-Ready: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2 |
|
06-May-2017 |
Victor Hsieh <victorhsieh@chromium.org> |
Stop control display via settings page chrome.system.display.setDisplayProperties can do the job. This API is limited to some use case, so we need to allow autotest extension to use it first. TEST=test_that display_ResolutionList TEST=test_that platform_RotationFps TEST=test_that video_PlaybackQuality TEST=test_that display_Tearing TEST=test_that video_GlitchDetection (failed, but even w/o this change) BUG=chromium:712705 Change-Id: Ia45c6da7d72e2de5ebc8f01ca1124811f283b0f3 Reviewed-on: https://chromium-review.googlesource.com/498013 Commit-Ready: Victor Hsieh <victorhsieh@chromium.org> Tested-by: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by: Victor Hsieh <victorhsieh@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
bd762fd7ab3497f4690d381db9624525f6d953c5 |
|
15-Mar-2017 |
Achuith Bhandarkar <achuith@chromium.org> |
autotest: init_network_controller=True Wherever we use SetHTTPServerDirectories, we should set init_network_controller=True. Also fix a bunch of pre-submit errors. BUG=chromium:701629 TEST=trybots. Change-Id: I79f52c10a596695d83c9152035a9878ca7969e60 Reviewed-on: https://chromium-review.googlesource.com/455320 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
62c44d80338e7c092587e667cc149350009c8c5e |
|
17-Feb-2016 |
Mussa <mussa@chromium.org> |
Use either DP or HDMI ports, whichever available. We have been using devices that have chameleon connected to hdmi to run our tests. We can widen the pool of devices by utilizing DP ports as well. In code, use whatever port that was found. We still run inside a pool, if you don't want to use something like VGA just don't add the VGA device into the pool. BUG=None. TEST=None. Change-Id: Ie2ec076883093655248febf1a3e51bc14925858e Reviewed-on: https://chromium-review.googlesource.com/327734 Commit-Ready: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
2629d57f1dad30dd9d3de53790bb8849c5490239 |
|
16-Feb-2016 |
avinash kodipelli <avkodipelli@chromium.org> |
Refactoring using new native HTML5 API's This test is removing locl html file and using shared html file BUG=chromium:566122 TEST=manual Change-Id: I7989d3ecfa6fbb3fcc0aa5d171a74458b37db8ed Reviewed-on: https://chromium-review.googlesource.com/327704 Commit-Ready: Avinash Kodipelli <avkodipelli@chromium.org> Tested-by: Avinash Kodipelli <avkodipelli@chromium.org> Reviewed-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
28762aa036959b0eaa7868d552c2ab88b4995f01 |
|
27-Jan-2016 |
Mussa <mussa@chromium.org> |
Loop to get a set of good frames. We have crbug/580736 open tracking the bug that we have get repeated frames when we try to capture frames. This CL introduces a loop, when we get repeated frames, we will simply try again. When that bug is fixed, we should revisit whether we are keeping the loop or not. BUG=chromium:580736 TEST=Local. Change-Id: Iec9dedd700c4c84a7fa85c4aecc6a2a1c15bd968 Reviewed-on: https://chromium-review.googlesource.com/324081 Commit-Ready: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
990897c202ea499ccb09cd65120ce48c944bc319 |
|
05-Jan-2016 |
Tom Wai-Hong Tam <waihong@chromium.org> |
Chameleon: Hack to reset fullscreen due to a wrong window position There is a bug in Chrome that fails to move the window to a correct position. Resetting fullscreen helps to resolve the problem and makes the test correct. BUG=chromium:574284 TEST=Ran the video_GlitchDetection_chameleon_vp8_720p on peach_pit. Change-Id: Iab412c8d46fa899b7aabe8778c55b6e3f734ce56 Reviewed-on: https://chromium-review.googlesource.com/320491 Commit-Ready: Wai-Hong Tam <waihong@chromium.org> Tested-by: Wai-Hong Tam <waihong@chromium.org> Reviewed-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
69222d9b346316392876efc396dc27860a92c6f9 |
|
17-Dec-2015 |
Mussa <mussa@chromium.org> |
Use 60fps 720p H264 video for Chameleon Image Comparison Tests. Chameleon captures video frames at 60fps. By using a 60fps video, captured frames don't repeat as often. This improves the chances that a bug free video will pass the frame checksum comparison. Hence, we reduce false positives. Other changes: ============== * Wait for event 'canplaythrough' when loading a video. I changed this from waiting for 'canplay' because 'canplaythrough' waits until the full video is buffered. This ensures that we can play the video continuously, reducing the chances that a video has to buffer while chameleon is capturing frames. As a result, increase the wait time out from 30s to 120s. * Print checksum counts into debug logs. BUG=None. TEST=Ran test on a few devices. Change-Id: I0135422f5475b9116675b393064ce57d5f3e7104 Reviewed-on: https://chromium-review.googlesource.com/319111 Reviewed-by: Wai-Hong Tam <waihong@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
3ea31ea7ed802ad963135576e3b12be6c48dee84 |
|
02-Dec-2015 |
David Haddock <dhaddock@chromium.org> |
Image comparison results page for video runs. This change generates an html page that allows you to flick through an array of paths. Example here: https://pantheon.corp.google.com/m/cloudstorage/b/chromiumos-test-assets-public/o/dhaddock/Test/slideshow.html BUG=None TEST=test_that -b <board> <ip> video_GltichDetection* Change-Id: If424c178c5dae990056a01b1a7d2dd593a5f295f Reviewed-on: https://chromium-review.googlesource.com/311805 Commit-Ready: David Haddock <dhaddock@chromium.org> Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
ebea153e11574dd429fc912b584f6a2c5e134f60 |
|
06-Nov-2015 |
Mussa <mussa@chromium.org> |
Reinstate checking that video can play before capturing. ** Also fix a few bugs I found while testing this change. We had this check before refactoring. It will catch a rare case that video can not play at all. It was missed during a refactor. So put it back. BUG=None. TEST=None. Change-Id: I6bcc87d476ee3e72e869718cc6fd9e65841976dd Reviewed-on: https://chromium-review.googlesource.com/311376 Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
8cab5cb5fbb5a759035a12382453aea5c1af3de9 |
|
02-Nov-2015 |
Mussa <mussa@chromium.org> |
Correct frame count conditional. We need to check if the # of golden checkums and the # of test checksums does not differ too much. Add the check in the conditional. BUG=None. TEST=Ran vp8 and mp4 tests on falco. Change-Id: I3cb159b685d08d72f7687f0f9206bc207b2eb0f6 Reviewed-on: https://chromium-review.googlesource.com/310213 Commit-Ready: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
f9cafd96a07eadf92d85cb82d7538e9a2706b1c1 |
|
29-Oct-2015 |
Cheng-Yi Chiang <cychiang@chromium.org> |
[autotest] multimedia: Rename display test extension Rename display test extension to multimedia test extension. This extension will be used for both display/video/audio tests. BUG=chromium:534953 TEST=run display_ClientChameleonConnection test Change-Id: I527c8930dc1b16083a24783d506acd66132b2cef Reviewed-on: https://chromium-review.googlesource.com/309549 Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
b448a758a490864f990c7815b1804aa1c6794ab5 |
|
21-Oct-2015 |
Mussa <mussa@chromium.org> |
Siimply Video Image Comparison Tests. Initially we were using screenshots taken using native terminal tools to test video playback quality. Now that we have chameleon we don't need to use screenshots anymore. Therefore, remove unwanted code and make the code flow easier to undestand. BUG=chromium:484057. TEST=Ran test on Jerry. Change-Id: I4abadc59f1b84d5522787510b63a6059dac995f1 Reviewed-on: https://chromium-review.googlesource.com/308628 Commit-Ready: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
55e4a38297449fcf3dbd693e2e6afe72fa84b519 |
|
30-Sep-2015 |
Ahmed Fakhry <afakhry@google.com> |
[Telemetry] Use browser.platform for SetHTTPServerDirectories and http_server SetHTTPServerDirectories and http_server were moved from Browser to Platform in the CL https://codereview.chromium.org/1364853006. This CL modifies the users of the Browser class to account for that change. BUG=chromium:537655 TEST=Ran the test locally Change-Id: I64dc425fbc6f5ed68993668739433e1d74a455f8 Reviewed-on: https://chromium-review.googlesource.com/303183 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Trybot-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
c02fefede41df9f1375b4b67d5f631b715e91ac1 |
|
26-Aug-2015 |
Chin-Huang Lin <chinlin@google.com> |
Chameleon: Use Telemetry ChromeOS Autotest Extension for Chameleon display tests. Since autotest_ext has provided access to chrome.windows object, we can simplify multimedia_test_extension. At the same time, we can also more easily develop new API functions, including set_full_screen and move_to_display. Action done: 1. Simplify multimedia_test_extension, and rename it to display_test_extension since audio tests do not use this extension currently and so that the new name is more explicit. 2. Add move_to_display() and set_fullscreen() into display_facade. 3. Modify chameleon_screen_test.py video_GlitchDetection.py display_ClientChameleonConnection.py to prevent regression. BUG=chromium:526916 Test=Tested on peppy with display_Resolution and passed. Change-Id: I18dda14bfbb23b27993b1c3d63785e22176eefb7 Reviewed-on: https://chromium-review.googlesource.com/295661 Commit-Ready: Chin-Huang Lin <chinlin@google.com> Tested-by: Chin-Huang Lin <chinlin@google.com> Reviewed-by: Yuli Huang <yuli@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
9e5559a5fa11f5610d756afb83c99e930c2ef94a |
|
21-Aug-2015 |
Mussa <mussa@chromium.org> |
Truncate test checksums if they are too many. Initially, I thought that we were getting too many test frames because the polling sleep interval took too long when the test was run in the lab. The fix went in but I still see the failures in some boards. This CL does two things: 1. Truncates the test checksums if they are too many. 2. Adds logging messages so that we can understand why this is happening. BUG=chromium:484057 TEST=Ran test on squawks. Change-Id: I2042685905eadf24ba67aa9de7158e871e85f5ee Reviewed-on: https://chromium-review.googlesource.com/295015 Trybot-Ready: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
e0b08e6170b57f90262726eb7f04e059cb47419c |
|
11-Aug-2015 |
Hsinyu Chao <hychao@chromium.org> |
Revert "autotest: move constants to common_lib" This reverts commit a4ac7a8f67d61f8a616724f9426dbc0fce71ce69. BUG=chromium:519353 Change-Id: Iec2873ad22b5bb90e46a9e5b323f9626a2c07d9b Reviewed-on: https://chromium-review.googlesource.com/292347 Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Tested-by: Sonny Rao <sonnyrao@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
a4ac7a8f67d61f8a616724f9426dbc0fce71ce69 |
|
06-Aug-2015 |
Eric Caruso <ejcaruso@chromium.org> |
autotest: move constants to common_lib This file gets imported from lots of server-side tests and infrastructure so it shouldn't be hiding in client/cros. This moves the file and fixes all imports. BUG=chromium:485834 TEST=run many tests, make sure there are no problems importing constants Change-Id: I5c2b2a0bef6ebc998e62f40162a6ec9cc4436480 Reviewed-on: https://chromium-review.googlesource.com/291302 Trybot-Ready: Eric Caruso <ejcaruso@chromium.org> Commit-Queue: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Chris Sosa <sosa@google.com>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
b8e622c18521e7171574396b7110925821f46807 |
|
08-Aug-2015 |
Mussa <mussa@chromium.org> |
[Chameleon] Allow user to specify max number of frames as an arg. We are capturing frames with chameleon asynchronously. We stop when we have got over the specified number of frames. This number has been specified as a configuration and it used during a test run. However, when we are collecting golden images we might need to choose a different number without having to change the conf. file. BUG=None. TEST=Ran test locally. Ensured nothing broke. Change-Id: I1bde45ccad9f3b9f27186c755929a687fd21a159 Reviewed-on: https://chromium-review.googlesource.com/291831 Trybot-Ready: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
2a13d12c2d4688567b9733e2216d532930fdb737 |
|
05-Aug-2015 |
Mussa <mussa@chromium.org> |
[Chameleon Video Tests] Save images when we receive too few of them. Sometimes we don't get as many frames as we expect. Specifically we are getting 1 frame repeated ~ 300 times. In this case and in the general case, save these frames in the results dir. BUG=chromium:516789 TEST=Temporarily set max frame count down from 360 to a much smaller number. Ran test, got same failure, checked that images were saved in resultsdir. Change-Id: I21a4ad00ee79b4d19c66c36057e0e9facf3182ba Reviewed-on: https://chromium-review.googlesource.com/290602 Reviewed-by: Wai-Hong Tam <waihong@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
5a04c913266fd9aa50a6393e2c3c059b19e5168d |
|
22-Jul-2015 |
Mussa <mussa@chromium.org> |
Use a Longest Common Subsequence(LCS) to compare chameleon frames. In our video frame comparison tests we have a list of golden checksums and a list of test checksums. Each checksum is computed from each frame. Due to the nature of capturing frames sometimes we miss a frame. Therefore, either of the two lists could end up with a missing frame, or what would appear to be an added frame in the other list. Currently we are walking the golden checksum list insisting that we find each checksum in the test checksum list. The test fails when we see a mismatch. But this mismatch could be because there is one extra or one less checksum, and the rest of the checksums could continue to be matched. SO, use LCS to measure how similar the two lists are. If we have less than 10 golden frames that coudln't be found in the test, we will say the test has passed. In future CLs, a check to make sure the mismatched frames are not consecutive will be added. BUG=chromium:484057 TEST=Ran a test 10 times on code without CL. Got a few (false) failures. Ran same test with this CL and got no failures. Change-Id: I5aea72e4cb9ada296e7df365b7108cf969e9c496 Reviewed-on: https://chromium-review.googlesource.com/285854 Reviewed-by: Wai-Hong Tam <waihong@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
f05e7fde321048aec0fef2303a181c6f69a26b59 |
|
24-Jul-2015 |
Mussa <mussa@chromium.org> |
Return pass if video image comparison test is run on an unsupported board. BUG=chromium:512292 TEST=Tested locally. Change-Id: I881c0d47e86130b9af5a138ec57b8311fa244aba Reviewed-on: https://chromium-review.googlesource.com/287911 Trybot-Ready: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
9627eb2b05b13171bc14a12a6e55eecc6b5339aa |
|
10-Jul-2015 |
Mussa <mussa@chromium.org> |
Dump checksums to log file to aid debugging. BUG=None. TEST=Local test on squawks. Change-Id: If1700b6f1bd9c2ea2f8338771363d0c953d2037e Reviewed-on: https://chromium-review.googlesource.com/284700 Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
d0c42994eca8286d9e4e53f275ec34e77da43814 |
|
29-May-2015 |
Mussa <mussa@chromium.org> |
Ensures first frame is loaded before capturing frames with Chameleon. + Use chameleon video image comparison tests on daisy and pit. Sometimes chameleon starts capturing frames before the video displays the first frame. This would cause the first frame to be totally white. At other times the capturing would start after the video has loaded. Make this deterministic by playing the video, pausing it, and then going back to '0' current time. BUG=chromium:418217 TEST=Tested on jerry that was previously failing. = Tested on daisy and pit. Change-Id: I064a20eb345c8321add8db498b18c58ade5ae211 Reviewed-on: https://chromium-review.googlesource.com/274530 Reviewed-by: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Commit-Queue: Aviv Keshet <akeshet@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
285d4ae4f893e3be1be202beb7f93d5472503089 |
|
05-May-2015 |
Mussa <mussa@chromium.org> |
Make Chameleon video image comparison less error prone. Chameleon captures frames very fast. Sometimes we get identical frames following one another. We have been doing a frame by frame comparison, demanding the exact same order of frames. This is very error prone. To fix this, use a unique set of consecutive frames checksums. During a test run, walk the frame buffer for searching for this sequence of frames. If there are more than one frame that have the same checksum, count this as one and get the next different checksum. I will add a control file for jerry. BUG=chromium:418217 TEST=Ran local tests on a jerry. Change-Id: Iebb3a0ab40d8f72b2bc81b4f9296e1a040f1ca27 Reviewed-on: https://chromium-review.googlesource.com/269412 Reviewed-by: Tom Tam <waihong@google.com> Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
e12f252071efa747f045e565594e4b03955a63af |
|
04-Apr-2015 |
Mussa <mussa@chromium.org> |
Ensure golden images list matches test images list. Refactored code to work for the case where we are using Chameleon. Introduced a bug where the sequence of time stamps was computed twice. This is random we ended up with non matching golden images and test images. BUG=None. TEST=Ran locally on squawks, which is passing on 42. (42 does not the breaking change.). Test Passed. Change-Id: Ia5759ad0aa61b999361f8464a900afd1012549ce Reviewed-on: https://chromium-review.googlesource.com/264013 Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
32a15dd607c55ed227b47591facd637b86fcb801 |
|
24-Mar-2015 |
Mussa <mussa@chromium.org> |
Use Chameleon to capture video frames for image comp tests. Chameleon helps us capture video frames during a video playback. Generating golden images will be done as a next step before enabling the test. BUG=chromium:418217 TEST=Locally tested. Change-Id: I9995d6d795cc2fade0f0d20813120d955d131bc6 Reviewed-on: https://chromium-review.googlesource.com/262202 Reviewed-by: Wai-Hong Tam <waihong@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
8957ec818a3fe50e93e56357a15b58b22a54614d |
|
13-Mar-2015 |
Ilja H. Friedel <ihf@chromium.org> |
Don't switch off screen before capture. Currently the screenshot utility is unable to capture screenshots when the screen switches off. Prevent this. Also get_display_resolution() should be public as it is used here. BUG=chromium:465590 TEST=test_that <ip> ui_SystemTray video_GlitchDetection.webm.480p passes Change-Id: I009901a9e3a6eccb504feaf862128bd7db5210ca Reviewed-on: https://chromium-review.googlesource.com/260052 Trybot-Ready: Ilja Friedel <ihf@chromium.org> Tested-by: Ilja Friedel <ihf@chromium.org> Reviewed-by: Haixia Shi <hshi@chromium.org> Reviewed-by: Ilja Friedel <ihf@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
c95277635c90ee616898d1f547440eff2dafc9cb |
|
26-Sep-2014 |
Mussa <mussa@chromium.org> |
Integrate Chameleon capturing into video tests. Video tests have been using native linux 'import' command to capture screenshots. We are now using chameleon to capture the screenshots. This serves as a first step to integrate chameleon into our video test suite. We will do so only with peach_pit and roll out to other devices. With this change we are also putting the logic to find chameleon ports into a seperate class that can then be reused. BUG=chromium:418217 TEST=Ran test on peach_pi. Change-Id: I38b9ea3311b53eda937f9eb685c0dd24a24af059 Reviewed-on: https://chromium-review.googlesource.com/220202 Reviewed-by: Hung-ying Tyan <tyanh@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
3f3b54f2a980afbc7f8b283432046e3af17b42f2 |
|
13-Sep-2014 |
Mussa <mussa@chromium.org> |
Force scale factor to value used for golden images. There was a change in the default scale factor that caused video images captured from hd devices: nyan and peach pi to appear larger than their corresponding reference images. This caused the tests to fail. We are fixing that in this CL. Applying these args on link will also change the underlying resolution. We therefore don't do that if the dut is a link. BUG=chromium:404773 TEST=Ran test on peach_pi and nyan_big without the change, confirmed that they fail locally as they do in the lab. Made the change and rann on same devices and ensured that the test passed. Ran with change on SD device and ensured the tests passed. (The scale factor change should not affect SD devices.) Ran on link with the change ensured tests also passed. Change-Id: I3b3a0a91b3f27a074ad9fb5b3fdb721473190d40 Reviewed-on: https://chromium-review.googlesource.com/217996 Reviewed-by: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
5f938c237602fe3d2f427d95f5311c4e22eb4408 |
|
05-Sep-2014 |
Mussa <mussa@chromium.org> |
Create ImageComparison Factory. Fall back to rgb comparison when bp is not available. Video tests have longed used image comparison to detect glitches. Recently we brought image comparison logic to ui/SystemTray. The factory logic that was once used in video tests was coupled with responsibilites that were specific to video tests. We couldn't reuse the factory to create just image comparison objects in ui tests. This change extracts the image comparison object making responsibility of the video test factory to its own factory: image_comparison_factory. We also modify the clients, both video and ui tests to use this new lightweight image comparison factory. Also, we have noticed that sometimes bp service is not available. This causes the test to fail because when it tries to create the bp_comparer an exception is thrown. Add logic to the image comparison factory that returns an rgb comparer when an attempt to create a bp_comparer fails. BUG=chromium:410890 TEST=Ran video_GlitchDetection test on link, verify they passed. Ran ui_SystemTray test on link, verify they also passed. Made bp_comparer raise an exception in its __init__ (simulating what would happen if bp service were not available). Ensured rgb_comparer was used although the test had asked for bp_comparer. Change-Id: I08a9a1d5b6a7fc25b2013ecc95204910f8871267 Reviewed-on: https://chromium-review.googlesource.com/216773 Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Reviewed-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
e354810a7be6057c91c30f9da7e65b2153c1164c |
|
29-Jul-2014 |
Mussa <mussa@chromium.org> |
Compare images locally before uploading to biopic. For our video tests we are currently using biopic to compare screenshots of the video. In some cases we end up uploading alot of images to biopic, this overloads the server, especially considering that we don't need to upload images which have passed the test. We could use biopic verification for test images that have failed the test. One solution to this is to use local comparison first and if that test fails, then upload to biopic so we can look at it later. In this CL: Introduce a local RGB comparer. Introduce a double comparer comparer. (See what I did there.) Unify the comparer interface (duck type). Use the new stuff in the video glitch detection test. BUG=chromium:393684 TEST=Ran video tests locally. Also locally tested the comparers. Change-Id: I144d5196b0c259453fe3a254c339da776acad91f Reviewed-on: https://chromium-review.googlesource.com/210400 Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
0967f8cbfa2e3ada3cca4a946cca582eae130df4 |
|
15-Jul-2014 |
Mussa <mussa@chromium.org> |
Bring on tests for resolution switching videos. We have image comparison based tests for video spanning mp4 and webm formats, 720p and 1080p definitions. We wish to add to the test suite a video that changes its resolution from 720p to 1080p triggering the use of Media Source Extenstion (MSE). With this change we have a different video so we are introducing a parameter 'video_name' that is specifiable from the control file. BUG=chromium:393753 TEST=Ran local tests. Change-Id: I5bafd710859f5d92dd9e439ce9b4505f6cfad42f Reviewed-on: https://chromium-review.googlesource.com/207928 Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Reviewed-by: Kris Rambish <krisr@chromium.org> Commit-Queue: Mussa Kiroga <mussa@chromium.org> Tested-by: Mussa Kiroga <mussa@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
5fec82c7a2f6315874629f7c0fed46364cecd9ee |
|
27-May-2014 |
mussa <mussa@google.com> |
Fix minor issues in video screenshot tests. Ran tests only on boards we care about, for the rest raise TestNAError We had splitted our CL to multiple smaller changelists. We fixed issues in those CLs iteratively. This CL makes minor fixes so that the whole things works again. BUG=chromium:363815 TEST=Ran test locally that use the whole code. Change-Id: I155acb6992f2449c8b20596eb5c83c620da20c76 Reviewed-on: https://chromium-review.googlesource.com/201698 Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Reviewed-by: Kris Rambish <krisr@chromium.org> Commit-Queue: Rohit Makasana <rohitbm@chromium.org> Tested-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|
ffb5077df39f107654a9e66d9748696d3d174408 |
|
14-May-2014 |
mussa <mussa@google.com> |
Adds basic test case to detect video glitches. This test case will select a 480p video, generate random time values within video duration and capture screenshots at those times. It will compare such images with known good images that it had downloaded when it(the test) began. * Removed video.html file because it was already included in another CL. * Changed 'TIME' attribute of the test from SHORT to LONG. Test runs for about 20mins. BUG=chromium:363815 TEST=Ran this test locally. Change-Id: Iaad9f058727548a9d23dbefb431d7638593d3790 Reviewed-on: https://chromium-review.googlesource.com/199646 Reviewed-by: Kris Rambish <krisr@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Commit-Queue: Rohit Makasana <rohitbm@chromium.org> Tested-by: Rohit Makasana <rohitbm@chromium.org>
/external/autotest/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
|