History log of /external/dhcpcd-6.8.2/dhcp-common.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
ddbf02ae19016710a31fca4b2bc26f08a6fe191f 05-Jan-2016 Samuel Tan <samueltan@google.com> [PATCH] UPSTREAM: Fix heap-based overflow in dhcp_envoption1

dhcp_optlen now returns the length of the data we can sanely work on given the
option definition and data length. Call dhcp_optlen in dhcp_envoption1 to take
into ensure these bounds are not overstepped. Fixes an issue reported by Nico
Golde where extra undersized data was present in the option. An example of this
would be an array of uint16's with a trailing byte.

http://roy.marples.name/projects/dhcpcd/ci/76a1609352263bd9?sbs=0

BUG: 26402253
Change-Id: Ic3c73277bb1cc09be08b3fbceecb97e2effd05ff
/external/dhcpcd-6.8.2/dhcp-common.c
68df7cfd9156424667636ad3544d0fa9f337647d 14-Aug-2015 Samuel Tan <samueltan@google.com> [PATCH] DHCPv6: Fix prefix delegation lease file name

Cherry-picked from
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/
master/net-misc/dhcpcd/files/patches/dhcpcd-6.8.2-DHCPv6-Fix-prefix-
delegation-lease-file-name.patch.

For DHCPv6, daemon creates two lease files, one for non-temporary
address and the other for prefix delegation. Currently only non-temporary
address lease is using the lease identifier obtained from command line
for its file name, since dhcpcd is using a separate pseudo interface
for handling prefix delegation messages.

So fix it to have both lease files using the same identifier obtained
from the command line, with non-temporary address lease ends in ".lease6"
and prefix delegation ends is ".pd.lease6".

BUG: 22956197
Change-Id: I24ada24e791e0be77aaadd148349be00ef2b6966

Reviewed-on: https://chromium-review.googlesource.com/282041
/external/dhcpcd-6.8.2/dhcp-common.c
0c07e7a4a10f902911d93f37e01b8a0308d67e96 14-Aug-2015 Samuel Tan <samueltan@google.com> [PATCH] UPSTREAM: Zero length embedded option

Cherry-picked from
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/
master/net-misc/dhcpcd/files/patches/dhcpcd-6.8.2-UPSTREAM-Zero-Length-
Embedded-Option.patch.

When we have a zero length for an embedded option, warn if any
more data or not the last option and return the number of
currently processed options. This fixes a potential buffer
overrun for options where the last embedded optional is an
optional string. Thanks to Paul Stewart @ Chromium for the fix.

http://roy.marples.name/projects/dhcpcd/ci/732e88eaa0?sbs=0

BUG: 22956197
Change-Id: I0291624e28fcec8f4d6f3affeb8fec1fff332f19

Reviewed-on: https://chromium-review.googlesource.com/281000
/external/dhcpcd-6.8.2/dhcp-common.c
8e603a0d0354b88712f1a81cc48dbd9936244fd5 14-Aug-2015 Samuel Tan <samueltan@google.com> [PATCH] ChromiumOS DHCPv6 support

Cherry-picked from
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/
master/net-misc/dhcpcd/files/patches/dhcpcd-6.8.2-ChromiumOS-DHCPv6-
support.patch.

Add support to emit DHCPv6 configuration/status updates through
DBus, and prevent the daemon from updating IPv6 system configurations.

Add command line option "-a" to enable ia options for shill usage,
since ia options can only be specified through the config file by
default. When "-a" option is enabled, the daemon will request ia_na
(Non-temporary Address) and ia_pd (Prefix Delegation) options from
the DHCPv6 server.

BUG: 22956197
Change-Id: I12ba8e72ec4f2e8aa1cede6c717f477be2df20ea

Reviewed-on: https://chromium-review.googlesource.com/275700
/external/dhcpcd-6.8.2/dhcp-common.c
e942e091ac1efb0ee1916add2b12f64fdfd59476 14-Aug-2015 Samuel Tan <samueltan@google.com> [PATCH] Add DBus RPC support

Cherry-picked from
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/
master/net-misc/dhcpcd/files/patches/dhcpcd-6.8.2-Add-DBus-RPC-support.patch.

Porting the DBus support from version 5.1.4 and allow it to be
configurable through the package configuration. Removed the unused
and incomplete implemention for DBus method GetInterfaces and GetStatus.

Also: update the default lease file name to tailor around the
expectation of shill ("dhcpcd-%dev.lease).

Also: update the config file to meet shill's expectation.

BUG: 22956197
Change-Id: Ic729dffc6b14fed0b27ed0731c11ef609434e03c

Review URL: http://codereview.chromium.org/2428004
Review URL: http://codereview.chromium.org/2851022
Review URL: http://codereview.chromium.org/2851023
Review URL: http://codereview.chromium.org/2865017
Review URL: http://codereview.chromium.org/2965010
Review URL: http://codereview.chromium.org/2957010
Review URL: http://codereview.chromium.org/3060016
Reviewed-on: http://gerrit.chromium.org/gerrit/2228
Reviewed-on: https://gerrit.chromium.org/gerrit/22597
Reviewed-on: https://gerrit.chromium.org/gerrit/36716
Reviewed-on: https://gerrit.chromium.org/gerrit/38183
Reviewed-on: https://gerrit.chromium.org/gerrit/59967
Reviewed-on: https://chromium-review.googlesource.com/178462
Reviewed-on: https://chromium-review.googlesource.com/185086
Reviewed-on: https://chromium-review.googlesource.com/195269
Reviewed-on: https://chromium-review.googlesource.com/259072
/external/dhcpcd-6.8.2/dhcp-common.c
9ae79b8946de6ac1e295417875f2ac7316dd0f80 14-Aug-2015 Samuel Tan <samueltan@google.com> [PATCH] Fix OOB read in dhcpcd.

Cherry-picked from
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/
master/net-misc/dhcpcd/files/patches/dhcpcd-6.8.2-Fix-OOB-read-in-dhcpcd.patch.

Should have done this sooner, but hey, late is better than never.

Based on https://googleplex-android-review.git.corp.google.com/#/c/588010/.

BUG: 22956197
Change-Id: I241cacc7c131237acbf1f8f011f1444e907eaebb

Reviewed-on: https://chromium-review.googlesource.com/242880
/external/dhcpcd-6.8.2/dhcp-common.c
a3595821594453ea89ef8e6790927694b0a1adf1 14-Aug-2015 Samuel Tan <samueltan@google.com> [PATCH] dhcpcd: Allow lease file to be set on command line

Cherry-picked from
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/
master/net-misc/dhcpcd/files/patches/dhcpcd-6.8.2-Allow-lease-file-to-be-
set-on-command-line.patch.

Currently, dhcpcd names its lease files using the interface name
as the unique part of the name. There are a couple reasons why
this may not work well: firstly if "eth0" can have different MAC
addresses (multiple USB-Ethernet dongles for example) leases for
one interface aren't valid for the other. Secondly, when using
a wireless interface, it would be convenient to hold multiple
leases in parallel for each SSID one is connected to.

This change adds a suffix to each interface argument (dhcpcd can
accept multiple interface arguments) that specifies the identifier
to use to save lease files with. By default, the behavior is
identical.

The second CL (https://gerrit.chromium.org/gerrit/22170) for fixing
pid file formating bug originally introduced by this CL is not needed
anymore since this bug doesn't exist/apply in the updated implementation.

BUG: 22956197
Change-Id: Id04168daa965065ca50e60f55c4cdc80f751c9c3

Reviewed-on: https://gerrit.chromium.org/gerrit/21991
Reviewed-on: https://gerrit.chromium.org/gerrit/22170
/external/dhcpcd-6.8.2/dhcp-common.c
d7ed851d6fc26c5e7db96971dbe6b44342b97727 14-Aug-2015 Samuel Tan <samueltan@google.com> Import dhcpcd 6.8.2

This is a simple import of dhcpcd 6.8.2.

SRC URI: http://roy.marples.name/downloads/dhcpcd/dhcpcd-6.8.2.tar.bz2
SHA1 Hash: 134a7c06bffc20789fedd5c0d259145d2dc4f058
(on the private dhcpcd repo 'trunk')

BUG: 22956197
Change-Id: I701af1d1532725b1058640fcb7ddeab1c24a797e
/external/dhcpcd-6.8.2/dhcp-common.c