| 25acf220a44ccc41104a690731fcf646cc3e8192 |
|
17-Oct-2017 |
Eric <eric@efcs.ca> |
Refactor most usages of KeepRunning to use the perfered ranged-for. (#459)
Recently the library added a new ranged-for variant of the KeepRunning
loop that is much faster. For this reason it should be preferred in all
new code.
Because a library, its documentation, and its tests should all embody
the best practices of using the library, this patch changes all but a
few usages of KeepRunning() into for (auto _ : state).
The remaining usages in the tests and documentation persist only
to document and test behavior that is different between the two formulations.
Also note that because the range-for loop requires C++11, the KeepRunning
variant has not been deprecated at this time.
/external/google-benchmark/test/user_counters_tabular_test.cc
|
| 3347a20e0e7aff733371cdc2ec371ea73bfdcecb |
|
01-Aug-2017 |
Roman Lebedev <lebedev.ri@gmail.com> |
reporter_output_test: json: iterations is int, not float (#431)
May be relevant for flakiness of win builds
Noted by @KindDragon
/external/google-benchmark/test/user_counters_tabular_test.cc
|
| b9be142d1e2dbc06cf2efd44919f6c422c43cddb |
|
25-Jul-2017 |
Roman Lebedev <lebedev.ri@gmail.com> |
Json reporter: don't cast floating-point to int; adjust tooling (#426)
* Json reporter: passthrough fp, don't cast it to int; adjust tooling
Json output format is generally meant for further processing
using some automated tools. Thus, it makes sense not to
intentionally limit the precision of the values contained
in the report.
As it can be seen, FormatKV() for doubles, used %.2f format,
which was meant to preserve at least some of the precision.
However, before that function is ever called, the doubles
were already cast to the integer via RoundDouble()...
This is also the case for console reporter, where it makes
sense because the screen space is limited, and this reporter,
however the CSV reporter does output some( decimal digits.
Thus i can only conclude that the loss of the precision
was not really considered, so i have decided to adjust the
code of the json reporter to output the full fp precision.
There can be several reasons why that is the right thing
to do, the bigger the time_unit used, the greater the
precision loss, so i'd say any sort of further processing
(like e.g. tools/compare_bench.py does) is best done
on the values with most precision.
Also, that cast skewed the data away from zero, which
i think may or may not result in false- positives/negatives
in the output of tools/compare_bench.py
* Json reporter: FormatKV(double): address review note
* tools/gbench/report.py: skip benchmarks with different time units
While it may be useful to teach it to operate on the
measurements with different time units, which is now
possible since floats are stored, and not the integers,
but for now at least doing such a sanity-checking
is better than providing misinformation.
/external/google-benchmark/test/user_counters_tabular_test.cc
|
| 020bac985b93308750b90cca6921b7425ca57b3d |
|
03-May-2017 |
Joao Paulo Magalhaes <dev@jpmag.me> |
Extend tabular counter tests to different counter sets.
/external/google-benchmark/test/user_counters_tabular_test.cc
|
| 25060449020a5f1e739064fc155ca7c4c94935a1 |
|
02-May-2017 |
Joao Paulo Magalhaes <dev@jpmag.me> |
Add unit test for counter sets.
/external/google-benchmark/test/user_counters_tabular_test.cc
|
| cf20dc967f2cf5307ca6e4bc06a36490c1b5c835 |
|
02-May-2017 |
Joao Paulo Magalhaes <dev@jpmag.me> |
Add test for tabular output of rate counters.
/external/google-benchmark/test/user_counters_tabular_test.cc
|
| c69b385c9ce92ce4b05c3109cfdb8086d75600d6 |
|
02-May-2017 |
Joao Paulo Magalhaes <dev@jpmag.me> |
Add first unit test for benchmark_tabular_counters.
/external/google-benchmark/test/user_counters_tabular_test.cc
|