| 4e42e67fa291bd27b2ffb00be57a4ca9a5000526 |
|
19-Feb-2018 |
Hidehiko Abe <hidehiko@google.com> |
Remove modification to deal with unused-parameter warning.
libchrome used to hit unused-parameter warning. Now, libchrome is built
with -Wno-unused-parameter flag, and its client libraries/executables
are built with the header files containing pragma to suppress the warning
from libchrome.
Thus, the modification can be removed to reduce the diff from
Chrome upstream.
Bug: 73270448
Test: Built locally. Treehugger.
Change-Id: I51b6349bfdb28ed15df1d12b836adccffabe53bb
/external/libchrome/dbus/bus.cc
|
| 36040ed30c39d2106a2cd5ec033e98b71302a744 |
|
13-Dec-2017 |
Hidehiko Abe <hidehiko@google.com> |
libchrome: Uprev the library to r456626 from Chromium
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r456626 which corresponds to git commit
08266b3fca707804065a2cfd60331722ade41969 of Mar 14, 2017
Notable changes are:
- FOR_EACH_OBSERVER macro removed (replaced by use of C++ 11
range-base for loop)
- base::Values no more FundamentalValue
- stl_util moved to base namespace
- some scoped pointers removed in crypto/ in favor
of BoringSSL UniquePtr.
- path() accessor renamed to GetPath() in ScopedTempDir (and other
classes)
- introduction of base::CallbackOnce
Test: All unit-tests should still pass.
Change-Id: I1e65efb167fa708e35ed7c6492f1cb66a6a46104
Merged-In: I180f9defc7607f462389fae17701fff553c4a2d0
/external/libchrome/dbus/bus.cc
|
| e5b2c6fa6f923f3a2f66346c2f169d9f0fceb3dc |
|
26-Jul-2017 |
Luis Hector Chavez <lhchavez@google.com> |
Revert "libchrome: Uprev the library to r456626 from Chromium"
This reverts commit 0601274935e7f632eb0d6ce0fd223b744349d20b.
Reason for revert: Broke the mac_sdk
Exempt-From-Owner-Approval: Fixing mac_sdk
Change-Id: I2cab1818261f3b75dcf7dfc3edf6d6b7bab541a8
/external/libchrome/dbus/bus.cc
|
| 0601274935e7f632eb0d6ce0fd223b744349d20b |
|
23-Mar-2017 |
Jay Civelli <jcivelli@google.com> |
libchrome: Uprev the library to r456626 from Chromium
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r456626 which corresponds to git commit
08266b3fca707804065a2cfd60331722ade41969 of Mar 14, 2017
Notable changes are:
- FOR_EACH_OBSERVER macro removed (replaced by use of C++ 11
range-base for loop)
- base::Values no more FundamentalValue
- stl_util moved to base namespace
- some scoped pointers removed in crypto/ in favor
of BoringSSL UniquePtr.
- path() accessor renamed to GetPath() in ScopedTempDir (and other
classes)
- introduction of base::CallbackOnce
Test: All unit-tests should still pass.
Change-Id: I5c2cb41ea4c037fe69fbb425e711b1399d55d591
/external/libchrome/dbus/bus.cc
|
| 0c4f26a46430b8c503c65f5cae1d2b6876d53e30 |
|
16-Jul-2016 |
Luis Hector Chavez <lhchavez@google.com> |
libchrome: Uprev the library to r405848 from Chromium
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r405848 which corresponds to git commit
909e5d3ecab27bb09cc570c1c215d0221bd6fe53 of Jul 15, 2016
Notable changes are:
- base::Bind() now explicitly disallows captures in lambdas (which was
never allowed in the style guide).
- base::ListValue::iterator now exposes std::unique_ptr<base::Value>
instead of raw base::Value*.
BUG: 29104761
TEST: All tests in libchrome_test pass on dragonboard-eng build
Change-Id: I94b285a3be074efa30c4e71ae93c8f2a99fb0b87
/external/libchrome/dbus/bus.cc
|
| 94ffa55491333f3dcc701befd0d2652922916d99 |
|
26-May-2016 |
Luis Hector Chavez <lhchavez@google.com> |
libchrome: Uprev the library to r395517 from Chromium
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r395517 which corresponds to git commit
ebdcb576bb346af95b8ad219f6250daf63122f98 of May 23, 2016
Notable changes are:
- scoped_ptr was removed in favor of std::unique_ptr
- base/thread_task_runner_handle.h was moved to base/threading.
BUG: 28985443
TEST: All tests in libchrome_test pass on dragonboard-eng build
Change-Id: Ic9f9ed1cafe754c96cd2f007984514e091aaba39
/external/libchrome/dbus/bus.cc
|
| 0d205d712abd16eeed2f5d5b1052a367d23a223f |
|
15-Jan-2016 |
Alex Vakulenko <avakulenko@google.com> |
libchrome: Uprev the library to r369476 from Chromium
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r369476 which corresponds to git commit
0471d0e2e2ef4a544a63481a389e1df33ea7c00a of Jan 14, 2016
Notable changes are:
- base::scoped_ptr<T> is now almost identical to std::unique_ptr<T>
No Pass() method, now std::move() is used on scoped pointers
- basictypes.h is removed and custom int types such as int32 are now
replaced with the standard int32_t and similar from <stdint.h>
- String utility functions are cleaned up/refactored. Now all are in
base:: namespace, many now return values rather than take pointers
for results, ambiguous Booleans are replaced with enums, such as:
base::StartsWithASCII(current_url, "https://", false);
now is:
base::StartsWith(current_url, "https://",
base::CompareCase::INSENSITIVE_ASCII);
- COMPILE_ASSERT() is now replaced with standard static_assert()
- Numeric range constants such as kuint64max are removed in favor of
standard <limits> constructs such as std::numeric_limits<uint64_t>::max()
- base::Value and derived classes use scoped_ptr<> more and support
for raw pointers to base::Value is deprecated and/or removed in
many places.
- base::MessageLoopProxy is completely removed (was marked deprecated before)
- base::MessageLoop::Quit() and QuitClosure are renamed to QuitWhenIdle
and QuitWhenIdleClosure for more semantic clarity.
Change-Id: I1f5436d253a0a32b2299160a76993752d818736f
/external/libchrome/dbus/bus.cc
|
| da04820d4f6c808cc997a3957be0aad62c4f3fd2 |
|
07-Jan-2016 |
Bertrand SIMONNET <bsimonnet@google.com> |
ChromeOS: Don't abort when the dbus connection drops.
We don't abort when the dbus bus disconnects on Android, we should do
the same on Chrome OS.
Bug: 26267381
Change-Id: I7b4060e91c89916fdaca33a617cdcae6c98e21e3
/external/libchrome/dbus/bus.cc
|
| 60d96a4a9e0d8c78d46c1f86dec60f9ecdbedbdb |
|
29-Dec-2015 |
Christopher Wiley <wiley@google.com> |
Fix unused parameter warnings in libchrome
Bug: 26228533
Test: libchrome builds under clang and gcc with this change
Change-Id: Ie534056c7557652fbbd7c2a134131d1cd25824e5
/external/libchrome/dbus/bus.cc
|
| 88ee374b55dcee26c0712f33ed88dde272225ff9 |
|
29-Dec-2015 |
Christopher Wiley <wiley@google.com> |
Revert "Fix compiler warnings in libchrome"
This reverts commit b636ff6a8ac3b54b3067289f01848252ab71eceb.
This broke trunk with messages like:
In file included from external/libchrome/base/time/time_posix.cc:29:0:
external/libchrome/base/lazy_instance.h:51:36: error: missing initializer for member 'base::LazyInstance<base::Lock, base::internal::LeakyLazyInstanceTraits<base::Lock> >::private_instance_' [-Werror=missing-field-initializers]
#define LAZY_INSTANCE_INITIALIZER {}
^
external/libchrome/base/time/time_posix.cc:39:38: note: in expansion of macro 'LAZY_INSTANCE_INITIALIZER'
g_sys_time_to_time_struct_lock = LAZY_INSTANCE_INITIALIZER;
^
external/libchrome/base/lazy_instance.h:51:36: error: missing initializer for member 'base::LazyInstance<base::Lock, base::internal::LeakyLazyInstanceTraits<base::Lock> >::private_buf_' [-Werror=missing-field-initializers]
#define LAZY_INSTANCE_INITIALIZER {}
^
external/libchrome/base/time/time_posix.cc:39:38: note: in expansion of macro 'LAZY_INSTANCE_INITIALIZER'
g_sys_time_to_time_struct_lock = LAZY_INSTANCE_INITIALIZER;
^
cc1plus: all warnings being treated as errors
Change-Id: I0c0308e716bd1ed7914e2a032e439a9261d38e56
/external/libchrome/dbus/bus.cc
|
| b636ff6a8ac3b54b3067289f01848252ab71eceb |
|
17-Dec-2015 |
Christopher Wiley <wiley@google.com> |
Fix compiler warnings in libchrome
Also fix compiler warnings in unit tests, except for unused parameter.
There are a ton of unused parameters in unit tests, and those errors
have no risk of spreading through the platform.
Bug: 26228533
Test: libchrome builds, unittests pass
Change-Id: I50431c8e143902c4b71b4381e4dbbc67cdc4507c
/external/libchrome/dbus/bus.cc
|
| dc9ba3fb3f920d97db54387c1a7ecce1df7bf5b1 |
|
19-Dec-2015 |
Bertrand SIMONNET <bsimonnet@google.com> |
dbus: Don't abort when the dbus connection drops.
Instead, rely on libdbus' mechanism to handle this. libdbus has been
patched to raise a SIGTERM signal, allowing the client to clean up and
exit cleanly when the dbus daemon disappears.
Bug: 26267381
Test: Stop dbus. Daemons using dbus exit cleanly.
Test: unit tests.
Change-Id: Id7aa816a336ae6444fb8bb4bde7c35928195e7b3
/external/libchrome/dbus/bus.cc
|
| c1e61c51d2705905445d148721157030614694cd |
|
28-Aug-2015 |
Peter Qiu <zqiu@google.com> |
Revert "libchrome: dbus: allow null callback for Bus::RemoveObjectProxy"
This reverts commit 038d81c71ac34d0bf9b626836e47e5c27e4103a5.
Change-Id: I399c18a6a1c4dd47318cbfaf385ac4764b19c77a
/external/libchrome/dbus/bus.cc
|
| 038d81c71ac34d0bf9b626836e47e5c27e4103a5 |
|
27-Aug-2015 |
Peter Qiu <zqiu@google.com> |
libchrome: dbus: allow null callback for Bus::RemoveObjectProxy
Some callers might not care when the object proxy destruction is
completed. So this make it easier/cleaner for such callers.
BUG=23560086
TEST=compile
Change-Id: I59fc45f9ec038ded5c1d0644314e3f1d35c8badd
/external/libchrome/dbus/bus.cc
|
| 5db5da5e853a090b44ab9cc2becda1670c69cbf1 |
|
26-Aug-2015 |
Daniel Erat <derat@google.com> |
Pull dbus/ directory forward to r337732.
Chrome OS was using a version of dbus/ (r337732, c1a556b)
that's newer than the rest of libchrome (r334380). Pull the
newer code into AOSP.
This change keeps the addition of a virtual d'tor for
PropertyBase (previously committed here in addition to being
upstreamed as r339031).
BUG=chromium:521005
Change-Id: Id62156187b042ff0a9d9ff95bf15672ac5dde37a
/external/libchrome/dbus/bus.cc
|
| ae6a045d2239408e25198ad17e2413bdde105788 |
|
16-Jul-2015 |
Daniel Erat <derat@google.com> |
Add upstream dbus/ code as of Chromium r334380.
Copy the unchanged source from
https://chromium.googlesource.com/chromium/src/dbus/ as of
r334380 (really r334285 a.k.a. d04f83ef in the dbus/
subtree).
Bug: 22317122
Change-Id: I598920914a737fe12e2f8199d6826f113991dc5b
/external/libchrome/dbus/bus.cc
|