| feb53912f8d8c29594a9fdff914d78bb36d6d56b |
|
02-Feb-2016 |
Steinar H. Gunderson <sesse@google.com> |
mesa: Fix locking of GLsync objects.
GLsync objects had a race condition when used from multiple threads
(which is the main point of the extension, really); it could be
validated as a sync object at the beginning of the function, and then
deleted by another thread before use, causing crashes. Fix this by
changing all casts from GLsync to struct gl_sync_object to a new
function _mesa_get_and_ref_sync() that validates and increases
the refcount.
In a similar vein, validation itself uses _mesa_set_search(), which
requires synchronization -- it was called without a mutex held, causing
spurious error returns and other issues. Since _mesa_get_and_ref_sync()
now takes the shared context mutex, this problem is also resolved.
Fixes bug #92757, found while developing Nageru, my live video mixer
(due for release at FOSDEM 2016).
v2: Marek: silence warnings, fix declaration after code
Signed-off-by: Steinar H. Gunderson <sesse@google.com>
Cc: "11.0 11.1" <mesa-stable@lists.freedesktop.org>
Signed-off-by: Marek Olšák <marek.olsak@amd.com>
/external/mesa3d/src/mesa/main/syncobj.h
|
| 755602df12cab123b8927e8d71b199b73e48b71b |
|
14-Sep-2013 |
Brian Paul <brianp@vmware.com> |
mesa: minor fix-ups for _mesa_validate_sync()
Return bool instead of int. Const-qualify the syncObj. Add some comments.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
/external/mesa3d/src/mesa/main/syncobj.h
|
| 21b5bf712b47e03d21dfa2c93acb272b9b575fe7 |
|
26-Aug-2013 |
Timothy Arceri <t_arceri@yahoo.com.au> |
mesa: make _mesa_validate_sync() non-static
Signed-off-by: Timothy Arceri <t_arceri@yahoo.com.au>
Reviewed-by: Brian Paul <brianp@vmware.com>
/external/mesa3d/src/mesa/main/syncobj.h
|
| b76f6d9557ff27140e18cf8aa2b57db8876d5d4d |
|
17-Apr-2013 |
Brian Paul <brianp@vmware.com> |
mesa: remove #include "mfeatures.h" from numerous source files
None of the remaining FEATURE_x symbols in mfeatures.h are used anymore.
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
/external/mesa3d/src/mesa/main/syncobj.h
|
| ab4c549378cc2e355e24b8cd3a4cbf28434fd6a8 |
|
18-Jan-2013 |
Eric Anholt <eric@anholt.net> |
mesa: Initially populate the display list with the exec list.
This cuts out a ton of code to make functions not set to a save_ variant
match.
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
/external/mesa3d/src/mesa/main/syncobj.h
|
| d05d5d9a919f429b9d03c76d779b5b9a102cc11d |
|
11-Sep-2012 |
Oliver McFadden <oliver.mcfadden@linux.intel.com> |
mesa: remove FEATURE_ARB_sync define.
Signed-off-by: Oliver McFadden <oliver.mcfadden@linux.intel.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
/external/mesa3d/src/mesa/main/syncobj.h
|
| 9520f483b8f1e45fa474674b415554988de5d8d3 |
|
01-Oct-2011 |
Brian Paul <brianp@vmware.com> |
mesa: s/INLINE/inline/
INLINE is still seen in some files (some generated files, etc) but this
is a good start.
Acked-by: Kenneth Graunke <kenneth@whitecape.org>
/external/mesa3d/src/mesa/main/syncobj.h
|
| f44d96e1af7a3a88677fa256d3fbb96834ffaf39 |
|
23-Nov-2010 |
Vinson Lee <vlee@vmware.com> |
mesa: Clean up header file inclusion in syncobj.h.
/external/mesa3d/src/mesa/main/syncobj.h
|
| f9995b30756140724f41daf963fa06167912be7f |
|
12-Oct-2010 |
Kristian Høgsberg <krh@bitplanet.net> |
Drop GLcontext typedef and use struct gl_context instead
/external/mesa3d/src/mesa/main/syncobj.h
|
| 10ff2646a443ca3c54d66443b346eb7063973b5e |
|
13-Sep-2010 |
Chia-I Wu <olv@lunarg.com> |
mesa: Less FEATURE_ARB_sync tests.
Add dummy static inline definitions to syncobj.h when FEATURE_ARB_sync
is 0, and remove most FEATURE_ARB_sync tests.
/external/mesa3d/src/mesa/main/syncobj.h
|
| f7d29d58815462a209bf5a2bf0734aa4ff72880a |
|
03-Aug-2010 |
Vinson Lee <vlee@vmware.com> |
mesa: Reduce header file inclusion in syncobj.h.
syncobj.h doesn't use any additional symbols that is added by context.h.
/external/mesa3d/src/mesa/main/syncobj.h
|
| 826d441cdfa16a16d165297beb3013f4ff8b4816 |
|
07-Sep-2009 |
Michal Krol <michal@vmware.com> |
mesa: Fix calling conventions of sync object api callbacks.
/external/mesa3d/src/mesa/main/syncobj.h
|
| 16b393d05990b6e917e144f9de87d0103b4c3e6d |
|
31-Aug-2009 |
Ian Romanick <ian.d.romanick@intel.com> |
ARB sync: Fix delete behavior and context destruction behavior
I believe this resolves the outstanding issues WRT sync object
deletetion. I have also added a large comment at the top of syncobj.c
describing the expected memory management behavior. I'm still a
little uncertain about the locking on ctx->Shared.
/external/mesa3d/src/mesa/main/syncobj.h
|
| f37070bab6af350caec905ea7658e9241042b6cc |
|
29-Aug-2009 |
Ian Romanick <ian.d.romanick@intel.com> |
ARB sync: Add support for GL_ARB_sync to swrast
This isn't quite right yet. The delete behavior and the context
clean-up needs some work.
/external/mesa3d/src/mesa/main/syncobj.h
|