History log of /external/perfetto/include/perfetto/ipc/deferred.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
5b65c9f715a02b08e44d20b88657fbae8d22351f 29-Jan-2018 Primiano Tucci <primiano@google.com> ipc: Fix dontreply logic when using derived Deferred messages

This is a follow up to Id56e124bbad0870c4a29653289bf021cfdbf4c14.
The previous CL added the right boilerplate but failed to work
as intended end-to-end. The reason was in the callback argument
adaptor in the Deferred class that was always binding the adapter
even when the original callback was empty.
Unfortunately this bug was not unveiled by the unittest because the
test was using the DeferredBase class (without the callback adapter)
and not a derivate like the production code.
This CL fixes the issue and the unittest (verified that the unittest
change alone without the change in deferred.h would have failed).

Test: perfetto_unittests --gtest_filter=ClientImplTest.InvokeMethodDropReply
Change-Id: I6fd11f7c27452526559beeb595641d141f6261f2
/external/perfetto/include/perfetto/ipc/deferred.h
4f9b6d7b7b2ad7b86e1577a18dc6e2df91b98164 05-Dec-2017 Primiano Tucci <primiano@google.com> Pivot source files into top-level src,include and unify test target

See discussion in go/perfetto-build-files .
This is to disambiguate things like
#include "base/logging.h"
when in the chrome tree.

Also this CL unifies the test targets into two monolithic targets:
perfetto_tests and perfetto_benchmarks. This is to avoid ending
up with confusing binary names in the chrome tree (e.g.,
ipc_unittests)

Bug: 68710794
Change-Id: I1768e15b661406052b2be060d7aab0f1e7443a98
/external/perfetto/include/perfetto/ipc/deferred.h